GNOME uses WebKit2. Mageiawelcome uses webkit. This results in unneeded dependencies for GNOME images. Please port mageiawelcome to webkit2.
CC: (none) => olav
Keywords: (none) => PATCH
Created attachment 7589 [details] port to webkit2 With that patch, mageiawelcome starts but the content is not OK. I guess the CSS needs being updated?
Check: $ LC_ALL=C rpm -e lib64webkit-gir3.0-2.4.10-1.mga6 error: Failed dependencies: typelib(WebKit) is needed by (installed) mageiawelcome-1.6-1.mga6.noarch typelib(WebKit) = 3.0 is needed by (installed) mageiawelcome-1.6-1.mga6.noarch
Created attachment 7590 [details] port to WebKit2 v2: really disable context menu
Attachment 7589 is obsolete: 0 => 1
Blocks: (none) => 18015
Summary: mageiawelcome: port to WebKit2 => mageiawelcome: port to WebKit2 (PATCH)
@Daniel, Papoteur: any comment?
CC: (none) => luigiwalser, yves.brungard_mageia
Whiteboard: (none) => MGA6TOO
Hi Thierry, I'm reviewing mageiawelcome. I applied your patch. It seems to work, but without applying the CSS. Thus, it is not yet functional. Do we have some tools to debug the HTML page, CSS and javascript?
Nope
Created attachment 10441 [details] write wekbit console messages to stdout Which shows eg: CONSOLE ERROR Not allowed to load local resource: file:///usr/share/mageiawelcome/js/jquery-json-2.4.min.js
Created attachment 10442 [details] Fix loading error show by previous debug patch to be applied with "git am -3 < 0001..." as usual
Created attachment 10443 [details] debug patch This patch enables to: - trace the loaded files (which shows a name issue with one of the js but fixing that doesn't fix anything) - open the inspector - replace the html code by some hardcoded code (which works)
Created attachment 10444 [details] Fix javascript path
Killing css/style.css & the inline JS from index.html restores some content here.
Thanks Thierry, I applied your patches. Good progress. Prefixing the command with LANGUAGE=C, the windows looks OK. Without, I have: file:///usr/share/mageiawelcome/js/ipc.js:1: CONSOLE ERROR SyntaxError: Invalid character '\u2864' file:///usr/share/mageiawelcome/js/jquery-2.0.3.min.js:1: CONSOLE ERROR SyntaxError: Invalid character '\u2a2f' file:///usr/share/mageiawelcome/js/kickstart.js:1: CONSOLE ERROR SyntaxError: Invalid character '\u2974' file:///usr/share/mageiawelcome/:19:4: CONSOLE ERROR ReferenceError: Can't find variable: $ and presentation without style.
There is still a problem with signal connection. It seems that the parameters transmitted in the callback function changed. In http://gitweb.mageia.org/software/mageiawelcome/tree/usr/share/mageiawelcome/webgui.py#n36 def connect_title_changed(browser, callback): def callback_wrapper(widget, frame, title): callback(title) browser.connect('notify::title', callback_wrapper) the title argument is not transmitted and a "missing 1 argument" error occurs. I didn't find a good way to pass the title of the notify event. Second argument passed seems to be a GParamString, but I didn't find a way to exploit it.
(In reply to papoteur from comment #13) > There is still a problem with signal connection. It seems that the > parameters transmitted in the callback function changed. > In > http://gitweb.mageia.org/software/mageiawelcome/tree/usr/share/mageiawelcome/ > webgui.py#n36 > def connect_title_changed(browser, callback): > def callback_wrapper(widget, frame, title): callback(title) > browser.connect('notify::title', callback_wrapper) > > the title argument is not transmitted and a "missing 1 argument" error > occurs. > I didn't find a good way to pass the title of the notify event. Second > argument passed seems to be a GParamString, but I didn't find a way to > exploit it. Just found the way: def callback_wrapper(widget, param): callback(widget.get_property(param.name))
Done
Resolution: (none) => FIXEDStatus: NEW => RESOLVED
Still needs to be packaged.
Status: RESOLVED => REOPENEDResolution: FIXED => (none)
Mageiawelcome is now rewritten using QML, without webkit.
Resolution: (none) => WONTFIXStatus: REOPENED => RESOLVED
Improper resolution again.
Status: RESOLVED => REOPENEDResolution: WONTFIX => (none)
Once this update is packaged for Mageia 6 and Cauldron, then it will be marked as FIXED.
Keywords: PATCH => (none)Summary: mageiawelcome: port to WebKit2 (PATCH) => mageiawelcome: remove dependency on webkit(1)
It is packaged as 1.17 in cauldron. I don't think it is of some interest to package it for Mageia 6. It includes some links for apges dedicated to Mageia 7.
It is of interest for Mageia 6, as webkit isn't getting fixed ever. If some of the changes in upstream 1.17 aren't correct for Mageia 6, then make a branch in git for mageiawelcome for Mageia 6 and only backport the changes to fix this bug.
Whiteboard: MGA6TOO => (none)Version: Cauldron => 6
I have created a topic/mga6 branch, adapted links and tagged a 1.18mga6 release. Now, a packager have to package it. Papoteur
Nice, thanks.
Assignee: napcok => pkg-bugsCC: (none) => napcok
Assigning to QA: ======================== Packages in 6/core/updates_testing: ======================== mageiawelcome-1.96-1.mga6.noarch.rpm Source RPM: ======================== mageiawelcome-1.96-1.mga6.src.rpm ========================
Assignee: pkg-bugs => qa-bugs
Advisory: ---------------------------------------- The previous version used webkit1 which is no more maintained. The new release is a new version using QML for the user interface, thus no more webkit.
Changed the path for the config file, as in the initial release, thus the application is not launched if "Open at start" is already unchecked. ======================== Packages in 6/core/updates_testing: ======================== mageiawelcome-1.97-1.mga6.noarch.rpm Source RPM: ======================== mageiawelcome-1.97-1.mga6.src.rpm ========================
MGA6-32 MATE on IBM Thinkpad R50e No installation issues. At CLI: $ mageiawelcome QML debugging is enabled. Only use this in a safe environment. QString::arg: Argument missing: Welkom bij Mageia!, Tester6 qml: Screen: 1 3.787921912059843 QOpenGLShader: could not create shader QOpenGLShader: could not create shader QOpenGLShader: could not create shader QOpenGLShader: could not create shader QOpenGLShader: could not create shader The outline of a new window appears quite shortly, but disappears before I could see whether there is any contents in it. I get exactly the same result with mageiawelcome-launcher
CC: (none) => herman.viaene
mga6 64 bit, Plasma, Nvidia driver, old Intel i7 Window opens correctly here. And do not open at login. This system first received 1.96 version which popped up despite it is not a new installation. 1.97 seem not to, OK. Problem: Also 1.97-1 pops up when it should not; On my wifes system which did not get the 1.96 version in between: Now after upgrade from some elder version than 1.96, at login the dialog pops up after upgrade to 1.97, and the checkmark is not set.
CC: (none) => fri
Ok, I missed to adapt the launcher. > QString::arg: Argument missing: Welkom bij Mageia!, Tester6 The translation is not accurate, it need %1 in the location for replacement of the name. > QOpenGLShader: could not create shader It seems that this installation doesn't manage OpenGL 2. I don't know if it is because of a missing lib, or inability of hardware or driver. I found that graphics is Intel 855GME.
My 32-bitter (old!!!!!) is OpenGL1.3, and its Intel graphics 82852/855GM .
I pushed a correction for the opening at login or not. ======================== Packages in 6/core/updates_testing: ======================== mageiawelcome-1.98-1.mga6.noarch.rpm ======================== mageiawelcome-1.98-1.mga6.src.rpm ======================== I have done nothing about the Intel graphics 82852/855GM. I found some information but it's not yet clear for me how to do. I hope to test which king of Opengl capable renderer is used and use or not some feature only rendered with OpenGL (LinearGradient). Papoteur
I made some tests today in Vbox and everything seems to work: 1. Install Mga6 using the Live Plasma 6.1 ISO 2. Activate the default repositories and run all the updates available. At this point, mageiawelcome is working as expected and pops-up only if the box is ticked. 3. Activate core_updates-testing repository and run "urpmi mageiwelcome" to update it with its dependencies. 4. The newest version is working as expected: a hidden ~/.mageiawelcome folder is created with the empty norun.flag file in it when the box is unticked. $ uname -romi 4.14.119-desktop-1.mga6 x86_64 x86_64 GNU/Linux $ rpm -qa | grep welcome mageiawelcome-1.98-1.1.mga6
CC: (none) => sebsweb
======================== Packages in 6/core/updates_testing: ======================== mageiawelcome-1.98-1.1.mga6.noarch.rpm ======================== mageiawelcome-1.98-1.1.mga6.src.rpm ========================
Created attachment 11027 [details] To test OpenGL platform (In reply to Herman Viaene from comment #27) > MGA6-32 MATE on IBM Thinkpad R50e > No installation issues. > At CLI: > $ mageiawelcome > QML debugging is enabled. Only use this in a safe environment. > QString::arg: Argument missing: Welkom bij Mageia!, Tester6 > qml: Screen: 1 3.787921912059843 > QOpenGLShader: could not create shader > > The outline of a new window appears quite shortly, but disappears before I > could see whether there is any contents in it. Hello Herman, Can I have some test from you? Check that qtdeclarative5 is installed. Save the file attached under the name test.qml Launch the command, in the directory you saved the file: QT_LOGGING_RULES=qml=true qmlscene test.qml A window will be displayed. Click on the center, then close it. Provide what has been written in console. the result will be in form of that: qml: 3.0:2 where 3.0 is the opengl used by the application, and 2 says that the application uses opengl.
@papoteur: First tested 1.98-1.1 to make sure this made no difference vs. 1.97: exactly same output. Checked qtdeclarative5 is installed: that is OK Now at CLI: $ QT_LOGGING_RULES=qml=true qmlscene test.qml QOpenGLShader: could not create shader Segmentatiefout (geheugendump gemaakt) i.e. Segmentation fault (memory dump made)
It seems that I won't find any solution for that. What I tried to get information about OpenGL version is provided only when OpenGL is used, not before :/ I tried Mageiawelcome with an old Laptop Dell dated 2007, Intel graphics 945M and it works fine.
Hello, I didn't find any solution.
I don't know how you would when Herman didn't even provide a stack trace. It sounds like he just has a broken system.
Resolution: WONTFIX => (none)Status: RESOLVED => REOPENED
on mga6-64 packages installed cleanly: python3-opengl-3.1.0-7.mga6.x86_64 mageiawelcome-1.98-1.1.mga6.noarch.rpm Tested all of the tabs and several links - all working displays on login if the box is checked OK for mga6-64
CC: (none) => jim
Whiteboard: (none) => MGA6-64-OK
on mga6-32 (in a vbox VM) packages installed cleanly: - mageiawelcome-1.98-1.1.mga6.noarch - python3-numpy-1.11.2-1.mga6.i586 - python3-opengl-3.1.0-7.mga6.i586 - python3-qt5-core-5.6-8.mga6.i586 - python3-qt5-gui-5.6-8.mga6.i586 - python3-qt5-network-5.6-8.mga6.i586 - python3-qt5-qml-5.6-8.mga6.i586 - python3-qt5-quick-5.6-8.mga6.i586 - python3-sip-4.18.1-1.mga6.i586 Tested all of the tabs and several links - all working displays on login if the box is checked OK for mga6-32
Whiteboard: MGA6-64-OK => MGA6-64-OK MGA6-32-OK
Validated update Suggested Advisory: ************************************************************************ GNOME uses WebKit2. Mageiawelcome uses webkit. This results in unneeded dependencies for GNOME images. Mageiawelcome is now rewritten using QML, without webkit. SRPM mageiawelcome-1.98-1.1.mga6.src.rpm ************************************************************************
Keywords: (none) => validated_updateCC: (none) => sysadmin-bugs
Heh, so initial report stated: "GNOME uses WebKit2. Mageiawelcome uses webkit. This results in unneeded dependencies for GNOME images. Please port mageiawelcome to webkit2." we tried to remove deps for Gnome to get it cleaner, and ended up pulling in qt stack instead... oh well... :/
CC: (none) => tmb
(In reply to Thomas Backlund from comment #42) I have removed the validation and OK's while I do some more testing
Keywords: validated_update => (none)Whiteboard: MGA6-64-OK MGA6-32-OK => (none)
Given the subject of the bug, it really needs to be tested on a system with Gnome as the only DE: On a system with only gnome installed: The following packages are selected: - lib64qt5quickparticles5-5.9.4-1.mga6.x86_64 - lib64qt5quicktest5-5.9.4-1.mga6.x86_64 - lib64qt5sql5-5.9.4-1.2.mga6.x86_64 - lib64qt5test5-5.9.4-1.2.mga6.x86_64 - lib64qt5xmlpatterns5-5.9.4-1.mga6.x86_64 - mageiawelcome-1.98-1.1.mga6.noarch - python3-opengl-3.1.0-7.mga6.x86_64 - python3-qt5-core-5.6-8.mga6.x86_64 - python3-qt5-gui-5.6-8.mga6.x86_64 - python3-qt5-network-5.6-8.mga6.x86_64 - python3-qt5-qml-5.6-8.mga6.x86_64 - python3-qt5-quick-5.6-8.mga6.x86_64 - python3-sip-4.18.1-1.mga6.x86_64 - qtdeclarative5-5.9.4-1.mga6.x86_64 - qtgraphicaleffects5-5.9.4-1.mga6.x86_64 - qtquickcontrols5-5.9.4-1.mga6.x86_64 - qtxmlpatterns5-xmlpatterns-5.9.4-1.mga6.x86_64 41MB of additional disk space will be used. As suggested in comment#42, the update does not seem to really resolve the bug. I leave it to others to decide on the appropriate action.
The only point was to remove the dependency on webkit1. If it does that and it still works, it's good.
Just to emphasize the point, after updating mageiawelcome I removed webkit1.0 and ran mageiawelcome again. No problem, so this is good to go. Thanks David and James.
CC: (none) => tarazed25
Keywords: (none) => validated_updateWhiteboard: (none) => MGA6-64-OK
Keywords: (none) => advisory
An update for this issue has been pushed to the Mageia Updates repository. https://advisories.mageia.org/MGAA-2019-0073.html
Resolution: (none) => FIXEDStatus: REOPENED => RESOLVED