Bug 17624 - yamagi-quake2 provide incorrect location for .pak file and missing yq2.cfg file
Summary: yamagi-quake2 provide incorrect location for .pak file and missing yq2.cfg file
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 5
Hardware: All Linux
Priority: Normal major
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard: advisory MGA5-64-OK
Keywords: validated_update
Depends on:
Blocks:
 
Reported: 2016-01-26 04:30 CET by Hoyt Duff
Modified: 2017-07-24 17:53 CEST (History)
5 users (show)

See Also:
Source RPM: yamagi-quake2-5.23-2.mga5.src.rpm
CVE:
Status comment:


Attachments

Description Hoyt Duff 2016-01-26 04:30:56 CET
Description of problem:

RPMDrake instructions provide incorrect location for .pak file
Version-Release number of selected component (if applicable):


How reproducible:
Select yamagi-quake2 in rpmdrake. The comments state:

"Install the PAK files in ~/.yq2/baseq2 or, alternatively for a system-wide installation, in /usr/share/games/quake2."

If you look in the startup script in /usr/games/quake2:

#!/bin/sh
/usr/games/quake2.bin +set basedir /usr/lib64/games/quake2 $*
exit 0

This makes the "basedir", or the dircetory to which the application looks for the pako.pak file, to be /usr/lib64/games/quake2, not /usr/share/games/quake2 which Mageia has told the user.

It should direct you to put the pako.pak file in the same diretory. Either is fine, but it should be the same.

Currently, following the instructions, the game will not locate the pak0.pak file and will not run.


As well,
  â/usr/share/doc/yamagi-quake2/README states:
"If you want to use it just copy "stuff\yq2.cfg" to your "baseq2\" folder"

No such file is provided in the RPM package.

That file does exist at https://github.com/yquake2/yquake2/blob/master/stuff/yq2.cfg



Reproducible: 

Steps to Reproduce:
Comment 1 Hoyt Duff 2016-01-26 05:03:04 CET
Also, without yg2.cfg, the game does no want to start.

CC: (none) => hoyt

Comment 2 Marja Van Waes 2016-01-26 06:58:56 CET
assigning to maintainer

CC: (none) => marja11
Assignee: bugsquad => rverschelde

Comment 3 Hoyt Duff 2016-01-26 17:56:12 CET
I should also add that I use the 64-bit version of Mageia 5.
Comment 4 Rémi Verschelde 2016-09-22 19:58:42 CEST
Finally took the time to work on this, it should be much better with yamagi-quake2-5.34-1.mga6.

I'd be very interested in feedback on the packaging, as I don't play it much myself. I've also added the yq2.cfg file as advised in comment 0.
Comment 5 Rémi Verschelde 2016-09-22 19:59:19 CEST
Marking as fixed, but feel free to reopen if you still experience the issue (or open a new bug report if the issue is different).

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Rémi Verschelde 2016-09-22 19:59:28 CEST

Severity: critical => major

Comment 6 Rémi Verschelde 2016-09-22 20:00:43 CEST
Reopening as I've only fixed it in Cauldron, not yet in Mageia 5.

Status: RESOLVED => REOPENED
Resolution: FIXED => (none)

Rémi Verschelde 2016-09-22 20:10:38 CEST

Summary: RPMDrake instructions provide incorrect location for .pak file and missing yq2.cfg file => yamagi-quake2 provide incorrect location for .pak file and missing yq2.cfg file

Comment 7 Rémi Verschelde 2016-09-22 20:15:23 CEST
Pushed updated package to Mageia 5. As the package was mostly broken, I took the liberty to sync with Cauldron and thus to update to the latest upstream version (5.34).


Suggested advisory:
===================

Updated yamagi-quake2 packages fix instructions and lookup for system-wide data

  yamagi-quake2 was mispackaged and included libraries in one location, but
  instructions to install the data system-wide in another location.
  The engine looks for both the libraries and the data files in the same location,
  so this location was enforced and the instructions fixed.

  Moreover, the default upstream configuration override is now provided.
  Several other packaging improvements have been operated.


RPMs in core/updates_testing:
=============================

yamagi-quake2-5.34-1.mga5
yamagi-quake2-ctf-5.34-1.mga5
yamagi-quake2-rogue-5.34-1.mga5
yamagi-quake2-server-5.34-1.mga5
yamagi-quake2-xatrix-5.34-1.mga5

SRPM in core/updates_testing:
=============================

yamagi-quake2-5.34-1.mga5

Assignee: rverschelde => qa-bugs

Comment 8 Rémi Verschelde 2016-09-22 20:24:56 CEST
@QA team: This one is a bit tricky to test, as it's just an engine for Quake 2, but you need to have the original game data to play it (or at least extract the data from the public demo).

There are instructions to do this in the README.md (/usr/share/doc/yamagi-quake2/README.md), i.e. https://github.com/yquake2/yquake2/blob/master/README.md#game-data-setup

Hopefully Hoyt can test the update candidate, and that should be good enough for validation.
Nicolas Lécureuil 2016-10-12 11:08:12 CEST

CC: (none) => mageia
Whiteboard: (none) => advisory

Comment 9 Hoyt Duff 2016-10-13 19:08:23 CEST
It works for me!

May I suggest that this be added to the description displayed in drakrpm, because many people will not bother with the README.md.

-- You need PAK files for Quake II to run this game --

Install the retail version PAK files in ~/.yq2/baseq2 or, alternatively for a system-wide installation, in /usr/lib64/games/quake2.

Install the demo version PAK files by following the directions at https://github.com/yquake2/yquake2/blob/master/README.md#game-data-setup


Thanks for your work on my bug report!
Comment 10 Hoyt Duff 2016-10-13 19:11:42 CEST
Perhaps "Obtain the demo version PAK . . ."
Comment 11 TheSuperGeek 2016-12-04 18:50:33 CET
Hello,
I tried on mageia 5 x64 with the demo package. All worked well.
I see in the MCC, that it's written to add the .pak files. So i think it's ok ?
Bye

CC: (none) => comptes.tsgeek

Comment 12 Rémi Verschelde 2016-12-04 19:16:55 CET
(In reply to Hoyt Duff from comment #9)
> May I suggest that this be added to the description displayed in drakrpm,
> because many people will not bother with the README.md.

I've added something in the description for the cauldron package (yamagi-quake2-5.34-2.mga6), but I'd prefer not to redo the Mageia 5 update candidate just for that.

Marking as OK for x86_64 based on comment 9 and comment 11, and validating.

Keywords: (none) => validated_update
Whiteboard: advisory => advisory MGA5-64-OK
CC: (none) => sysadmin-bugs

Comment 13 Mageia Robot 2016-12-04 23:15:28 CET
An update for this issue has been pushed to the Mageia Updates repository.

http://advisories.mageia.org/MGAA-2016-0141.html

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED

Comment 14 Hoyt Duff 2017-07-19 19:07:30 CEST
Mageia6 package installs yamagi-quake3 in all the correct directories and works as expected.

There are public-domain-licensed high-res textures available from
http://www.moddb.com/games/quake-2/addons/quake-2-32-bit-high-resolution-textures-pack

That really make the game look great on modern hardware.

Thank you Remi for your work on this. Quake 2 is available for purchase from GOG.com (US$10) and also STEAM (US$5). The GOG version includes additional content and is DRM free.

I would be glad to fund your purchase from GOG so you can have the games files for testing. Just let me know how I might do that.
Comment 15 Rémi Verschelde 2017-07-24 11:29:33 CEST
(In reply to Hoyt Duff from comment #14)
> There are public-domain-licensed high-res textures available from
> http://www.moddb.com/games/quake-2/addons/quake-2-32-bit-high-resolution-
> textures-pack

Do you think that's something we could package in a way that makes it usable out of the box? Or do you have to replace pack files of the installed game manually to override them?

> I would be glad to fund your purchase from GOG so you can have the games
> files for testing. Just let me know how I might do that.

Thanks for the offer, but to be honest I have so many Linux games already that I don't know what to make of them :D

So far testing yamagi-quake2 with the demo seemed sufficient, and if you can confirm that the full game and the extensions work as expected, we should be all covered. I might grab Quake 2 on GOG one day to satisfy my "game hoarder" impulses though ;)
Comment 16 Hoyt Duff 2017-07-24 17:53:32 CEST
(In reply to Rémi Verschelde from comment #15)

> 
> Do you think that's something we could package in a way that makes it usable out of the box? Or do you have to replace pack files of the installed game manually to override them?
> 

They have a unique name and are simply placed in the baseq2 directory.


> So far testing yamagi-quake2 with the demo seemed sufficient, and if you can confirm that the full game and the extensions work as expected, we should be all covered. I might grab Quake 2 on GOG one day to satisfy my "game
> hoarder" impulses though ;)

Everything works. Thank you very much!

Note You need to log in before you can comment on or make changes to this bug.