Bug 15990 - Isodumper - remove the new uefi support which copies iso contents to fat formatted USB stick
Summary: Isodumper - remove the new uefi support which copies iso contents to fat form...
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 4
Hardware: i586 Linux
Priority: release_blocker normal
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard: advisory mga4-64-ok
Keywords: PATCH, validated_update
Depends on:
Blocks: 14069
  Show dependency treegraph
 
Reported: 2015-05-20 10:43 CEST by claire robinson
Modified: 2015-05-27 18:58 CEST (History)
6 users (show)

See Also:
Source RPM: isodumper
CVE:
Status comment:


Attachments
kill-uefi-mode.diff (4.62 KB, patch)
2015-05-20 15:53 CEST, claire robinson
Details | Diff

Description claire robinson 2015-05-20 10:43:13 CEST
Isodumper was recently upgraded to provide the functionality to copy iso
contents to fat formatted USB if uefi was selected.

Should start by saying thanks for adding it in the first place and hope you won't feel it was time wasted.

Intrinsic UEFI support has now progressed such that images can simply be
dd'ed to USB in the same way as for non-uefi so, to avoid confusion, the
uefi additions to isodumper will now need to be removed. An update will
also need to be pushed to mga4.

Reproducible: 

Steps to Reproduce:
claire robinson 2015-05-20 10:44:15 CEST

Priority: Normal => release_blocker
Blocks: (none) => 14069
Whiteboard: (none) => MGA4TOO

Comment 1 claire robinson 2015-05-20 15:53:04 CEST
Created attachment 6593 [details]
kill-uefi-mode.diff

Patch contributed by Thierry to qa-discuss ML.

Untested currently
claire robinson 2015-05-20 15:53:14 CEST

Keywords: (none) => PATCH

Comment 2 papoteur 2015-05-20 19:44:58 CEST
Version 0.42 commited on git.
It removes the "Uefi feature".
David will package it.
Comment 3 Rémi Verschelde 2015-05-20 19:48:13 CEST
A tip for a future time: you can add a mention to the bug report in the commit log as "mga#15990", and then an automatic comment is added to the corresponding bug report with the commit log. Just so you know for a future occasion :)
Comment 4 David GEIGER 2015-05-20 20:20:04 CEST
Just for the commit reference:

commit	1064c2fd49856b0d70bc7f17bf87e3312ed4e65b
Author: Papoteur <papoteur@mageialinux-online.org>
Date:   Wed May 20 17:38:11 2015

    Suppress UEFI feature

---
Commit Link:
http://gitweb.mageia.org/software/isodumper/commit/?id=1064c2fd49856b0d70bc7f17bf87e3312ed4e65b

CC: (none) => geiger.david68210

Comment 5 Mageia Robot 2015-05-20 20:44:26 CEST
commit 1d8543df63c9280fc47473526b8b9295ec40d1cd
Author: daviddavid <geiger.david68210@...>
Date:   Wed May 20 20:44:12 2015 +0200

    New release 0.42
    
    - fix for bug mga#15990
---
 Commit Link:
   http://gitweb.mageia.org/software/isodumper/commit/?id=1d8543df63c9280fc47473526b8b9295ec40d1cd
Comment 6 Nicolas Lécureuil 2015-05-22 01:01:57 CEST
isodumper is on cauldron. can we close this bugreport ?

CC: (none) => mageia

Comment 7 claire robinson 2015-05-22 09:06:00 CEST
Not yet it needs to be pushed in mga4 too. I see it was built but not assigned to QA yet. Doing so now.

SRPM and RPM seems to be: isodumper-0.42-1.mga4

Advisory
--------
This update for isodumper removes the setting which was previously needed for UEFI functionality. UEFI support has progressed such that this feature is no longer needed.

CC: (none) => yves.brungard_mageia
Version: Cauldron => 4
Assignee: yves.brungard_mageia => qa-bugs
Whiteboard: MGA4TOO => (none)

Comment 8 Len Lawrence 2015-05-22 14:31:12 CEST
Attempted UEFI install of mga5 final round 2 Mageia-5-x86_64-DVD from USB iso written with isodumper 0.42 installed on a Mageia 4 machine.

The UEFI machine presented the option of booting from UEFI USB - selected.
Immediate failure:

UEFI boot fail
error: file '/isolinux/x86_64/vmlinuz' not found
alloc magic broken at 0x9a77fc00: 9a6ca9a0
Aborted.....

Checked the file contents - all looks OK
[lcl@belexeuli ISOQA]$ ls /run/media/lcl/Mageia-5rc-x86_64
autorun.inf  boot.catalog  dosutils  EFI  isolinux  x86_64
[lcl@belexeuli ISOQA]$ ls /run/media/lcl/Mageia-5rc-x86_64/isolinux/x86_64
all.rdz  vmlinuz
Everything mounted readonly

CC: (none) => tarazed25

Comment 9 Nicolas Lécureuil 2015-05-22 14:39:20 CEST
/run/media/lcl/Mageia-5rc/

i think this is not the correct iso as there is Rc in the name.
Comment 10 Thomas Backlund 2015-05-22 14:41:37 CEST
Yeah, ennael forgot to remove "rc" on round 2 in the label, so you can only test on live x86_64 for now as the above iso name is "5rc" instead of "5" wich the boot menu expects.

it's fixed in git and will be on next round of classical isos

CC: (none) => tmb

Comment 11 Len Lawrence 2015-05-22 14:46:15 CEST
Thanks Thomas.  I have tested a 4 -> 5 upgrade with the same USB stick on a CSM machine.  That runs fine.
Comment 12 Len Lawrence 2015-05-22 14:54:12 CEST
By the way, the ISO looks like the correct one:
..../Mageia-5-x86_64-DVD/Mageia-5-x86_64-DVD.iso
DATE.txt = Tue May 19 00:04:04 CEST 2015
Bytes written: 3917479936
SHA1 sum: 9874b9959c85731ccb43e1abe286e4d5121a622b
MD5  sum: 82e489a5f61e3b74e8dcc5a21571eb7a
Comment 13 Thomas Backlund 2015-05-22 15:10:51 CEST
Yes, that iso is a correct round 2 classical iso, the filename is correct, its only the iso volume label that is wrong
Len Lawrence 2015-05-22 15:12:44 CEST

CC: tarazed25 => (none)

Comment 14 papoteur 2015-05-23 09:27:42 CEST
Hello,
The problem Len reported is not a problem in relation to Isodumper.
Comment 15 claire robinson 2015-05-23 18:26:12 CEST
Thanks guys

Validating. Advisory uploaded.

Please push to 4 updates

Thanks

Keywords: (none) => validated_update
Whiteboard: (none) => advisory mga4-64-ok
CC: (none) => sysadmin-bugs

Comment 16 Charles Edwards 2015-05-23 18:49:14 CEST
Should this update not carry a warning that it will only work for Mga5 or newer ISOs.

If user wished to copy Mga4 or older ISO they would Still need to use isodumper-41

CC: (none) => cae

Comment 17 claire robinson 2015-05-23 18:51:45 CEST
Mga4 isos never included uefi support. The feature being removed was an added option to support beta/rc mga5 isos only. All isos dump to usb in the same manner now for both mga4 and mga5 but mga5 64bit isos will also work with uefi.
Comment 18 Rémi Verschelde 2015-05-23 18:55:29 CEST
I think we should hold this update for now, and only push it just before Mageia 5 is released. People wanting to try Mageia 5 RC in the meantime need the previous isodumper which is currently in Core Updates, so it would be better not to replace it too soon IMO.

Keywords: validated_update => (none)

Comment 19 Rémi Verschelde 2015-05-23 18:55:44 CEST
(Feel free to revalidate if you don't agree though)
Comment 20 Charles Edwards 2015-05-23 19:53:51 CEST
(In reply to claire robinson from comment #17)
> Mga4 isos never included uefi support. The feature being removed was an
> added option to support beta/rc mga5 isos only. All isos dump to usb in the
> same manner now for both mga4 and mga5 but mga5 64bit isos will also work
> with uefi.


On my systems which support UEFI if I boot from usb stick that also supports UEFI that stick Can Only be booted UEFI.

That means if any of my systems boot MBR with a msdos partition table I can not 
upgrade from Mga4 to 5 using usb I can only Install.

With dvd/cd media I can choose to either boot MBR or UEFI.
Comment 21 claire robinson 2015-05-23 21:01:11 CEST
The issues you describe have nothing to do with isodumper Charles.

A full UEFI system supports GPT partition table. If you have MSDOS then IINM you'll still need to use legacy mode. Please use the ML for further discussion though.

This is now waiting for isodumper to be pushed to 4/updates and will be closed automatically when that happens.

Thanks
Comment 22 Samuel Verschelde 2015-05-27 10:11:43 CEST
(In reply to Rémi Verschelde from comment #19)
> (Feel free to revalidate if you don't agree though)

I'd rather validate it so that we make sure people have had time to update isodumper in case they forget to apply updates before they dump mga5 to their stick.
Comment 23 Rémi Verschelde 2015-05-27 10:13:22 CEST
OK, let's push it now then :)

Keywords: (none) => validated_update

Comment 24 Mageia Robot 2015-05-27 18:58:31 CEST
An update for this issue has been pushed to Mageia Updates repository.

http://advisories.mageia.org/MGAA-2015-0051.html

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.