Created attachment 6307 [details] doPartitionDisk screen When pterjan created that screen, long long ago, it was visible that the windows partition could be resized https://farm3.staticflickr.com/2429/4025954643_3de81b40fb_o.png However, after already becoming as good as invisible http://docteam.mageia.nl/en/installer/content/images/dx2-doPartitionDisks.png it has now become totally invisible: windows and mageia are glued together, without division between them.
the attachment is how it currently looks, with Adwaita
Whiteboard: (none) => 5RC
Status: NEW => ASSIGNEDAssignee: bugsquad => pterjan
Created attachment 6318 [details] Untested patch
(In reply to Pascal Terjan from comment #2) > Created attachment 6318 [details] > Untested patch I tried to patch drakx-installer-stage2-16.84-1 in SVN with it, but it fails. + /usr/bin/patch -U -s -p1 -b --suffix .0001 --fuzz=0 -i /home/marja/home2/marja/svn/drakx-installer-stage2/SOURCES/0001-show-resize-handle.patch 1 out of 3 hunks FAILED -- saving rejects to file perl-install/fs/partitioning_wizard.pm.rej perl-install/fs/partitioning_wizard.pm.rej contains: --- perl-install/fs/partitioning_wizard.pm +++ perl-install/fs/partitioning_wizard.pm @@ -305,14 +305,12 @@ sub create_display_box { my $display_box = ugtk3::gtkset_size_request(Gtk3::HBox->new(0,0), -1, 26); - my $sep_count = @parts - 1; #- ratio used to compute initial partition pixel width (each partition should be > min_width) #- though, the pixel/sectors ratio cannot be the same for all the partitions - my $initial_ratio = $totalsectors ? ($width - @parts * $minwidth - $sep_count) / $totalsectors : 1; + my $initial_ratio = $totalsectors ? ($width - @parts * $minwidth) / $totalsectors : 1; my $vbox = Gtk3::VBox->new; - my $part_sep; my $desc; if ($resize) { ~
ah, the patch doesn't work because it is made against the git version of perl-install/fs/partitioning_wizard.pm ? Will try again tonight
I'll test it properly tonight, I'm not even sure this method exists :)
(In reply to Pascal Terjan from comment #5) > I'll test it properly tonight, I'm not even sure this method exists :) lol Thanks, I'm happy to leave the testing to you :-)
Created attachment 6320 [details] Small improvement I fixed the separator between other partitions and made this one larger but this is still not enough to make it visible. I tried adding an image with the 3 dots but it caused the stage2 to crash immediately :(
(In reply to Pascal Terjan from comment #7) > Created attachment 6320 [details] > Small improvement > > I fixed the separator between other partitions and made this one larger but > this is still not enough to make it visible. > > I tried adding an image with the 3 dots but it caused the stage2 to crash > immediately :( Thanks for having tried, and for already improving it this far :-) Does "- GtkWindow no longer supports resize grips" in this message about gtk+ 3.13.4 release: https://mail.gnome.org/archives/ftp-release-list/2014-July/msg00029.html mean there is no longer a normal way to do this? CC'ing ovitters, in the hope he can maybe help.
CC: (none) => olav
Is it possible to turn the grey of the separator into black and white dots? (Can e.g. the resolution of only that seperator be set to a very low value?) If so, would that look more like a grip?
Created attachment 6322 [details] New version
commit 4e8627d6cba69fbfa8ed574f83d3722b0bdf6e49 Author: Pascal Terjan <pterjan@...> Date: Tue Apr 21 21:27:36 2015 +0000 Make the resize handler more visible (mga#15728) --- Commit Link: http://gitweb.mageia.org/software/drakx/commit/?id=4e8627d6cba69fbfa8ed574f83d3722b0bdf6e49
Closing
Status: ASSIGNED => RESOLVEDResolution: (none) => FIXED
That looks really good! Thanks Pascal
Nice job, it's indeed much clearer this way.
CC: (none) => rverschelde
commit 8a3e0a2b8b39048f5c4727cf408239a257737907 Author: Pascal Terjan <pterjan@...> Date: Tue Apr 21 21:27:36 2015 +0000 Make the resize handler more visible (mga#15728) --- Commit Link: http://gitweb.mageia.org/software/drakx/commit/?id=8a3e0a2b8b39048f5c4727cf408239a257737907