grub2 autogenerate /boot/grub2/grub.cfg.
But we miss a failsafe entry like we've with eg: grub
=> we need to generate a failsafe entry in grub2.cfg through a custom in /etc/grub.d/
Steps to Reproduce:
This can be enabled in grub2-mkconfig with the GRUB_DISABLE_RECOVERY=false var in /etc/default/grub
SuSE has a nice patch which allows for setting a string of kernel parameters for the recovery mode using GRUB_CMDLINE_LINUX_RECOVERY. I have this working in a test build.
What would you recommend that we should use?
The string that SuSE uses is:
"showopts apm=off noresume edd=off powersaved=off nohz=off highres=off processor.max_cstate=1 nomodeset x11failsafe"
We don't care about what does Suse :-)
Just add "failsafe" which is what we do for LILO/GRUB and voila.
Which means drakboot must set GRUB_CMDLINE_LINUX_RECOVERY=false then?
(In reply to Thierry Vignaud from comment #3)
> Which means drakboot must set GRUB_CMDLINE_LINUX_RECOVERY=false then?
That replaces "splash" with "single" in the kernel command line. If that is what what you want, then yes.
With the suse patch you can specify exactly what to add.
Having never used a 'failsafe' entry I'm not sure what you are expecting (or to be honest, why it's needed ;)
> (In reply to Thierry Vignaud from comment #3)
> > Which means drakboot must set GRUB_CMDLINE_LINUX_RECOVERY=false then?
Err NO! I misread your question - GRUB_CMDLINE_LINUX_RECOVERY does not exist (is not recognised) by current system - that is a new variable used when the SuSE patch is applied.
GRUB_DISABLE_RECOVERY=false is what I thought you meant :)
It is already in the default /etc/default/grub and set to true.
So we need to set it to false in /etc/default/grub.
And we need to patch grub2 to replace "splash" by "failsafe" instead of "single"
OK I can do that, but what about:
It will only be applied to new installs.
Actually, it would be drakboot job to alter /etc/default/grub.
grub2 should only be patched for the "failsafe" keyword
OK I have committed an update to grub2, patched to use 'failsafe' rather than 'single' when GRUB_DISABLE_RECOVERY=false, but I have left the default /etc/default/grub untouched.
Author: Thierry Vignaud <thierry.vignaud@...>
Date: Mon Apr 13 08:35:56 2015 -0400
do generate 'failsafe' entry for grub2 (mga#15675)