Bug 15636 - Confusing windows 8 drive letter guessing/naming in installer partitioner
Summary: Confusing windows 8 drive letter guessing/naming in installer partitioner
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Installer (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Low minor
Target Milestone: ---
Assignee: Thierry Vignaud
QA Contact:
URL:
Whiteboard:
Keywords: NEEDINFO
Depends on:
Blocks:
 
Reported: 2015-04-06 21:46 CEST by Samuel Verschelde
Modified: 2017-11-17 21:11 CET (History)
2 users (show)

See Also:
Source RPM:
CVE:
Status comment:


Attachments
Outputs from fdisk and gdisk (8.50 KB, text/plain)
2015-04-06 21:47 CEST, Samuel Verschelde
Details
ddebug.log (16.72 KB, text/plain)
2015-04-07 20:07 CEST, Samuel Verschelde
Details
don't guess a drive letter for recovery partition (mga15636) (555 bytes, patch)
2015-04-08 11:01 CEST, Thierry Vignaud
Details | Diff
report.bug.xz (292.24 KB, application/x-xz)
2015-04-08 20:54 CEST, Samuel Verschelde
Details

Description Samuel Verschelde 2015-04-06 21:46:25 CEST
(in EFI mode, although that's maybe not relevant)

Using the classical installer, at custom partitioning stage, the /media/win_c and /media/win_d mountpoint are inverted (win_c for D: and win_d for C:) and the guessed letters displayed in partition details are even different from that.

Details:

* sda1 : "Guessed letter: C". Not mounted, which is ok, but it shouldn't have 
a guessed letter at all.
* sda2 : "Guessed letter: D". Mounted as /boot/EFI, which is ok, but it 
shouldn't have a guessed letter at all
* sda4 : "Guessed letter: E". Not mounted (same comment as sda1)
* sda5 : "Guessed letter: F". Mounted as /media/win_d. Ideally should be 
"Guessed letter C" + mountpoint /media/win_c... This is the partition that 
contains the Windows 8 system, labelled Boot. Maybe we should use labels for 
mountpoints when available?

Now the second disk:

* sdb5: "Guessed letter: C" (it starts from C again, is that a bug?). Mounted 
as /media/win_c. Expected : "Guessed letter: D", mountpoint /media/win_d. 

In addition to that, the partitioner also shows the booted USB key as sdc:

* sdc1 : "Guessed letter: C" (again). No mountpoint (which is good). Expected: "Guessed letter: E", or no guessed letter at all.

Attached are outputs from fdisk and gdisk about my disks.

Reproducible: 

Steps to Reproduce:
Comment 1 Samuel Verschelde 2015-04-06 21:47:15 CEST
Created attachment 6203 [details]
Outputs from fdisk and gdisk
Comment 2 Thierry Vignaud 2015-04-07 06:45:21 CEST
You tried an old installer.
Please attach your /root/drakx/report.bug.xz for checking.
All of these should be fixed as of drakx 16.76

CC: (none) => thierry.vignaud

Thierry Vignaud 2015-04-07 06:45:44 CEST

Hardware: i586 => All

Comment 3 Samuel Verschelde 2015-04-07 20:05:57 CEST
Either the installer currently in boot-nonfree.iso on distrib-coffee is an old one, or it's not fixed. I've downloaded it again and booted it from an usb key.

To make things clear: the previous issue, which I had reported on the QA mailing list, is fixed. I mean, only the relevant partitions have mountpoints. The issue that remains is mountpoint naming and displayed guessed drive letters. Not critical, just confusing.

Attaching ddebug.log which I copied from /tmp during install.
Comment 4 Samuel Verschelde 2015-04-07 20:07:10 CEST
Created attachment 6214 [details]
ddebug.log
Comment 5 Marja Van Waes 2015-04-07 20:15:49 CEST
(In reply to Samuel VERSCHELDE from comment #3)
> Either the installer currently in boot-nonfree.iso on distrib-coffee is an
> old one, or it's not fixed. I've downloaded it again and booted it from an
> usb key.

stage2 is not _in_ boot-nonfree.iso, but stage1 on the iso pulls it in (it is called mdkinst.sqfs and can be found in /distrib/cauldron/<arch>/install/stage2/
> 
> To make things clear: the previous issue, which I had reported on the QA
> mailing list, is fixed. I mean, only the relevant partitions have
> mountpoints. The issue that remains is mountpoint naming and displayed
> guessed drive letters. Not critical, just confusing.
> 
> Attaching ddebug.log which I copied from /tmp during install.

it says 
* second stage install running (DrakX v16.78)

so you did indeed use a newer one

CC: (none) => marja11

Marja Van Waes 2015-04-07 20:19:03 CEST

Attachment 6214 mime type: text/x-log => text/plain

Comment 6 Thierry Vignaud 2015-04-08 09:58:54 CEST
Comment on attachment 6214 [details]
ddebug.log

This is useless, you didn't go further so we don't see what the installer would have done...

Attachment 6214 is obsolete: 0 => 1

Comment 7 Samuel Verschelde 2015-04-08 10:14:34 CEST
I don't think you understood by bug report, or I don't understand your comment. My bug report is not about what the installer will do afterwards, but what it does at partitioning stage.

I know what it does afterwards. It does what it announces when I select the partitions in the partitioner to see their information:
* set /dev/sda2 mountpoint as /boot/EFI (which is OK)
* set /dev/sda5 mountpoint as /media/win_d (should be /media/win_c)
* set /dev/sdb5 mountpoint as /media/win_c (should be /media/win_d)

Doesn't mount other windows partitions anymore, since version 16.78 (which is OK since they are recovery or hidden partitions).

And the "Guessed letter" information displayed in each partition's information in the partitionner:
* is wrong
* uses the letter "C" 3 times
* is not coherent with the mountpoint names
Comment 8 Thierry Vignaud 2015-04-08 10:36:47 CEST
I fail to see any "set /dev/" in the report.bug you attached...
Thierry Vignaud 2015-04-08 10:39:31 CEST

Keywords: (none) => NEEDINFO

Comment 9 Samuel Verschelde 2015-04-08 10:48:03 CEST
I first thought you needed the logs for checking the version, since you said I was using an old installer. Now if you need the complete logs until installation, if that helps I'll provide that tonight.
Comment 10 Rémi Verschelde 2015-04-08 10:53:56 CEST
ddebug.log shows you have a /dev/sda6 partition with:
/dev/sda6  147666944 198866943  51200000 24.4G Microsoft basic data

Shouldn't a drive letter be guessed for this one too and a mount point assigned?

As for this bug report, I see two related bugs:

1) "Guessed letter" and the actual mount point are not synced (e.g. "Guessed letter: F" ends up as /media/win_d when it should be /media/win_f.

2) Recovery partitions and stuff like that are properly ignored for the mount point, but they are still taken into account in the "Guessed letter" logic (fixing this should fix (1), but maybe (1) also calls for a check that guessed letter and mount point are the same?)
Comment 11 Thierry Vignaud 2015-04-08 10:56:51 CEST
(In reply to Samuel VERSCHELDE from comment #9)
yes I want the complete logs.

(In reply to Rémi Verschelde from comment #10)
for 2) we might have a missing call to isRecovery() in the partition view
Comment 12 Thierry Vignaud 2015-04-08 11:01:48 CEST
Created attachment 6219 [details]
don't guess a drive letter for recovery partition (mga15636)

untested
Comment 13 Samuel Verschelde 2015-04-08 20:54:52 CEST
Created attachment 6223 [details]
report.bug.xz
Comment 14 Thierry Vignaud 2015-04-09 14:59:44 CEST
(In reply to Rémi Verschelde from comment #10)
> ddebug.log shows you have a /dev/sda6 partition with:
> /dev/sda6  147666944 198866943  51200000 24.4G Microsoft basic data
> 
> Shouldn't a drive letter be guessed for this one too and a mount point
> assigned?

sda6 really is an ext4 partition (it's the root partition)
Thierry Vignaud 2015-04-30 22:29:54 CEST

Priority: Normal => Low
Severity: normal => minor

Comment 15 Samuel Verschelde 2015-06-02 14:50:11 CEST
Is this bug report still NEEDINFO because there's a patch to test?

Keywords: (none) => PATCH
Assignee: bugsquad => thierry.vignaud

Comment 16 Thierry Vignaud 2015-06-02 15:25:41 CEST
Patch is already applied

Keywords: PATCH => (none)

Comment 17 Samuel Verschelde 2015-06-02 15:37:27 CEST
(In reply to Thierry Vignaud from comment #16)
> Patch is already applied

You mean attachment 6219 [details] which you described as untested? (I haven't tested myself yet /o\)
Comment 19 Thierry Vignaud 2015-06-02 15:44:56 CEST
You can test Mga5 RC or final.
Comment 20 Marja Van Waes 2017-11-17 21:11:05 CET
(In reply to Thierry Vignaud from comment #18)
> Yes:
> http://gitweb.mageia.org/software/drakx/commit/perl-install/partition_table.
> pm?id=5efbf00cc1845b67ac7d4a03b9a75ecf18e50004

(In reply to Thierry Vignaud from comment #19)
> You can test Mga5 RC or final.

No one replied that the fix doesn't work, so assuming the fix works well.

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.