Bug 15503 - tcl-tcllib new XSS security issue
Summary: tcl-tcllib new XSS security issue
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Security (show other bugs)
Version: 4
Hardware: i586 Linux
Priority: Normal major
Target Milestone: ---
Assignee: QA Team
QA Contact: Sec team
URL: http://lwn.net/Vulnerabilities/636948/
Whiteboard: has_procedure advisory MGA4-32-OK MGA...
Keywords: validated_update
Depends on:
Blocks:
 
Reported: 2015-03-16 20:41 CET by David Walser
Modified: 2015-05-07 11:12 CEST (History)
3 users (show)

See Also:
Source RPM: tcl-tcllib-1.13-5.mga5.src.rpm
CVE:
Status comment:


Attachments
test log for 64 bit test (2.91 KB, text/plain)
2015-05-07 09:35 CEST, Vladimir Zawalinski
Details

Description David Walser 2015-03-16 20:41:17 CET
Fedora has issued an advisory on March 5:
https://lists.fedoraproject.org/pipermail/package-announce/2015-March/151847.html

Fedora updated it to 1.16 and added a patch to fix this issue in this commit:
http://pkgs.fedoraproject.org/cgit/tcllib.git/commit/?h=f21&id=ef43118e860831d125864519ac2dca25de4e7ad7

The upstream bug and commit to fix this issue are linked in the RedHat bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1197669

Mageia 4 and Mageia 5 are affected.

Reproducible: 

Steps to Reproduce:
David Walser 2015-03-16 20:41:54 CET

Whiteboard: (none) => MGA5TOO, MGA4TOO

David Walser 2015-03-26 18:37:58 CET

Assignee: bugsquad => joequant

Comment 1 David Walser 2015-04-30 18:10:45 CEST
Ping?  Joseph, you are the maintainer of most of the packages that require this one.
Comment 2 Joseph Wang 2015-05-01 06:54:59 CEST
Pushed the fix to cauldron
Comment 3 David Walser 2015-05-01 21:20:39 CEST
Thanks Joseph!

Updated and patched packages uploaded for Mageia 4 and Cauldron.

Advisory:
========================

Updated tcl-tcllib package fixes security vulnerability:

tcllib is vulnerable to a Cross-Site-Scripting (XSS) issue in html::textarea.

References:
https://lists.fedoraproject.org/pipermail/package-announce/2015-March/151847.html
========================

Updated packages in core/updates_testing:
========================
tcl-tcllib-1.16-1.mga4

from tcl-tcllib-1.16-1.mga4.src.rpm

CC: (none) => joequant
Version: Cauldron => 4
Assignee: joequant => qa-bugs
Whiteboard: MGA5TOO, MGA4TOO => (none)

Comment 4 Vladimir Zawalinski 2015-05-05 10:53:28 CEST
Testing MGA4.1  32 and 64 bit, Vbox hardware

Following procedure here:
http://www.tldp.org/HOWTO/TclTk-HOWTO-5.html
to execute a rudimentary proc. in MGA4.1  32 and 64 bit architectures on vbox

CC: (none) => vzawalin1

Vladimir Zawalinski 2015-05-05 10:56:33 CEST

Whiteboard: (none) => has_procedure

Comment 5 claire robinson 2015-05-05 11:01:31 CEST
There is a PoC if you want to experiment with it Vlad
http://core.tcl.tk/tcllib/tktview/09110adc430de8c91d26015f9697cdd099755e63
Comment 6 Vladimir Zawalinski 2015-05-05 11:30:32 CEST
Thank you Claire and Shlomi, for your respective tips!

CC: (none) => shlomif

Comment 7 Shlomi Fish 2015-05-05 11:57:03 CEST
(In reply to Vladimir Zawalinski from comment #6)
> Thank you Claire and Shlomi, for your respective tips!

What are you talking about? I didn't say anything about this bug.
Comment 8 Vladimir Zawalinski 2015-05-05 13:23:23 CEST
(In reply to Shlomi Fish from comment #7)
> (In reply to Vladimir Zawalinski from comment #6)
> > Thank you Claire and Shlomi, for your respective tips!
> 
> What are you talking about? I didn't say anything about this bug.

Apologies. You didn't. I had both bug reports open as well as email and inadvertently got my comments mixed. I was referring to your post on 15803.
Comment 9 Shlomi Fish 2015-05-05 13:53:15 CEST
(In reply to Vladimir Zawalinski from comment #8)
> (In reply to Shlomi Fish from comment #7)
> > (In reply to Vladimir Zawalinski from comment #6)
> > > Thank you Claire and Shlomi, for your respective tips!
> > 
> > What are you talking about? I didn't say anything about this bug.
> 
> Apologies. You didn't. I had both bug reports open as well as email and
> inadvertently got my comments mixed. I was referring to your post on 15803.

I see. Thanks for the clarification.
Comment 10 Vladimir Zawalinski 2015-05-06 08:56:02 CEST
(In reply to claire robinson from comment #5)
> There is a PoC if you want to experiment with it Vlad
> http://core.tcl.tk/tcllib/tktview/09110adc430de8c91d26015f9697cdd099755e63

Claire, the web example quoted in the PoC in examples.com no longer exists. To follow that avenue through I would have to learn a bit of Tcl/Tk, something that I don't necessarily want to do right now, nor is there enough time to do so.

So I am taking the approach that it is assumed the developers have plugged the security hole and it is no necessary to do that, but it is necessary to show that Tcl-lib as patched for the bug has not introduced other problems.

I have executed two rudimentary scripts, before and after updating from "updates-testing for each architecture.

The first throws a GUI window and offers a button to close. It is irrelevant to the testing since it also executed when tcl-tcllib was removed.

The second executes the example shown on the tcl ticket that you provided. This script does depend on the presence of tcl-tcllib, and executed as expected before and after application of the update.

Version of tcl-tcllib before the update was 1.13.3.mga4
Version of tcl-tcllib after the update  was 1.16.1.mga4 (noarch.rpm)

I therefore conclude that there was no regression to rudimentary functionality in Mageia4.1 32 bit environment using the test performed.
Vladimir Zawalinski 2015-05-06 08:56:27 CEST

CC: shlomif => (none)

Vladimir Zawalinski 2015-05-06 08:57:06 CEST

CC: (none) => eeeemail

Comment 11 claire robinson 2015-05-06 09:37:06 CEST
example.com usually means replace it with a domain of your choice. You could use localhost for example. It looks like it will open an alert window, which is how this sort of thing is normally demonstrated.

You testing is fine though, well done! 64bit next then please and then we can validate it.

Email from bugs assigned to QA comes to qa-bugs ML so it's best not to add yourself to CC for updates or you'll get two emails each time.

CC: eeeemail => (none)

Comment 12 claire robinson 2015-05-06 09:37:59 CEST
Please remember to add the relevant whiteboard marker for your tests when you're happy with the result.
Comment 13 Vladimir Zawalinski 2015-05-06 09:41:14 CEST
(In reply to claire robinson from comment #12)
> Please remember to add the relevant whiteboard marker for your tests when
> you're happy with the result.

Thanks for the reassurance. Will update the whiteboard after I have completed the 64 bit tests.

CC: vzawalin1 => (none)

Comment 14 Vladimir Zawalinski 2015-05-07 09:35:25 CEST
Created attachment 6459 [details]
test log for 64 bit test

CC: (none) => vzawalin1

Comment 15 Vladimir Zawalinski 2015-05-07 09:42:19 CEST
Same test process as for 32 bit test.
Ran the test script shown at end of attachment. This needs 'ncgi' which is in tcl-tcllib.
This was run for tcl-tcllib  versions 1.13.3 and 1.16.1 respectively.
No difference in results so conclude no observable regression in rudimentary functionality
Vladimir Zawalinski 2015-05-07 09:43:42 CEST

Whiteboard: has_procedure => has_procedure MGA4-32-OK MGA4-64-OK

claire robinson 2015-05-07 10:33:11 CEST

Attachment 6459 mime type: application/octet-stream => text/plain

Comment 16 claire robinson 2015-05-07 10:54:23 CEST
Well done Vlad. Congratulations on your first update!

Confirmed with..

$ tclsh
%   package require ncgi
  package require html
  
  ::ncgi::parse
  ::ncgi::header
  puts [::html::textarea ta]
  puts textarea
  puts ta
1.4.2
% 1.4
% % % Content-Type: text/html

% <textarea name="ta"></textarea>

% textarea
% ta

No obvious regression.



Validating. Advisory uploaded.

Please push to 4 updates

Thanks!

Keywords: (none) => validated_update
Whiteboard: has_procedure MGA4-32-OK MGA4-64-OK => has_procedure advisory MGA4-32-OK MGA4-64-OK
CC: (none) => sysadmin-bugs

Comment 17 Mageia Robot 2015-05-07 11:12:56 CEST
An update for this issue has been pushed to Mageia Updates repository.

http://advisories.mageia.org/MGASA-2015-0201.html

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.