Bug 15001 - switch_themes script in bootsplash should rebuild the initrd when updating plymouth theme
Summary: switch_themes script in bootsplash should rebuild the initrd when updating pl...
Status: NEW
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: Mageia 7
Assignee: All Packagers
QA Contact:
URL:
Whiteboard: MGA5TOO
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-10 14:36 CET by Rémi Verschelde
Modified: 2017-03-25 14:57 CET (History)
5 users (show)

See Also:
Source RPM: bootsplash-3.3.11-4.mga5
CVE:
Status comment:


Attachments

Description Rémi Verschelde 2015-01-10 14:36:28 CET
As pointed out in 14864, updating mageia-theme-Default (which calls among others /usr/share/bootsplash/scripts/switch_themes Mageia-Default in its %posttrans) should rebuild the initrd.

Barry experienced that it's necessary at least for grub2 users (I did not need to do so here on a system with grub legacy).

Currently in its "update" function switch_themes calls:
    if [[ -z $update ]]; then
	    /usr/sbin/plymouth-set-default-theme $theme
    fi

/usr/sbin/plymouth-set-default-theme has a --rebuild-initrd switch:
  -R, --rebuild-initrd   Rebuild initrd (necessary after changing theme)

Adding this switch to the switch_themes instruction should do the trick.

Reproducible: 

Steps to Reproduce:
Comment 1 Rémi Verschelde 2015-01-10 14:36:55 CET
CC'ing shlomi who is the maintainer of bootsplash. WDYT?

CC: (none) => shlomif

Rémi Verschelde 2015-01-10 14:37:10 CET

CC: (none) => zen25000

Comment 2 Shlomi Fish 2015-01-10 16:38:04 CET
Hello Rémi,

(In reply to Rémi Verschelde from comment #1)
> CC'ing shlomi who is the maintainer of bootsplash. WDYT?

no idea about that - I just adopted bootsplash because it was an orphan and I'm not knowledgeable about it. If you want, I can revoke my maintainer status of it.

Regards,

-- Shlomi Fish
Comment 3 Barry Jackson 2015-03-20 18:21:33 CET
CCing Thomas as he has been looking at a similar issue in Bug15486

CC: (none) => tmb

Samuel Verschelde 2015-05-31 23:19:31 CEST

Whiteboard: (none) => MGA5TOO

Comment 4 Rémi Verschelde 2015-06-01 19:26:25 CEST
Adding to the Mageia 6 tracker so that we don't forget about it (though the whole theme scripts should probably be completely reworked for Mageia 6, thus obsoleting this report).

Blocks: (none) => 15527

Samuel Verschelde 2015-06-02 10:01:55 CEST

Target Milestone: --- => Mageia 6

Comment 5 Samuel Verschelde 2015-06-02 10:10:22 CEST
Rémi, is this worth an ERRATA entry?
Comment 6 Rémi Verschelde 2015-06-02 10:29:21 CEST
I think so, at least if installing a custom theme (e.g. plymouth-theme-glow) does not trigger a rebuild of the initrd. I'll try that to confirm.

Whiteboard: MGA5TOO => MGA5TOO FOR_ERRATA

Comment 7 Rémi Verschelde 2015-06-02 10:36:24 CEST
Actually no, custom plymouth themes do trigger a rebuild of the initrd when installed. It's only if you update mageia-theme-Default that no rebuild is done, so it shouldn't affect Mageia 5 users (unless we provide an update to mageia-theme and forget about this bug).

Whiteboard: MGA5TOO FOR_ERRATA => MGA5TOO

Comment 8 Marja Van Waes 2016-07-12 17:27:53 CEST
(In reply to Rémi Verschelde from comment #4)
> Adding to the Mageia 6 tracker so that we don't forget about it (though the
> whole theme scripts should probably be completely reworked for Mageia 6,
> thus obsoleting this report).

And? Did the scripts get reworked, too?

CC: (none) => marja11

Comment 9 Rémi Verschelde 2016-07-13 11:25:52 CEST
Not that I know of, but it's not critical for Mageia 6 as long as the initrd is properly rebuilt for the new theme before making the ISOs.

Blocks: 15527 => 18932

Comment 10 Samuel Verschelde 2016-10-10 23:07:15 CEST
Assigning to all packagers collectively since Shlomi has no idea how to fix it.

Blocks: 18932 => (none)
Assignee: bugsquad => pkg-bugs
Target Milestone: Mageia 6 => Mageia 7

Comment 11 Donald 2017-03-25 14:01:03 CET
This should be added, while it's unlikely that an update to Mageia-theme would be shipped, the penalty for having this is small.

Rebuilding the initrd should take too long and while the regularity of kernel updates flush this out to a large degree, it is surely still good form to have the the initrd rebuild to show any theme changes in case we get another Mageia 2 like incident.

CC: (none) => watersnowrock

Comment 12 Thomas Backlund 2017-03-25 14:57:57 CET
If you restrict it to rebuilding current initrd it could be ok.

But its not ok to rebuild all found initrds as it could cause a previous working kernel/initrd to becomu unbootable in case there is some bugs, rendering the recovery processes unusable...

Note You need to log in before you can comment on or make changes to this bug.