Bug 14210 - Two trash icons on LXDE desktop
Summary: Two trash icons on LXDE desktop
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 5
Hardware: All Linux
Priority: Normal enhancement
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard: IN_ERRATA advisory MGA5-64-OK
Keywords: validated_update
Depends on: 14288
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-01 22:54 CEST by Nicolas Salguero
Modified: 2016-03-16 19:08 CET (History)
3 users (show)

See Also:
Source RPM: mageia-lxde-config, pcmanfm
CVE:
Status comment:


Attachments
This source RPM is obsolete (see https://bugs.mageia.org/attachment.cgi?id=5507) (404.57 KB, application/x-rpm)
2014-10-01 22:54 CEST, Nicolas Salguero
Details

Description Nicolas Salguero 2014-10-01 22:54:50 CEST
Created attachment 5465 [details]
This source RPM is obsolete (see https://bugs.mageia.org/attachment.cgi?id=5507)

Hi,

When logging on LXDE, two trash icons appear on LXDE desktop.

Best regards.

Nico.
Nicolas Salguero 2014-10-17 09:26:03 CEST

Attachment 5465 is obsolete: 0 => 1
Attachment 5465 description: RPM source => This source RPM is obsolete (see https://bugs.mageia.org/attachment.cgi?id=5507)

Comment 1 Alex Loginov 2014-10-22 13:02:15 CEST
Patch was commited and will be fixed with an update for pcmanfm-1.2.3.
See https://bugs.mageia.org/show_bug.cgi?id=14288

*** This bug has been marked as a duplicate of bug 14288 ***

Status: NEW => RESOLVED
CC: (none) => loginov_alex
Resolution: (none) => DUPLICATE

Comment 2 Alex Loginov 2014-10-22 16:30:12 CEST
Oops, it's not a duplicate.

Status: RESOLVED => REOPENED
Depends on: (none) => 14288
Resolution: DUPLICATE => (none)

Comment 3 Alex Loginov 2014-10-23 22:51:32 CEST
You will see two trash icons if to enable trash in settings. So, we have a partial fix.
Comment 4 Nicolas Salguero 2015-05-27 11:21:26 CEST
I have updated the errata https://wiki.mageia.org/en/Mageia_5_Errata#LXDE concerning this problem.

Whiteboard: (none) => IN_ERRATA

Comment 5 Nicolas Salguero 2016-03-02 11:21:51 CET
Suggested advisory:
========================

The updated packages remove the trash.desktop file from mageia-lxde-config-Default package and re-enable trash in pcmanfm settings.  So, for a new user, it will not be possible to have two trash icons on LXDE desktop.  Existing users who once logged into LXDE will have to manually remove the trash.desktop file present on their desktop and enable trash in their pcmanfm settings.
========================

Updated packages in core/updates_testing:
========================
i586:
mageia-lxde-config-Default-0.6.4-1.1.mga5.noarch.rpm
pcmanfm-1.2.3-2.1.mga5.i586.rpm

x86_64:
mageia-lxde-config-Default-0.6.4-1.1.mga5.noarch.rpm
pcmanfm-1.2.3-2.1.mga5.x86_64.rpm

Source RPMs:
mageia-lxde-config-Default-0.6.4-1.1.mga5.src.rpm
pcmanfm-1.2.3-2.1.mga5.src.rpm

Status: REOPENED => ASSIGNED
Assignee: bugsquad => qa-bugs

Nicolas Salguero 2016-03-02 11:23:16 CET

Version: Cauldron => 5

Comment 6 Nicolas Salguero 2016-03-02 12:50:02 CET
Oops, there was an error in Source RPMs: it is "mageia-lxde-config-0.6.4-1.1.mga5.src.rpm".

Source RPM: (none) => mageia-lxde-config, pcmanfm

Comment 7 Lewis Smith 2016-03-02 21:41:47 CET
@Nicolas

I have LXDE long installed, with only one Trash Desktop icon:
 /home/lewis/Desktop/org.lxde.trash.desktop
I cannot remember whether there were two originally (& I deleted the duplicate). 
PCmanFM has in Edit-Preferences-General=Behaviour "Move deleted files to Trash can" checked.
Can you please say how to get back to the original duplicate Trash Desktop icons in order to test this update?
Is this update only applicable to *new* LXDE users? What should be its effect on existing users with 2 icons? Or 1 if they have deleted a duplicate?
TIA

CC: (none) => lewyssmith

Comment 8 Nicolas Salguero 2016-03-02 22:52:19 CET
Hi,

When you right-click on the desktop, choose "Desktop Preferences".  In the tab "Desktop Icons", click on the check-box 'Show "Trash Can" folder on the desktop'.  You obtain two trash icons on the desktop.

The new packages modify the "template" used to initialize LXDE configuration for a user logging into LXDE for the first time: they do not give the org.lxde.trash.desktop but use the way provided by pcmanfm to display the trash icon on the desktop.

For existing users, the new packages do nothing: the users are free to keep their org.lxde.trash.desktop but, if they want to use the trash icon directly provided by pcmanfm, they will have to manually delete their org.lxde.trash.desktop if they do not want two trash icons on the desktop.

Best regards,

Nico.
Comment 9 Lewis Smith 2016-03-03 20:18:00 CET
Testing x64 real hardware, LXDE Desktop

Thanks Nicolas for your Comment 8.
This is all somewhat nebulous. Before the update, I had only Desktop Trash shortcut icon ~/Desktop/org.lxde.trash.desktop, presumably having deleted the PCmanFM one previously. I restored that as described: right-click Desktop, Desktop Preferences, Desktop Icons, tick 'Show Trashcan folder'.
Result: 2 icons, the new PCmanFM one *not* being a shortcut.
Applied the update:
 mageia-lxde-config-Default-0.6.4-1.1.mga5.noarch.rpm
 pcmanfm-1.2.3-2.1.mga5.x86_64.rpm
Logout, Login. No change: both icons (expected).
Out of interest, I manually deleted ~/Desktop/org.lxde.trash.desktop  which left the icon on the desktop! Logout/Login still showed both icons - and the deleted file restored.
So I right-clicked the old Desktop shortcut Trash icon, deleted it from the pop-up menu; the file disappeared along with the icon, leaving just the PCmanFM one. Logout/Login shows just the one Trash icon, the file
 ~/Desktop/org.lxde.trash.desktop
is *not* re-created.
Accepting that this update is really for new LXDE Desktop installations, I am happy to OK it. (Not willing to take out LXDE for re-installation; this sort of thing can be catastrophic).

BTW I wonder whether the advice "For existing users, the new packages do nothing: the users are free to keep their org.lxde.trash.desktop but, if they want to use the trash icon directly provided by pcmanfm, they will have to manually delete their org.lxde.trash.desktop if they do not want two trash icons on the desktop" should be one of those update 'read this info' pop-ups.

Whiteboard: IN_ERRATA => IN_ERRATA MGA5-64-OK

Comment 10 claire robinson 2016-03-15 19:38:44 CET
Validating. Advisory uploaded with tweaks as below..

+  The updated packages remove the trash.desktop file from 
+  mageia-lxde-config-Default package and re-enable trash in pcmanfm settings.  
+  So, for a new user, it will not be possible to have two trash icons on LXDE 
+  desktop.
+
+  For existing users, the new packages do nothing: the users are free to keep 
+  their org.lxde.trash.desktop but, if they want to use the trash icon directly 
+  provided by pcmanfm, they will have to manually delete org.lxde.trash.desktop
+  from ~/Desktop if they do not want two trash icons on the desktop.

Keywords: (none) => validated_update
Whiteboard: IN_ERRATA MGA5-64-OK => IN_ERRATA advisory MGA5-64-OK
CC: (none) => sysadmin-bugs

Comment 11 Mageia Robot 2016-03-16 19:08:05 CET
An update for this issue has been pushed to the Mageia Updates repository.

http://advisories.mageia.org/MGAA-2016-0041.html

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.