Bug 13679 - Diskdrake shows no partitions for sda (initially) when custom partitioning in 5alpha1 i586 live installer
Summary: Diskdrake shows no partitions for sda (initially) when custom partitioning in...
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Installer (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: release_blocker normal
Target Milestone: ---
Assignee: Thierry Vignaud
QA Contact:
URL:
Whiteboard: 5RC
Keywords: PATCH
: 11988 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-07-04 18:42 CEST by Barry Jackson
Modified: 2015-03-23 22:55 CET (History)
9 users (show)

See Also:
Source RPM:
CVE:
Status comment:


Attachments
Screenshot (603.70 KB, image/png)
2014-07-04 22:52 CEST, Barry Jackson
Details

Description Barry Jackson 2014-07-04 18:42:33 CEST
Description of problem:
When custom partitioning is selected in installer, diskdrake initially shows no partitions for sda although it is the active tab. Clicking on sdb does show partitions, as does sda eventually when clicked on.

Could be rather disconcerting for a user not familiar with diskdrake 

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.


Reproducible: 

Steps to Reproduce:
Barry Jackson 2014-07-04 18:42:52 CEST

Whiteboard: (none) => 5alpha1

Comment 1 Barry Jackson 2014-07-04 22:52:25 CEST
Created attachment 5254 [details]
Screenshot
Comment 2 claire robinson 2014-07-04 23:03:04 CEST
Guessing this is probably to do with the ongoing gtk updates too.

Might help to see what's going on if you could attach a report.bug from tty2 in the installer Barry. Try the 'bug' command to dump it onto a usb stick.

Thanks

CC: (none) => eeeemail, olav
Assignee: bugsquad => thierry.vignaud

Comment 3 Barry Jackson 2014-07-05 00:55:38 CEST
I have done lots more testing tonight on this using:

Mageia-5-alpha1-LiveCD-KDE4-en-i586-CD.iso (round 3)
Mageia-5-alpha1-LiveDVD-KDE4-x86_64-DVD.iso (round 3)
Mageia-5-alpha1-x86_64-DVD.iso

Despite originally seeing this on the full DVD classical installer (unless I made a mistake on the pad), I can now only reproduce it using the i586 Live iso, and only when installing directly (not from live mode).

@Claire - I tried using 'bug' command but it seems not to be available in the live install.

Hardware: x86_64 => i586

Barry Jackson 2014-07-05 00:56:42 CEST

Summary: Diskdrake shows no partitions for sda (initially) when custom partitioning in 5alpha1 installer => Diskdrake shows no partitions for sda (initially) when custom partitioning in 5alpha1 i586 live installer

Comment 4 Thierry Vignaud 2014-07-09 16:03:24 CEST
Humm, that's a very old bug that strikes again (see eg: bug #5661 & bug #11988)
Comment 5 Barry Jackson 2015-03-08 23:08:19 CET
I have seen it recently installing Mga5-RC.
sda is blank until sdb tab is clicked and sda is clicked - from then on it works OK. 
I don't know what happens with only one drive as have only been testing multi-drive installs.
Comment 6 Sander Lepik 2015-03-08 23:12:33 CET
I've seen it happening with mga4.1 classical installer and with mga5b3 live installer. Both were done with USB stick, so I was able to click on sdb and then again on sda.

CC: (none) => mageia

Comment 7 Sander Lepik 2015-03-12 10:03:55 CET
*** Bug 15474 has been marked as a duplicate of this bug. ***

CC: (none) => unruh

Sander Lepik 2015-03-12 10:04:18 CET

Priority: Normal => release_blocker
Hardware: i586 => All

Comment 8 Marja Van Waes 2015-03-14 21:07:53 CET
seen with pre-RC

CC: (none) => marja11
Whiteboard: 5alpha1 => 5RC

Comment 9 David Walser 2015-03-17 16:04:22 CET
*** Bug 11988 has been marked as a duplicate of this bug. ***

CC: (none) => mageia

Comment 10 Martin Whitaker 2015-03-18 22:50:18 CET
I've traced what's causing this behaviour.

When running on the desktop, the first switch_page signal received by the diskdrake notebook widget has a page index of 0. This causes the partition buttons and info for the first device (sda) to be generated and displayed once the widget is drawn.

When running in the installer, the first switch_page signal has a page index of 1 (this is with two devices present - I'd guess it would be the last page index with more devices). This causes the partition buttons and info for the second device (sdb) to be generated. However, when the widget is drawn, it is the first page that is displayed, hence no partition buttons and info.

This patch fixes the bug for me:

--- mdkinst/lib/libDrakX/diskdrake/hd_gtk.pm.orig	2015-03-18 21:24:09.126965475 +0000
+++ mdkinst/lib/libDrakX/diskdrake/hd_gtk.pm	2015-03-18 21:24:39.269821371 +0000
@@ -113,6 +113,7 @@
     # ensure partitions bar is properly sized on first display:
     $notebook_widget->signal_connect(realize => $update_all);
     $w->sync;
+    $notebook_widget->set_current_page(0);
     # workaround for $notebook_widget being realized too early:
     if (!$done_button) {
 	$notebook_widget->set_current_page(-1);

P.S. In my case, sdb is the USB stick I'm using for the installation. Should this appear as an installation destination?
Comment 11 Barry Jackson 2015-03-19 00:51:07 CET
(In reply to Martin Whitaker from comment #10)
> I've traced what's causing this behaviour.
Nice!
> P.S. In my case, sdb is the USB stick I'm using for the installation. Should
> this appear as an installation destination?
In that view it's not actually being suggested "as an installation destination" is it, so I would say yes it should be shown as it's part of the system at that time.
Rémi Verschelde 2015-03-19 15:22:39 CET

Keywords: (none) => PATCH
CC: (none) => remi

Comment 12 Ben McMonagle 2015-03-20 08:54:23 CET
apparent in Mageia-5-RC-x86_64-DVD

multiple HDDs system

CC: (none) => westel

Comment 13 Sander Lepik 2015-03-20 10:28:07 CET
Thierry, can you review the patch and apply if it seems OK?
Comment 14 Rémi Verschelde 2015-03-20 11:02:44 CET
Thanks for your patch Martin!

As for bug 13894, I've added the proposed patch to the drakx-installer-stage2 package for now (drakx-installer-stage2-16.68-3.mga5). I'll let Thierry review the patch and commit it to the git repo if it's the good fix.
Comment 15 Marja Van Waes 2015-03-20 12:27:28 CET
(In reply to Rémi Verschelde from comment #14)
> Thanks for your patch Martin!
> 
> As for bug 13894, I've added the proposed patch to the
> drakx-installer-stage2 package for now
> (drakx-installer-stage2-16.68-3.mga5). I'll let Thierry review the patch and
> commit it to the git repo if it's the good fix.

I've tested "DrakX v16.68_3_Akien"-stage2 *5* times on a 64bits efi system where I've seen the bug several times, including on recent installs, but probably not in every install I did.

Tested with and without ext. HD attached, directly going into Custom or first choosing to use existing partitions and then returning to the doPartitionDisks screen and then selecting "Custom", etc. ..... in all cases, the partitions were immediately visible after selecting "Custom"
Comment 16 Mageia Robot 2015-03-20 21:40:19 CET
commit a6bbd53b018cff4c36b31347d72b8b915ffa8583
Author: Thomas Backlund <tmb@...>
Date:   Fri Mar 20 22:33:54 2015 +0159

    fix initial display in diskdrake (Martin Whitaker, mga#13679)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=a6bbd53b018cff4c36b31347d72b8b915ffa8583
Comment 17 Anne Nicolas 2015-03-23 22:51:00 CET
Fixed in last set of isos including this patch

Status: NEW => RESOLVED
CC: (none) => ennael1
Resolution: (none) => FIXED

Comment 18 w unruh 2015-03-23 22:55:18 CET
Thanks to all for fixing this.

Note You need to log in before you can comment on or make changes to this bug.