Bug 13428 - update request: removal of X memory leak in Intel video driver
Summary: update request: removal of X memory leak in Intel video driver
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 4
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard: mga4-64-ok, MGA4-32-OK advisory
Keywords: validated_update
Depends on:
Blocks:
 
Reported: 2014-05-23 11:10 CEST by Guillaume Lang
Modified: 2014-06-27 17:28 CEST (History)
8 users (show)

See Also:
Source RPM: x11-driver-video-intel-2.99.907-2.mga4.src.rpm
CVE:
Status comment:


Attachments

Description Guillaume Lang 2014-05-23 11:10:17 CEST
Description of problem:
X leaks memory, easily using over 1GB after a few days (see also multi-GBs leaks: https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/1272338).

Hardware: Sandy Bridge HD3000

This problem would appear to be solved in release 2.99.908 of the driver:
http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/NEWS
"""
* Cap the freed Pixmap cache and reuse it more often
    Fixes a regression in 2.99.907 that caused the memory used by X to
    grow until it was cleaned up during server regreneration
    https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/1272338
"""


Version-Release number of selected component (if applicable):
x11-driver-video-intel 2.99.907-2.mga4

How reproducible:
The leak occurs again after restarting the computer.

Steps to Reproduce:
1. Do various things (web browsing).
2. X memory use slowly creeps up, never to come down.


Reproducible: 

Steps to Reproduce:
Comment 1 Thomas Backlund 2014-05-29 21:04:15 CEST
There is now a x11-driver-video-intel-2.99.909-1.1.mga4 available for tests in 

Mageia 4 Core Updates Testing


Advisory:
Updated x11-driver-video-intel fixes memory leak and other issues:

* Restore the pipe stall when changing CC state on gen6, otherwise
  the GPU may not flush intermediate results from all EU resulting
  in render corruption (usually the occasional black box).
  Regression from 2.99.906
  https://bugs.freedesktop.org/show_bug.cgi?id=72375

* Fix invalid pageflipping of GLXPixmaps by UXA.
  https://bugs.freedesktop.org/show_bug.cgi?id=73282

* Consistently treat DPMS Suspend/Standy as Off, otherwise we may
  incorrectly restore the backlight in UXA.

* Fix disabling the backlight in UXA when querying the value whilst off
  https://bugs.freedesktop.org/show_bug.cgi?id=73181.

* Invalidate between every operation if rendering into the source or mask.
  Fixes regression in 2.99.907 on Ivybridge (seen in KDE)
  https://bugs.freedesktop.org/show_bug.cgi?id=73208

* Check for available batch buffer state before restoring state on gen4,
  otherwise we overwrite surface state with commands and cause a GPU hang.
  https://bugs.freedesktop.org/show_bug.cgi?id=73348

* Prevent an invalid free by TearFree
  https://bugs.freedesktop.org/show_bug.cgi?id=73469

* Fix confusion in TearFree when it tried to pageflip to a stale bo
  https://bugs.freedesktop.org/show_bug.cgi?id=70905

* Initialise TearFree contents with the current frontbuffer upon creation,
  otherwise old content may be visible for significant fractions of a
  second after resume or DPMS on
  https://bugs.freedesktop.org/show_bug.cgi?id=73842

* Nullify the old pointer into a CPU mmapping of the bo when promoting it
  on the GPU. Eventually that old pointer becomes invalid and will cause
  the Xserver to crash.
  Fixes regression in 2.99.906
  https://bugs.freedesktop.org/show_bug.cgi?id=73351

* Restore the serialNumber on the GC correctly after falling back to
  software. This was seen to cause corruption with Wine.
  https://bugs.freedesktop.org/show_bug.cgi?id=73856

* Do not ignore CPU damage on a pixmap unless the Composite operation
  will completely overwrite it. This was observed in xfce4.
  https://bugs.freedesktop.org/show_bug.cgi?id=69528

* Skip fake outputs during initial probe as they can cause a NULL pointer
  dereference.
  https://bugs.freedesktop.org/show_bug.cgi?id=73981

* Fix rendering of dashed zero-width lines onto 24bit buffers
  https://bugzilla.redhat.com/show_bug.cgi?id=1059152

* Cap the freed Pixmap cache and reuse it more often
  Fixes a regression in 2.99.907 that caused the memory used by X to
  grow until it was cleaned up during server regreneration
  https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/1272338



SRPM:
x11-driver-video-intel-2.99.909-1.1.mga4.src.rpm

i586:
x11-driver-video-intel-2.99.909-1.1.mga4.i586.rpm

x86_64:
x11-driver-video-intel-2.99.909-1.1.mga4.x86_64.rpm



The reason for not going higher than 909 + glamor xv revert is that it requires newer glamor and librm than we have in mga4.

CC: (none) => tmb
Hardware: x86_64 => All
Assignee: bugsquad => qa-bugs

Comment 2 David GEIGER 2014-06-05 19:59:55 CEST
Tested mga4-64,

Testing complete for new x11-driver-video-intel-2.99.909-1.1.mga4, Ok for me nothing toreport, seems work correctly here.

- x11-driver-video-intel-2.99.909-1.1.mga4.x86_64

Intel Core i3-2350M_2.3GHz, 8 GO RAM DDR3, screen LED 17" (1600x900), CG Intel HD  integrated + CG Nvidia GeForce 610M_1GB dedicated (Optimus Technology).

CC: (none) => geiger.david68210

Comment 3 user7 2014-06-05 21:34:06 CEST
Testing complete on MGA 4, i586.

Tested x11-driver-video-intel-2.99.909-1.1 for a couple of days now, no heavy usage but desktop effects + videos. The computer seemed to get a bit hotter than before, but not in any significant way, and I am not even sure this is actually a regression (or I noticed it only now because I was paying more attention). So OK for me.

Intel Core 2 Duo T6570 CPU with integrated Intel GM 45 Express graphics.

CC: (none) => wassi

Comment 4 Manuel Hiebel 2014-06-07 00:33:08 CEST
with integrated card on i5 450M, no regression

Whiteboard: (none) => mga4-64-ok mga4-32-ok

Comment 5 Manuel Hiebel 2014-06-14 22:08:05 CEST
In fact sometimes when using firefox, I get a large horizontal black line :/

Will downgrade to see if it's not something other.
Comment 6 user7 2014-06-16 13:49:17 CEST
Manuel Hiebel: Now that you mention it, I have seen a similar problem lately, but didn't associate it with this driver update so far. I see a line in firefox in which all pixels are "scrambled". Minimizing and maximizing firefox fixes the issue. How can you downgrade a package?
Comment 7 Rémi Verschelde 2014-06-16 14:40:13 CEST
(In reply to user7 from comment #6)
> How can you downgrade a package?

Disable the testing repo and run "urpmi --downgrade x11-driver-video-intel"

CC: (none) => remi

Comment 8 user7 2014-06-16 17:29:18 CEST
Thanks, I did that and will report back in a few days. I'll also pay attention to the heat issue I mentioned in a previous comment.
Comment 9 user7 2014-06-17 20:17:47 CEST
The heat issue remains even with the downgraded package, so it's probably related to the warmer outside temperatures. :)
However the graphic fragments in Firefox are gone after downgrading, so they are indeed a regression of the new driver package.

I deleted the "mga4-32-ok" marker from the whiteboard for now, as I'd avise against pushing this update. I never experienced the memory leak it is supposed to fix (therefore can not confirm the fix) and it does cause a regression.

Whiteboard: mga4-64-ok mga4-32-ok => mga4-64-ok

Comment 10 Manuel Hiebel 2014-06-18 15:22:00 CEST
No more issue too with the old package :/

Whiteboard: mga4-64-ok => (none)

Comment 11 Otto Leipälä 2014-06-20 23:17:12 CEST
Manuel Hiebel: i have too this problem too with updated intel driver,i have hd3000 sandy bridge laptop.

CC: (none) => ozkyster

Rémi Verschelde 2014-06-22 14:24:20 CEST

Whiteboard: (none) => feedback

Comment 12 Rémi Verschelde 2014-06-22 14:38:39 CEST
@Manuel, Wassi, Otto: Which DE/compositing settings are you using?
Comment 13 Rémi Verschelde 2014-06-22 14:43:37 CEST
Could you post a screenshot of the issue, so that it can be compared to the regressions shown on https://bugs.freedesktop.org/show_bug.cgi?id=74327 ?
Comment 14 Thomas Backlund 2014-06-22 15:14:09 CEST
Ok, one missing post .909 fix spotted by akien, so the rpm to test is now:

x11-driver-video-intel-2.99.909-1.2.mga4

Whiteboard: feedback => (none)

Comment 15 Manuel Hiebel 2014-06-22 15:58:41 CEST
installing, review this week :)
Comment 16 Rémi Verschelde 2014-06-22 16:05:21 CEST
I confirm that the regression is no longer present in 2.99.909-1.2.mga4 on i586. It would need some more testing before the MGA4-32-OK tag can be added, I only tested against the previous regression, and made sure that supertuxkart worked great :-)
Comment 17 David GEIGER 2014-06-22 16:22:49 CEST
Tested mga4-64,

Testing complete for new x11-driver-video-intel-2.99.909-1.2.mga4, Ok for me nothing to report, seems work correctly here. No regression found.

I can't reproduce the issue on comment 5.


- x11-driver-video-intel-2.99.909-1.2.mga4.x86_64

Intel Core i3-2350M_2.3GHz, 8 GO RAM DDR3, screen LED 17" (1600x900), CG Intel HD  integrated + CG Nvidia GeForce 610M_1GB dedicated (Optimus Technology).
Comment 18 user7 2014-06-22 16:26:44 CEST
Remi: I am using KDE, desktop effects are enabled. It looks pretty much like the screenshots in the link you posted.

I installed the new x11-driver-video-intel-2.99.909-1.2.mga4 package and will test it for a few days, then report back.
Comment 19 William Kenney 2014-06-23 02:06:07 CEST
On real hardware, M4, KDE, 32-bit

Package(s) under test:
x11-driver-video

x11-driver-video-intel:
Version: 2.99.909-1.1.mga4
        Currently installed version: 2.99.909-1.1.mga4
        Group: System/X11
        Architecture: i586

KDE, Flash video, desktop works. I'm not having any
problems with these:

Test platform:
Intel, P4 530J 3.0 GHz, 800MHz FSB, 1MB L2, LGA 775
GigaByte  GA-81915G Pro F4  i915G  LGA 775  MoBo
lspci -v:
00:02.0 VGA compatible controller: Intel Corporation 82915G/GV/910GL Integrated Graphics Controller
        Subsystem: Gigabyte Technology Co., Ltd GA-8I915ME-G Mainboard
        ...........
        Kernel driver in use: i915
        Kernel modules: i915, intelfb

Test platform:
Intel Pentium 4 631 Cedar Mill 3.0Ghz LGA 775
Intel BOXD945GCPE LGA 775 Micro ATX MoBo
lspci -v:
00:02.0 VGA compatible controller: Intel Corporation 82945G/GZ Integrated Graphics Controller
        Subsystem: Intel Corporation Device d607
        ...........
        Kernel driver in use: i915
        Kernel modules: i915, intelfb

CC: (none) => wilcal.int

Comment 20 Otto Leipälä 2014-06-23 12:34:06 CEST
Kde and kde effects,it affects to all effects and programs in my system.
Comment 21 user7 2014-06-24 17:26:47 CEST
Testing complete on MGA 4, i586.

Tested x11-driver-video-intel-2.99.909-1.2 for a couple of days now, no heavy usage but desktop effects + videos. The regression is gone, everything works as expected. OK for me.

Intel Core 2 Duo T6570 CPU with integrated Intel GM 45 Express graphics.
Comment 22 Manuel Hiebel 2014-06-25 19:51:05 CEST
Ok for me too.

(In reply to Otto Leipälä from comment #20)
> Kde and kde effects,it affects to all effects and programs in my system.

Anyone understand this ?

Whiteboard: (none) => mga4-64-ok

Comment 23 Rémi Verschelde 2014-06-25 20:25:09 CEST
(In reply to Manuel Hiebel from comment #22)
> (In reply to Otto Leipälä from comment #20)
> > Kde and kde effects,it affects to all effects and programs in my system.
> 
> Anyone understand this ?

This was an answer to my question in comment 12.
@Otto: Did you have the time to test the new update candidate and can you confirm that it fixes the regression?
Comment 24 Otto Leipälä 2014-06-26 13:41:30 CEST
Yes i tested it and it's fine no problems anymore.
user7 2014-06-26 16:24:34 CEST

Whiteboard: mga4-64-ok => mga4-64-ok, MGA-32-OK

user7 2014-06-26 16:24:41 CEST

Whiteboard: mga4-64-ok, MGA-32-OK => mga4-64-ok, MGA4-32-OK

Comment 25 Dave Hodgins 2014-06-26 22:56:39 CEST
Advisory uploaded to svn. Someone from the sysadmin team please push 13428.adv
to updates.

Keywords: (none) => validated_update
Whiteboard: mga4-64-ok, MGA4-32-OK => mga4-64-ok, MGA4-32-OK advisory
CC: (none) => davidwhodgins, sysadmin-bugs

Comment 26 Thomas Backlund 2014-06-27 17:28:46 CEST
Update pushed:
http://advisories.mageia.org/MGAA-2014-0138.html

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.