Bug 133 - no warning with a / partition encrypting (and without a separate /boot )
Summary: no warning with a / partition encrypting (and without a separate /boot )
Status: REOPENED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Installer (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Pascal Terjan
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-20 15:57 CET by Manuel Hiebel
Modified: 2022-07-21 20:33 CEST (History)
15 users (show)

See Also:
Source RPM: drakx-installer-stage2
CVE:
Status comment:


Attachments

Description Manuel Hiebel 2011-02-20 15:57:26 CET
Grub don't support booting with the directorie /boot encrypting, so there must
be a separate partition for /boot if we want encrypting /


Steps to Reproduce:
1. install cauldron
2. put a / partition encrypted without separate /boot partition
3. reboot
=>Fatal boot.

=>>Add a Warning that explain we must have a separate partition.

(p.s: sorry for my bad English)


Reproducible: 

Steps to Reproduce:
Comment 1 Manuel Hiebel 2011-02-20 15:58:23 CET
bug upstream https://qa.mandriva.com/show_bug.cgi?id=62573
Ahmad Samir 2011-03-09 21:13:00 CET

Source RPM: (none) => drakx-installer-stage2
See Also: (none) => https://qa.mandriva.com/show_bug.cgi?id=62573

Dan Joita 2011-03-17 19:24:42 CET

Priority: Normal => High
Severity: normal => critical

Comment 2 Manuel Hiebel 2011-04-06 21:48:25 CEST
Still present in the beta1 (tested with the dual)

Hardware: i586 => All

Manuel Hiebel 2011-04-06 21:51:03 CEST

CC: (none) => manuel

Ahmad Samir 2011-04-07 01:33:25 CEST

CC: (none) => mageia, pterjan

Comment 3 Manuel Hiebel 2011-04-23 23:26:17 CEST
still present with a netinstall.
Comment 4 Manuel Hiebel 2011-06-09 16:30:29 CEST
seems it is resolved thanks

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 5 Manuel Hiebel 2012-03-11 15:48:43 CET
I can reproduce again :/

Resolution: FIXED => (none)
Priority: High => release_blocker
Status: RESOLVED => REOPENED
CC: (none) => thierry.vignaud
Summary: no warning with a / partition encrypting => no warning with a / partition encrypting (and without a separate /boot )

Comment 6 John Bowden 2012-03-24 22:35:31 CET
I have just done a install of x86_64-DVD deleting a / and /home and creating a /boot, / and /home. / and /home were encrypted and the encryption option for /boot is disabled. 1st reboot went ok. Did not encrypt /swap

CC: (none) => led43john

Comment 7 Oliver Burger 2012-03-27 10:01:06 CEST
Perhaps as a workarround, do some documentation about this?
E.g. add to the help texts in installer.

CC: (none) => doc-bugs, oliver.bgr

Anne Nicolas 2012-04-02 15:48:02 CEST

CC: (none) => ennael1
Assignee: bugsquad => john

Comment 8 Anne Nicolas 2012-04-02 15:48:54 CEST
Docteam (Johnr) will add a note in documentation
Comment 9 John Rye 2012-04-02 16:40:43 CEST
A warning note has been added to diskdrake section
Comment 10 Anne Nicolas 2012-04-02 16:59:49 CEST
Closing then

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED

Comment 11 Pascal Terjan 2012-04-02 17:06:33 CEST
I would prefer to leave it open, I am quite sure the code is supposed to give you a warning...
Comment 12 Pascal Terjan 2012-04-02 17:10:57 CEST
fsedit::check_mntpoint has:

    if ($mntpoint eq "/" && (isLUKS($part) || isRawLUKS($part)) && !fs::get::has_mntpoint("/boot", $all_hds)) {
        cdie N("You've selected an encrypted partition as root (/).
No bootloader is able to handle this without a /boot partition.
Please be sure to add a separate /boot partition");
    }
Comment 13 Marja Van Waes 2012-04-02 18:42:50 CEST
(In reply to comment #11)
> I would prefer to leave it open, I am quite sure the code is supposed to give
> you a warning...

(In reply to comment #12)
> fsedit::check_mntpoint has:
> 
>     if ($mntpoint eq "/" && (isLUKS($part) || isRawLUKS($part)) &&
> !fs::get::has_mntpoint("/boot", $all_hds)) {
>         cdie N("You've selected an encrypted partition as root (/).
> No bootloader is able to handle this without a /boot partition.
> Please be sure to add a separate /boot partition");
>     }

reopening and assigning to you, then :)

Assignee: john => pterjan
Priority: release_blocker => Normal
CC: (none) => marja11
Severity: critical => normal

Comment 14 Marja Van Waes 2012-04-02 18:43:25 CEST
(In reply to comment #13)

> 
> reopening and assigning to you, then :)
again

Resolution: FIXED => (none)
Status: RESOLVED => REOPENED

Comment 15 Marja Van Waes 2012-05-26 13:02:54 CEST
Hi,

This bug was filed against cauldron, but we do not have cauldron at the moment.

Please report whether this bug is still valid for Mageia 2.

Thanks :)

Cheers,
marja

Keywords: (none) => NEEDINFO

Manuel Hiebel 2012-05-26 17:34:39 CEST

Keywords: NEEDINFO => (none)
Whiteboard: (none) => MGA2TOO

Comment 16 Marja Van Waes 2012-07-06 15:04:10 CEST
Please look at the bottom of this mail to see whether you're the assignee of this  bug, if you don't already know whether you are.


If you're the assignee:

We'd like to know for sure whether this bug was assigned correctly. Please change status to ASSIGNED if it is, or put OK on the whiteboard instead.

If you don't have a clue and don't see a way to find out, then please put NEEDHELP on the whiteboard.

Please assign back to Bug Squad or to the correct person to solve this bug if we were wrong to assign it to you, and explain why.

Thanks :)

**************************** 

@ the reporter and persons in the cc of this bug:

If you have any new information that wasn't given before (like this bug being valid for another version of Mageia, too, or it being solved) please tell us.

@ the reporter of this bug

If you didn't reply yet to a request for more information, please do so within two weeks from now.

Thanks all :-D
Manuel Hiebel 2013-02-25 00:12:06 CET

Whiteboard: MGA2TOO => MGA2TOO 3beta3

Glen Ogilvie 2013-03-17 00:49:31 CET

CC: (none) => nelg

Comment 17 Dick Gevers 2014-11-15 05:58:20 CET
Pascal please consider a fix? (Or closure?)

Whiteboard: MGA2TOO 3beta3 => (none)

Comment 18 Manuel Hiebel 2015-04-25 19:17:50 CEST
or maybe switch to grub2 as default
Comment 19 papoteur 2017-08-06 09:43:06 CEST
Just done an installation with encrypted root partition. I get at least one time the warning. Live install.

CC: (none) => yves.brungard_mageia

Comment 20 Mauricio Andrés Bustamante Viveros 2018-03-16 07:16:13 CET
Using MGA6-32

If i use the expert partitioning mode (custom partitioning), create the / partition and sets encrypted, write the password, and continue, the MGA installer is unable to show the warning message that papoteur see, but the install ends without errors

After reboot, grub2 tries to decrypt the / partition, using the correct password not works

Trying to install again using the actual partitioning scheme (with / encrypted) the MGA installer is able to show the warning message

My five cents in this:

1. Detect if I am creating the first partition, selecting the / mountpoint (autoselected by default) and disable the encrypt option
or
2. Detect if I am creating the first partition, selecting the / mountpoint (autoselected bt default) and autocreate a /boot partition
and
3. Continue showing the message if the end user tries to select as / partition an encrypted partition (suppossed the partition scheme already exists)

CC: (none) => neoser10

Comment 21 Mauricio Andrés Bustamante Viveros 2018-03-23 19:13:43 CET
Adding mageiatools@ml.mageia.org as Marja requested in #mageia-qa IIRC

I am reading the \drakx-installer-stage2-17.88 source rpm
I found that the sub check_mntpoint makes some verifications when is run, but as comment 20, I did not see that the verifications are executed when I am creating new partitions in mageia installer, using the manual partitioning option, only if I am selecting already created partitions and assigning mount points

Is possible to make this sub check_partitions (I understand as the responsible for some checks when the end user tries to create mount points without / symbol, or with non alfanumeric characters) to be executed inmediatly the end user clicks the OK botton in the select mount point, and in the create partition subs??

This to ensure that the end user can not continue (click in done) in the partitioning screen as sometimes I can do with / partition with encryption

CC: (none) => mageiatools

Comment 22 Morgan Leijström 2018-03-24 17:20:15 CET
Maybe it is a bit complicated to check each step user create, change, deletes, etc partitions.

Maybe simplify to do a thorough check of many aspects when user is about to exit the partitioning?

Also see Bug 12035 - diskdrake should sanity check the fstab it is about to write

CC: (none) => fri

Comment 23 Mauricio Andrés Bustamante Viveros 2018-03-25 05:38:29 CEST
Morgan, The sub check_mntpoint has code for validaing mount point, the / partition with LUKS encryption, mount points already assigned (avoiding duplicated entries), some directories that must be contained in the / partition (etc, /libs)

That is the reason to suggest making the validations only after the end user makes click in the OK button of: 

Adding a new partition
Changing mount points

I do not consider making the validations in the moment that installer wants or tries to write to disk the modified partition scheme, because a faulty code, can lead to un usable partitioning, or damage to the entire scheme, and can generate confusion to the end user if the end user modifies many partitions in the scheme. 

PD: Validating again while write this, I found that $ and the (space) keys, that to my understanding are non alphanumerical characters ( these are special characters ) are not making popup the warning ... reviewing the code, only if \x7f-\xff characters are used, the popup is shown
Dan Fandrich 2022-07-21 20:33:13 CEST

CC: (none) => dan


Note You need to log in before you can comment on or make changes to this bug.