Description of problem: gparted have incorrect run script #!/bin/sh if [[ "500" != "0" ]] ; then /usr/bin/pkexec /usr/libexec/gparted "" exit 0 fi exec /usr/libexec/gparted "" Version-Release number of selected component (if applicable): gparted-0.18.0-1.mga5.src.rpm How reproducible: always Steps to Reproduce: 1. cat /usr/bin/gparted Error in spec, must be: cat >%{buildroot}%{_bindir}/%{name} <<EOF #!/bin/sh if [[ "\$EUID" != "0" ]] ; then %{_bindir}/pkexec %{_libexecdir}/%{name} "\$@" exit \$? fi exec %{_libexecdir}/%{name} "\$@" EOF Reproducible: Steps to Reproduce:
Keywords: (none) => TriagedAssignee: bugsquad => supp
Thomas is not really active, added colin at it seems he added this part
CC: (none) => mageia
I have uploaded a updated package for Mageia 4. Suggested advisory: ======================== Updated gparted packages fix: - version 0.18.0 - added "\" before "$" in spec file for right creating run script /usr/bin/gparted ======================== Updated packages in core/updates_testing: ======================== gparted-0.18.0-1.mga4 Source RPMs: gparted-0.18.0-1.mga4.src.rpm
Version: Cauldron => 4Assignee: supp => qa-bugs
Can you explain, beyond the changelog, the reason for the update please Alex. Advisories should be written in sentences and paragraphs in conversational language please.
Whiteboard: (none) => feedback
Also if the version bump is necessary (0.16.2 -> 0.18) then the reason for that too please.
If to write "$" in spec, but not "\$", then it interpreted by bs as variable, but we must have "$" in bash run script. 0.16.2 -> 0.18 is only version update.
Removing feedback marker. Please write future advisories in plain conversational language Alex. It is used on http://advisories.mageia.org and the updates-announce mailing list so needs to be presented as information useful to a user rather than a packager.
Whiteboard: feedback => (none)
Testing complete mga4 32 & 64 Before ------ # cat /usr/bin/gparted #!/bin/sh if [[ "501" != "0" ]] ; then /usr/bin/pkexec /usr/libexec/gparted "" exit 0 fi exec /usr/libexec/gparted "" After ----- # cat /usr/bin/gparted #!/bin/sh if [[ "517" != "0" ]] ; then /usr/bin/pkexec /usr/libexec/gparted "$@" exit $? fi exec /usr/libexec/gparted "$@" Quickly checked to see it still works.
Whiteboard: (none) => mga4-32-ok mga4-64-ok
Advisory uploaded. Validating. Could sysadmin please push to 4 updates Thanks
Keywords: (none) => validated_updateWhiteboard: mga4-32-ok mga4-64-ok => advisory mga4-32-ok mga4-64-okCC: (none) => sysadmin-bugs
QA team found incorrect run script again, fixed in gparted-0.18.0-1.1.mga4. Needs testing again. I have uploaded a updated package for Mageia 4. Suggested advisory: ======================== Updated gparted packages fix: - updated version to 0.18.0 - added "\" before "$" in spec file for right creating run script /usr/bin/gparted (run script must have variables instead of values; run script had values before an update) ======================== Updated packages in core/updates_testing: ======================== gparted-0.18.0-1.1.mga4 Source RPMs: gparted-0.18.0-1.1.mga4.src.rpm
Keywords: validated_update => (none)Whiteboard: advisory mga4-32-ok mga4-64-ok => (none)
Alex, I've no idea what this is supposed to fix.
Guessing "517" should be a variable too.
> Guessing "517" should be a variable too. Yes.
Testing complete mga4 64 Looks more sane.. #!/bin/sh if [[ "$EUID" != "0" ]] ; then /usr/bin/pkexec /usr/libexec/gparted "$@" exit $? fi exec /usr/libexec/gparted "$@" Confirmed it asks for root auth when run as normal user and not when run as root.
Whiteboard: (none) => has_procedure mga4-64-ok
Testing complete mga4 32 Advisory updated. Validating. Could sysadmin please push to 4 updates Thanks
Keywords: (none) => validated_updateWhiteboard: has_procedure mga4-64-ok => has_procedure advisory mga4-32-ok mga4-64-ok
Update pushed: http://advisories.mageia.org/MGAA-2014-0124.html
Status: NEW => RESOLVEDCC: (none) => tmbResolution: (none) => FIXED