Bug 12790 - "Register" link in forum header is broken
Summary: "Register" link in forum header is broken
Status: RESOLVED FIXED
Alias: None
Product: Websites
Classification: Unclassified
Component: forums.mageia.org (show other bugs)
Version: trunk
Hardware: i586 Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Forums Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-16 05:58 CET by Steve Havelka
Modified: 2014-04-27 17:03 CEST (History)
5 users (show)

See Also:
Source RPM:
CVE:
Status comment:


Attachments

Description Steve Havelka 2014-02-16 05:58:36 CET
Click on "register" and you get a broken page.  Please set this link to point to the identity server!

Reproducible: 

Steps to Reproduce:
Comment 1 Marja Van Waes 2014-02-16 08:47:37 CET
Conifrmed:

> Access forbidden!

> You don't have permission to access the requested object. It is either
> read-protected or not readable by the server.

> If you think this is a server error, please contact the webmaster.
> Error (none)
> forums.mageia.org
> Apache/2.2.22 (Mandriva Linux/PREFORK-0.1mdv2010.2) 


Registering from Bugzilla still gives the correct page

CC'ing maat, coling and filip

CC: (none) => filip.komar, maat-ml, mageia, marja11

Comment 2 Marja Van Waes 2014-02-16 09:00:23 CET
The 2nd link works, though.

* Clicking on "Register" in between the "FAQ" and "Login" buttons, gives an error

* First clicking on "Login" and then on the "Register" button at the bottom left of the page, gives the correct page.
Comment 3 Maat 2014-02-16 10:54:31 CET
I think it should be okay by now.

But i change these in admin control panel which touches only the templates in database... i only did header tuning on /en/ forum as a testbed, which explains why /de/ forum looks slightly different.

The bad thing is that when we upgrade phpbb version sometimes it overrides the template (ie when phpbb crew touched it)

If we patch the template code (as we did to add header) next update will not override our changes but we will have a high risk of merge conflict :-/

i think a better option could be to clone the default template to create a "mageia" template... phpbb upgrades would never owerride the changes made on something outside of phpbb boundaries then we would be able to code and update templates through git pull + phpbb update with less issues
Comment 4 Florian Hubold 2014-02-16 14:20:48 CET
(In reply to Maat from comment #3)
> I think it should be okay by now.

It is, but only for english forum. As I can't see any clear TODO items from your comment, how did you change this in ACP? I don't see an option to change the register link.

For german forum it still points to https://forums.mageia.org/de/ucp.php?mode=register

CC: (none) => doktor5000

Comment 5 Maat 2014-02-16 16:28:41 CET
yes it is just for /en/

i hope to stabilize it in /en/ so that we have just to copy/paste to have /de/ forums ok

in ACP you habe to go to "styles" tab then choose templates and edit prosilver and tweak overall_header.html

1) => Add this just above the #wrap div :

<h1 id="mgnavtitle">{SITENAME} <span id="mgnavsubtitle">- {SITE_DESCRIPTION}</span></h1>

2) => reorganize the top part of phpbb header

2.a) Save in the header the search form (we need to move it lower in the page)

2.b) remove all the phpbb top bar with logo and site_name and site_description and search form so that the wrap div starts with navbar

2.c) add search bock at the end of the nav bar. It will show ugly at first because of css but we can solve that later


3) => Correct a href for register link (search REGISTER keyword)

Then save the file

Goto style themes section then edit prosilver search for #search-box css section and edit it to reduce margin-top from 30px to 5px

Save the file, check, and let me know if everything is ok

Hope i did not miss something important. In case we'll fine tweak together.

(Note: you can compare files in /en/ and /de/ to double check. Not sure but you could even copy/paste alle the html and css code from /en/ to /de/... but make sure you back up /de/ code in a .txt file before trying that ^^)
Comment 6 Filip Komar 2014-02-16 16:36:41 CET
(In reply to Maat from comment #5)
> 
> Then save the file
> 
> Goto style themes section then edit prosilver search for #search-box css
> section and edit it to reduce margin-top from 30px to 5px
> 
> Save the file, check, and let me know if everything is ok
> 
> Hope i did not miss something important. In case we'll fine tweak together.
> 
> (Note: you can compare files in /en/ and /de/ to double check. Not sure but
> you could even copy/paste alle the html and css code from /en/ to /de/...
> but make sure you back up /de/ code in a .txt file before trying that ^^)

Maat, are you really sure that this change is written to the files? I could be wrong but AFAIK such changes are written to db.
Comment 7 Maat 2014-02-16 17:02:23 CET
Sorry, i miss-used the word "files" : yes it's in db you're right

at install (or update if there's an override) db loads what's in the files.

after if i change the "file" content with ACP only the database is concerned
Comment 8 Filip Komar 2014-02-16 21:52:43 CET
I didn't know that html can be changed in ACP too or maybe I forgot that.

I would use ACP only for testing. After that I would create a patch and push it to git. That way we can't lose it (which is a shame) and we can propagate it to de forum too.
Comment 9 Filip Komar 2014-04-27 17:03:28 CEST
Seems fixed.

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.