Bug 12723 - dkms-fsam7400 fails to build the module
Summary: dkms-fsam7400 fails to build the module
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 4
Hardware: i586 Linux
Priority: Normal major
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard: has_procedure MGA4-32-OK MGA4-64-OK a...
Keywords: Triaged, validated_update
Depends on:
Blocks:
 
Reported: 2014-02-11 17:45 CET by Samuel Verschelde
Modified: 2014-02-13 21:10 CET (History)
4 users (show)

See Also:
Source RPM: dkms-fsam7400-0.5.2-3.mga4.src.rpm
CVE:
Status comment:


Attachments

Description Samuel Verschelde 2014-02-11 17:45:46 CET
To reproduce:

- install kernel-[flavor]-devel-* matching your current kernel
- install dkms-fsam7400
- watch it fail

Reproducible: 

Steps to Reproduce:
Comment 1 Samuel Verschelde 2014-02-11 17:47:23 CET
Build log:

[samuel@localhost ~]$ cat /var/lib/dkms/fsam7400/0.5.2-3.mga4/build/make.log 
DKMS make.log for fsam7400-0.5.2-3.mga4 for kernel 3.12.9-desktop-1.mga4 (i586)
mar. févr. 11 17:28:04 CET 2014
make: Entering directory '/usr/src/linux-3.12.9-desktop-1.mga4'
  CC [M]  /var/lib/dkms/fsam7400/0.5.2-3.mga4/build/fsam7400.o
/var/lib/dkms/fsam7400/0.5.2-3.mga4/build/fsam7400.c: In function âcommon_proc_initâ:
/var/lib/dkms/fsam7400/0.5.2-3.mga4/build/fsam7400.c:331:4: erreur: implicit declaration of function âcreate_proc_entryâ [-Werror=implicit-function-declaration]
    ent = create_proc_entry(PROC_RADIO,
    ^
/var/lib/dkms/fsam7400/0.5.2-3.mga4/build/fsam7400.c:331:8: attention : assignment makes pointer from integer without a cast [enabled by default]
    ent = create_proc_entry(PROC_RADIO,
        ^
/var/lib/dkms/fsam7400/0.5.2-3.mga4/build/fsam7400.c:335:10: erreur: déréférencement d'un pointeur de type incomplet
       ent->uid = uid;
          ^
/var/lib/dkms/fsam7400/0.5.2-3.mga4/build/fsam7400.c:336:10: erreur: déréférencement d'un pointeur de type incomplet
       ent->gid = gid;
          ^
/var/lib/dkms/fsam7400/0.5.2-3.mga4/build/fsam7400.c:337:10: erreur: déréférencement d'un pointeur de type incomplet
       ent->read_proc = common_proc_get_radio;
          ^
/var/lib/dkms/fsam7400/0.5.2-3.mga4/build/fsam7400.c:338:10: erreur: déréférencement d'un pointeur de type incomplet
       ent->write_proc = common_proc_set_radio;
          ^
cc1: some warnings being treated as errors
scripts/Makefile.build:314: recipe for target '/var/lib/dkms/fsam7400/0.5.2-3.mga4/build/fsam7400.o' failed
make[1]: *** [/var/lib/dkms/fsam7400/0.5.2-3.mga4/build/fsam7400.o] Error 1
Makefile:1228: recipe for target '_module_/var/lib/dkms/fsam7400/0.5.2-3.mga4/build' failed
make: *** [_module_/var/lib/dkms/fsam7400/0.5.2-3.mga4/build] Error 2
make: Leaving directory '/usr/src/linux-3.12.9-desktop-1.mga4'

Keywords: (none) => Triaged

Comment 2 Matteo Pasotti 2014-02-12 19:13:21 CET
There is now dkms-fsam7400-0.5.2-3.1.mga4 in core/updates_testing waiting for validation
--------------------------------------

I have uploaded a patched package for Mageia 4.

You can test it simply trying to install the package and verify it installs without errors. 
If you have an laptop/notebook by Acer or some Fujitsu-Siemens that is in need of this RF kill switch you can test also if the applied patch doesn't impact its functionality. 

Suggested advisory:
========================

Updated dkms-fsam7400 package fix the compilation bug reported.

The create_proc_entry interface has been replaced by proc_create for kernel >= 3.10.

References:
https://lwn.net/Articles/549737/
========================

Updated packages in core/updates_testing:
========================
dkms-fsam7400-0.5.2-3.1.mga4

Source RPM:
dkms-fsam7400-0.5.2-3.1.src.rpm
Matteo Pasotti 2014-02-12 19:14:25 CET

CC: (none) => matteo.pasotti
Assignee: matteo.pasotti => qa-bugs

Comment 3 Samuel Verschelde 2014-02-12 19:33:41 CET
Confirming bug fixed on Mageia 4 64 bits.

I don't have the needed hardware, so just tested that it builds without error and that modprobe -v fsam7400 doesn't give any error.

Whiteboard: (none) => has_procedure MGA4-64-OK

Comment 4 Rémi Verschelde 2014-02-13 11:33:38 CET
Testing complete on Mageia 4 i586.

I could not test for regression as I don't have the needed hardware, but it builds fine and modprobe -v fsam7400 works too.

CC: (none) => remi
Whiteboard: has_procedure MGA4-64-OK => has_procedure MGA4-32-OK MGA4-64-OK

Comment 5 Rémi Verschelde 2014-02-13 12:26:42 CET
Validating update, advisory has been uploaded. Please push to 4 core/updates.

Keywords: (none) => validated_update
Whiteboard: has_procedure MGA4-32-OK MGA4-64-OK => has_procedure MGA4-32-OK MGA4-64-OK advisory
CC: (none) => sysadmin-bugs

Comment 6 Thomas Backlund 2014-02-13 21:10:25 CET
Update pushed:
http://advisories.mageia.org/MGAA-2014-0044.html

Status: NEW => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.