Bug 12621 - deluge bittorrent client does not respond if built-in plugin twisted enabled
Summary: deluge bittorrent client does not respond if built-in plugin twisted enabled
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 4
Hardware: All Linux
Priority: Normal major
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL: http://bugs.debian.org/cgi-bin/bugrep...
Whiteboard: mga4-32-ok mga4-64-ok advisory
Keywords: PATCH, validated_update
Depends on:
Blocks:
 
Reported: 2014-02-06 00:49 CET by Atilla ÖNTAŞ
Modified: 2014-02-11 23:57 CET (History)
4 users (show)

See Also:
Source RPM: deluge-1.3.6-4.mga.src.rpm
CVE:
Status comment:


Attachments
fixes twisted 13.1 compat -- the _parse() function was replaced by the _URI class (902 bytes, patch)
2014-02-06 00:49 CET, Atilla ÖNTAŞ
Details | Diff

Description Atilla ÖNTAŞ 2014-02-06 00:49:52 CET
Created attachment 4945 [details]
fixes twisted 13.1 compat -- the _parse() function was replaced by the _URI class

Currently deluge-1.3.6 has a known bug that it stops responding if builtin twisted (ip blocker) plugin is enabled. Application opens fine but it does not starts installing and can not be closed unless forced from commandline.

From commandline we can see these errors:

~$ deluge
Unhandled error in Deferred:
Unhandled Error
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/deluge/plugins/init.py", line 48, in
enable
    self.plugin.enable()
  File "/usr/lib/python2.7/dist-
packages/deluge/plugins/Blocklist-1.2.egg/blocklist/core.py", line 114, in
enable
    self.update_timer.start(self.config["check_after_days"] * 24 * 60 * 60,
update_now)
  File "/usr/lib/python2.7/dist-packages/twisted/internet/task.py", line 173,
in start
    self()
  File "/usr/lib/python2.7/dist-packages/twisted/internet/task.py", line 218,
in __call__
    d = defer.maybeDeferred(self.f, *self.a, **self.kw)
--- <exception caught here> ---
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 137,
in maybeDeferred
    result = f(*args, **kw)
  File "/usr/lib/python2.7/dist-
packages/deluge/plugins/Blocklist-1.2.egg/blocklist/core.py", line 149, in
check_import
    d = self.download_list()
  File "/usr/lib/python2.7/dist-
packages/deluge/plugins/Blocklist-1.2.egg/blocklist/core.py", line 258, in
download_list
    return download_file(url,
deluge.configmanager.get_config_dir("blocklist.download"), on_retrieve_data,
headers)
  File "/usr/lib/python2.7/dist-packages/deluge/httpdownloader.py", line 195,
in download_file
    scheme, host, port, path = client._parse(url)
exceptions.AttributeError: 'module' object has no attribute '_parse'

Fix is committed to deluge's git as two commits. I have merge them into one and will submit into Cauldron if no one objects:

http://git.deluge-torrent.org/deluge/commit/deluge/httpdownloader.py?h=1.3-stable&id=8bf18d6694db24e04cb65f20f2e219ec14043f8e

http://git.deluge-torrent.org/deluge/commit/?h=1.3-stable&id=06ee112344f7
Atilla ÖNTAŞ 2014-02-06 00:52:58 CET

Whiteboard: (none) => MGA4TOO

Comment 1 Atilla ÖNTAŞ 2014-02-06 01:06:58 CET
I have submitted deluge-1.3.6-5.mga5 to Cauldron with above patch applied. This patch fixes the issue this bug report describes.
Comment 2 Atilla ÖNTAŞ 2014-02-06 01:18:37 CET
I have uploaded a patched/updated deluge package for Mageia 4.

You can test this by enabling twisted (ip filter) plugin.

Suggested advisory:
========================

Updated deluge package fixes this issue:

In built-in ip filter plugin twisted 13.1.0 the _parse() function was replaced by the _URI class but httpdownloader.py file did not aware of this changes. As a result if ip filter plugin is enabled application starts with AttributeError: 'module' object has no attribute '_parse' and does not respond. 

I have merged two upstream git commits into one patch which fixes the issue.

References:
bugs.debian.org/cgi-bin/bugreport.cgi?bug=729929
http://git.deluge-torrent.org/deluge/commit/deluge/httpdownloader.py?h=1.3-stable&id=8bf18d6694db24e04cb65f20f2e219ec14043f8e
http://git.deluge-torrent.org/deluge/commit/?h=1.3-stable&id=06ee112344f7
========================

Updated packages in core/updates_testing:
========================
deluge-1.3.6-4.1.mga4

Source RPMs: 
========================
deluge-1.3.6-4.1.mga4.src.rpm

Assignee: tarakbumba => qa-bugs

Samuel Verschelde 2014-02-06 08:50:53 CET

CC: (none) => stormi
Version: Cauldron => 4

Manuel Hiebel 2014-02-08 22:53:44 CET

Whiteboard: MGA4TOO => mga4-64-ok

Comment 3 Rémi Verschelde 2014-02-11 18:17:03 CET
Testing complete on Mageia 4 i586, I could reproduce the bug and the update candidate fixes it.

CC: (none) => remi
Whiteboard: mga4-64-ok => mga4-32-ok mga4-64-ok

Comment 4 Rémi Verschelde 2014-02-11 19:33:57 CET
Validating update.

Advisory uploaded, could a sysadmin push the update to core/updates for Mageia 4? Thanks.

Keywords: (none) => validated_update
Whiteboard: mga4-32-ok mga4-64-ok => mga4-32-ok mga4-64-ok advisory
CC: (none) => sysadmin-bugs

Comment 5 Thomas Backlund 2014-02-11 23:57:08 CET
Update pushed:
http://advisories.mageia.org/MGAA-2014-0032.html

Status: NEW => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.