Description of problem: Indexhtml package supposed to be display useful information about Mageia. But it simply doesn't work. There are critical problems for this package: 1. /usr/bin/about-mageia script looks for non-existent /usr/share/mdv directory. It should be /usr/share/mga directory. 2. If i supply correct path for about-mageia script; i get only "Coming soon" written web page on my default web browser; which seems to me nonsense. So, i recommend (if otherwise not planned) about-mageia script should open Mageia web site's about page. I have re-written the script to satisfy this. Will attach soon. Reproducible: Steps to Reproduce:
Created attachment 4670 [details] Modified about-mageia script to open mageia.org/about This script first tests internet connectivity; if a working internet connection detected then calculates installed system's locale and opens localized mageia.org/about page via xdg-open command.
Assignee: bugsquad => tarakbumba
Keywords: (none) => Junior_jobWhiteboard: (none) => MGA3TOO
Attachment 4670 mime type: application/octet-stream => text/plain
Keywords: (none) => PATCHCC: (none) => ennael1, thierry.vignaud
CC: (none) => tmb
http://www.mageia.org/$lang/community is maybe better
(In reply to Manuel Hiebel from comment #2) Well, name suggests us to use about page. May be community page provides more; about page provides berief information about Mageia. So, i' ve used about page. Also i improved the script a bit to check if localized page is available, if not it defaults to english page. I committed changes to package, waiting for freeze push.
I have uploaded a patched/updated package for Mageia 3. Suggested advisory: ======================== Updated indexhtml package to fix : Indexhtml package supposed to be display useful information about Mageia.But it did not working. about-mageia script supplied with package was looking for non-existent directory and if correct path supplied displayed almost empty web page. Updated package fixes this issue and new about-mageia script opens mageia.org/about page for user in a web browser. References: https://bugs.mageia.org/show_bug.cgi?id=12131 ======================== Updated packages in core/updates_testing: ======================== indexhtml-1-9.mga3.noarch.rpm Source RPMs: indexhtml-1-9.mga3.noarch.rpm.src.rpm xmoto-1.2.2-3.1.mga2.tainted.src.rpm
Sorry, there is no xmoto-1.2.2-3.1.mga2.tainted.src.rpm in advisory.
Assignee: tarakbumba => qa-bugs
just checked more and there is more easier to do: http://gitweb.mageia.org/software/indexhtml/tree/about/about-mageia change mdk to mga in: http://gitweb.mageia.org/software/indexhtml/tree/about/index.html.in before </head> add: <script language=javascript> function redirect(){ window.location = "http://mageia.org/about"; } </script> and change <body> to <body onload="redirect()"> all the two in http://gitweb.mageia.org/software/indexhtml/tree/about/index.html.in I just modified mageia.org/about, it should now redirect automatically to the correct lang (there useless stuff but well)
Assignee: qa-bugs => bugsquad
(In reply to Manuel Hiebel from comment #6) Your suggestion seems cause errors: ./create_html.sh Merging translations into index.html. not well-formed (invalid token) at line 5, column 33, byte 269 at /usr/lib/perl5/vendor_perl/5.18.1/x86_64-linux-thread-multi/XML/Parser.pm line 187.
Nop, as it said "Merging translations into index.html." So no issue I made. And I didn't make any change for about-mageia.desktop, which is the second intltool-merge. It looks more warning.
(In reply to Manuel Hiebel from comment #8) But i get an empty index.html file...
indeed sorry, it looks like <script language=javascript> was not valid in xml using <script language="javascript"> instead made it working.
(In reply to Manuel Hiebel from comment #10) Thanks. This time it worked. But i still in doubt to use your suggestion. Because, as i see, browser first opens index.html but it is impossible to read what is written and quickly redirected to mageia.org/about. It somewhat seems not pretty for me. Sorry. Also, i don' t understand why we even need an index.html. Index.html is untouched almost 2 years now and what will "Coming soon..." ?
Well it's a quick fix, I'm not the author of this. You can remove generation of localised html + content too if you want. But adding a shell script to redirect something already present is not better ihmo.
ah didn't see you don't provide the code anymore, but it this case: cd about ./create_html.sh is useless too
(In reply to Manuel Hiebel from comment #13) I did not provide a code to source from the beginning. I only replace about-mageia.sh script with a new one in package not source. Thanks for the hint, i remove build create_html.sh stuff from specfile. Now waiting for the freeze push...
(In reply to Atilla ÃNTAÅ from comment #14) Naah... create_html.sh is needed to create desktop file. I reverted my previous commit.
I' m assigning bug report to qa-bugs@ml.mageia.org because there is an Mageia 3 update proposed and updates policy requires this.
Assignee: bugsquad => qa-bugs
Since objections have been raised to the implementation of these changes on the dev list, let's wait until that's settled and this is pushed in Cauldron before pushing the Mageia 3 update to QA.
CC: (none) => qa-bugsAssignee: qa-bugs => tarakbumba
Manuel and David; we have to decide which fix should be used: 2014/1/19 Thomas Backlund <tmb@mageia.org>: > Since there is still disagreement of what the fix should be, it wont get > pushed to cauldron or mga3 I prefer using about-mageia script included as source; which doesn' t interfere with the source code and do not cause to display "Coming soon" page.
Package indexhtml in Mageia 4 RC is very old. No new translations. There is problem with mdk->mga. There is problem with pot file. There are no strings About Mageia More about Mageia in pot file from about-mageia.desktop.in for translations. desktop file is without translations. Atilla, in MATE you can see untranslated Menu and unworked about-mageia. As Mageia 4 will be soon, then please hide about-mageia from Menu in MATE.
CC: (none) => loginov_alex
(In reply to Alex Loginov from comment #19) Alex, if we decide which fix will be used then indexhtml will work as intended. For the transalitons for about-mageia.desktop; there are no translations at all in source... To hide about-magia from menu, about-mageia.desktop should be patched...
Please add strings for translation in POT file and realy use them in spec for about-mageia.desktop localization.
(In reply to Alex Loginov from comment #21) Alex, current source does not contain translations but git has. I' m not the developer of the source code but merely trying to fix an important issue. Anyway, i pulled translations from git and added them into package. Now, available translations included.
Now, we are in Final Release eve, then the chance to fix this issue for ISOs is missed. We can always provide updates though. But we still need to decide which woraround should be used. More opinions?
If nobody can decide, but Atilla has workaround and want to fix, then better to use anything instead nothing. It's "nobody" package. Any maintainer can take it. Atilla, will you take and support?
Please push Atilla's solution(In reply to Alex Loginov from comment #24) > If nobody can decide, but Atilla has workaround and want to fix, then better > to use anything instead nothing. yes please go
CC: (none) => makowski.mageia
I have submitted indexhtml-1-12.mga5 to Cauldron.
I have uploaded a patched/updated package to core/updates_testing for Mageia 3. Suggested advisory: ======================== Updated indexhtml package to fix : Indexhtml package supposed to be display useful information about Mageia. But it did not working. about-mageia script supplied with package itself was looking for non-existent /usr/share/mdv directory and if correct path (/usr/share/mga) supplied displayed almost empty web page. Another problem was it was not including updated translations. Updated translations added from our git.mageia.org Updated package fixes this issue and new about-mageia script opens mageia.org/about page for user in a web browser. References: https://bugs.mageia.org/show_bug.cgi?id=12131 ======================== Updated packages in core/updates_testing: ======================== indexhtml-1-9.2.mga3.noarch.rpm ----------------------------------------------------------------------------- ----------------------------------------------------------------------------- I have uploaded a patched/updated package to core/updates_testing for Mageia 4. Suggested advisory: ======================== Updated indexhtml package to fix : Indexhtml package supposed to be display useful information about Mageia. But it did not working. about-mageia script supplied with package itself was looking for non-existent /usr/share/mdv directory and if correct path (/usr/share/mga) supplied displayed almost empty web page. Another problem was it was not including updated translations. Updated translations added from our git.mageia.org Updated package fixes this issue and new about-mageia script opens mageia.org/about page for user in a web browser. References: https://bugs.mageia.org/show_bug.cgi?id=12131 ======================== Updated packages in core/updates_testing: ======================== indexhtml-1-10.1.mga4.noarch.rpm Source RPMs: indexhtml-1-10.1.mga4.src.rpm
Version: Cauldron => 4Assignee: tarakbumba => qa-bugsSource RPM: indexhtml-1-10.mga4.src.rpm => indexhtml-1-9.mga3.src.rpm, indexhtml-1-10.mga4.src.rpm
CC: makowski.mageia => (none)
Tested mga4_64, Testing complete for indexhtml-1.10.1.mga4, Ok for me I confirm that bug is fixed here. Before : $ about-mageia file not found for about Mageia $ cat /usr/bin/about-mageia #!/bin/sh if [ "x$GNOME_DESKTOP_SESSION_ID" != "x" -a -x /usr/bin/yelp ]; then www_browser="/usr/bin/yelp" else www_browser="xdg-open" fi for lang in `echo $LANG:$LANGUAGE | tr ':' ' ' | cut -d'_' -f1` ; do file="/usr/share/mdk/about/index-$lang.html" if [ -f "$file" ]; then $www_browser $file exit 0 fi done if [ -f /usr/share/mdk/about/index.html ]; then $www_browser /usr/share/mdk/about/index.html exit 0 fi echo "file not found for about Mageia" exit 1 -------------------------------------------------------------------------------- After : $ about-mageia " Open http://www.mageia.org/fr/about/ " $ cat /usr/bin/about-mageia #!/bin/sh WGET="$(which wget)" $WGET -q --tries=20 --timeout=10 http://www.google.com -O /tmp/google.idx &> /dev/null if [ ! -s /tmp/google.idx ]; then echo "ERROR: No internet connection detected. In order to display About Mageia page you should have an working connection." exit 1 else for lang in `echo $LANG:$LANGUAGE | tr ':' ' ' | cut -d'_' -f1` ; do $WGET -q --tries=20 --timeout=10 http://www.mageia.org/$lang/about -O /tmp/mageiaorg.idx &> /dev/null if [ ! -s /tmp/mageiaorg.idx ]; then echo "WARNING: There is no localized Mageia About web page; displaying English web page" xdg-open "http://www.mageia.org/en/about" else xdg-open "http://www.mageia.org/$lang/about" exit 0 fi done fi
CC: (none) => geiger.david68210
Tested mga4_32, Testing complete for indexhtml-1.10.1.mga4, Ok for me I confirm that bug is fixed here too. Before : $ about-mageia file not found for about Mageia $ cat /usr/bin/about-mageia #!/bin/sh if [ "x$GNOME_DESKTOP_SESSION_ID" != "x" -a -x /usr/bin/yelp ]; then www_browser="/usr/bin/yelp" else www_browser="xdg-open" fi for lang in `echo $LANG:$LANGUAGE | tr ':' ' ' | cut -d'_' -f1` ; do file="/usr/share/mdk/about/index-$lang.html" if [ -f "$file" ]; then $www_browser $file exit 0 fi done if [ -f /usr/share/mdk/about/index.html ]; then $www_browser /usr/share/mdk/about/index.html exit 0 fi echo "file not found for about Mageia" exit 1 -------------------------------------------------------------------------------- After : $ about-mageia " Open http://www.mageia.org/fr/about/ " $ cat /usr/bin/about-mageia #!/bin/sh WGET="$(which wget)" $WGET -q --tries=20 --timeout=10 http://www.google.com -O /tmp/google.idx &> /dev/null if [ ! -s /tmp/google.idx ]; then echo "ERROR: No internet connection detected. In order to display About Mageia page you should have an working connection." exit 1 else for lang in `echo $LANG:$LANGUAGE | tr ':' ' ' | cut -d'_' -f1` ; do $WGET -q --tries=20 --timeout=10 http://www.mageia.org/$lang/about -O /tmp/mageiaorg.idx &> /dev/null if [ ! -s /tmp/mageiaorg.idx ]; then echo "WARNING: There is no localized Mageia About web page; displaying English web page" xdg-open "http://www.mageia.org/en/about" else xdg-open "http://www.mageia.org/$lang/about" exit 0 fi done fi
Whiteboard: MGA3TOO => MGA3TOO MGA4-64-OK MGA4-32-OK
Tested mga3_64, Testing complete for indexhtml-1.9.2.mga3, Ok for me I confirm that bug is fixed here. Before : $ about-mageia file not found for about Mageia $ cat /usr/bin/about-mageia #!/bin/sh if [ "x$GNOME_DESKTOP_SESSION_ID" != "x" -a -x /usr/bin/yelp ]; then www_browser="/usr/bin/yelp" else www_browser="xdg-open" fi for lang in `echo $LANG:$LANGUAGE | tr ':' ' ' | cut -d'_' -f1` ; do file="/usr/share/mdk/about/index-$lang.html" if [ -f "$file" ]; then $www_browser $file exit 0 fi done if [ -f /usr/share/mdk/about/index.html ]; then $www_browser /usr/share/mdk/about/index.html exit 0 fi echo "file not found for about Mageia" exit 1 -------------------------------------------------------------------------------- After : $ about-mageia " Open http://www.mageia.org/fr/about/ " $ cat /usr/bin/about-mageia #!/bin/sh WGET="$(which wget)" $WGET -q --tries=20 --timeout=10 http://www.google.com -O /tmp/google.idx &> /dev/null if [ ! -s /tmp/google.idx ]; then echo "ERROR: No internet connection detected. In order to display About Mageia page you should have an working connection." exit 1 else for lang in `echo $LANG:$LANGUAGE | tr ':' ' ' | cut -d'_' -f1` ; do $WGET -q --tries=20 --timeout=10 http://www.mageia.org/$lang/about -O /tmp/mageiaorg.idx &> /dev/null if [ ! -s /tmp/mageiaorg.idx ]; then echo "WARNING: There is no localized Mageia About web page; displaying English web page" xdg-open "http://www.mageia.org/en/about" else xdg-open "http://www.mageia.org/$lang/about" exit 0 fi done fi
Tested mga3_32, Testing complete for indexhtml-1.9.2.mga3, Ok for me I confirm that bug is fixed here too. Before : $ about-mageia file not found for about Mageia $ cat /usr/bin/about-mageia #!/bin/sh if [ "x$GNOME_DESKTOP_SESSION_ID" != "x" -a -x /usr/bin/yelp ]; then www_browser="/usr/bin/yelp" else www_browser="xdg-open" fi for lang in `echo $LANG:$LANGUAGE | tr ':' ' ' | cut -d'_' -f1` ; do file="/usr/share/mdk/about/index-$lang.html" if [ -f "$file" ]; then $www_browser $file exit 0 fi done if [ -f /usr/share/mdk/about/index.html ]; then $www_browser /usr/share/mdk/about/index.html exit 0 fi echo "file not found for about Mageia" exit 1 -------------------------------------------------------------------------------- After : $ about-mageia " Open http://www.mageia.org/fr/about/ " $ cat /usr/bin/about-mageia #!/bin/sh WGET="$(which wget)" $WGET -q --tries=20 --timeout=10 http://www.google.com -O /tmp/google.idx &> /dev/null if [ ! -s /tmp/google.idx ]; then echo "ERROR: No internet connection detected. In order to display About Mageia page you should have an working connection." exit 1 else for lang in `echo $LANG:$LANGUAGE | tr ':' ' ' | cut -d'_' -f1` ; do $WGET -q --tries=20 --timeout=10 http://www.mageia.org/$lang/about -O /tmp/mageiaorg.idx &> /dev/null if [ ! -s /tmp/mageiaorg.idx ]; then echo "WARNING: There is no localized Mageia About web page; displaying English web page" xdg-open "http://www.mageia.org/en/about" else xdg-open "http://www.mageia.org/$lang/about" exit 0 fi done fi
Whiteboard: MGA3TOO MGA4-64-OK MGA4-32-OK => MGA3TOO MGA4-64-OK MGA4-32-OK MGA3-64-OK MGA3-32-OK
Advisory uploaded. Validating. Could sysadmin please push to 3 & 4 updates Thanks!
Keywords: (none) => validated_updateWhiteboard: MGA3TOO MGA4-64-OK MGA4-32-OK MGA3-64-OK MGA3-32-OK => MGA3TOO has_procedure advisory MGA4-64-OK MGA4-32-OK MGA3-64-OK MGA3-32-OKCC: (none) => sysadmin-bugs
http://advisories.mageia.org/MGAA-2014-0095.html
Status: NEW => RESOLVEDCC: (none) => mageiaResolution: (none) => FIXED
commit e63429937b6cfa71709e3c39e0a340e448a0b583 Author: Rémi Verschelde <rverschelde@...> Date: Mon Mar 13 19:19:36 2017 +0100 Fix about-mageia looking for non-existing directory (mga#12131) This fix had been provided as an alternative source in the SRPM and never committed to git. (That's bad!) --- Commit Link: http://gitweb.mageia.org/software/indexhtml/commit/?id=e63429937b6cfa71709e3c39e0a340e448a0b583