Bug 11956 - LXDE doesn't start lxpolkit by default mga4b2 (mcc can't be opened)
Summary: LXDE doesn't start lxpolkit by default mga4b2 (mcc can't be opened)
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: release_blocker major
Target Milestone: ---
Assignee: Mageia Bug Squad
QA Contact:
URL:
Whiteboard: mga4b2
Keywords: PATCH
Depends on:
Blocks: 11184 11704
  Show dependency treegraph
 
Reported: 2013-12-11 18:21 CET by Daniel Napora
Modified: 2014-01-07 12:24 CET (History)
5 users (show)

See Also:
Source RPM: lxde-common-0.5.5-16.mga4.src.rpm
CVE:
Status comment:


Attachments
Proposed patch to spec file (565 bytes, patch)
2013-12-11 18:22 CET, Daniel Napora
Details | Diff

Description Daniel Napora 2013-12-11 18:21:03 CET
Description of problem:
lxpolkit not starting by default in LXDE, so it is impossible to launch MCC and other drakes from menu





Reproducible: 

Steps to Reproduce:
Comment 1 Daniel Napora 2013-12-11 18:22:13 CET
Created attachment 4604 [details]
Proposed patch to spec file

Proposed patch to lxde-common.spec

CC: (none) => napcok

Daniel Napora 2013-12-11 18:39:20 CET

Whiteboard: (none) => mga4b2

Comment 2 Manuel Hiebel 2013-12-11 23:53:55 CET
have'nt we switched to mate polkit ?

CC: (none) => mageia
See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=11959

Comment 3 Daniel Napora 2013-12-12 00:05:47 CET
I don't know about switching to mate-polkit, but lxpolkit is part of lxsession, and it works very well. The only thing missing is to start lxpolkit automatically.
Why should lxde use mate-polkit if everything is in place?
Comment 4 Colin Guthrie 2013-12-12 00:24:39 CET
(In reply to Daniel Napora from comment #3)
> I don't know about switching to mate-polkit, but lxpolkit is part of
> lxsession, and it works very well. The only thing missing is to start
> lxpolkit automatically.
> Why should lxde use mate-polkit if everything is in place?

The lxde polkit stuff is a bit of a mess upstream. Code for exists in two places, both part of lxsession and in a separate lxpolkit. We have both versions. Happy to go with one of them but it really should be sorted out upstream. I don't think it's as "nice" looking as the mate one but as it exists we should probably use it... if someone can work out which one is the correct one it should be easy to make it start at login.
Comment 5 Daniel Napora 2013-12-12 00:29:49 CET
Actually mate-polkit is also installed, but I have no glue why... task-lxde doesn't require it.
Also mate-polkit is configured to start authentication agent only with MATE and XFCE.

So we have two ways to fix LXDE polkit integration:
1. Apply proposed patch to lxde-common. Then we can avoid installing mate-polkit.
2. Patch mate-polkit to start authentication agent also in LXDE
Comment 6 Daniel Napora 2013-12-12 00:59:33 CET
I can confirm that suggested patch solve this problem in my fresh Cauldron installation made from beta2 pre-release iso.
Manuel Hiebel 2013-12-14 11:56:13 CET

Keywords: (none) => PATCH
Priority: Normal => release_blocker
CC: (none) => ennael1
Blocks: (none) => 11704
Summary: LXDE doesn't start lxpolkit by default mga4b2 => LXDE doesn't start lxpolkit by default mga4b2 (mcc can't be opened)

Manuel Hiebel 2013-12-14 11:58:02 CET

Blocks: (none) => 11184

Comment 7 Manuel Hiebel 2013-12-15 00:56:53 CET
*** Bug 11984 has been marked as a duplicate of this bug. ***

CC: (none) => richard.j.walker

Comment 8 Anne Nicolas 2013-12-15 15:08:35 CET
Can we take a decision with this one? Maybe go with the easiest one even if upstream code is messy. I wil build weekly isos until final release so we can test it quickly and revert if it does work properly. WDYT ?
Comment 9 Colin Guthrie 2013-12-15 19:24:00 CET
Seeing as there does not appear to be any maintainer interest, I've just taken the steps necessary to make mate-polkit start under lxde.

This can easily be undone so if anyone with more interest/time than me wants to revert this and use lxpolkit code (after checking with upstream and getting them to sort out where the code should live and get their i18n on it sorted) then that's perfectly fine. I've left instructions on what is needed in the lxpolkit spec file (which now contains an error which should prevent submission).

Will leave this open until tests are complete.
Comment 10 Daniel Napora 2013-12-18 12:21:04 CET
I confirm that mate-polkit starts and works with LXDE now.
So one more step to finish this LXDE-polkit-mess story is to add:

Requires:  mate-polkit

to task-lxde and task-lxde-minimal

\o/
Comment 11 Colin Guthrie 2013-12-18 12:28:24 CET
You should probably just add:

Requires: polkit-agent

and the rpmsrate stuff will bring in mate-polkit as the default provider of that.
Comment 12 Doug Laidlaw 2013-12-20 11:09:56 CET
I just changed my Mga3 Official to Cauldron.  I had the old problem until I installed polkit-desktop-policy.  That was already there in theoriginal Cauldron installation

CC: (none) => laidlaws

Comment 13 Colin Guthrie 2013-12-20 12:39:32 CET
Strange, polkit-desktop-policy does nada in cauldron....

Likely it should... but currently it contains no files, so it's odd that installing this package had any affect at all....

Also can you clarify what the "old problem" is?
Comment 14 Doug Laidlaw 2013-12-20 13:16:12 CET
Looks as though I observed incorrectly (and posted to the wrong bug.)

I changed my Mga3 to Cauldron by changing the sources as per the wiki, and installed 2200 packages.  The position with Xfce was basically as in Bug 11184, and I thought that was where I was posting to.  The Mcc panel icon did nothing.  I installed Mate's polkit and copied across the .desktop file from Cauldron to the Launcher directory: still nothing.

I then booted into the old Cauldron and took a list of the polkit RPMs installed.  Came back here and noticed that I did not have polkit-desktop-policy, so I installed it.  That seemed to fix things, but the reboot may have been enough.  Gwenview would't open, but a further reboot fixed that.

I can launch "Add and remove software" from the menu repeatedly and MCC from the panel or a desktop icon repeatedly.

Sorry, my concentration is slipping.
Comment 15 Daniel Napora 2013-12-26 13:07:00 CET
(In reply to Colin Guthrie from comment #11)
> You should probably just add:
> 
> Requires: polkit-agent
> 
> and the rpmsrate stuff will bring in mate-polkit as the default provider of
> that.

urpmi polkit-agent ask users to choice:
1.mate-polkit
2.gnome-shell
3.cinnamon

I don't think giving users chance to make wrong choices is good solution. So maybe better to specify mate-polkit as required for task-lxde and task-lxde-minimal.
Comment 16 Colin Guthrie 2013-12-26 13:14:11 CET
Yeah, on reflection I think you're right. I presume task-lxde already requires task-lxde-minimal so the require should really only be in the -minimal one right?
Comment 17 Atilla ÖNTAŞ 2013-12-30 22:12:53 CET
(In reply to Colin Guthrie from comment #16)
I have added mate-polkit as requires into task-lxde-minimal and committed. Waiting for freeze push. Please close this bug report if the new mate-polkit package fixes this issue for you. Thanks.

CC: (none) => tarakbumba

Comment 18 Anne Nicolas 2014-01-03 17:10:08 CET
Package submitted. Reporter please have a look on that one
Comment 19 Doug Laidlaw 2014-01-03 17:24:29 CET
I thought I had taken myself off this Bug.  See Comment 14.
Doug Laidlaw 2014-01-03 17:24:59 CET

CC: laidlaws => (none)

Comment 20 Daniel Napora 2014-01-07 12:24:07 CET
Resolved \o/

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.