Bug 11460 - elinks does not properly verify SSL certificates
Summary: elinks does not properly verify SSL certificates
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Security (show other bugs)
Version: 3
Hardware: i586 Linux
Priority: Normal major
Target Milestone: ---
Assignee: QA Team
QA Contact: Sec team
URL: http://lwn.net/Vulnerabilities/570334/
Whiteboard: advisory mga3-64-OK mga3-32-ok
Keywords: validated_update
Depends on:
Blocks:
 
Reported: 2013-10-14 19:12 CEST by David Walser
Modified: 2014-01-21 17:35 CET (History)
5 users (show)

See Also:
Source RPM: elinks-0.12-3.mga3.src.rpm
CVE:
Status comment:


Attachments

Description David Walser 2013-10-14 19:12:34 CEST
Fedora has issued an advisory on October 6:
https://lists.fedoraproject.org/pipermail/package-announce/2013-October/119053.html

The patch Fedora added doesn't look valid for us, as they don't use openssl, but use nss_compat_ossl (not sure what that is exactly, but I guess it's some way of using nss) which their patch depends on.  The upstream change to fix this with openssl does not apply cleanly to pre5 or pre6 (which we should update to BTW):
http://pkgs.fedoraproject.org/cgit/elinks.git/tree/elinks-0.12pre6-ssl-hostname.patch
http://repo.or.cz/w/elinks.git/commitdiff/0c3f3e09
https://bugzilla.redhat.com/show_bug.cgi?id=881411
https://bugzilla.redhat.com/show_bug.cgi?id=881399

Reproducible: 

Steps to Reproduce:
David Walser 2013-10-14 19:12:40 CEST

Whiteboard: (none) => MGA3TOO, MGA2TOO

David Walser 2013-11-21 23:05:17 CET

Blocks: (none) => 11726

Comment 1 David Walser 2013-11-22 16:14:18 CET
Removing Mageia 2 from the whiteboard due to EOL.

http://blog.mageia.org/en/2013/11/21/farewell-mageia-2/

Whiteboard: MGA3TOO, MGA2TOO => MGA3TOO

Comment 2 Shlomi Fish 2014-01-04 12:56:59 CET
Hi David,

(In reply to David Walser from comment #1)
> Removing Mageia 2 from the whiteboard due to EOL.
> 
> http://blog.mageia.org/en/2013/11/21/farewell-mageia-2/

this should be fixed in the Cauldron svn repository in:

[Q]

Path: .
Working Copy Root Path: /home/shlomif/Download/unpack/Mageia/elinks
URL: svn+ssh://svn.mageia.org/svn/packages/cauldron/elinks/current
Relative URL: ^/cauldron/elinks/current
Repository Root: svn+ssh://svn.mageia.org/svn/packages
Repository UUID: 01bf705a-734c-4999-978a-dc8ab10ec44d
Revision: 564555
Node Kind: directory
Schedule: normal
Last Changed Author: shlomif
Last Changed Rev: 564555
Last Changed Date: 2014-01-04 13:54:33 +0200 (Sat, 04 Jan 2014)

[/Q]

What I did was update to -pre6 and forward-port the patch (which was somewhat time consuming but doable). Should it be tested now? Should I submit it as a freeze request?

Regards,

-- Shlomi Fish

CC: (none) => shlomif

Comment 3 David Walser 2014-01-04 13:45:59 CET
(In reply to Shlomi Fish from comment #2)
> What I did was update to -pre6 and forward-port the patch (which was
> somewhat time consuming but doable). Should it be tested now? Should I
> submit it as a freeze request?

I assume you mean the upstream patch.  Yes, send a freeze push request for Cauldron.  Thank you so much for working on this!  You could also make the same changes in Mageia 3 SVN and build it in updates_testing there, to help it get wider testing (and obviously that'll be needed so that we can do the security update for Mageia 3).
Comment 4 Shlomi Fish 2014-01-04 15:04:52 CET
Hi David,

(In reply to David Walser from comment #3)
> (In reply to Shlomi Fish from comment #2)
> > What I did was update to -pre6 and forward-port the patch (which was
> > somewhat time consuming but doable). Should it be tested now? Should I
> > submit it as a freeze request?
> 
> I assume you mean the upstream patch.  

Yes, the one from git.

> Yes, send a freeze push request for
> Cauldron.  

I sent it. Thanks.

> Thank you so much for working on this!  You could also make the
> same changes in Mageia 3 SVN and build it in updates_testing there, to help
> it get wider testing (and obviously that'll be needed so that we can do the
> security update for Mageia 3).

Done: http://pkgsubmit.mageia.org/ - elinks-0.12-1.mga3 was now uploaded to core/updatest_testing (after I did an svn merge).

Regards,

-- Shlomi Fish
Comment 5 David Walser 2014-01-05 00:47:22 CET
Just noting that it's now elinks-0.12-3.1.mga3 in updates_testing.
Comment 6 David Walser 2014-01-09 16:11:53 CET
elinks-0.12-7.mga4 uploaded for Cauldron.

Version: Cauldron => 3
Blocks: 11726 => (none)
Whiteboard: MGA3TOO => (none)

Comment 7 David Walser 2014-01-09 17:13:18 CET
Advisory:
========================

Updated elinks package fixes security vulnerability:

When verifying SSL certificates, elinks fails to warn the user if the hostname
of the certificate does not match the hostname of the website.

The elinks package has been updated to version 0.12-pre6 and patched to fix
this issue.

References:
https://lists.fedoraproject.org/pipermail/package-announce/2013-October/119053.html
========================

Updated packages in core/updates_testing:
========================
elinks-0.12-3.1.mga3

from elinks-0.12-3.1.mga3.src.rpm

Assignee: bugsquad => qa-bugs

Comment 8 Anne Nicolas 2014-01-17 09:37:32 CET
working on it

CC: (none) => ennael1

Comment 9 Bill Wilkinson 2014-01-20 18:50:05 CET
Tested mga3-64.

Attempted to go to https://tv.eurosport.com, which has an expired certificate--error replied.

Https://bugs.mageia.org loads normally for a text-based browser.

CC: (none) => wrw105
Whiteboard: (none) => mga3-64-OK

Comment 10 Anne Nicolas 2014-01-20 18:53:17 CET
ok I let it down then
Comment 11 Bill Wilkinson 2014-01-20 19:00:46 CET
tested mga3-32 as in comment 9.

replies as above.

Sorry Anne!  MrsB recommended that I take a look at this this morning as part of our "clean out updates" push!

Ready for advisory upload to svn and validation.

Whiteboard: mga3-64-OK => mga3-64-OK mga3-32-ok

Comment 12 claire robinson 2014-01-20 20:21:53 CET
Is there a CVE for this, it's given a Grave security rating at debian?
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=694658

Advisory uploaded without CVE. Validating

Could sysadmin please push from 3 core/updates_testing to updates

Thanks

Keywords: (none) => validated_update
Whiteboard: mga3-64-OK mga3-32-ok => advisory mga3-64-OK mga3-32-ok
CC: (none) => sysadmin-bugs

Comment 13 David Walser 2014-01-20 20:36:13 CET
Thanks.  No CVE that I'm aware of.
Comment 14 Thomas Backlund 2014-01-21 17:35:23 CET
Update pushed:
http://advisories.mageia.org/MGASA-2014-0014.html

Status: NEW => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.