Finally done some work to implement: https://wiki.mageia.org/en/Feature:ChronyDefaultNTP The chrony package has been imported and should be ready to submit. I haven't built it yet on the build system, but it's built locally and running fine in a VM. For the drakx changes, I have made an attempt to implement. I haven't tested them (wouldn't know how to anyway), but I made the changes that looked right to make. Obviously I didn't commit it, because I checked out from svn and everything's being converted to git, and I'd like to get it reviewed first. Colin, hopefully you can commit this to the git of drakx if it's good. I'll attach my svn diff. Reproducible: Steps to Reproduce:
Created attachment 4290 [details] svn diff of svn/soft/perl-install with changes needed for chrony rpmsrate-raw in meta-task should also be changed s/ntp/chrony/: Index: rpmsrate-raw =================================================================== --- rpmsrate-raw (revision 472352) +++ rpmsrate-raw (working copy) @@ -820,7 +820,7 @@ 5 CAT_FILE_TOOLS davfs2 5 CAT_FILE_TOOLS hfsutils 4 CAT_FILE_TOOLS reiser4progs - 5 CAT_SYSTEM ntp + 5 CAT_SYSTEM chrony 5 CAT_SYSTEM dhcp-client zcip 5 CAT_SYSTEM rp-pppoe ppp-pppoatm pptp-linux bpalogin 5 CAT_SYSTEM b43-openfwwf b43-fwcutter ndiswrapper @@ -842,7 +842,7 @@ 5 pptp-linux dhcpcd dhcpxd dhcp-client rp-pppoe pump ppp nfs-utils ppp-pppoe ppp-pppoatm - autologin ntp samba-server ncpfs mageia-gfxboot-theme + autologin chrony samba-server ncpfs mageia-gfxboot-theme shorewall shorewall-ipv6 iptables samba-client perl-Net-DNS mandi-ifw dhcp-client netcat-traditional sndconfig curl mtools usbutils
Comment on attachment 4290 [details] svn diff of svn/soft/perl-install with changes needed for chrony Looks generally OK with a quick look. There may be more we can do in drakclock related to using the dbus interfaces now exported by systemd's datetimed (much like Gnome does), but I'll need to poke into it a bit to know what's possible there.
Per Ãyvind has implemented this in his branch (it'd be nice to take a look at his code) by just replacing ntp with chrony instead of supporting both. A couple tips he gave me: 1) it should add iburst at the end of the server definition lines in chrony.conf so that it will sync immediately when chrony starts (kind of like what ntpdate.service does now) 2) it should do a waitsync after choosing the ntp server right after chronyd has been started by also doing systemctl start chrony-wait
Hiya, I've eventually taken a look at this - so sorry for the delay! I've added the iburst thing and made several other changes. There were a few syntax bugs and I think I've fixed them all up! Please double check! http://gitweb.mageia.org/software/drakx/commit/?id=d54857e5704e52bc93d810250732affc82e1d65f It seems to work well for me in both scenarios (tho' I did have to push one fix afterwards to fix a string comparison bug I introduced in the above commit). Anyway, all seems well now I think.
Hey Colin, thanks for committing this. The only things I noticed are, with the differences in your commit vs. my patch for: - perl-install/standalone/finish-install - perl-install/install/steps.pm your commit forces it to install and use chrony. My intention was that if you already had ntpd installed, it would just use and still support that. Also, have the needed changes to rpmsrate I posted in Comment 1 been addressed anywhere?
(In reply to David Walser from comment #5) > Hey Colin, thanks for committing this. The only things I noticed are, with > the differences in your commit vs. my patch for: > - perl-install/standalone/finish-install I mentioned all the differences in the patch commit message, so it should be clear. I dropped the finish-install stuff as this is only used after live CD installs thus there should be no "legacy" installs here, and we should not have to deal with old systems - we can just assume chrony. > - perl-install/install/steps.pm > > your commit forces it to install and use chrony. My intention was that if > you already had ntpd installed, it would just use and still support that. I don't see how the steps.pm changes did that. I could see this argument working if applied to finish-install if it were not for the pre-condition that it is only used for live installs where we can control ntp inclusion. Is this what you were referring to? > Also, have the needed changes to rpmsrate I posted in Comment 1 been > addressed anywhere? Nope, missed this bit but done now. Thanks! (that does somewhat lessen my argument about finish-install, but the principle of it does still stand I think :p)
OK, looking at install/steps.pm again, it looks like your code should do the same thing as mine. I'll have to test this when I get a chance, but the code looks fine to me now.
I just did some testing, and the installer works fine for installing and configuring chrony. Using drakclock from MCC in a running system works sometimes, but there are some issues, as seen in Bug 11502. Also, if you have both ntp and chrony installed, drakclock should configure chrony, but it does ntp in that case, which is incorrect. Speaking of drakclock, there's also Bug 9785 which isn't related to this bug.
Testing the installer on an upgrade with ntp and chrony installed, (and both services previously disabled) it configured ntp.conf and enabled ntpd.service, which is incorrect. One one attempt at doing the above, it appeared to at least configure ntp.conf correctly. On one other attempt, for some reason it put the africa ntp servers in ntp.conf, even though I left the default "All servers" selected in the installer, which should have put pool.ntp.org in ntp.conf. I did one final attempt with only ntp installed, and it put the africa servers in there again, and did not enable ntpd.service.
what about this bug ? is it still valid ?
CC: (none) => mageia
I'm not aware that any work has been done on this.