Bug 10527 - open-iscsi does not start, due to kernel module not loaded
Summary: open-iscsi does not start, due to kernel module not loaded
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 3
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard: mga3-64-ok mga3-32-ok
Keywords: PATCH, Triaged, validated_update
Depends on:
Blocks:
 
Reported: 2013-06-14 14:52 CEST by Glen Ogilvie
Modified: 2014-05-08 18:04 CEST (History)
4 users (show)

See Also:
Source RPM: open-iscsi-2.0-872.2.mga3.src.rpm
CVE:
Status comment:


Attachments

Description Glen Ogilvie 2013-06-14 14:52:53 CEST
Description of problem:

/usr/lib/systemd/system/open-iscsi.service

is missing the logic to load the kernel module.  The init scripts in Mageia 2 did this.  

It needs to do something like:

modprobe -q iscsi_tcp

Suggested solution:


svn://svn.mageia.org/svn/packages/cauldron/open-iscsi/current/SOURCES/open-iscsi.service


Index: open-iscsi.service
===================================================================
--- open-iscsi.service  (revision 443049)
+++ open-iscsi.service  (working copy)
@@ -5,6 +5,8 @@
 [Service]
 Type=forking
 ExecStart=/sbin/iscsid
+ExecStartPre=/usr/sbin/modprobe -q iscsi_tcp
+ExecStopPost=/usr/sbin/modprobe -r iscsi_tcp
 
 [Install]
 WantedBy=multi-user.target



I can commit this change, if that's OK with the package maintainer, as I have access.

Reproducible: 

Steps to Reproduce:
Glen Ogilvie 2013-06-14 14:53:30 CEST

Keywords: (none) => PATCH

Comment 1 Manuel Hiebel 2013-06-29 15:24:22 CEST
there is no maintainer, I added other commiters in case of, but feel free to commit I guess

Keywords: (none) => Triaged
CC: (none) => guillomovitch, luigiwalser, oe, tmb

Comment 2 Oden Eriksson 2013-07-02 14:35:18 CEST
fixed with open-iscsi-2.0-872.2.1.mga3 + open-iscsi-2.0-872.3.mga4
Comment 3 David Walser 2013-07-02 16:35:26 CEST
Thanks Oden.

Advisory:
========================

The open-iscsi service would not start successfully in Mageia 3, as the kernel
module needed by the service was not loaded.  This has been corrected.

========================

Updated packages in core/updates_testing:
========================
open-iscsi-2.0-872.2.1.mga3
libiscsi0-2.0-872.2.1.mga3
libiscsi-devel-2.0-872.2.1.mga3
python-libiscsimodule-2.0-872.2.1.mga3

from open-iscsi-2.0-872.2.1.mga3.src.rpm

Assignee: bugsquad => qa-bugs

Comment 4 claire robinson 2013-07-02 17:33:00 CEST
Glen can you see if this fixes it for you please and let us know which release and architecture you tested with. Thanks.
Comment 5 Glen Ogilvie 2013-07-04 10:37:26 CEST
Tested on Mageia 3, x86_64.  Confirmed working.

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 6 claire robinson 2013-07-04 10:40:06 CEST
It needs to be tested i586 too before it can be validated and pushed to updates before the bug is closed :)

Status: RESOLVED => REOPENED
Resolution: FIXED => (none)

Comment 7 Glen Ogilvie 2013-07-04 12:35:45 CEST
I thought after clicking closed that maybe I shouldn't have.  Sorry.  I can fire up a i586 vm in the weekend and test iscsi works if need be, although based on what has changed, I think this fix will apply to both.   i586 does not have different kernel module names, and all the fix does is load the right kernel module on startup.

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED

Comment 8 claire robinson 2013-07-04 12:45:54 CEST
re-opening again :D

Each arch of an update candidate needs to be tested before it can be validated. The rpm's for i586 are not the same ones used by x86_64 so the only way to know it works is to try it. The only time this isn't the case really is for noarch packages, but even then it's useful to check they are present and installable/updateable from either repository.

You can see our validation process here if you like:
https://wiki.mageia.org/en/QA_process_for_validating_updates

I included this update in the list of 'easy bugs' for new QA testers but none have ventured forward yet :\ Feel free to check it i586 too if it's not done by the time you get to it Glen, thankyou.

Status: RESOLVED => REOPENED
Resolution: FIXED => (none)

claire robinson 2013-07-04 12:46:13 CEST

Whiteboard: (none) => mga3-64-ok

Guillaume Rousse 2013-07-04 13:04:23 CEST

CC: guillomovitch => (none)

Comment 9 claire robinson 2013-07-05 17:58:52 CEST
Testing complete mga3 32

Before
------

# service open-iscsi start
Redirecting to /bin/systemctl start open-iscsi.service
Job for open-iscsi.service failed. See 'systemctl status open-iscsi.service' and 'journalctl -n' for details.

# journalctl -n
-- Logs begin at Thu, 2013-06-13 09:17:53 BST, end at Fri, 2013-07-05 16:52:40 BST. --
systemd[1]: Starting Open iSCSI Daemon...
iscsid[26403]: iSCSI logger with pid=26404 started!
iscsid[26404]: Missing or Invalid version from /sys/module/scsi_transport_iscsi
systemd[1]: open-iscsi.service: control process exited, code=exited status=1
systemd[1]: Failed to start Open iSCSI Daemon.

# lsmod | grep isc
#


After
-----
# service open-iscsi start
Redirecting to /bin/systemctl start open-iscsi.service

# journalctl -n
-- Logs begin at Thu, 2013-06-13 09:17:53 BST, end at Fri, 2013-07-05 16:53:41 BST. --
systemd[1]: Starting Open iSCSI Daemon...
kernel: Loading iSCSI transport class v2.0-870.
kernel: iscsi: registered transport (tcp)
iscsid[26524]: iSCSI logger with pid=26525 started!
systemd[1]: Started Open iSCSI Daemon.
iscsid[26525]: transport class version 2.0-870. iscsid version 2.0-872
iscsid[26525]: iSCSI daemon with pid=26526 started!
iscsid[26525]: Warning: InitiatorName file /etc/iscsi/initiatorname.iscsi does 

# lsmod | grep isc
iscsi_tcp              18015  0 
libiscsi_tcp           20301  1 iscsi_tcp
libiscsi               46927  2 libiscsi_tcp,iscsi_tcp
scsi_transport_iscsi    48137  3 iscsi_tcp,libiscsi

Whiteboard: mga3-64-ok => mga3-64-ok mga3-32-ok

Comment 10 claire robinson 2013-07-05 18:04:12 CEST
Validating. Advisory from comment 3 uploaded.

Could sysadmin please push from 3 core/updates_testing to core/updates

Thanks!

Keywords: (none) => validated_update
CC: (none) => sysadmin-bugs

Comment 11 Nicolas Vigier 2013-07-06 16:31:36 CEST
http://advisories.mageia.org/MGAA-2013-0049.html

Status: REOPENED => RESOLVED
CC: (none) => boklm
Resolution: (none) => FIXED

Nicolas Vigier 2014-05-08 18:04:22 CEST

CC: boklm => (none)


Note You need to log in before you can comment on or make changes to this bug.