Bug 10424 - License for Mageia on web site
Summary: License for Mageia on web site
Status: RESOLVED FIXED
Alias: None
Product: Websites
Classification: Unclassified
Component: www.mageia.org (show other bugs)
Version: trunk
Hardware: All Linux
Priority: Normal enhancement
Target Milestone: ---
Assignee: Atelier Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-04 11:50 CEST by Alex Loginov
Modified: 2013-07-22 15:27 CEST (History)
3 users (show)

See Also:
Source RPM:
CVE:
Status comment:


Attachments
Diff to implementation php-mo.php by Joss Crowcroft (4.96 KB, patch)
2013-07-22 13:59 CEST, Filip Komar
Details | Diff

Description Alex Loginov 2013-06-04 11:50:29 CEST
Please add license for Mageia on web site with translations.
Some users wants to install Mageia in state institutions, government
institutions instead ROSA. And we need Russian text of license on official
Mageia web site.
Now license is in installer, but better way to have license on web site also.

Reproducible: 

Steps to Reproduce:
Romain d'Alverny 2013-06-05 15:46:12 CEST

CC: (none) => rdalverny

Comment 1 Romain d'Alverny 2013-06-05 15:55:19 CEST
Option A:

 - make a svn:externals reference from web/www/langs/license_po to soft/drakx/trunk/perl-install/share/po
 - add a web/www/en/license/index.php page calling license strings, wrapped into gettext()
 - add some intro/aside comments on the same page, localized in .lang files then.
 - when the license text is updated in soft/drakx, it will only require to adjust the reference text in the PHP code, so that all strings are up to date.

Option B:

 - actually, there are numerous other ways, but I can't think of one shorter/simpler than A at this point.
Comment 2 Alex Loginov 2013-06-05 22:28:39 CEST
Good way - to use po files.
Comment 3 Filip Komar 2013-06-13 08:15:09 CEST
This seems very promising for extraction of license strings from po files:
https://github.com/josscrowcroft/php.mo/blob/master/php-mo.php

I'll ask doc team if they can help with "an introduction text ... (summarizing, explaining the core principles, and why this license was chosen)."

CC: (none) => filip.komar

Comment 5 Romain d'Alverny 2013-06-13 15:55:58 CEST
That's a good point Damien; we should add, at least, a link to the licensing policy in the doc too.
Comment 6 Filip Komar 2013-06-20 00:45:13 CEST
(In reply to Filip Komar from comment #3)
> This seems very promising for extraction of license strings from po files:
> https://github.com/josscrowcroft/php.mo/blob/master/php-mo.php

Apart from the small bug which I had to fix this actually proved to be very useful.

I already have a working prototype of "Option A". Second point is already done and a part of first. For now I still wait for text of third point.

Should I commit the page when prototyping stage is over so that we can all give a comment on it? A test domain would be useful for that.

Status: NEW => ASSIGNED

Comment 7 Romain d'Alverny 2013-06-20 10:16:43 CEST
(In reply to Filip Komar from comment #6)
> I already have a working prototype of "Option A". Second point is already
> done and a part of first. For now I still wait for text of third point.

Cool!

> Should I commit the page when prototyping stage is over so that we can all
> give a comment on it? A test domain would be useful for that.

Yes, go ship it! :)
Comment 8 Filip Komar 2013-06-21 00:11:05 CEST
(In reply to Romain d'Alverny from comment #7)
> > Should I commit the page when prototyping stage is over so that we can all
> > give a comment on it? A test domain would be useful for that.
> 
> Yes, go ship it! :)

Here it is:
http://www.mageia.org/en/about/license/

Unfortunately there are still some parsing errors from po files. I already identified one: commented fuzzy strings default to parse error and script for now just return FALSE instead of an array. You'll notice those as they have a debug comment on top of the page.

I'll try to fix those issues soon but any comment or proposal is more than welcome especially in this stage. I already know that design is not really superb (as that area is not my strong point) ;) but I think it'll do for now.

Note that preamble is short as I still need some content there.
Comment 9 Manuel Hiebel 2013-06-21 09:43:34 CEST
Pretty good job ! :)
Comment 10 Filip Komar 2013-06-21 20:50:41 CEST
(In reply to Filip Komar from comment #8)
> Unfortunately there are still some parsing errors from po files. I already
> identified one: commented fuzzy strings default to parse error and script
> for now just return FALSE instead of an array. You'll notice those as they
> have a debug comment on top of the page.

Actually I didn't find any other parsing bugs. Until fixed debug comment will stay.

I noticed that license in po file is not fully translated or is in rough shape in some languages. One has even copies of English string from msgid to msgstr. We'll expose those now.



(In reply to Manuel Hiebel from comment #9)
> Pretty good job ! :)

Thanks Manuel. Nice to read that. Glad you like it. Thx for your work too.
Comment 11 Filip Komar 2013-07-10 22:18:48 CEST
@Alex and Romain: any comments?

I updated page a bit and I fixed that 'parsing bug' in the php-mo.php file. It didn't anticipated commented unused strings so it chocked on them.

I also did another small fix to save stored entry on empty line as that "fuzzy flag first line" rare bug which didn't saved previous proper string at all.

I'm also still missing an introduction text.
Comment 12 Alex Loginov 2013-07-11 14:52:10 CEST
Filip, I looked http://www.mageia.org/ru/about/license/
I like it. Thank you very much.
Comment 13 James Kerr 2013-07-11 15:37:52 CEST
In the English version, in the penultimate line of Section 2, regarding Limited Liability,
  "the exclusion or limitation or liability"
I think should be "the exclusion or limitation *of* liability"

Also (a trivial point) - there is an unnecessary line break between "component" and "licensor" in Section 3.
Comment 14 Romain d'Alverny 2013-07-11 17:38:03 CEST
(In reply to Filip Komar from comment #11)
> @Alex and Romain: any comments?

It looks good to me. :)

> I updated page a bit and I fixed that 'parsing bug' in the php-mo.php file.
> It didn't anticipated commented unused strings so it chocked on them.
> 
> I also did another small fix to save stored entry on empty line as that
> "fuzzy flag first line" rare bug which didn't saved previous proper string
> at all.

Do you have a link to your diffs?

> I'm also still missing an introduction text.

At this point, it will faster to go without one, and wait for a question to raise questions about it, or someone to propose one.
Comment 15 Filip Komar 2013-07-22 13:59:55 CEST
Created attachment 4216 [details]
Diff to implementation php-mo.php by Joss Crowcroft

I removed function phpmo_convert and phpmo_write_mo_file as they are not needed here.

I also fixed fopen to not generate Warning on missing files and list to avoid Notice on commented unused string lines. I added case for handling them as previous script just choke with FALSE.

I fixed "fuzzy flag first line" bug by moving array fill part to the empty line as it should be present in every string pair anyway.
This bug happened on very rare case when po file had first commented unused string with fuzzy flag. Because of that previous string was not saved. Any other string with fuzzy flag in the first line would also trigger this bug but I didn't test if such po file is valid (msgfmt -c) at all.
Comment 16 Filip Komar 2013-07-22 14:17:31 CEST
(In reply to Alex Loginov from comment #12)
> Filip, I looked http://www.mageia.org/ru/about/license/
> I like it. Thank you very much.

Thanks Alex. I'm closing this bug.

(In reply to James Kerr from comment #13)
> In the English version, ...

James can you please open a new bug about it as this bug report only asked for the web page. Source for English text is here:
http://svnweb.mageia.org/soft/drakx/trunk/perl-install/messages.pm?view=markup
I think it's safe to assume to assign tv to fix it.

(In reply to Romain d'Alverny from comment #14)
> It looks good to me. :)
Thanks Romain.

> Do you have a link to your diffs?
I created attachment 4216 [details] in comment #15.

> > I'm also still missing an introduction text.
> 
> At this point, it will faster to go without one, and wait for a question to
> raise questions about it, or someone to propose one.

I did as you suggested.

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED

Comment 17 James Kerr 2013-07-22 15:27:41 CEST
(In reply to Filip Komar from comment #16)

Bug#10814 opened, as requested.

Note You need to log in before you can comment on or make changes to this bug.