Bug 985 - Add faac to audiokonverter (when appropriate repo available)
Summary: Add faac to audiokonverter (when appropriate repo available)
Status: RESOLVED INVALID
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal enhancement
Target Milestone: Mageia 2
Assignee: Shlomi Fish
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 1730 2833
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-25 14:42 CEST by Philippe Didier
Modified: 2014-05-08 18:04 CEST (History)
2 users (show)

See Also:
Source RPM: audiokonverter-5.9-1
CVE:
Status comment:


Attachments
spec file from plf to adapt to mageia (3.52 KB, text/plain)
2011-09-18 23:01 CEST, Philippe Didier
Details
draft of the spec file (3.92 KB, text/plain)
2011-09-25 01:09 CEST, Philippe Didier
Details
patch for core repo (2.65 KB, text/plain)
2011-09-25 01:11 CEST, Philippe Didier
Details
patch for tainted repo (2.29 KB, text/plain)
2011-09-25 01:13 CEST, Philippe Didier
Details

Description Philippe Didier 2011-04-25 14:42:43 CEST
Description of problem:
Please add audiokonverter 
It should be in tainted repo , using the plf version of the mandriva srpm spec, with its depedencies lame faad (already provided)
- faac, 
- mplayer (plf version too!)

(Perhaps need of an other bug report for faac... )
Perhaps first need  of a solution to build some rpms in tainted and core with the same buildsystem (for mplayer mencoder for instance ) and a solution to differentiate the 2 kind of rpms (suffix .mga for core and .mgt for tainted ?! to allow "upgrade" from core to tainted version)

Version-Release number of selected component (if applicable):

audiokonverter-5.9-1
Ahmad Samir 2011-05-11 02:26:22 CEST

Depends on: (none) => 338

Comment 1 Philippe Didier 2011-09-18 23:01:20 CEST
Created attachment 809 [details]
spec file from plf to adapt to mageia
Comment 2 Philippe Didier 2011-09-18 23:08:41 CEST
Since faac is provided in tainted repo for mageia 1 and cauldron

https://bugs.mageia.org/show_bug.cgi?id=1730

If mplayer is rebuilt with faac 

https://bugs.mageia.org/show_bug.cgi?id=2771

audiokonverter may be built and used ....
Philippe Didier 2011-09-22 00:38:36 CEST

Depends on: 338 => (none)

Comment 3 Philippe Didier 2011-09-22 00:39:04 CEST
Since last meeting it seems that FAAC won't be neither in tainted nor in non-free repo. 
There won't either exist a special non-free&tainted repo for now :

Mageia-dev meeting Wed Sep 21 2011 :

"as a policy: tainted will have only free software inside"

"policy will be reviewed for Mageia 2 to add potentially non-free tainted repo"


 That may mean that this bug report can't be fixed now, but must not be closed as wontfix and may remain as a reminder until the next policy review for Mageia 2...

Depends on: (none) => 1730

Manuel Hiebel 2011-09-23 21:54:15 CEST

Keywords: (none) => Junior_job, PATCH

Comment 4 Philippe Didier 2011-09-25 00:49:23 CEST
I tried to adapt a spec file to mageia (1 or cauldron)
and 2 patches :
One patch for core : audiokonverter.free.patch (disabling mp3 and faac encoding)
one patch for tainted : audiokonverter.nofaac.patch (allowing mp3 encoding, disabling faac encoding)

the second patch won't be used in nonfree-tainted repo if this repo is created for mageia2 (including faac and packages built with faac such as vlc mplayer libquicktime audiokonverter



These are drafts : feel free to try and modify them

Summary: please add audiokonverter in tainted repo => please add audiokonverter in core and tainted repos

Comment 5 Philippe Didier 2011-09-25 01:09:44 CEST
Created attachment 823 [details]
draft of the spec file

feel free to correct and adapt it (I couldn't test it...)
Comment 6 Philippe Didier 2011-09-25 01:11:56 CEST
Created attachment 824 [details]
patch for core repo

patch for core repo (no mp3 encoding no aac encoding)

Attachment 809 is obsolete: 0 => 1

Comment 7 Philippe Didier 2011-09-25 01:13:36 CEST
Created attachment 825 [details]
patch for tainted repo

patch for tainted repo allowing mp3 encoding but not allowing aac encoding
Philippe Didier 2011-09-25 04:02:24 CEST

Depends on: (none) => 2833

Comment 8 Barry Jackson 2011-09-30 13:23:26 CEST
(In reply to comment #7)
> Created attachment 825 [details]
> patch for tainted repo
> 
> patch for tainted repo allowing mp3 encoding but not allowing aac encoding

Hi Phillipe - thanks for your work on this - I have tidied up the spec and it appears to be working fine. I had to re-make the no-faac patch as it failed to install - not sure why.
The src.rpm is here and should be landing in cauldron soon.
http://barjac-mtf.zapto.org/audiokonverter-5.9.1-0.mga2.src.rpm
Please test if you can when it appears in Cauldron.

CC: (none) => zen25000

Comment 9 Philippe Didier 2011-09-30 20:04:55 CEST
Thanks to take care of this bug report...

And sorry for the double typo in no-faac patch : 
I wrote it using the free patch as a model and I simply pasted and copied some parts of it, without correcting the line numbers (@@ -41,16 +36,6 @@ ought to be @@ -41,16 +41,6 @@ ... and @@ -74,16 +69,6 @@ ought to be @@ -74,16 +74,6 @@... that's what you corrected on your srpm, which I downloaded and explored) 

that's the reason why it failed to install for you

And that's the reason why I'm not yet ready to be a packager :(

For my own use, I have faac installed (and I'm sorry there's yet no solution for this on mageia)

I haven't installed cauldron on my computer ... too much precious stuff on it !!!
I have to buy a new one dedicated to experimentations to play with cauldron ;) and tests...


Nevertheless, anybody can test the package : 
in konqueror or dolphin a right click :
- on an audio file 
(MimeType=audio/x-wav;audio/aac;audio/x-flac;audio/x-mp3;audio/mpeg;audio/mp3;audio/vorbis;inode/directory;audio/x-ms-wma;audio/vnd.rn-realaudio;application/vnd.rn-realaudio;audio/mp4;audio/x-musepack;audio/x-wavpack;audio/x-m4a;audio/x-real-audio)
- or on a video file
(MimeType=video/avi;video/mp4;video/mpeg;video/msvideo;video/ogg;video/quicktime;video/theora;video/vnd.rn-realvideo;application/vnd.rn-realvideo;video/x-matroska;video/x-mpeg;video/x-mpeg2;video/x-ms-asf;video/x-msvideo;video/x-ms-wmv;video/x-ogg;video/x-ogm;video/x-quicktime;video/x-theora;video/x-avi;video/x-flv) 

proposes a new actions menu (allowing to extract sound from a video, or to convert an audio file)
Comment 10 Philippe Didier 2011-09-30 20:15:26 CEST
PS 
Don't close this bug report when audiokonverter is in cauldron ... we must keep it as a reminder if eventually a non-free & tainted repo is created for Mageia2 !
Comment 11 Barry Jackson 2011-10-01 20:41:35 CEST
audiokonverter is now available in Cauldron/core/release and Cauldron/tainted/release for testing.

Changing bug title and targeting it to mga3.

Thanks Philippe for your hard work on this.

Component: New RPM package request => RPM Packages
Hardware: i586 => All
Target Milestone: --- => Mageia 3
Summary: please add audiokonverter in core and tainted repos => Add faac to audiokonverter (when appropriate repo available)

Comment 12 Manuel Hiebel 2011-10-01 20:48:27 CEST
> Changing bug title and targeting it to mga3.
Mageia2 :)

Keywords: Junior_job, PATCH => (none)
Target Milestone: Mageia 3 => Mageia 2

Comment 13 Barry Jackson 2011-10-01 21:03:40 CEST
I thought this had been ruled out for mga2 - that's why I put mga3 - but hey, we live in hope! ;)
Comment 14 Marja Van Waes 2011-12-03 11:47:51 CET
(In reply to comment #3)
> Since last meeting it seems that FAAC won't be neither in tainted nor in
> non-free repo. 
> There won't either exist a special non-free&tainted repo for now :
> 
> Mageia-dev meeting Wed Sep 21 2011 :
> 
> "as a policy: tainted will have only free software inside"
> 
> "policy will be reviewed for Mageia 2 to add potentially non-free tainted repo"
> 
> 
>  That may mean that this bug report can't be fixed now, but must not be closed
> as wontfix and may remain as a reminder until the next policy review for Mageia
> 2...

Assigning to maintainer, who can decide to fix or wontfix, depending on what the new policy review leads to.

CC: (none) => marja11
Assignee: bugsquad => shlomif

Comment 15 Nicolas Vigier 2011-12-05 14:23:25 CET
Please don't keep open bug reports for things that cannot be fixed, as there is no plan at the moment to create a nonfree tainted repository. If you want to keep a reminder of things that could be done if a nonfree tainted repository was created, please create a wiki page about faac instead.

CC: (none) => boklm

Comment 16 Manuel Hiebel 2011-12-05 15:04:33 CET
really close

Status: NEW => RESOLVED
Resolution: (none) => INVALID

Nicolas Vigier 2014-05-08 18:04:26 CEST

CC: boklm => (none)


Note You need to log in before you can comment on or make changes to this bug.