Bug 920 - 'urpme --auto-orphans' message shouldn't be shown when using rpmdrake
Summary: 'urpme --auto-orphans' message shouldn't be shown when using rpmdrake
Status: RESOLVED OLD
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal enhancement
Target Milestone: ---
Assignee: Thierry Vignaud
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 14594
  Show dependency treegraph
 
Reported: 2011-04-21 17:55 CEST by Ahmad Samir
Modified: 2015-03-07 09:18 CET (History)
6 users (show)

See Also:
Source RPM: rpmdrake
CVE:
Status comment:


Attachments

Description Ahmad Samir 2011-04-21 17:55:49 CEST
For rpmdrake to be new-user friendly, I think it shouldn't show the notification about the possibility to use 'urpme --auto-orphans'.

That message is OK when using urpme from terminal, as logically users using the CLI are a bit more advanced.

New users, however, will usually opt for using the GUI tools; display that message there is a bit dangerous, the various/many forum/ML posts about users system being wrecked after using that command line show that it's not exactly an option for new users; the most recurrent cause was:
- user uninstall package A which he thinks he doesn't need
- task-$DE{minimal,} depends on package A, so uninstalling A takes out the task-$DE package
- users executes 'urpme --auto-orphans' and ends up with a borked system since his DE is gone
- yes, it's indeed easy to Alt+Ctrl+F1, login as root, and urpmi task-$DE, but a new user doesn't know that Alt+Ctrl+F1 will take him to a virtual terminal


I think this is a release_blocker, i.e. a decision should be made (hopefully to take the message out of the GUI) before Mageia's first official release.

Thanks.
Comment 1 Ahmad Samir 2011-04-21 17:56:37 CEST
(And sorry for the typos... not enough sleep).
Comment 2 James Kerr 2011-04-21 19:28:54 CEST
I think that this suggestion will receive unanimous support from those of us who have spent time in the Mandriva forums helping users.
Marcello Anni 2011-04-22 18:15:11 CEST

CC: (none) => marcello.anni

Comment 3 andré blais 2011-04-25 10:55:28 CEST
I agree as well.

CC: (none) => andr55

Thierry Vignaud 2011-04-28 14:23:53 CEST

Priority: release_blocker => Normal
Severity: normal => enhancement

Comment 4 Ahmad Samir 2011-04-28 19:04:58 CEST
@Thierry: FWIW, I still think this is a release_blocker, a decision needs to be made before Mageia 1, either leave that message (with fully knowing it has wrecked / will wreck-until-its-shortcomings-are-fixed, many systems out there, as users see it in the GUI and think "--auto-orphans is good for cleaning the system of useless packages") or remove it.

Also it's not an enhancement request, this is a bug, IIUC the general rationale for rpmdrake is keeping is simple and leaving out all the advanced-users features/options, --auto-orphans is a feature for advanced users any which way I look it.

Over & out.
Comment 5 Thierry Vignaud 2011-04-29 01:47:15 CEST
That would need changes in urpmi too, which is a bit invasive at this stage
Comment 6 andré blais 2011-04-29 08:33:43 CEST
I agree that the current auto-orphans message -- and the function, as it is now implemented -- should be changed.  And that it is effectively a bug.
And that a complete correction is a bit involved.

So maybe just changing the message, to something like :
------------------
"The following packages seem to be orphaned."
...
(list of packages)
...
You may want to consider removing the above packages.
Please verify that you do not use these packages, or any packages that might be removed with them.
You can verify the function of each package before removal."
----------------------

That is, changing the preceding and following messages.

This is just a rough suggestion.  Undoubtedly the message could be refined.

In any case, just changing the message would be relatively quick to implement, and a lot better than the current "auto-orphans" message.

Alternately, the routine printing the message could be just commented out for now ?  (That is probably what I would do if I were familiar with the program.)

We can always fix the auto-orphans function later.

What do you think ?  Ahmad ?  Thierry ?
Comment 7 Marcello Anni 2011-05-24 18:39:30 CEST
so, what is the status of this enchancement? can it be integrated for 1 release? it will be important for new users and could avoid a lot of issues...
Comment 8 Ahmad Samir 2011-05-24 19:07:48 CEST
Comment#5 still stands true.
Comment 9 Marcello Anni 2011-05-27 11:20:42 CEST
i propose to workaround this issue changing the urpmi message. is it still possible? i'm sendind an e-mail also to 18n team to manage this possible change of translation. 
 
these are the messages that should be changed:

#: ../urpm/orphans.pm:440
#, c-format
msgid ""
"The following package:\n"
"%s\n"
"is now orphaned, if you wish to remove it, you can use \"urpme --auto-orphans"
"\""
msgid_plural ""
"The following packages:\n"
"%s\n"
"are now orphaned, if you wish to remove them, you can use \"urpme --auto-"
"orphans\""
msgstr[0] ""
"Il seguente pacchetto:\n"
"%s\n"
"è ora orfano, se desideri rimuoverlo, puoi eseguire il comando \"urpme --"
"auto-orphans\""
msgstr[1] ""
"I seguenti pacchetti:\n"
"%s\n"
"sono ora orfani, se desideri rimuoverli, puoi eseguire il comando \"urpme --"
"auto-orphans\""

i propose to change the message this way:

"these packages are orphans. If you are an experienced user and you want to remove them, you can use "urpme --auto-orphans". Otherwise we discourage the use of this comand"


thanks

cheers,
Marcello
Comment 10 Anne Nicolas 2011-05-27 11:24:42 CEST
As already said in posts, no such changes now, before the release. BTW it would require to get all translations ready.
Comment 11 Marcello Anni 2011-05-27 11:30:35 CEST
it is only a string change, nothing relevant that could create issues and bugs. And if the i18n team will manage to do this (at least for most used languages) will you approve this? thanks

cheers,
Marcello
Comment 12 Anne Nicolas 2011-05-27 11:32:25 CEST
Maybe all mails were not clear enough... It will not happen now. As an update after release only
Comment 13 Marcello Anni 2011-06-13 11:43:59 CEST
can we have it now?
Comment 14 Marcello Anni 2011-06-26 16:34:24 CEST
now that update process is started, can we start to think about fixing it? as it is a mandriva long-time bug, i think that fixing it it will be a good signal given to the community. thanks


cheers,
Marcello
Comment 15 Grigory Maksaev 2011-08-19 23:46:50 CEST
Hi,

why not to create a corresponding option (in a form of a button) in the appropriate place of MCC (maybe, somewhere by the package list)?
It might call a menu with a short description and waring, if necessary : Remove all the orphaned packages? Yes/No.

One more thing that I'd suggest to think about is a small tool within MCC that would create and maintain the list of newly installed and updated packages with dates. One can do of course something like "rpm -qa --last | head", but it would be great to have this option with GUI.

Thank you.

CC: (none) => schlecht

Comment 16 andré blais 2011-08-20 05:18:38 CEST
Only problem is that up to now, packages identified as orphans can very easily be packages that are be useful to keep.
The only criteria seems to be that it was installed as a requirement of another package.

So for example, if a task package is installed, and then uninstalled in order to remove one of the referenced packages, all the other packages installed with the task package are tagged as orphans.  Not a good idea.
And untagging a package as an orphan requires using a command-line tool.  Cumbersome if want to untag several (or many) packages.
It would be better if the orphan status could be managed by graphic tools.
Comment 17 andré blais 2011-08-20 06:11:25 CEST
Also, when the list of orphan packages is presented in a window by rpmdrake, to continue the window must be closed.
It would be better if rpmdrake would continue automatically, and let the user close the window later.
That would facilitate the user selectively removing suggested orphans.
If would be useful if the user could select non-orphans from the graphic interface at this point as well.
Thierry Vignaud 2011-08-22 14:37:18 CEST

Status: NEW => ASSIGNED

Comment 18 Rémi Verschelde 2011-09-13 13:43:12 CEST
Why is this bug tagged as a simple enhancement? I think it's severity is major, if not release_blocker for Mga2 too.

There are some cases of users who totally broke their system down with this command (at least for an end-user's point of vue, I agree that a simple urpmi <what was removed> in tty1 could do the trick), and the people who are knowledgeable enough to use this command (and check wether the listed packages can be uninstalled with no risk) do know it.

CC: (none) => rverschelde

Comment 19 Thierry Vignaud 2011-09-17 12:33:30 CEST
Fixed in SVN.
Please don't joke about release_blocker severity...

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED

andré blais 2011-10-09 07:33:15 CEST

CC: andre999 => andre999mga

Comment 20 Marcello Anni 2011-12-23 21:46:40 CET
i'm sorry, what has changed exactely? thanks
Comment 21 Morgan Leijström 2014-02-04 11:17:56 CET
To clean this up, i think first step would be to write up and discuss a clear document of how it really *should* work.
https://bugs.mageia.org/show_bug.cgi?id=12567

CC: (none) => fri

Florian Hubold 2014-02-04 14:22:58 CET

See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=12567

andré blais 2014-02-04 19:31:16 CET

CC: andr55 => (none)

Florian Hubold 2014-11-18 21:22:12 CET

Blocks: (none) => 14594

Comment 22 w unruh 2015-03-07 08:23:29 CET
This is still a bug, 5 years later. I have no idea why any message about orphans is there either in the GDI or the CLI. And orphan is not something bad, and to suggest that they should be removed is a gross disservice to the user. It confuses them to absolutely no purpose, and destroys systems. Please get rid of the suggestion that orphaned files should be removed from the output of urpme

Status: RESOLVED => REOPENED
CC: (none) => unruh
Resolution: FIXED => (none)

Comment 23 Manuel Hiebel 2015-03-07 09:18:11 CET
we have a new one: bug 14594

Status: REOPENED => RESOLVED
See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=14594
Resolution: (none) => OLD


Note You need to log in before you can comment on or make changes to this bug.