Bug 900 - [Review Request] migration from colorScheme to kde ColorScheme
Summary: [Review Request] migration from colorScheme to kde ColorScheme
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Mageia Bug Squad
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-20 00:10 CEST by Luc Menut
Modified: 2011-05-07 13:02 CEST (History)
2 users (show)

See Also:
Source RPM:
CVE:
Status comment:

Attachments
patch for mageia-kde4-config (1.40 KB, patch)
2011-04-20 00:13 CEST, Luc Menut 		Details | Diff
patch for xsettings-kde (735 bytes, patch)
2011-04-20 00:15 CEST, Luc Menut 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Description Luc Menut 2011-04-20 00:10:11 CEST 
Description of problem:
Since kde 4.5 IIRC, kde saves the choosen color scheme in kdeglobals [General]ColorScheme.
Previously Mandriva saved the color scheme in kdeglobals [KDE]colorScheme, and uses it in xsettings-kde (to sync IaOra colors on gtk apps).
patch2 kdebase-workspace-4.1.1-save_color_scheme_name.patch disable in Mageia

I think we should adapt xsettings-kde and our configuration files to use the upstream [General]ColorScheme.

The following patches adapt mageia-kde4-config and xsettings-kde to upstream ColorScheme.
I can push these patches if you are agree with the change.

Version-Release number of selected component (if applicable):
xsettings-kde-0.12.1-1.0.1.mga1
mageia-kde4-config-1-0.26.mga1
Luc Menut 2011-04-20 00:11:57 CEST

CC: (none) => balcaen.john

Comment 1 Luc Menut 2011-04-20 00:13:54 CEST 
Created attachment 251 [details]
patch for mageia-kde4-config
Luc Menut 2011-04-20 00:14:21 CEST

CC: (none) => dmorganec

Comment 2 Luc Menut 2011-04-20 00:15:05 CEST 
Created attachment 252 [details]
patch for xsettings-kde
Comment 3 Luc Menut 2011-05-03 21:53:59 CEST 
I just found that currently with iaora as widget style, colors are not synchronized between kde/qt and gtk apps.
eg if you change in systemsettings the color from the default Ia Ora Night to Ia Ora Smooth, gtk apps still uses Ia Ora Night as color.
We should either used the 2 patches I proposed in attachments, or reapply kdebase-workspace-4.1.1-save_color_scheme_name.patch .
Comment 4 D Morgan 2011-05-06 15:35:57 CEST 
i need you advice luc, but seems saner to use your 2 patches instead of reapplying kdebase-workspace-4.1.1-save_color_scheme_name.patch .
Comment 5 Luc Menut 2011-05-06 22:11:44 CEST 
(In reply to comment #4)
> i need you advice luc, but seems saner to use your 2 patches instead of
> reapplying kdebase-workspace-4.1.1-save_color_scheme_name.patch .

Yes, I think it's better to use [General]ColorScheme now. This allows to remove a custom patch.
Comment 6 John Balcaen 2011-05-06 23:39:05 CEST 
(In reply to comment #5)
> (In reply to comment #4)
> > i need you advice luc, but seems saner to use your 2 patches instead of
> > reapplying kdebase-workspace-4.1.1-save_color_scheme_name.patch .
> 
> Yes, I think it's better to use [General]ColorScheme now. This allows to remove
> a custom patch.
Could you commit then? :)
Comment 7 Luc Menut 2011-05-06 23:59:29 CEST 
(In reply to comment #6)
> Could you commit then? :)

Done
http://svnweb.mageia.org/soft?view=revision&revision=1153 mageia-kde4-config
http://svnweb.mageia.org/soft?view=revision&revision=1154 xsettings-kde

but I don't exactly know what should be done to release a new tar.gz.
could you do this, please?

PS: I'm working on some fixes & improvements on kde4-firstsetup.sh.
Comment 8 John Balcaen 2011-05-07 13:02:03 CEST 
xsettings & mageia-kde4-config have been pushed.
Please open a new bug report for kde4-firstsetup.sh when you can show us your fixes & improvements :)

Thks again.

Status: NEW => RESOLVED
Resolution: (none) => FIXED
Note You need to log in before you can comment on or make changes to this bug.