Bug 8819 - Add default sources at the end of the installation
Summary: Add default sources at the end of the installation
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Installer (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: release_blocker enhancement
Target Milestone: ---
Assignee: Thierry Vignaud
QA Contact:
URL:
Whiteboard:
Keywords: NEEDINFO, PATCH
: 12941 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-01-25 20:36 CET by Adrien D
Modified: 2015-05-26 14:54 CEST (History)
8 users (show)

See Also:
Source RPM:
CVE:
Status comment:


Attachments
ask to set up network if !already done (untested) (766 bytes, patch)
2015-05-13 15:18 CEST, Thierry Vignaud
Details | Diff
new "You have not configured network" screen (181.42 KB, image/png)
2015-05-13 18:59 CEST, Marja Van Waes
Details
ask to set up network if !already done (untested) (v2) (788 bytes, patch)
2015-05-13 20:54 CEST, Thierry Vignaud
Details | Diff
live patch (1.84 KB, text/plain)
2015-05-15 10:19 CEST, Thierry Vignaud
Details
add online media at installation end (mga#8819) (2.09 KB, patch)
2015-05-17 11:07 CEST, Thierry Vignaud
Details | Diff
add online media at installation end (mga#8819) (2.24 KB, patch)
2015-05-19 16:17 CEST, Thierry Vignaud
Details | Diff
report.bug.xz from boot-nonfree.iso install, using patched stage2 (160.26 KB, application/x-xz)
2015-05-19 20:39 CEST, Marja Van Waes
Details
report.bug.xz from boot-nonfree.iso install, with patched stage2 (160.55 KB, application/x-xz)
2015-05-19 22:06 CEST, Marja Van Waes
Details
report.bug.xz from 2015-05-21 (161.55 KB, application/x-xz)
2015-05-21 14:40 CEST, claire robinson
Details
do not die if network fail to start (comment #60 to #62) (1.09 KB, patch)
2015-05-25 11:57 CEST, Thierry Vignaud
Details | Diff

Description Adrien D 2013-01-25 20:36:37 CET
Hi Team Mageia,

I don't knwo wrere I can put this proposal...

Is it possible, at the end of the Mageia's Installation to set up a default urpmi.cfg with HTTP, FTP ou RSYNC medias ?

In other words, remove the DVD media in URPMI and  offer the user to add software repositories?

Thanks !
Adrien D 2013-01-25 20:37:48 CET

CC: (none) => adrien.daugabel+mga

Comment 1 Manuel Hiebel 2013-01-25 23:34:35 CET
if you add updates it will add them all, and for the rest dup of bug 102 I think

Severity: normal => enhancement

David Walser 2013-01-29 22:50:09 CET

CC: (none) => ennael1, luigiwalser

Comment 2 David Walser 2014-03-05 16:37:40 CET
*** Bug 12941 has been marked as a duplicate of this bug. ***
Comment 3 David Walser 2014-03-05 16:38:38 CET
It should automatically add mirrorlist sources in urpmi.cfg.

Assignee: bugsquad => thierry.vignaud

Comment 4 Manuel Hiebel 2014-03-06 00:18:33 CET
btw, this is already done on live via finish-install and http://gitweb.mageia.org/software/drakx/tree/perl-install/standalone/finish-install#n120
Comment 5 David Walser 2014-03-06 00:36:35 CET
Nice, so we just need the classical installer to do the same.
Comment 6 David Walser 2015-05-11 22:07:39 CEST
Thierry, any chance of getting this fixed?  Adding mirrorlist sources in a classical installer installation should be trivial.
Comment 7 Thierry Vignaud 2015-05-13 13:45:13 CEST
Classical installer already does that unless:
- either it's a network install
- or network was NOT configured at summary step
Comment 8 David Walser 2015-05-13 14:21:48 CEST
(In reply to Thierry Vignaud from comment #7)
> Classical installer already does that unless:

Since when?

> - either it's a network install

I suppose that makes sense.

> - or network was NOT configured at summary step

That doesn't.  Just because they didn't configure it in the summary step doesn't mean they won't do it later.  It's not like you need a network connection to add the mirrorlist entries since they always look the same.  Granted it'll need a network connection to download the repository metadata, but it can do that after they've booted and configured the network (mgaonline does it automatically).
Comment 9 Thierry Vignaud 2015-05-13 14:37:14 CEST
(In reply to David Walser from comment #8)
> Since when?

Since forever

> > - or network was NOT configured at summary step
> 
> That doesn't.  Just because they didn't configure it in the summary step
> doesn't mean they won't do it later.  It's not like you need a network
> connection to add the mirrorlist entries since they always look the same. 
> Granted it'll need a network connection to download the repository metadata,
> but it can do that after they've booted and configured the network
> (mgaonline does it automatically).

We will never hardcode a list of media to manually write in a dummy urpmi.cfg.
Either network was configured and we run (g)urpmi.addmedia or it wasn't and we skip updates.
Comment 10 David Walser 2015-05-13 14:42:45 CEST
So I guess we'll continue to be the only major distro that doesn't do this and continue to have new users not understanding why they can't find most packages or any updates because they don't have online repositories configured.  Sigh.
Comment 11 Samuel Verschelde 2015-05-13 14:50:14 CEST
Or we could add them at first boot. IIRC Live installation does/did that.
Comment 12 David Walser 2015-05-13 14:52:37 CEST
The Lives have a thing that runs at first boot that has the ability to do that.  Classical installations don't have something like that.

It really makes no sense for us to not do this automatically like Debian, Ubuntu, Fedora, OpenSuSE, etc do.
Thierry Vignaud 2015-05-13 15:18:18 CEST

CC: (none) => marja11

Comment 13 Thierry Vignaud 2015-05-13 15:18:42 CEST
Created attachment 6534 [details]
ask to set up network if !already done (untested)

We could just ask to set up network if it hasn't been already done.

Please test
Thierry Vignaud 2015-05-13 15:18:48 CEST

Keywords: (none) => PATCH

Comment 14 David Walser 2015-05-13 15:34:19 CEST
I've asked on the qa-discuss list to see if anyone can help test.

Still, some people might be using wifi and therefore can't configure the network in the installer and have to wait until they've booted the system.
Comment 15 Samuel Verschelde 2015-05-13 15:41:19 CEST
Something that occurred to me after seeing the discussion in #qa-discuss is that sources are installed only if people choose to install updates right after the installation finishes.

I think we should add them before even asking the question, if network is available. This way, after reboot they'll quickly see the red exclamation mark from mgaonline if any update is available.

Or, if we don't want to force any download (data quotas or limited bandwidth where the user is) we pop up a confirmation "we're going to blah blah", then ask about installation of the updates.
Comment 16 Samuel Verschelde 2015-05-13 15:42:51 CEST
(In reply to Samuel VERSCHELDE from comment #15)
> Or, if we don't want to force any download (data quotas or limited bandwidth
> where the user is) we pop up a confirmation "we're going to blah blah", then
> ask about installation of the updates.

I mean:
* ask for confirmation before adding media
* add media
* ask for confirmation before installing updates
* install updates
Comment 17 David Walser 2015-05-13 17:21:10 CEST
Comment on attachment 6534 [details]
ask to set up network if !already done (untested)

Just a small suggestion for the text string in there.  How about:

"A network connection is needed to enable update media.  Do you want to configure the network now?"
Comment 18 Marja Van Waes 2015-05-13 18:59:19 CEST
Created attachment 6535 [details]
new "You have not configured network" screen

(In reply to David Walser from comment #17)
> Comment on attachment 6534 [details]
> ask to set up network if !already done (untested)
> 
> Just a small suggestion for the text string in there.  How about:
> 
> "A network connection is needed to enable update media.  Do you want to
> configure the network now?"

I prefer David's text over the current one.

The patch works, I tried with a boot.iso install from a USB-disk. 

I get all the normal screens for configuring a network, including the question in the last one whether I want to start the connection now (which defaults to "No")

I did not see any updates being installed (my local mirror on the USB-disk had just been updated), but after install I see that my /etc/urpmi/urpmi.cfg has been expanded with 

Core\ Release2  {
  key-ids: 80420f66
  mirrorlist: $MIRRORLIST
  with-dir: media/core/release
}
and all the other $MIRRORLIST entries

So, it works if users want to set up their network and start it at that point
Comment 19 Marja Van Waes 2015-05-13 19:24:24 CEST
s/from a USB-disk/with a mirror on a USB disk/

I'll try again after setting up the network in the summary step, to see whether the new screen does indeed not pop up then
Comment 20 Thomas Andrews 2015-05-13 19:52:44 CEST
Just a couple of personal notes that apply only to me:

I got out of the habit of starting my connection from the installer back in the days of Mandriva, when there was some kind of bug that prevented it from working correctly. (Probably conquered LONG ago) Later, that was reinforced when I set up a computer that could only connect via wifi, and I discovered it wouldn't work until after a reboot, anyway.

Also, I've never, in all my years of using Mandrake/Mandriva/Mageia, used the "get updates" option from the installer. I received some advice on Usenet way back in the beginning that it didn't always work well. This was mostly because it used $MIRRORLIST, or whatever the Mandrake/Mandriva equivalent was called, which can give you mirrors that aren't up-to-date, and that using specific nearby mirrors was almost always best. 

With Mandriva, I used the Easyurpmi website to select mirrors and generate a script to add them. There was no such site for Mageia (that I know of), and the option to add a specific mirror isn't obvious, so I used $MIRRORLIST for Mageia 1, 2, and with 3 in the beginning. It became obvious that the sync problem with some mirrors remains, and I saw a post once again on Usenet about how to add a specific mirror, so I started doing that again. 

To this day I have little use for $$MIRRORLIST, and the first thing I do on an install that adds it is replace it with a specific mirror. So, in my specific case, the only thing your proposal would do for me is add an extra step to the installation - removing the $MIRRORLIST entries. 

Now, if you could solve the problem of keeping all mirrors reasonably up to date, my attitude would be different.
Comment 21 Marja Van Waes 2015-05-13 20:09:38 CEST
(In reply to Marja van Waes from comment #19)
> s/from a USB-disk/with a mirror on a USB disk/
> 
> I'll try again after setting up the network in the summary step, to see
> whether the new screen does indeed not pop up then

It pops up, regardless of whether the network was already enabled/set up or not.

I tried with the LAN-cable removed, too, to make sure that a connection couldn't be set up silently.

Btw, the last time I tried, "start the connection now" defaulted to "Yes"

(In reply to Thomas Andrews from comment #20)

> 
> To this day I have little use for $$MIRRORLIST, and the first thing I do on
> an install that adds it is replace it with a specific mirror. So, in my
> specific case, the only thing your proposal would do for me is add an extra
> step to the installation - removing the $MIRRORLIST entries. 
> 
> Now, if you could solve the problem of keeping all mirrors reasonably up to
> date, my attitude would be different.

It is impossible to kep all mirrors up to date, we're not in control.

With the current patch, you won't need to remove the $MIRRORLIST entries afterwards if you keep the default "No" for the suggestion to configure your network now.

I think for many users, especially for newbies, $MIRRORLIST is much better than having _no_ update media configured (which too many of them will end up with)
Comment 22 Thierry Vignaud 2015-05-13 20:54:25 CEST
Created attachment 6536 [details]
ask to set up network if !already done (untested) (v2)

Actually the test logic was inverted :-(
Text updated according to David feedback

Attachment 6534 is obsolete: 0 => 1

Comment 23 Thomas Andrews 2015-05-13 21:04:13 CEST
> It is impossible to kep all mirrors up to date, we're not in control.
> 
> With the current patch, you won't need to remove the $MIRRORLIST entries
> afterwards if you keep the default "No" for the suggestion to configure your
> network now.
> 
> I think for many users, especially for newbies, $MIRRORLIST is much better
> than having _no_ update media configured (which too many of them will end up
> with)

OK, if the patch works as you describe it won't affect me. It also won't affect those who are installing in a situation with a limited Internet connection or none at all. And I suppose I would have to agree with your last sentence if I make the effort to step out of my closet and look at the bigger situation. 

Balancing the needs of new users against the desires of established users is always something of a tightrope walk, made even more difficult because of our diversity. It's a wonder that we stay as balanced as we do.
Comment 24 Marja Van Waes 2015-05-13 21:39:09 CEST
(In reply to Thierry Vignaud from comment #22)
> Created attachment 6536 [details]
> ask to set up network if !already done (untested) (v2)
> 
> Actually the test logic was inverted :-(
> Text updated according to David feedback

Tried with the second patch

+ /usr/bin/patch -U -s -p1 -b --suffix .0001 --fuzz=0 -i /home/marja/home2/marja/svn/drakx-installer-stage2/SOURCES/0001-ask-to-setup-network-if-not-yet-done-2nd.patch

I had removed the network cable before install, so I'd be forced to set up a Wireless connection.

However, that did not happen: the new screen did not appear


* starting step `installUpdates'
matchbox-wm: X error warning (0xa081d2): 140 (opcode: 138)
* to put in /mnt/etc/modprobe.preload nvram, evdev, hdaps
* starting network (ppp: ethernet)
* running: /sbin/modprobe ppp
modprobe: FATAL: Module ppp not found.
* running: /sbin/modprobe -n ppp
modprobe: FATAL: Module ppp not found.
* running: /sbin/modprobe bsd_comp
* running: /sbin/modprobe ppp_deflate
* running: /etc/rc.d/init.d/syslog start with root /mnt
* program not found: /etc/rc.d/init.d/syslog
* running: /usr/sbin/ifup enp12s0 with root /mnt

Determining IP information for enp12s0... failed; no link present.  Check cable?
* no network connexion!
* step "installUpdates" took: 0:00:39

Sorry :-(
Comment 25 Thierry Vignaud 2015-05-14 00:43:01 CEST
Your network is already configured.
It cannot be up b/c you removed the link, that's nothing related to the issue at hand...
Comment 26 Marja Van Waes 2015-05-14 09:48:26 CEST
(In reply to Thierry Vignaud from comment #25)
> Your network is already configured.
> It cannot be up b/c you removed the link, that's nothing related to the
> issue at hand...

So regardless of whether there was a LAN cable plugged in during install, or not, it gets configured.

That means the patch can only be tested on a machine _without_ LAN adapter :-/

I don't have any such machine. The only person I know who had one, is wobo.

The 64 bit mdkinst.sqfs with the 2nd patch is here, for people without LAN adapter to test:
http://waesvanm.home.xs4all.nl/Packaging/bug8819/64bit/

@ wobo,

only CC'ing you in case you're less MIA than I think ;-)

CC: (none) => molch.b

Comment 27 Marja Van Waes 2015-05-14 10:15:04 CEST
Martin's reply on qa-discuss ml is interesting:

Op 14-05-15 om 10:06 schreef Martin Whitaker:
> Most WiFi adapters can't be configured during classical install because
> they rely on non-free firmware (even though the firmware is available
> and installed). Thomas has stated this is intentional (bug 8469), so not
> much chance of getting it fixed.
Comment 28 Marja Van Waes 2015-05-14 10:24:42 CEST
I should first have read bug 8469 

It is still possible to test, Thomas reminds:

> only boot-nonfree.iso and live medias have the nonfree firmware available at
> all times

So with boot-nonfree iso and a mirror on a local disk, someone without LAN-adapter could test it.

On the local mirror, 
/distrib/cauldron/x86_64/install/stage2/mdkinst.sqfs
and
/distrib/cauldron/x86_64/install/stage2/VERSION
need to be replaced with the ones from 
http://waesvanm.home.xs4all.nl/Packaging/bug8819/64bit/
before starting the installation

CC: (none) => mageia

Comment 29 Thomas Backlund 2015-05-14 11:25:39 CEST
If this fix gets added to stage2 we need a way to skip the step it or live media creation will be broken

CC: (none) => tmb

Comment 30 David Walser 2015-05-14 18:10:14 CEST
Marking as release blocker for now so some sort of status on this can be decided before we release.  Whether something will be implemented has yet to be determined.  Once it's status for mga5 is resolved, it should be moved to the mga6 release critical tracker.  Thanks.

Priority: Normal => release_blocker

Comment 31 Thierry Vignaud 2015-05-15 10:11:17 CEST
(In reply to Marja van Waes from comment #26)
> > Your network is already configured.
> > It cannot be up b/c you removed the link, that's nothing related to the
> > issue at hand...
> 
> So regardless of whether there was a LAN cable plugged in during install, or
> not, it gets configured.
> 
> That means the patch can only be tested on a machine _without_ LAN adapter
> :-/

The target is DVD install.
I'll provide an OEM patch for testing.
Comment 32 Thierry Vignaud 2015-05-15 10:19:24 CEST
Created attachment 6547 [details]
live patch

Just put this file as "patch.pl" on a USB key you'll plug to your test VM/machine
Then start the installer, but as CD prompt, instead of:
- typing <enter>
  => type "linux patch"
- or selecting the default entry
  => edit the entry ("e" for grub2), then add linux at end of parameters
Comment 33 Thierry Vignaud 2015-05-15 10:32:02 CEST
Forget that:
- for DVD install, we already offer to install updates,
  which implies adding media
- for network install, we don't as all media should alread be set up

So we should think about it and define exactly what's the target:
- DVD: say we're going to add media, then ask to install updates?

Keywords: (none) => NEEDINFO

Thierry Vignaud 2015-05-15 10:32:50 CEST

Attachment 6547 is obsolete: 0 => 1

Comment 34 Marja Van Waes 2015-05-15 10:43:56 CEST
(In reply to Thierry Vignaud from comment #33)
> Forget that:
> - for DVD install, we already offer to install updates,
>   which implies adding media
> - for network install, we don't as all media should alread be set up
> 
> So we should think about it and define exactly what's the target:
> - DVD: say we're going to add media, then ask to install updates?

What about (since advanced users don't like $MIRRORLIST):

  Update media need to be added. Do you agree with adding them now.
  - yes
  - no, I'm an advanced user and know what I'm doing.

And, if yes was chosen, ask to install updates?
Comment 35 Samuel Verschelde 2015-05-15 12:04:48 CEST
(In reply to Marja van Waes from comment #34)
> What about (since advanced users don't like $MIRRORLIST):
> 
>   Update media need to be added. Do you agree with adding them now.
>   - yes
>   - no, I'm an advanced user and know what I'm doing.
> 
> And, if yes was chosen, ask to install updates?

"Update media need to be added for your computer to stay secure and to allow you to install software from Mageia's large library. Do you want to add them now? Note: you can also add them after installation, from Mageia's Control Center."

- Yes
- No

(users who don't want can just click no, as I proposed in comment #16. No need to imply that advanced users prefer "no". $MIRRORLIST is fine. If it gives you an outdated mirror, then we must remove that mirror from the list. If it gives you a slow mirror, well, it's functional, you can still choose another one by yourself.)
Comment 36 Thierry Vignaud 2015-05-17 11:07:20 CEST
Created attachment 6566 [details]
add online media at installation end (mga#8819)

Attachment 6536 is obsolete: 0 => 1

Comment 37 David Walser 2015-05-19 15:02:22 CEST
N("You now have the opportunity to setup online media.") . "\n\n" .
N("This enables to install security updates.") . "\n\n" .
N("To setup those media, you will need to have a working Internet connection.

I think repositories is probably the more appropriate word to use here.  I would just make minor alterations to the text, it's pretty good.

N("You now have the opportunity to setup online repositories.") . "\n\n" .
N("This enables you to install updated packages.") . "\n\n" .
N("You will need to have a working Internet connection to proceed.
Comment 38 David Walser 2015-05-19 15:04:17 CEST
(In reply to David Walser from comment #37)
> N("This enables you to install updated packages.") . "\n\n" .

Shlomi suggested "allows" instead of "enables," which might work better too.
Comment 39 Thierry Vignaud 2015-05-19 15:31:38 CEST
(In reply to David Walser from comment #37)
> I think repositories is probably the more appropriate word to use here.  I
> would just make minor alterations to the text, it's pretty good.

Historically we've always spoken of "media", not "repositories".
The "medium" & "media" words are used everywhere in the installer, so it's not the moment to use "repo" in one place.

If you want to fight with translators, we can s/media/repositories/ & s/medium/repository/ in perl-URPM/urpmi/rpmdrake/drakx for mga6 :-)
 
OK for s/enables/allows/

But does the patch works like you want?
Comment 40 David Walser 2015-05-19 15:42:21 CEST
(In reply to Thierry Vignaud from comment #39)
> Historically we've always spoken of "media", not "repositories".
> The "medium" & "media" words are used everywhere in the installer, so it's
> not the moment to use "repo" in one place.

OK, that's fine :o)

> But does the patch works like you want?

I'd prefer to not require a network connection during the installer for enabling this, as that may not be possible.  Hopefully this is a step in the right direction.

Marja, are you able to test this newest patch?
Comment 41 Thierry Vignaud 2015-05-19 16:17:03 CEST
Created attachment 6579 [details]
add online media at installation end (mga#8819)

updated patch (typo fix)

Attachment 6566 is obsolete: 0 => 1

Comment 42 Marja Van Waes 2015-05-19 16:49:50 CEST
(In reply to David Walser from comment #40)

> 
> Marja, are you able to test this newest patch?

I thought it could only be tested by someone without LAN adapter?

(In reply to Thierry Vignaud from comment #41)
> Created attachment 6579 [details]
> add online media at installation end (mga#8819)
> 
> updated patch (typo fix)

Thx, it drove me crazy that I didn't understand what caused the build error.

Now I don't understand why "install::pkgs::clean_rpmdb_shared_regions();" fixed it :-þ 
But at least now I don't care ;-)
Comment 43 David Walser 2015-05-19 16:58:02 CEST
(In reply to Marja van Waes from comment #42)
> (In reply to David Walser from comment #40)
> 
> > 
> > Marja, are you able to test this newest patch?
> 
> I thought it could only be tested by someone without LAN adapter?

If you don't have a LAN adapter you can't add online sources so this won't do anything.  IINM it can only be tested if you do have one.
Comment 44 Marja Van Waes 2015-05-19 17:05:45 CEST
(In reply to David Walser from comment #43)
> (In reply to Marja van Waes from comment #42)
> > (In reply to David Walser from comment #40)
> > 
> > > 
> > > Marja, are you able to test this newest patch?
> > 
> > I thought it could only be tested by someone without LAN adapter?
> 
> If you don't have a LAN adapter you can't add online sources so this won't
> do anything.  IINM it can only be tested if you do have one.

nm, I see

   #- bring all interface up for installing updates packages.

so maybe my earlier test (with removed LAN cable) will work now to force being able to configure my WLAN adapter here
Comment 45 Thierry Vignaud 2015-05-19 20:39:12 CEST
This was already there.
The question has just been split into 2:
- ask for adding media
- ask for installing updates
Comment 46 Marja Van Waes 2015-05-19 20:39:20 CEST
Created attachment 6586 [details]
report.bug.xz from boot-nonfree.iso install, using patched stage2

Test 1 (using patch failed)

Adding the patch to a classical iso install, I had hoped this option
https://wiki.mageia.org/en/Drakx-installer_tips_and_tricks#Using_a_patch_.26_regular_ISO
wouldn't need the install to be done from DVD, but work with classical install from USB, too

This didn't work.

The only patch-related thing I see in stage1.log is:

* welcome to the Mageia install (mdk-stage1, version 5 built May  8 2015 22:57:36)
* opening /proc/cmdline... 
*       BOOT_IMAGE=/isolinux/x86_64/vmlinuz quiet noiswmd linux patch

and in ddebug.log

* getFile install/patch-oem.pl on disk://sdc1/x86_64/
* change_phys_medium disk://sdc1/x86_64/ for file install/patch-oem.pl
* Cannot open /tmp/media/x86_64//install/patch-oem.pl: No such file or directory

However, I had named the patch patch.pl and it was in sdb1/  :-(

________________________________________________________________________________

Test 2

After patching stage2 and using it with boot-nonfree.iso, for a _non_-network install, I did get the screen that invites me to setup the update media, as before. However, when ticking "Yes" the next thing I got was 
  An error occurred
  failed to add media

installer did not try to bring up the wlan adapter.
Attaching report.bug.xz, in case installer should have done that in spite of this not being a classical iso install.
Comment 47 Thierry Vignaud 2015-05-19 20:41:14 CEST
This is not a live patch to use as patch*.pl but a patch to apply to mdkinst.sqfs
Comment 48 Marja Van Waes 2015-05-19 20:51:38 CEST
(In reply to Thierry Vignaud from comment #45)
> This was already there.

So this can still only be tested by someone with no other network adapter than a wireless one?
Comment 49 David Walser 2015-05-19 20:54:34 CEST
(In reply to Marja van Waes from comment #48)
> (In reply to Thierry Vignaud from comment #45)
> > This was already there.
> 
> So this can still only be tested by someone with no other network adapter
> than a wireless one?

I don't see how wired vs. wireless itself matters, it's just that, my understanding was that the wireless support in the installer didn't include WPA or firmwares, so it's practically useless in reality in most cases.
Comment 50 Marja Van Waes 2015-05-19 21:09:18 CEST
(In reply to David Walser from comment #49)
> (In reply to Marja van Waes from comment #48)
> > (In reply to Thierry Vignaud from comment #45)
> > > This was already there.
> > 
> > So this can still only be tested by someone with no other network adapter
> > than a wireless one?
> 
> I don't see how wired vs. wireless itself matters, it's just that, my
> understanding was that the wireless support in the installer didn't include
> WPA or firmwares, so it's practically useless in reality in most cases.

Well, maybe I have a wrong idea about what I should be testing. I thought the option to install updates already always worked, when a LAN connection was present (so without setting it up in the summary step).
Comment 51 David Walser 2015-05-19 21:13:51 CEST
Thierry said online sources were already there if you were installing from network sources (like boot.iso bootstrapped installation via HTTP), so there was no further action needed for the installer to take there.  So this just means test a case where you're installing from an ISO or a local HDD installation via boot.iso.
Comment 52 Marja Van Waes 2015-05-19 22:06:59 CEST
Created attachment 6587 [details]
report.bug.xz from boot-nonfree.iso install, with patched stage2

(In reply to David Walser from comment #51)
> So this just
> means test a case where you're installing from an ISO or a local HDD
> installation via boot.iso.

OK, redid the test with boot-nonfree.iso, but now plugged in the cable when I got the screen with the invitation to setup online media.
Chose yes.
There was a message that the network was being brought up and messages about media being added.
Then the other screen, giving the opportunity to download updates appeared (this one still contains a message about a working internet connection being needed, too). Chose yes again. New drakxtools &friends weren't on my mirror, yet, so they were downloaded and installed.

Attachment 6535 is obsolete: 0 => 1
Attachment 6586 is obsolete: 0 => 1

Comment 53 Marja Van Waes 2015-05-19 22:27:23 CEST
forgot to add that the $MIRRORLIST entries had indeed been added to 
/etc/urpmi/urpmi.cfg
Comment 54 Anne Nicolas 2015-05-20 21:21:26 CEST
Tested here using an iso and stage2 including that patch, in vbox. Network device was unplugged. I got the message proposing to add media and first activate network interface. THen media were added and updates done.

So all ok for me
Comment 55 Mageia Robot 2015-05-20 23:00:04 CEST
commit f33a077282e0277512c6e409c2c3fc5443f0a2f7
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Sun May 17 10:58:47 2015 +0200

    add online media at installation end (mga#8819)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=f33a077282e0277512c6e409c2c3fc5443f0a2f7
Comment 56 Thierry Vignaud 2015-05-21 06:04:42 CEST
Closing

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 57 David Walser 2015-05-21 06:16:04 CEST
Not quite fixed, but improved.  It still requires a network connection during the installer, which isn't always possible, and really shouldn't be needed.  This can be moved to the Mageia 6 critical tracker.

Priority: release_blocker => High
Status: RESOLVED => REOPENED
Resolution: FIXED => (none)

Comment 58 Samuel Verschelde 2015-05-21 08:58:25 CEST
I'd rather open a new enhancement report for that David. The initial bug report is fixed.
Comment 59 Thierry Vignaud 2015-05-21 09:15:57 CEST
Indeed.
And way too long already.

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED

Comment 60 claire robinson 2015-05-21 14:39:04 CEST
I'll reopen but can start a new bug if preferred.

With a wired network connection and usb wifi adapter plugged in too it tried to bring up the network but shows "An error occurred. Failed to add media.".

I've a report.bug to attach.

After this message was OK'd it says some steps were not completed are you sure you want to quit now. If you say yes, it reboots.

Status: RESOLVED => REOPENED
Resolution: FIXED => (none)

Comment 61 claire robinson 2015-05-21 14:40:40 CEST
Created attachment 6601 [details]
report.bug.xz from 2015-05-21
claire robinson 2015-05-21 14:40:47 CEST

CC: (none) => eeeemail

Comment 62 Samuel Verschelde 2015-05-21 14:43:42 CEST
I'd say blocker for the "are you sure you want to quit now" + reboot which can make users think installation failed. 

Although the network error is important too.

Priority: High => release_blocker

Comment 63 Marja Van Waes 2015-05-21 14:53:07 CEST
(In reply to claire robinson from comment #61)
> Created attachment 6601 [details]
> report.bug.xz from 2015-05-21

* starting step `installUpdates'
* to put in /mnt/etc/modprobe.preload ivtv, evdev
* starting network (ppp: wifi)
* running: /sbin/modprobe ppp
modprobe: FATAL: Module ppp not found.
* running: /sbin/modprobe -n ppp
modprobe: FATAL: Module ppp not found.
* running: /sbin/modprobe bsd_comp
* running: /sbin/modprobe ppp_deflate
* running: /etc/rc.d/init.d/syslog start with root /mnt
* program not found: /etc/rc.d/init.d/syslog
* running: /usr/sbin/ifup wlp0s2f1u6 with root /mnt

Determining IP information for wlp0s2f1u6... failed; no link present.  Check cable?
* no network connexion!
* installUpdates: failed to add media
* step "installUpdates" took: 0:00:19
* step "installUpdates" failed with error: failed to add media at /usr/lib/libDrakX/install/steps_interactive.pm line 760.

* error: failed to add media at /usr/lib/libDrakX/install/steps_interactive.pm line 760.
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

(So the LAN connection didn't come up)

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 


The part after that...is it maybe trying to figure out what the USB-wlan adapter is?:

   * running: /sbin/modprobe sd_mod
   etc. and a lot of blkid etc.


I don't remember ever having seen this right after the installUpdates step.
Comment 64 Marja Van Waes 2015-05-21 15:00:21 CEST
forgot to say that there is indeed nothing about starting step `exitInstall' in the log
Comment 65 David Walser 2015-05-21 15:55:51 CEST
(In reply to Samuel VERSCHELDE from comment #58)
> I'd rather open a new enhancement report for that David. The initial bug
> report is fixed.

No it isn't fixed.

All of the major distros except for Mageia automatically add online sources with no network connection or further interaction required when you do an ISO installation.  Fedora, OpenSuSE, Debian, and Ubuntu.  Even with what's been implemented, there will still be unnecessary difficulty for new users (and those that help them).

If it makes someone feel better to clone this bug rather than reopen it, that's fine, but it still needs a bug report for further consideration in the future.
Comment 66 Samuel Verschelde 2015-05-21 16:03:09 CEST
(In reply to David Walser from comment #65)
> If it makes someone feel better to clone this bug rather than reopen it,
> that's fine, but it still needs a bug report for further consideration in
> the future.

Yes, after 65 comments and a fix (be it a partial), we can allow ourselves to open a different bug report for the automated adding of sources even when offline. Which is technically quite different since AFAIK urpmi doesn't support that currently.
Comment 67 Rémi Verschelde 2015-05-21 16:04:43 CEST
(In reply to David Walser from comment #65)
> (In reply to Samuel VERSCHELDE from comment #58)
> > I'd rather open a new enhancement report for that David. The initial bug
> > report is fixed.
> 
> No it isn't fixed.
> 

If we could stop with this habit to fight on the resolution of bug reports upon semantics, it would be nice. The bug summary is "Add default sources at the end of the installation", and that's what has been done, provided that the network can be started.

Your suggestion to configure the update sources regardless of the availability of network is very relevant, but would indeed be better place in another put report, with a more focused summary.

Reading the whole 65 comments of this bug report clearly show that there has been much confusion as to what each different contributors expected this bug report to mean (Thierry's patch, Marja believing that she needed to test with no ethernet adapter, etc.).

So please let's this bug report be about the feature that Thierry just implemented and that might still need some work according to comment 60, and let's open a new bug report for the "network-independent" enhancement proposed for Mageia 6.
Comment 68 David Walser 2015-05-21 16:06:04 CEST
The nature of the issue isn't different at all.  It doesn't matter that the nature of the fix will be.  Also, I'm not convinced that it's not possible.  Nothing needs to be downloaded to write the mirrorlist entries in urpmi.cfg, they always look the same.  The only thing that needs to be downloaded is the metadata that goes in /var/lib/urpmi, and that can be downloaded when the system is up and running, which is how the other distros do it, and mgaonline also does that too.
Comment 69 Samuel Verschelde 2015-05-21 16:08:28 CEST
Ok Luigi you're right, now *please* let's do as Akien said.
Comment 70 David Walser 2015-05-21 16:09:56 CEST
(In reply to Rémi Verschelde from comment #67)
> If we could stop with this habit to fight on the resolution of bug reports
> upon semantics, it would be nice. The bug summary is "Add default sources at
> the end of the installation", and that's what has been done, provided that
> the network can be started.

In other words it hasn't been done, it's only been partially done with a caveat.  That's pretty plain.  There wouldn't this "fighting" if people wouldn't have a habit of prematurely closing bugs that aren't fixed.  That's not my fault, so don't insult me by getting mad at me about it.  Anyway, I'll make a new bug report.
Comment 71 David Walser 2015-05-21 16:11:00 CEST
Just so it's clear to those reading this bug, this one's still open because of what Claire posted in Comment 60.  It will be cloned to a new bug for full resolution of this issue possibly at a later time.
David Walser 2015-05-21 16:16:31 CEST

Blocks: (none) => 16002

David Walser 2015-05-21 16:17:29 CEST

Blocks: 16002 => (none)

Comment 72 David Walser 2015-05-21 16:19:10 CEST
Bug 16002 is now created for fully fixing this issue later.

Thank you to everyone that's helped with this so far!
Comment 73 Thierry Vignaud 2015-05-25 11:57:44 CEST
Created attachment 6638 [details]
do not die if network fail to start (comment #60 to #62)
Comment 74 Mageia Robot 2015-05-25 13:42:47 CEST
commit af6fca4f534629de9371ea6a29843505050b3374
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Mon May 25 13:42:12 2015 +0200

    die is not an option here (mga#8819)
    
    just log the faillure and offer to either retry or abort
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=af6fca4f534629de9371ea6a29843505050b3374
Comment 75 Thierry Vignaud 2015-05-25 17:27:39 CEST
Closing

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED

Comment 76 Samuel Verschelde 2015-05-26 14:54:16 CEST
Thanks Thierry for this fix and the numerous others.

Note You need to log in before you can comment on or make changes to this bug.