Bug 8769 - diskdrake no longer provides the "use" button, after selecting an existing crypto-luks encrypted partition (live mode)
Summary: diskdrake no longer provides the "use" button, after selecting an existing cr...
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: i586 Linux
Priority: release_blocker normal
Target Milestone: ---
Assignee: Thierry Vignaud
QA Contact:
URL:
Whiteboard: 3beta2
Keywords: NEEDINFO
Depends on:
Blocks: 8892
  Show dependency treegraph
 
Reported: 2013-01-22 02:54 CET by Dave Hodgins
Modified: 2013-03-01 06:16 CET (History)
4 users (show)

See Also:
Source RPM: drakxtools-15.19-1.mga3.src.rpm
CVE:
Status comment:


Attachments
diskdrake image (59.18 KB, image/png)
2013-01-22 23:14 CET, Dave Hodgins
Details
Patch to show use button, when existing luks block device selected. (823 bytes, patch)
2013-01-29 00:19 CET, Dave Hodgins
Details | Diff
$all_hds (13.55 KB, text/plain)
2013-02-27 22:46 CET, Manuel Hiebel
Details

Description Dave Hodgins 2013-01-22 02:54:17 CET
Using the gnome live cd, I can't select an existing encrypted partition
for the installation.  If it is selected for /, get a message that a "real"
filesystem has to be selected.
Dave Hodgins 2013-01-22 02:54:39 CET

Whiteboard: (none) => 3beta2

Comment 1 Dave Hodgins 2013-01-22 02:58:17 CET
Creating a new encrypted partition is works.
Dave Hodgins 2013-01-22 03:21:03 CET

Assignee: bugsquad => thierry.vignaud

Comment 2 Dave Hodgins 2013-01-22 23:14:48 CET
Created attachment 3424 [details]
diskdrake image

Although it's a separate problem, I think it's in the same section of code, so I'll append it to this bug report, rather then open a new bug report.

As shown by the attached image, after creating an encrypted partition,
the size of each partition shown in the selection area shrinks to the
point of it being very difficult to read, or select the correct partition.
Comment 3 Jim Darby 2013-01-28 15:23:13 CET
Confirmed in 64-bit version as well.

CC: (none) => uberscubajim

Comment 4 Jim Darby 2013-01-28 15:26:06 CET
(In reply to comment #3)
> Confirmed in 64-bit version as well.

More specifically if you re-install on a system that has LUKS partitions you don't get the option to âuseâ (unlock) the LUKS partition.

But you can add new encrypted partitions...
Dave Hodgins 2013-01-28 23:17:09 CET

Priority: Normal => release_blocker

Comment 5 Dave Hodgins 2013-01-29 00:15:58 CET
Adding pterjan to cc list, as suggested by leuhmanu on irc.

CC: (none) => pterjan

Comment 6 Dave Hodgins 2013-01-29 00:19:00 CET
Created attachment 3452 [details]
Patch to show use button, when existing luks block device selected.

Removing the check to see if the luks device is formatted,
allows the existing luks block device to be selected.

Since the detection of a luks device is based on the partition
or logical volume having already been encrypted, it shouldn't
be needed to check for formatted, or not, until after it's opened.
Comment 7 Dave Hodgins 2013-01-29 02:22:45 CET
Strange.  The patch seemed to work when I was chrooted into a Mageia 3 install,
but after booting from a live dvd, then applying the patch, diskdrake still
isn't working.
Anne Nicolas 2013-01-29 23:01:52 CET

CC: (none) => ennael1
Blocks: (none) => 8892

Comment 8 Pascal Terjan 2013-02-08 15:06:19 CET
chrooting doesn't help to test such code :(
The behaviour is based on reading various files in /proc, /sys and /etc so you need a consistent system (if you chroot /proc and /sys will refer to your main system)
Comment 9 Florian Bauer 2013-02-15 21:31:08 CET
Hallo Pascal, as the patch from Dave doesn't work, is there any workaround possible to enable the "use" button in diskdrake?
I want to test MGA 3 beta 2 on my laptop with existing encrypted partition but I can't set the mount point for this partition without "use" it in diskdrake...

If there is no workaround will this be fixed in beta 3?

Thank you in advance!
Florian

CC: (none) => alfaflo

Comment 10 Manuel Hiebel 2013-02-26 11:41:09 CET
is this still valid ? I could use the already lucks partition from previous test with the last stage2 (from this morning) for the / partition
Comment 11 Florian Bauer 2013-02-26 14:51:32 CET
(In reply to Manuel Hiebel from comment #10)
> is this still valid ? I could use the already lucks partition from previous
> test with the last stage2 (from this morning) for the / partition

I've used the MGA3 Beta 2 live DVD and there the used "diskdrake" in the installer didn't allow to "use" the encrypted partition.

However the general function to access the encrypted disk is available in Beta 3 as if I boot with live DVD I can access the encrypted disk with e.g. dolphin. I can also mount the drive manually with "cryptsetup" in a terminal.
So it seems for me that diskdrake on installer is "broken" - if it is fixed with latest updates, it's fine, but how to test when the available live DVD contains the buggy one? :-)
Comment 12 Manuel Hiebel 2013-02-26 16:55:50 CET
using the netinstall https://wiki.mageia.org/en/Boot.iso_install
Comment 13 Dave Hodgins 2013-02-26 23:45:41 CET
Still valid with the Mageia-3-beta3-LiveCD-KDE4-en-i586-CD created
Sat Feb 23 23:00:00 CET 2013

I'll try with a boot-nonfree.iso to see if it's still valid there.
Comment 14 Dave Hodgins 2013-02-26 23:57:40 CET
Using the Feb 22 19:15 boot-nonfree.iso, it's working properly.

Just have to make sure the updates get included in the next iso builds.
Comment 15 Pascal Terjan 2013-02-27 00:53:18 CET
Live CD and installation cd/boot.iso often behave differently.

Live CD is a full system with init system running while installer does things "manually". It could be that something on the livecd does something about that partition causing diskdrake to not see it in the expected state.

Also, the notFormatted check doesn't mean what you think for LUKS, it refers to the encrypted partition, not the decrypted one inside. It means that a new encrypted partition was created but not initialized.

I still can't do any test but I would be interested if someone could dump the content of $all_hds and post if (after removing content of dmcrypt_key)
Comment 16 Manuel Hiebel 2013-02-27 00:56:47 CET
>I still can't do any test but I would be interested if someone could dump the >content of $all_hds and post if (after removing content of dmcrypt_key)

how do you do that ?

Summary: diskdrake no longer provides the "use" button, after selecting an existing crypto-luks encrypted partition. => diskdrake no longer provides the "use" button, after selecting an existing crypto-luks encrypted partition (live mode)

Comment 17 Thierry Vignaud 2013-02-27 05:52:24 CET
Just add "use Data::Dumper; output('/tmp/all_hds.pm', Dumper $allh_hds)"
in the appropriate place.
Then edit /tmp/all_hds.pm in order to remove your dmcrypt_key then attach it here

Keywords: (none) => NEEDINFO

Comment 18 Manuel Hiebel 2013-02-27 22:46:28 CET
Created attachment 3557 [details]
$all_hds

I don't know if it's good or not
Manuel Hiebel 2013-02-27 22:47:03 CET

Attachment 3557 mime type: application/x-perl => text/plain

Comment 19 Manuel Hiebel 2013-03-01 01:36:14 CET
it "seems" to works with new live iso set (Gnome, x86_64 beta3 from yesterday)
Comment 20 Dave Hodgins 2013-03-01 06:16:01 CET
Confirmed fixed.

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.