Bug 8638 - Draksambashare is not fully localized
Summary: Draksambashare is not fully localized
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: i586 Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Olivier Blin
QA Contact:
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-01-09 02:05 CET by Marek Laane
Modified: 2013-01-19 17:32 CET (History)
1 user (show)

See Also:
Source RPM: drakx-net-1.16-1.mga3
CVE:
Status comment:


Attachments
First option untranslated (29.26 KB, image/png)
2013-01-09 02:09 CET, Marek Laane
Details
Two options groups labels untranslated (43.19 KB, image/png)
2013-01-09 02:12 CET, Marek Laane
Details
Patch to fix the problems (make the strings localizable) (2.14 KB, patch)
2013-01-18 20:55 CET, Yuri Chornoivan
Details | Diff
Screenshot that proves that the first problem is fixed (50.77 KB, image/png)
2013-01-18 20:56 CET, Yuri Chornoivan
Details
Screenshot that proves that the second and third problems are fixed (54.34 KB, image/png)
2013-01-18 20:56 CET, Yuri Chornoivan
Details

Description Marek Laane 2013-01-09 02:05:28 CET
Description of problem:
Looking at draksambashare I discovered that there are some texts not made yet translatable. It is hard to describe them, so I add some pictures with comments where untranslated parts are visible.

(Of course, it would be very nice if "yes" and "no" and security options "user", "shares" and "domain" would also be translatable but I remember from old days that it was said not to be possible ...)

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
Comment 1 Marek Laane 2013-01-09 02:09:32 CET
Created attachment 3344 [details]
First option untranslated

It is rather weird because it is translated and also marked as so in the code (http://svnweb.mageia.org/soft/drakx-net/trunk/bin/draksambashare?revision=3625&view=markup, line 1156) but for whatever reason it is still shown in English
Comment 2 Marek Laane 2013-01-09 02:12:41 CET
Created attachment 3345 [details]
Two options groups labels untranslated

It is the dialog to modify resource. These option groups labels are not marked to be translatable in the code: http://svnweb.mageia.org/soft/drakx-net/trunk/bin/draksambashare?revision=3625&view=markup, lines 717 and 739)
Comment 3 Marek Laane 2013-01-09 02:14:24 CET
And for second attachments: there is also untranslatable "Advanced options" which is also not noted to be translated in the code: http://svnweb.mageia.org/soft/drakx-net/trunk/bin/draksambashare?revision=3625&view=markup. line 778
Manuel Hiebel 2013-01-09 11:47:39 CET

Assignee: bugsquad => mageia

Comment 4 Yuri Chornoivan 2013-01-18 20:55:02 CET
Created attachment 3399 [details]
Patch to fix the problems (make the strings localizable)
Comment 5 Yuri Chornoivan 2013-01-18 20:56:14 CET
Created attachment 3400 [details]
Screenshot that proves that the first problem is fixed
Comment 6 Yuri Chornoivan 2013-01-18 20:56:48 CET
Created attachment 3401 [details]
Screenshot that proves that the second and third problems are fixed
Comment 7 Manuel Hiebel 2013-01-18 21:01:37 CET
thanks

Keywords: (none) => PATCH
CC: (none) => thierry.vignaud
Source RPM: drakx-net-1.16-1.mga3.noarch => drakx-net-1.16-1.mga3

Comment 8 Thierry Vignaud 2013-01-19 17:32:31 CET
Thx
Fixed in SVN.

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.