Description of problem: rpmlint warns : W: setup-not-quiet W: setup-not-in-prep when %setup_compile_flags macro is used. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3.
CC: (none) => rick
Assignee: bugsquad => rick
Created attachment 5802 [details] patch for rpmlint attached patch for rpmlint attached
(In reply to Richard Houser from comment #1) > Created attachment 5802 [details] > patch for rpmlint attached > > patch for rpmlint attached The problem with this patch and the one here: http://paste.debian.net/140124/ (which like I told you previously, should really be attached to this bug report) is that it won't match lines like «%setup» or «%setup\t». Please convert it to use a regex like «^%setup\b». Regards, -- Shlomi Fish
CC: (none) => shlomif
Created attachment 5803 [details] rpmlint-1.5-mga-fix_setup_compile_flags.patch Updated to account for tabs in the line and calls without arguments
Attachment 5802 is obsolete: 0 => 1
A new patch has been submitted, and I obsoleted the one that was already attached to this ticket. I explicitly did not include the start of string anchor, as the lines in question might not start with the setup macro. I attempted to use "\b" at the start, but that results in the string always failing to match, with or without leading space. I don't really see that lack of a boundary at the start a problem though, and the previous code didn't have anything of the sort, either.
(In reply to Richard Houser from comment #4) > A new patch has been submitted, and I obsoleted the one that was already > attached to this ticket. > > I explicitly did not include the start of string anchor, as the lines in > question might not start with the setup macro. I attempted to use "\b" at > the start, but that results in the string always failing to match, with or > without leading space. I don't really see that lack of a boundary at the > start a problem though, and the previous code didn't have anything of the > sort, either. Sorry for the late response, Richard, but I got distracted with other problems here. Some comments about the patch: 1. https://docs.python.org/2/library/re.html#re.search - re.search should be re.match (or maybe use r'^\s*%setup\b' .) 2. I want the patch against the "mgarepo checkout" checkout. 3. Please also submit the patch (against the source tarball) upstream - http://sourceforge.net/projects/rpmlint/ . Regards, -- Shlomi Fish
Created attachment 5817 [details] rpmlint-1.5-mga-fix_setup_compile_flags.patch Stop setup macro warnings on macros that only start with setup. Also, allow those macros to work with leading whitespace.
Attachment 5817 description: Stop setup macro warnings on macros that only start with setup => rpmlint-1.5-mga-fix_setup_compile_flags.patch
Attachment 5803 is obsolete: 0 => 1
Created attachment 5818 [details] existing patch, but against the RPM package itself Patch against the mga subversion for the while package (not for upstream)
(In reply to Richard Houser from comment #7) > Created attachment 5818 [details] > existing patch, but against the RPM package itself > > Patch against the mga subversion for the while package (not for upstream) That patch is not against the "mgarepo checkout". Please add an "svn diff" patch that includes the patch against the source package. I've explained that several times already. Please reach me on IM and I will explain it interactively: http://www.shlomifish.org/me/contact-me/ Regards, -- Shlomi Fish
The existing patch 5818 was accepted unchanged, committed, and sent upstream.
Resolution: (none) => FIXEDStatus: NEW => RESOLVED