Post scriptum
on sourceforge  http://sourceforge.net/projects/opencpn/files/opencpn/3.0.2/
we can only get deb packages or mac dmg packages or windowsinstaller for the last version 3.0.2... don't know why the source is not downloadable here !!!

the stable source file may be downloaded from here (it's not a beta!!!)
http://opencpn.org/ocpn/downloads/beta/OpenCPN-3.0.2-Source.tar.gz

You may use too
git clone -b stable https://github.com/OpenCPN/OpenCPN.git

URL: (none) => http://opencpn.org/ocpn/

Created attachment 3018 [details]
spec file for opencpn

typo corrected :
 BuildRequires : libfreetype6-devel 
instead of simply freetype-devel

Attachment 3013 is obsolete: 0 => 1

Hi Philippe
/OT changes pushed OK in ardour3 thanks.

OK this builds in Cauldron, both arch, however can you please look at the following in the spec:-
1. The .desktop file fails to validate (desktop-file-validate to check)
2. The package name should not be repeated in the Summary (although it may in the description)
3. Define a tarname 'OpenCPN' and use it to replace any strings.

4. These are OK
BuildRequires:	pkgconfig(libgps)
BuildRequires:	pkgconfig(gtk+-2.0)
BuildRequires:	pkgconfig(gl)
BuildRequires:	pkgconfig(glu)
BuildRequires:	pkgconfig(zlib)
BuildRequires:	pkgconfig(freetype2)

There is no issue with tinyxml so you can remove the comments.

Attach a patch and I'll commit it.

CC: (none) => zen25000
Assignee: bugsquad => philippedidier

Oh, I forgot, gpsd-clients
                         ^

Created attachment 3189 [details]
little modifications to the previous spec file

Hi Barry !

Here some modifications to the previous spec file

modified BR (using pkgconfig)
added BR gettext
corrected typo in Requires gpsd-clients

NB
I did run desktop-file-validate and got no warning for Mageia2 ?!

[baz@jackodesktop applications]$ desktop-file-validate opencpn.desktop
opencpn.desktop: hint: value "Education;Science;Geography;" for key "Categories" in group "Desktop Entry" contains more than one main category; application might appear more than once in the application menu

Better to do it this way as version is already defined:
%define tarname OpenCPN
...
Source0: http://%{name}.org/ocpn/downloads/beta/%{tarname}-%{version}.tar.gz
...
%setup -q -n %{tarname}-%{version}-Source

:)

Created attachment 3190 [details]
patch to get more standard desktop file

Created attachment 3191 [details]
little modifications to the previous spec file

Attachment 3189 is obsolete: 0 => 1

I would just a comment for Mageia packagers (I don't know where to write it so that it's read by anybody wanting to update OpenCPN):

ONLY PACKAGE A STABLE VERSION OF OpenCPN
NEVER PROVIDE AN ALPHA OR A BETA OR A RC VERSION .

This software is used to navigate, SAFELY, on the sea, with official charts...

If anybody wants to use a beta, he must know the risks it implies !!! 

Providing a beta version on cauldron is not a good idea : if Mageia3 appears before the next stable version of OpenCPN is published... Mageia3 users will use an unstable version of this software : it may be dangerous !

It's better to wait and provide the next stable version as an update (jumping over the alpha, beta and rc releases)

People wanting to test the beta release must know how to build their own rpm !!! and use it carefully !

Sorry for the typo : I meant

I would just add a comment for Mageia packagers ../..

Created attachment 3192 [details]
little modifications to the previous spec file

Adding an advice that it is not a beta version !

Attachment 3191 is obsolete: 0 => 1

This is Cauldron and one would not expect a serious user to be running Cauldron. Also, once in a stable release then only bug-fix updates are allowed, no new versions. A problem could occur if a bets was in Cauldron when it became stable, so I think on balance it is better to add a warning so no pre-release versions get into the distro.

The best approach IMO would be to simply add your warning as README_packaging.txt as Source1 and then put a note at the top of the spec something like:
## NOTE Please read README_packaging.txt before updating this package.

then remove the 'this is stable...' comment as unnecessary.

If you are using %{tarname} in Source0 then you should also use %{name} see my previous post. ;)

I don't think ChartPlotter is a word, maybe 'Chart Plotter' ?

$ desktop-file-validate opencpn.desktop 
opencpn.desktop: hint: value item "Geography" in key "Categories" in group "Desktop Entry" can be extended with another category among the following categories: Education, or Science
opencpn.desktop: hint: value "Geography;" for key "Categories" in group "Desktop Entry" does not contain a registered main category; application might only show up in a "catch-all" section of the application menu

See:-
http://standards.freedesktop.org/menu-spec/menu-spec-1.0.html#category-registry

I forgot to add - please use desktop-file-install in the spec to make the adjustment to the desktop file rather than a patch:-
https://wiki.mageia.org/en/Packaging_guidelines#desktop-file-install_usage

Created attachment 3193 [details]
advice for packagers

Created attachment 3194 [details]
cumulated modifications to the initial spec file

Hi Barry !

I hope it's not far from being OK now

I will provide an other spec file for this software :
There's a useful plugin including a log book inside OpenCPN, 
this plugin must be built at the same time as OpenCPN.

I don't know if it is better to provide an  OpenCPN rpm  with this plugin bundled... it would be a little tricky to split it into two rpms :
a naked OpenCPN.rpm 
and a OpenCPN-logbook_plugin.rpm

Nevertheless, there's a little problem with this plugin...
A user needs to have an easy access to 2 zip files to adapt its GUI (each user has a his own .opencpn directory where some files are installed, extracted from the zip files)
these zip are provided by the logbook source tar but I don't know where to install them, informing the user where they are

besides this, the source needs a magic script  mk_git_tar

Attachment 3190 is obsolete: 0 => 1
Attachment 3192 is obsolete: 0 => 1

Created attachment 3195 [details]
a spec file including the logbook plugin

Here is the spec file including the logbook

Created attachment 3196 [details]
a script to download the git source and compress it

(In reply to comment #17)
> Created attachment 3196 [details]
> a script to download the git source and compress it

it's for the logbook plugin !

Been busy I see ;)

1. You remove Education then add it back - why?
All you need to do is remove Science:

 desktop-file-install  \
 --dir=%{buildroot}%{_datadir}/applications \
 --remove-category='Science' \
  %{buildroot}%{_datadir}/applications/%{name}.desktop

2. No you can't do this:-
gzip -dc ~/rpm/SOURCES/LogbookKonni_pi.tar.gz | tar -xvf -
Use:-
gzip -dc %{SOURCE1} | tar -xvf -

Which makes me think you are not using bm for build testing?
# urpmi bm
cd opencpn
bm -l

3. You left Option instructions in the script header from my other script which are not in that version - it needs cleaning.

4. Yes %{_datadir}/%{name}/ sounds as good a place as any for those files. They don't contain any pre-built binaries do they?

It builds in Cauldron - not had chance to test yet. Looking good ;)

PS Maybe add both example git download commands to the script header.

Created attachment 3200 [details]
cumulated modifications to the initial spec file (without log book plugin)

Attachment 3194 is obsolete: 0 => 1

Created attachment 3201 [details]
a script to download the git source and compress it

Attachment 3196 is obsolete: 0 => 1

Created attachment 3202 [details]
a spec file including the logbook plugin

Attachment 3195 is obsolete: 0 => 1

Is there any chance that anyone would want this without the plugin? 
If there is then it would make sense to add the plugin as a sub-package so that it can be installed as required.

Mid air collision : I re save the changes

(In reply to comment #19)
> Been busy I see ;)
> 
> 1. You remove Education then add it back - why?
> All you need to do is remove Science:
> 
>  desktop-file-install  \
>  --dir=%{buildroot}%{_datadir}/applications \
>  --remove-category='Science' \
>   %{buildroot}%{_datadir}/applications/%{name}.desktop
> 
I thought the order of the categories was important...
I corrected this in the spec file

> 2. No you can't do this:-
> gzip -dc ~/rpm/SOURCES/LogbookKonni_pi.tar.gz | tar -xvf -
> Use:-
> gzip -dc %{SOURCE1} | tar -xvf -
> 
corrected in the spec file

> Which makes me think you are not using bm for build testing?
> # urpmi bm
> cd opencpn
> bm -l
> 
Indeed I always used to use rpmbuild -ba inside SPECS directory 

> 3. You left Option instructions in the script header from my other script which
> are not in that version - it needs cleaning.
> 
corrected in the mk_git_tar provided

> 4. Yes %{_datadir}/%{name}/ sounds as good a place as any for those files. They
> don't contain any pre-built binaries do they?
> 
They contain only templates or images or html files.

I added some lines in the summary to tell where to find them : didn't find a way to automatically search for them in the right directory when configuring the log book... 
Is there a better way to inform the user ?


> It builds in Cauldron - not had chance to test yet. Looking good ;)
To really test it you need 
- a connected GPS (but your boat  will placed be in the town where you live :-( nevertheless it will able to center the display on this place)
- marine charts (I don't think the marine charts will cover this town ;-) but you can drag to display the zone that they concern)

(In reply to comment #23)
> Is there any chance that anyone would want this without the plugin? 
Perhaps : this plugin is not absolutely necessary

> If there is then it would make sense to add the plugin as a sub-package so that
> it can be installed as required.
I thought about this...
something like opencpn-logbook-plugin.rpm, requiring opencpn to be installed
and proposed as an optional require for opencpn

It would need a very detailed %files part in the spec file

Something like:

%package logbook-plugin

Summary:	A logbook plugin for %{tarname}
Group:		Geography
Requires:	%{name} = %{version}-%{release}

%description logbook-plugin
Konni's logbook plugin for %{tarname}
NB : the LogbookKonni_Layouts.zip LogbookKonni_Other.zip may be downloaded from 
https://github.com/nohal/logbookkonni_pi/blob/master/LogbookKonni_Layouts.zip
https://github.com/nohal/logbookkonni_pi/blob/master/LogbookKonni_Other.zip

%files logbook-plugin
%{_datadir}\.....

Please try to use IRC when you can to save cluttering bugzilla any more than necessary ;) I keep looking but you are never there :\

Created attachment 3206 [details]
a spec file including the logbook plugin splitted two rpms

Hi Barry

Here it is !
I splited it in two rpms
- 1 opencpn.rpm quite the same as the one created with 3200 attachment
- 2 opencpn-logbook-plugin.rpm

It's perhaps not respecting the canonical way to write a spec... but it works : everything is in the right rpm ! nothing missing.

I have weird free hours !!! It may be difficult to meet on IRC (maybe we may use personal e.mail addresses)

Nice!

Just a few points I noticed

1. The url in description is bad - page missing.
2. You don't need "-n %{name}-" for sub package, just "%package logbook-plugin"
"%description logbook-plugin" etc. as %{name} is implied.
3. You can replace your %prep section with:
%prep
%setup -q -a 1 -n %{tarname}-%{version}-Source
mv LogbookKonni_pi -t plugins/

There may be a way to avoid needing the mv, but I don't know it.

4. Readme_packaging.txt should be README_packaging.txt as in line 1.

5. You re-included BuildRequires: pkgconfig(freetype2) is it needed? I built it OK without, and it pulls in lib64freetype6-devel.

Nearly there ;)

(In reply to comment #28)
Hi Barry !

> Nice!
> 
> Just a few points I noticed
> 
> 1. The url in description is bad - page missing.
they changed the address, I corrected it

> 2. You don't need "-n %{name}-" for sub package, just "%package logbook-plugin"
> "%description logbook-plugin" etc. as %{name} is implied.
I thought it was better :
when surfing on the repository tree it's easier to find related rpms if they are sorted with alphabetic order
when using MCC too 
I prefer explicit and clear names than implicit relations (it wouldn't be easy to find gimp plugins for instance if gimp was not included in their rpm name)

> 3. You can replace your %prep section with:
> %prep
> %setup -q -a 1 -n %{tarname}-%{version}-Source
> mv LogbookKonni_pi -t plugins/
> 
> There may be a way to avoid needing the mv, but I don't know it.
> 
This doesn't work... even with mv LogbookKonni_pi.tar.gz
 (=> file not found, in the log)

> 4. Readme_packaging.txt should be README_packaging.txt as in line 1.
> 
Corrected

> 5. You re-included BuildRequires: pkgconfig(freetype2) is it needed? I built it
> OK without, and it pulls in lib64freetype6-devel.
perhaps BR pkgconfig(freetype2) is implied by something else (can't imagine what..)
I know that the presence of libfreetype.so is checked in the beginning of the building process and thought it needed to be explicitely required (I have not a real buildsystem to verify)
If it's useless, I remove it ...

> 
> Nearly there ;)

Quite now :-)

If it's OK I will request a new package : Bristol that existed for Mandriva 2010.1 : I cooperated with Frank Kober to provide it !

Created attachment 3210 [details]
renamed advice for packagers

Attachment 3193 is obsolete: 0 => 1

Created attachment 3211 [details]
corrected spec file, bringing the logbook plugin, splitted in two rpms

Attachment 3206 is obsolete: 0 => 1

> > 2. You don't need "-n %{name}-" for sub package, just "%package logbook-plugin"
> > "%description logbook-plugin" etc. as %{name} is implied.
> I thought it was better :
> when surfing on the repository tree it's easier to find related rpms if they
> are sorted with alphabetic order
> when using MCC too 
> I prefer explicit and clear names than implicit relations (it wouldn't be easy
> to find gimp plugins for instance if gimp was not included in their rpm name)
> 
You misunderstand.
This does not affect the package naming in any way - only the spec.
%package foo == %package -n %{name}-foo  :)

> > 3. You can replace your %prep section with:
> > %prep
> > %setup -q -a 1 -n %{tarname}-%{version}-Source
> > mv LogbookKonni_pi -t plugins/
> > 
> > There may be a way to avoid needing the mv, but I don't know it.
> > 
> This doesn't work... 

Oh yes it does.

You didn't read (or copy/paste what I put).

> 
> If it's OK I will request a new package : Bristol that existed for Mandriva
> 2010.1 : I cooperated with Frank Kober to provide it !

OK, but slow down - let's finish this first.

There are some more issues to fix:

1. You added a new description line. Lines in description have a maximum length limit of 80 chars.
2. Don't put Version or Release or License in sub-packages - I thought we had a bug in rpmbuild when I produced a different sub-package release!
3. Shorten those long cp lines by splitting to make reading easier.

OK you just appeared on IRC
:)

Opencpn is now in Cauldron and will be provided in Mageia3

Status: NEW => RESOLVED
Resolution: (none) => FIXED