Bug 7581 - package request : gigedit
Summary: package request : gigedit
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: New RPM package request (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal enhancement
Target Milestone: ---
Assignee: Barry Jackson
QA Contact:
URL: http://www.linuxsampler.org/
Whiteboard:
Keywords:
Depends on: 7575
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-26 01:23 CEST by Philippe Didier
Modified: 2012-11-16 22:20 CET (History)
1 user (show)

See Also:
Source RPM: gigedit-0.2.0
CVE:
Status comment:


Attachments
spec file for the last svn 2366 of gigedit (2.75 KB, text/x-rpm-spec)
2012-09-30 20:27 CEST, Philippe Didier
Details
modified spec file for the last svn 2366 of gigedit (Requires added) (2.76 KB, text/x-rpm-spec)
2012-10-02 00:24 CEST, Philippe Didier
Details
an icon from oxygen for gigedit (9.16 KB, image/png)
2012-11-15 21:10 CET, Philippe Didier
Details

Description Philippe Didier 2012-09-26 01:23:01 CEST
It was provided by Mandriva 2010.2

It's a Samples Editor from linuxsampler project

I tried to adapt the spec file and to create patches but I'm stuck 

If anybody have more skill he's welcome ...
Philippe Didier 2012-09-26 01:24:22 CEST

Depends on: (none) => 7575, 7576
Source RPM: (none) => gigedit-0.2.0
Whiteboard: (none) => MGA2TOO

Philippe Didier 2012-09-26 01:30:28 CEST

Depends on: 7576 => (none)

Philippe Didier 2012-09-26 01:35:06 CEST

URL: (none) => http://www.linuxsampler.org/

Comment 1 Philippe Didier 2012-09-30 20:27:13 CEST
Created attachment 2887 [details]
spec file for the last svn 2366 of gigedit

NB 
You need to download the last svn revision
Use Make -f Makefile.cvs on the downloaded directory
Compress the modified directory in tar.bz format
Name it gigedit-svn2366.tar.bz2

Gigedit can now be built on Mageia2

Just needs a desktop file ?
Comment 2 Philippe Didier 2012-09-30 20:28:52 CEST
NB
Better to use it with the last svn revision of gig :
we can now work on soundfonts .sf2 or .sfz
Comment 3 Philippe Didier 2012-10-02 00:24:06 CEST
Created attachment 2899 [details]
modified spec file for the last svn 2366 of gigedit (Requires added)

Attachment 2887 is obsolete: 0 => 1

Comment 4 Barry Jackson 2012-11-15 00:34:09 CET
Damn!
I forgot the .desktop file - and I did think about it when I ran it to test :\
I'll fix it tomorrow, it's getting late - in the meantime it's in Cauldron less desktop file.
Philippe, I wonder if there is an icon anywhere for it?

CC: (none) => zen25000
Assignee: bugsquad => zen25000
Whiteboard: MGA2TOO => (none)

Comment 5 Philippe Didier 2012-11-15 05:01:21 CET
Hi Barry

I didn't find any icon for gigedit

Anyway Gigedit may have a desktop file to work as a standalone application, (I used to launch it from a command line)
but it may be launched from inside qsampler to edit a sample file (there's an edit button that launches gigedit from the channel used in Qsampler) this never worked for Mandriva...

And I discovered an omission in the spec file imported from mandriva that prevents to launch gigedit from qsampler (that's an imported mandriva's bug ...we may get rid of it ) :

 the list of files to install in the lib rpm must contain
 " %_libdir/linuxsampler/plugins/*.so" too
that means :


%package -n %{libname}
Group:		System/Libraries
Summary:	Libraries for %{name}
Provides:	%{name} = %{version}-%{release}

%description -n %{libname}
Libraries from %{name}

%files -n %{libname}
%_libdir/gigedit/libgigedit.so.%{major}*
%_libdir/linuxsampler/plugins/*.so


I just corrected this, rebuilt the rpm and now it works :
That's an antenatal bug correction in Mageia !



I noticed too that in your cleaned spec, the devel rpm doesn't contain the *.a files but only the *.so ones... is it your intention ?

Thanks again
Philippe
Comment 6 Barry Jackson 2012-11-15 12:43:27 CET
OK if you find an icon let me know - otherwise I'll make something.

I moved libgigeditlinuxsamplerplugin.so from -devel to lib in svn but I'll wait until I add a .desktop before committing.
http://svnweb.mageia.org/packages/cauldron/gigedit/current/SPECS/gigedit.spec?view=log

Yes I removed *.a, *.la as per Mageia library policy:
https://wiki.mageia.org/en/Libraries_policy#.2A.la_files
https://wiki.mageia.org/en/Packaging_guidelines#Packaging_Static_Libraries_2

Let me know what you think about the rpm groups on all these packages - I used Sound/Utilities on some before I saw you had used Sound/Midi - look here and let me know which is most appropriate for each, as you know them well.
https://wiki.mageia.org/en/RPM_groups_policy

Thanks.
Comment 7 Philippe Didier 2012-11-15 21:08:36 CET
The chosen groups seem OK

(only gigedit may be in Sound/Midi instead of Sound/Utilities it would be easier to find it in the same group as Qsampler)

I only found a mimetype icon from Mageia that will fit for gigedit
You may find it in /usr/share/icons/oxygen/128x128/mimetypes/audio-midi.png :
it exists in every format
I attach it
Comment 8 Philippe Didier 2012-11-15 21:10:29 CET
Created attachment 3098 [details]
an icon from oxygen for gigedit
Comment 9 Philippe Didier 2012-11-15 21:12:51 CET
it would be better to find an icon with a waveform instead of the score above the keyboard... I didn't find any !
Comment 10 Barry Jackson 2012-11-16 01:09:02 CET
OK now has a desktop file - done and submitted.

Closing as fixed - please test;)

Thanks for all your help Philippe. :)

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 11 Philippe Didier 2012-11-16 20:56:09 CET
Thanks to you Barry !!!

I downloadeded your srpm
Built rpms for Mageia2
installed them

Gigedit can be launched from inside Qsampler !!! the mandriva's bug is resolved \o/

otherwise :
Gigedit can be launched from the KDE menu (in "sound and video" sub menu)
 thanks for your desktop file

Everything is OK for Mageia2 :
Every package from the linuxsampler group is fine, and interacts correctly with the others...

No bug to declare !

The svn files corrected lots of problems that prevented to build on Mageia2 with the current tar ...

I can't yet test them on a Cauldron but we may guess that if they could fluently be built they will fluently work...

There were some musicians using Mandriva... they surely will get interested with Mageia
Comment 12 Barry Jackson 2012-11-16 22:20:03 CET
Excellent - you did it! Your persistence paid off :)

So, just lv2 now and that's maybe not so easy since it needs collaboration.
I will c.c. the the maintainer on that bug and see what can be done. I think only one matters as the other is not even mentioned in the revision logs.

Cheers,
Barry

Note You need to log in before you can comment on or make changes to this bug.