sorry for the typo : (I wrote "to" instead of "two"...)

Its spec file, and the 2 patches provided in the srpm allow two different
buildings (allowing to encode into mp3 with the tainted version)

ping

Sorry it took me so long.

>

This was fixed in Magiea 3/Cauldron. Should it also be fixed in Mageia 2?

Regards,

-- Shlomi Fish

I think it would be great to fix it in Mageia2 !

But maybe it needs to be proposed as update in both core and tainted repo ?... with a new release number 5.9.1-2 ...

Thanks !

Pḧilippe

(In reply to comment #4)
> I think it would be great to fix it in Mageia2 !
> 
> But maybe it needs to be proposed as update in both core and tainted repo ?...
> with a new release number 5.9.1-2 ...
> 

Well, it would involve some work and would have to be done in updates_testing first, so I'm reluctant to do it. Is it that critical for you? QA team, what do you say?

Regards,

-- Shlomi Fish

> Thanks !
> 
> Pḧilippe

Shlomi there is no reason from QA not to do this. It's up to you as the maintainer.

It's actually quiet at the moment and a good time to do it, alpha2 testing will start in another week which makes us busy again.

Hi Claire,

(In reply to comment #6)
> Shlomi there is no reason from QA not to do this. It's up to you as the
> maintainer.
> 
> It's actually quiet at the moment and a good time to do it, alpha2 testing will
> start in another week which makes us busy again.

OK, I have submitted audiokonverter-5.9.1-2.mga2 for core/updates_testing and tainted/updates_testing. Please test. Should I reassign the bug?

Regards,

-- Shlomi Fish

To Shlomi :
It's not critical for me :
I rebuilt for myself a tainted version of audiokonverter (and even more a "twisted" version with faac allowing to encode into *.aac that can be provided by Mageia ...)
I know that it works ...

The work may be a junior job : 
- only change the release number from 1 to 2 in the spec file
- submit to update_testing in core and tainted

QA has quite nothing to do : there's absolutely no difference in the rpm : 
in core it's strictly identical
only to verify if the tainted version built adds the ability to encode into *.mp3 file 

Regards

mid air collision !

> OK, I have submitted audiokonverter-5.9.1-2.mga2 for core/updates_testing and
> tainted/updates_testing. Please test. Should I reassign the bug?
> 
> Regards,
> 
> -- Shlomi Fish

Yes you should please, there are more details on how to provide updates here on the wiki..

https://wiki.mageia.org/en/Updates_policy#Maintainer_.28or_any_interested_packager.29

Thanks

Assigning to QA. The SRPM is:

audiokonverter-5.9.1-2.mga3.src.rpm

Regards,

-- Shlomi Fish

Status: NEW => ASSIGNED
Assignee: bugsquad => qa-bugs

Just adding more detail, this is a good one for our beginners.

SRPM's
audiokonverter-5.9.1-2.mga2.src.rpm
audiokonverter-5.9.1-2.mga2.tainted.src.rpm

RPM's
audiokonverter-5.9.1-2.mga2.i586.rpm
audiokonverter-5.9.1-2.mga2.x86_64.rpm
audiokonverter-5.9.1-2.mga2.tainted.i586.rpm
audiokonverter-5.9.1-2.mga2.tainted.x86_64.rpm

tested on Mageia2 i586

both  core and tainted version are OK !

with Konqueror or Dolphin : a right click on a video file allow to extract a sound file as ogg flac or wav (and mp3 with the tainted version)
with an audio file you cant convert it into ogg, flac, wav (or mp3) too !

That's just what we need for now ! (until we have an official way to use faac in Mageia to convert into aac or m4a files) (for a personal use I can send the spec file to allow aac conversion)

Thankyou Philippe :)

Can I tempt you to join the QA team?

Whiteboard: (none) => mga2-32-OK

I can help from time to time for the softwares I know... 
But I have not regularly time enough to really join a team !

More than this :
I can't use a Cauldron on my everyday job computer ....

I only tested LiveCD from beta to official (sending bug reports)

I waited before installing Mageia2 that the first critical bugs appeared and were corrected ! (even if my work is backed up, it's too risky to use a new distro too soon...)
I still use a double boot Mandriva 2010.2 - Mageia2 and I'm only beginning to migrate definitely on Mageia2... ( try to correct the last very little bugs !)

I can only be a late tester !!!

We don't use cauldron in the QA team. We mainly test updates for mageia 1 and mageia 2 and then we test the ISO's before they are released.

I'm getting errors with mga2 x86_64 core:

converting to wav seems OK

when converting to flac I've got:
# Now converting: /home/test/Music/test.avi

# DISPLAYED REMAINING TIME MAY BE WRONG!


# Extracting audio...   please wait


# Now encoding audio.


flac 1.2.1, Copyright (C) 2000,2001,2002,2003,2004,2005,2006,2007  Josh Coalson
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

audiokonv27454.wav: ERROR: 'data' subchunk has size of 0


when converting to ogg I've got:
# Now converting: /home/test/Music/test.avi

# DISPLAYED REMAINING TIME MAY BE WRONG!

Writing metadata...
Error opening input file '/home/test/Music//test.ogg'.
Done.


[root@localhost test]# rpm -qa | grep wav
lib64wavpack1-4.60.1-2.mga1
wavpack-4.60.1-2.mga1
[root@localhost test]# rpm -qa | grep flac
lib64flac8-1.2.1-10.mga2
flac-1.2.1-10.mga2

same packages as in i586. Same setup in i586 (with same avi file) works as in described in comment#12

got same errors with tainted version (again: i586 works here, too). 

Additionally I've got following message when converting to mp3:
# Now converting: /home/test/Music/test.avi

# DISPLAYED REMAINING TIME MAY BE WRONG!

which: no id3v2 in (/usr/lib64/libfm:/usr/bin:/bin:/usr/local/bin:/usr/X11R6/bin/:/usr/games:/usr/lib64/qt4/bin:/home/test/bin:/home/test/.kde4//bin)



no big changes after installing with #urpmi id3v2:
# Now converting: /home/test/Music/test.avi

# DISPLAYED REMAINING TIME MAY BE WRONG!

Writing metadata...
Couldn't stat file '/home/test/Music//test.mp3'
Done.
# Now converting: /home/test/Music/test.avi

# DISPLAYED REMAINING TIME MAY BE WRONG!

which: no id3v2 in (/usr/lib64/libfm:/usr/bin:/bin:/usr/local/bin:/usr/X11R6/bin/:/usr/games:/usr/lib64/qt4/bin:/home/test/bin:/home/test/.kde4//bin)


[root@localhost test]# rpm -qa | grep libfm
libfm-0.1.17-1.mga2
[root@localhost test]# rpm -qa | grep id3v2
id3v2-0.1.12-1.mga2
[root@localhost test]# rpm -qa | grep lame
lame-3.99.5-1.mga2.tainted
lib64lame0-3.99.5-1.mga2.tainted

Hi Marc !
2 different problems :

1)
There seems to be a path problem 

Can you get the properties of the audio track of this videofile with audiokonverter ? 

Do you have a /tmp directory with read and write access for your user (that
seems to be called "test") ?

Can you find /tmp/movie2sound.info appearing in this /tmp directory when you have tried to get the properties of the audio track of your videofile ?


The temporary audiokonvxxxxxxx.wav extracted from the video is in this /tmp directory !
This file is used to be copied in /home/test/Music/test.wav or converted into 
/home/test/Music/test.flac or ogg or mp3, after the conversion the temporary file is deleted !

It looks like if this temporary file is not found !


2) There seems to be a missing Require in the spec file :

NB for Shlomi
You may add 
Requires : id3v2
in the spec file
(I never saw the problem of this dependency because id3v2 was always installed on my computer... when I tested audiokonverter)

(In reply to comment #18)
> Hi Marc !
> 2 different problems :
> 
> 1)
> There seems to be a path problem 
> 
> Can you get the properties of the audio track of this videofile with
> audiokonverter ? 
> 
> Do you have a /tmp directory with read and write access for your user (that
> seems to be called "test") ?
> 
> Can you find /tmp/movie2sound.info appearing in this /tmp directory when you
> have tried to get the properties of the audio track of your videofile ?
> 
> 
> The temporary audiokonvxxxxxxx.wav extracted from the video is in this /tmp
> directory !
> This file is used to be copied in /home/test/Music/test.wav or converted into 
> /home/test/Music/test.flac or ogg or mp3, after the conversion the temporary
> file is deleted !
> 
> It looks like if this temporary file is not found !
> 

I don't understand. Your punctuation and grammar seems to be erratic. Please send again the message with your suggestions and rephrase.

Wow, I've just bumped the %rel, rebuilt, and resubmitted, and suddenly QA finds a lot of errors. It's not as if I did any substantial change. But this is really demotivating. 

> 
> 2) There seems to be a missing Require in the spec file :
> 
> NB for Shlomi
> You may add 
> Requires : id3v2
> in the spec file

OK, I will.

Regards,

-- Shlomi Fish

> (I never saw the problem of this dependency because id3v2 was always installed
> on my computer... when I tested audiokonverter)

> Wow, I've just bumped the %rel, rebuilt, and resubmitted, and suddenly QA finds
> a lot of errors. It's not as if I did any substantial change. But this is
> really demotivating. 


As you well know Shlomi, it is only when updates are built for the stable distro that QA get to test them. I don't recall audiokonverter being updated previously. 

Packagers moaning is _really_ demotivating for the QA team too. Would you rather Mageia releases buggy software and have to shepherd these bug reports from normal users who may not be as easy to gain useful information from or who may not even bother to report them and instead just leave Mageia behind?

We are all on the same team here, with the same goals, or should be. I wish people would stop denigrating us when we do the job well that we are specifically here to perform.

Marc is new to QA and is testing one of his first updates. What effect do you think this has on the team?

Hi Claire,

I apologise for my outburst earlier. See below for my response.

(In reply to comment #20)
> > Wow, I've just bumped the %rel, rebuilt, and resubmitted, and suddenly QA finds
> > a lot of errors. It's not as if I did any substantial change. But this is
> > really demotivating. 
> 
> 
> As you well know Shlomi, it is only when updates are built for the stable
> distro that QA get to test them. I don't recall audiokonverter being updated
> previously.

Yes, I know that.
 
> 
> Packagers moaning is _really_ demotivating for the QA team too. Would you
> rather Mageia releases buggy software and have to shepherd these bug reports
> from normal users who may not be as easy to gain useful information from or who
> may not even bother to report them and instead just leave Mageia behind?
> 

You are right. That's not what I want.

> We are all on the same team here, with the same goals, or should be. I wish
> people would stop denigrating us when we do the job well that we are
> specifically here to perform.

Yes, I understand that now. I woke up feeling grumpy today, from some reason
(don't know exactly why), and was taking it out on several things. I apologise for that. 

> 
> Marc is new to QA and is testing one of his first updates. What effect do you
> think this has on the team?

Marc, if you're reading this - I now realise you have done a good job of testing audiokonverter on Mageia. As it stands, these problems may be caused due to bad packaging, but they also may be issues in the upstream software, which would be harder to fix.

Anyway, I have prepared and uploaded a new package with a %subrel of 1 (making it -2.1) which now depends on id3v2 , and it should be tested instead.

Regards,

-- Shlomi Fish

Hi Shlomi 

It was not clear indeed

There are two parts in my comment :

1) the first part is for Marc Latteman :
I want to explore whether it is an audiokonverter problem or if  his whole mga2x86_64 installation creates the problem... (it seems that the script has no access to the /temp directory where the first extraction is done as /temp/audiokonverterrandomnumber.wav)

I don't know what is the tree created by a x86_64 ...
Is there a /temp directory ? with write and read access for any user ?

It would be useful that someone else with Mageia2 x86_64 test audiokonverter


It would be useful too that Marc creates a new user on his system ! (does the fact that his user's name is "test", the avi file is "test.avi", the extracted file is "test.ogg" or "test.flac", induce some confusion)




2) the second part is for you : I never saw the missing "Requires: id3v2" because this id3v2.rpm was always installed on my computer before I use audiokonverter 

(I'm a long time user of audiokonverter : I used it with KDE 3.5 ... on Mandriva 2008.1  and asked to modify the spec file when Mandriva 2010.1 changed to KDE4.x as you may see it in the changelog : needed to choose KDE4 scripts instead of KDE3 scripts
ie anytowav4 instead of anytowav
   audioconvert4 instead of audioconvert
   and so on ... )

There's only this little missing Require to add in the spec file so that one of the error messages that Marc found disappear. 



PS I didn't saw any problem on a 586 system (Marc didn't too ...) We need to explore and understand why this appears only on his x86_64 system .

OK - here are some more information:

@Shlomi: It seems that this issue has nothing to do with your particular package: I checked also audiokonverter-5.9.1-1.mga2 from core and it seems that this is already not working properly for x86_64? Can someone confirm? It seems no one uses this tool, otherwise it should have been reported earlier.


However coming back to comment #18:
tested on a different (realHW) machine, with a different user and different movie(s) - same result:
# Now converting: /media/Daten/Filme/Mary_und_Max.avi

# DISPLAYED REMAINING TIME MAY BE WRONG!


# Extracting audio...   please wait


# Now encoding audio.


flac 1.2.1, Copyright (C) 2000,2001,2002,2003,2004,2005,2006,2007  Josh Coalson
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

WARNING: /tmp/audiokonv31817.wav is not a WAVE file; treating as a raw file
ERROR: for encoding a raw file you must specify a value for --endian, --sign, --channels, --bps, and --sample-rate
Type "flac" for a usage summary or "flac --help" for all options

There is no corresponding audiokonv31817.wav file in /tmp/

Trying to get the audio properties but getting no result. movie2sound.info is present in /tmp/ but empty.
[root@Rechner tmp]# ls -l movie2sound.info
-rw-rw-r-- 1 marc marc 0 Sep 17 22:27 movie2sound.info

Again: same tests performed in VM with i586 with same avi-files (tested always several) and everything works as intended.

CC: (none) => marc.lattemann

OK !
It seems to be a mplayer problem !!!

Audiokonverter is just a collection of scripts

when you want to get audio properties from a movie file
this script is launched :

mplayer -really-quiet -nolirc -nojoystick -nortc -vo null -ao null -frames 1 -identify "${1}" |grep AUDIO|tail -4|sed 's/ID_//g'|sed 's/AUDIO_NCH/channels/g'|sed 's/AUDIO_RATE/sampling frequency [Hz]/g'|sed 's/AUDIO_BITRATE/bitrate/g'|sed 's/AUDIO_CODEC/format/g' >> /tmp/movie2sound.info

in which "${1}" is the name of the movie file with its path, for you it is :
/media/Daten/Filme/Mary_und_Max.avi

if the movie2sound.info file is empty it's a mplayer problem 

You may try this script in a console on a 586 system and on a x86_64 : just copy and paste it in a console

mplayer  -nolirc -nojoystick -nortc -vo null -ao null -frames 1 -identify /media/Daten/Filme/Mary_und_Max.avi |grep AUDIO|tail -4|sed 's/ID_//g'|sed 's/AUDIO_NCH/channels/g'|sed 's/AUDIO_RATE/sampling frequency [Hz]/g'|sed 's/AUDIO_BITRATE/bitrate/g'|sed 's/AUDIO_CODEC/format/g' >> /tmp/movie2sound.info

(I suppressed the really-quite option so that you may read the mplayer comments )

You will get a movie2sound.info file in the /tmp directory : it must not be empty (if there was another one before, it will be overwritten)

Actually as longer as I'm playing around I'm getting confused :( sometimes it works sometimes not... I've found one avi.file, which I can convert on one machine but not on an other one. And also the movie2sound.info works for some files as well. I'm sorry, but I did not get consistent results

Ok ! so it seems to be only an *.avi file problem !!!

To prevent from confusion :
We need to compare with as less variables modified as possible.


The avi extension covers lots of differently encoded video or audio streams in one container ... 
The codec for the audio stream may be :

MPEG-1 Layer III (MP3) · MPEG-1 Layer II · MPEG-1 Layer I · Advanced Audio Coding · AAC · AAC+ · eAAC+ · SBR  · Parametric Stereo · G.711 · G.719 · G.722 · G.722.1 · G.722.2 · G.723 · G.723.1 · G.726 · G.728 · G.729 · G.729.1 · G.729a · AC3 · AMR · Apple Lossless · ATRAC · CELT · FLAC · iLBC · Monkey's Audio · μ-law · Musepack · Nellymoser · OptimFROG · Opus · RealAudio · RTAudio · SHN · Siren · Speex · TAK · Vorbis · WavPack · WMA

Same for the video codecs....


More than this :
Some *.avi files are badly created (depending of which software is used and which user uses it !!!)
I have got some problem with some avi files whose the audiotrack  couldn't be extracted nor converted (even if they could be read by the tainted version of VLC but wrongly displayed with mplayer or xine )



If you test an avi file on a computer and an other avi file on an other computer you can't compare the results .

If you use the tainted version of mageia on a computer and the core version on an other you can't compare the results (the tainted version are built with more codecs ... faad and lame for instance, allowing to read an aac sound-track and convert it into a mp3 file, which is not allowed by the core version) 




The best you can do to test the tainted version of audiokonverter is to use it with the tainted versions of mplayer and ffmpeg on two computers (i586 and x86_64)

Then you may use *.mpg files, *.flv file, *.mp4 files, *.wmv files, *.vob files

to "show properties", and extract and convert the audiotrack into mp3, flac, wav, ogg


You can try, too, to convert audio files from one codec to another :

*.mp3 file into ogg, wav, flac (even if it is stupid to try to get lossless compression from a compressed file!!!)
*.wav into mp3, flac ogg
*.aac file into mp3, flac, ogg, wav
*.ogg file into wav, mp3, flac
*.flac file into wav, mp3, ogg,

NB : you can read an *.acc (or *.mpa) file, thanks to faad decoder, and encode it into mp3 (thanks to lame)
but you can't create an *.aac (or *.mpa) file : Mageia doesn't provide the faac encoder... that's the reason why the tainted version is built with a patch.


If it's OK this way you can validate the update
Nevermind with those junk *.avi files ...

Testing complete for audiokonverter-5.9.1-2.mga2.tainted.src.rpm on Mageia release 2 (Official) for x86_64 ,for me it's Ok and the conversion works fine .

Tests with several audio and video files.

CC: (none) => geiger.david68210

Thanks David :
So we can validate this update : the problem that Marc encountered is certainly only an avi file problem ... I had twice this kind of error with two "exotic" avi files. It's certainly a limit that encounters sometimes  mplayer and so audiokonverter !

I added MGA2-64-OK on the whiteboard...

This update candidate can be pushed from updates_testing into the updates repos (both core and tainted ...)


To Marc :
You may propose your blocking avi file to the mplayer team, with the script used to get info from it... Let them explore why this file is obscure for mplayer...

RESOLVED FIXED ?

Thanks again to Shlomi  and to Claire for your goodwilling and patience !

Whiteboard: mga2-32-OK => mga2-32-OK MGA2-64-OK

P.S.
Advisory proposal :
Audiokonverter was only built for the core repository
this update proposes two flavours : 
- first one, built for the core repository (opensource and patent free)

- second one, built for the tainted repository (allowing to create mp3 files) that may not be distributed in some countries such as USA, Japan, because of local laws concerning patented softwares.

Thanks everybody for testing!

@Philipp: IIRC, the sysadmin team sets the bug status to RESOLVED FIXED once it pushed the update. You can find the exact validation procedure here: https://wiki.mageia.org/en/QA_process_for_validating_updates#Validate

----
The following packages will require linking:

id3v2-0.1.12-1.mga2 (Core Release)


------------------------------------------------------------------------------------------
Update validated.
Thanks.

Advisory:
--------------
audiokonverter was only built for the Core repository, but not for Tainted. This update fixes this issue, by introducing two flavours.
--------------

SRPMs: 
audiokonverter-5.9.1-2.mga2.src.rpm
audiokonverter-5.9.1-2.mga2.tainted.src.rpm

Could sysadmin please push from core/updates_testing to core/updates and from tainted/updates_testing to tainted/updates.

Thank you!
------------------------------------------------------------------------------------------

Keywords: (none) => validated_update
CC: (none) => sysadmin-bugs, wassi

Package linked and update pushed:
https://wiki.mageia.org/en/Support/Advisories/MGAA-2012-0208

Status: ASSIGNED => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED