Bug 6055 - scilab cli and scilab advanced cli have no associated icons in the kde menu
Summary: scilab cli and scilab advanced cli have no associated icons in the kde menu
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 4
Hardware: All Linux
Priority: Normal minor
Target Milestone: ---
Assignee: QA Team
QA Contact: Claire Revillet
URL:
Whiteboard: MGA4-32-OK MGA4-64-OK advisory
Keywords: Junior_job, validated_update
Depends on:
Blocks:
 
Reported: 2012-05-23 14:35 CEST by Yann COLLETTE
Modified: 2014-02-21 19:23 CET (History)
4 users (show)

See Also:
Source RPM: scilab
CVE:
Status comment:


Attachments
spec with fix (1.30 KB, patch)
2014-02-05 12:05 CET, Alex Loginov
Details | Diff
spec with fix (1.83 KB, patch)
2014-02-05 19:24 CET, Alex Loginov
Details | Diff
Done for Icons and Categories. (1.71 KB, patch)
2014-02-05 19:26 CET, Alex Loginov
Details | Diff
spec with fix (1.71 KB, patch)
2014-02-05 23:30 CET, Alex Loginov
Details | Diff
spec with fix (1.32 KB, patch)
2014-02-06 22:51 CET, Alex Loginov
Details | Diff
patch for desktop (5.02 KB, patch)
2014-02-06 22:53 CET, Alex Loginov
Details | Diff

Description Yann COLLETTE 2012-05-23 14:35:47 CEST
I installed scilab 5.3.3 (the one shipped with mageia 2 64 bits).
In the kde menu, category sciences, there are 3 entries related to scilab.
- scilab
- scilab CLI
- scilab advanced CLI

scilab CLI and scilab advanced CLI have no associated icons (this looks a little bit ugly in the kde menu).
Manuel Hiebel 2012-05-24 19:19:45 CEST

Assignee: bugsquad => grenoya
Severity: normal => minor

Comment 1 Alex Loginov 2012-12-18 13:08:04 CET
I confirm.
scilab-cli.desktop and scilab-adv-cli.desktop:
Icon=/usr/share/scilab-cli/icons/scilab.xpm
Directory scilab-cli does not exists.

CC: (none) => loginov_alex

Comment 2 Alex Loginov 2013-05-14 08:28:04 CEST
scilab-5.4.0-2.mga3.i586 have bug also.

Keywords: (none) => Junior_job
Hardware: x86_64 => All
Version: 2 => Cauldron

Rémi Verschelde 2013-11-24 11:21:08 CET

CC: (none) => remi
Assignee: grenoya => remi
QA Contact: (none) => grenoya

Comment 3 Alex Loginov 2014-02-05 12:05:36 CET
Created attachment 4935 [details]
spec with fix

This patch for spec fixes this bug and deletes double desktop file.
Rémi Verschelde 2014-02-05 12:19:23 CET

Assignee: remi => stormi

Comment 4 Rémi Verschelde 2014-02-05 13:43:35 CET
Alex, can you also fix the desktop categories so that Scilab (and Xcos) are not listed both in Science::Physics and Science::Math, but only in Science::Physics?
Comment 5 Claire Revillet 2014-02-05 13:48:56 CET
(In reply to Rémi Verschelde from comment #4)
> Alex, can you also fix the desktop categories so that Scilab (and Xcos) are
> not listed both in Science::Physics and Science::Math, but only in
> Science::Physics?

Why Physics?
I understand your point that been listed in both is a problem, but Scilab can be used to do mathematics without any link to an application domain.
For Xcos, I agree that it's only physics.

Is it possible to put Scilab in Science::Maths and Xcos in Science::Physics?
Comment 6 Rémi Verschelde 2014-02-05 13:51:35 CET
(In reply to Claire Revillet from comment #5)
> 
> Why Physics?
> I understand your point that been listed in both is a problem, but Scilab
> can be used to do mathematics without any link to an application domain.
> For Xcos, I agree that it's only physics.
> 
> Is it possible to put Scilab in Science::Maths and Xcos in Science::Physics?

I admit the proposal was arbitrary, it's just that I don't like it being in two categories :) Science::Engineering would be good, but I don't think there is such a category. Scilab in Science::Math and Xcos in Science::Physics would be fine by me.
Comment 7 Alex Loginov 2014-02-05 19:24:19 CET
Created attachment 4942 [details]
spec with fix

Done for Icons and Categories.
Comment 8 Alex Loginov 2014-02-05 19:26:03 CET
Created attachment 4943 [details]
Done for Icons and Categories.

Attachment 4935 is obsolete: 0 => 1
Attachment 4942 is obsolete: 0 => 1

Comment 9 Alex Loginov 2014-02-05 23:30:34 CET
Created attachment 4944 [details]
spec with fix

Attachment 4943 is obsolete: 0 => 1

Comment 10 Samuel Verschelde 2014-02-05 23:41:21 CET
Alex, please use the desktop-file-utils (desktop-file-edit for example) to alter .desktop files
Comment 11 Samuel Verschelde 2014-02-06 00:29:15 CET
(In reply to Samuel VERSCHELDE from comment #10)
> Alex, please use the desktop-file-utils (desktop-file-edit for example) to
> alter .desktop files

or patches. sed will not allow to detect future upstream changes in the desktop files. Patches will allow it because they'll fail and need re-diff. It's a good thing if patches fail: it forces us to ask ourselves "is that patch still pertinent?"
Comment 12 Alex Loginov 2014-02-06 09:19:30 CET
In this case we had own %{_real_vendor}-%{name}.desktop with Categories=Science;Math;
I deleted %{_real_vendor}-%{name}.desktop.
With help sed I returned our Categories permanently in the future, but in upstream's desktop files.
Comment 13 Samuel Verschelde 2014-02-06 10:28:05 CET
Alex. You are an experienced packager and that's great. However, contributing to the core of Mageia requires not only packaging skills, but also the ability to respect the policies.

Here, I'm asking you to use a patch instead of sed to alter the .desktop files, so that future changes from upstream in the .desktop files are automatically detected during build (the patch will fail if the the desktop file has changed, which will allow us to review if the patch is still needed or not).
Comment 14 Alex Loginov 2014-02-06 22:51:59 CET
Created attachment 4955 [details]
spec with fix

Attachment 4944 is obsolete: 0 => 1

Comment 15 Alex Loginov 2014-02-06 22:53:49 CET
Created attachment 4956 [details]
patch for desktop

This patch fixes Icons, Categories and adds Russian.
Comment 16 Samuel Verschelde 2014-02-07 22:36:24 CET
Patch and spec file committed with only a small change to the spec: naming of the patch. Submitted to cauldron.
Comment 17 Alex Loginov 2014-02-08 09:55:52 CET
Patch was sent into upstream http://bugzilla.scilab.org/show_bug.cgi?id=13229
Comment 18 Alex Loginov 2014-02-09 21:21:44 CET
Let's put updates for mga4.
Comment 19 Alex Loginov 2014-02-19 20:43:55 CET
Updated in Cauldron and in Mageia 4, uploaded by stormi.

Advisory:
========================

Updated scilab:
- add Russian comments in desktop files
- fix icons for scilab-cli, scilab-adv-cli
- fix categories in desktop files
- delete double Scilab from Menu

========================

Updated packages in core/updates_testing:
========================
scilab-5.5.0-0.beta1.4.mga4

from SRPMS:
scilab-5.5.0-0.beta1.4.mga4.src.rpm

Assignee: stormi => qa-bugs

Alex Loginov 2014-02-19 20:52:14 CET

Version: Cauldron => 4

Comment 20 claire robinson 2014-02-21 16:10:05 CET
Claire and Yann could you test the fixes please and ensure scilab still works as expected. It would be useful if you could give a quick procedure here how to test scilab too so that we can refer to it the next time it is updated.

Thanks!
Comment 21 Rémi Verschelde 2014-02-21 17:51:12 CET
Testing complete Mageia 4 i586. I did not specifically test in KDE, but I can confirm that the similar fix pushed to cauldron does the trick in KDE, and given the simplicity of the fix, I consider it good.

Whiteboard: (none) => MGA4-32-OK

Comment 22 Rémi Verschelde 2014-02-21 18:30:10 CET
Testing complete Mageia 4 x86_64.

Whiteboard: MGA4-32-OK => MGA4-32-OK MGA4-64-OK

Comment 23 Rémi Verschelde 2014-02-21 18:32:32 CET
Validating update, advisory uploaded. Please push to 4 core/updates.

Keywords: (none) => validated_update
Whiteboard: MGA4-32-OK MGA4-64-OK => MGA4-32-OK MGA4-64-OK advisory
CC: (none) => sysadmin-bugs

Comment 24 Thomas Backlund 2014-02-21 19:23:07 CET
Update pushed:
http://advisories.mageia.org/MGAA-2014-0058.html

Status: NEW => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.