Bug 6022 - After Live Install, ask before overwriting user files if needed (drakx-finish-installer)
Summary: After Live Install, ask before overwriting user files if needed (drakx-finish...
Status: NEW
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal critical
Target Milestone: ---
Assignee: Mageia tools maintainers
QA Contact:
URL:
Whiteboard:
Keywords: FOR_ERRATA5, FOR_ERRATA6
: 20636 (view as bug list)
Depends on:
Blocks: 5990
  Show dependency treegraph
 
Reported: 2012-05-22 16:04 CEST by Dave Hodgins
Modified: 2017-07-11 11:46 CEST (History)
9 users (show)

See Also:
Source RPM: drakxtools-14.21-1.mga2.src.rpm
CVE:
Status comment:


Attachments

Description Dave Hodgins 2012-05-22 16:04:22 CEST
If a user mistakenly uses a live cd to try and upgrade an existing
system (by unselecting the option to format the partition(s)),
drakx-finish-install will overwrite contents of any files in
/home/$user, with the files from /home/live, if the user does,
as most will, reuses the same user name.

The finish-install should check to see if /home/$user already
exists, and get permission, before overwriting the files, or
all the user to leave the /home/live directory as is.

Hopefully, the user won't have the user name live, already in
use.  If they do, the live cd should get permission, before
overwriting.
Dave Hodgins 2012-05-22 16:06:33 CEST

Priority: Normal => release_blocker

Comment 1 Dave Hodgins 2012-05-22 16:19:04 CEST
See bug 5990 for an example of the damage that can be done.
Manuel Hiebel 2012-05-22 16:44:21 CEST

CC: (none) => mageia, tmb

Comment 2 Manuel Hiebel 2012-05-22 16:47:40 CEST
as in mdv and in mga1 so no regression so far

Blocks: (none) => 5990
Target Milestone: --- => Mageia 3

Comment 3 Marja Van Waes 2012-05-26 13:08:15 CEST
Hi,

This bug was filed against cauldron, but we do not have cauldron at the moment.

Please report whether this bug is still valid for Mageia 2.

Thanks :)

Cheers,
marja

Keywords: (none) => NEEDINFO

Comment 4 Dave Hodgins 2012-05-28 03:05:07 CEST
This bug is for the Mageia 3, on first boot after install from a live cd.

Keywords: NEEDINFO => (none)
Hardware: i586 => All

Dave Hodgins 2012-06-20 04:33:51 CEST

Whiteboard: (none) => MGA2TOO

Comment 5 Manuel Hiebel 2012-11-24 18:50:29 CET
(no regression, should not be used for upgrade, etc)

Priority: release_blocker => Normal
Target Milestone: Mageia 3 => ---
Summary: Do not overwrite files without permission. => ask for overwrite files (drakx-finish-installer)
Severity: critical => enhancement

Comment 6 Nic Baxter 2015-03-10 06:26:06 CET
Should this be closed? It appears not to be a bug as the medium is not designed to upgrade existing installations.

CC: (none) => nic

Comment 7 Samuel Verschelde 2016-10-15 16:17:13 CEST
(In reply to Nic Baxter from comment #6)
> Should this be closed? It appears not to be a bug as the medium is not
> designed to upgrade existing installations.

It's still a valid enhancement request. There's no reason why we couldn't use the Live DVD with an existing home directory, so we should probably give a warning in the first boot wizard if the chosen username matches one that already has a home directory: advise to choose a different username to avoid existing configuration files to be overwritten, but let the user keep its initial choice if wanted.

Assigning to Mageia Tools maintainer group.

Assignee: bugsquad => mageiatools
Whiteboard: MGA2TOO => (none)

Samuel Verschelde 2016-10-15 16:18:44 CEST

Summary: ask for overwrite files (drakx-finish-installer) => After Live Install, ask before overwriting user files if needed (drakx-finish-installer)

Comment 8 Marja Van Waes 2017-04-06 01:10:34 CEST
*** Bug 20636 has been marked as a duplicate of this bug. ***

CC: (none) => krnekit

Comment 9 Marja Van Waes 2017-04-06 01:13:12 CEST
When doing a Live install, after creating mount points for / and /home, only / is formatted by default.

/home is not formatted by default.

That's odd if we don't support doing a fresh install from a Live DVD while keeping /home

CC: (none) => marja11

Comment 10 Nikita Krupenko 2017-04-06 06:42:40 CEST
"live media shouldn't be used for an upgrade" isn't an argument, because clean install with existing home isn't an upgrade. And in this case user can lose data, see Bug 20636. So this is critical.

I don't think, it's so hard to not touch user's home if it's already exists. At least there should be a warning.

Severity: enhancement => critical

Comment 11 Marja Van Waes 2017-04-06 07:19:38 CEST
(In reply to Nikita Krupenko from comment #10)
> "live media shouldn't be used for an upgrade" isn't an argument, because
> clean install with existing home isn't an upgrade.

I agree, and I think many will. It was only last night that I learned that:
* all our warnings about not using the Live iso for an upgrade, were also meant for clean installs while keeping /home
* QA team does _not_ test installing from Live isos while keeping /home

That one wiki page in which I made it more clear that keeping /home can lead to data loss, isn't enough... there are undoubtedly more wiki pages, forums posts, official Mageia manuals etc. that will need to be updated with the warning about possible data loss if you try this :-(

> And in this case user can
> lose data, see Bug 20636. So this is critical.

You're right
> 
> I don't think, it's so hard to not touch user's home if it's already exists.
> At least there should be a warning.

CC'ing Martin Whitaker, who said in duplicate bug #20636, comment #5 :

> Unfortunately most people only read the Wiki *after* something's gone wrong
> :-(
> 
> I do think we should fix this.

Setting the IN_ERRATA* keywords, but also hoping this'll be solved before Mga6 release.

Keywords: (none) => IN_ERRATA5, IN_ERRATA6
CC: (none) => mageia

Comment 12 papoteur 2017-04-06 08:50:20 CEST
Hello,
I discover this big limitation in using Live supports, I have never been aware of that. And never given instructions in this direction when checking or writing documentation, or giving instructions in forum.
The better solution seems to avoid such a behaviour. If we haven't improvement on that for MGA 6, we should review our documentation and give large echos in forum.

CC: (none) => doc-bugs, yves.brungard_mageia

Comment 13 Marja Van Waes 2017-07-10 22:43:21 CEST
Seems I had set wrong keywords, correcting them now.

(In reply to papoteur from comment #12)
> Hello,
> I discover this big limitation in using Live supports, I have never been
> aware of that. And never given instructions in this direction when checking
> or writing documentation, or giving instructions in forum.
> The better solution seems to avoid such a behaviour. If we haven't
> improvement on that for MGA 6, we should review our documentation and give
> large echos in forum.

Yes, we need to tell everywhere that installing from a Live DVD while keeping /home, is not supported.

Keywords: IN_ERRATA5, IN_ERRATA6 => FOR_ERRATA5, FOR_ERRATA6

Comment 14 Chris B 2017-07-10 23:25:50 CEST
Wait. Our Live DVDs are just perfect to do just that: doing a fresh install of M6 while keeping a separate /home partition. I did it with my main desktop weeks ago. No data loss.
By default /home will not be formatted. The checkmark is set to not format it. You can even use the same user name, and it will -at least with Xfce- work just fine. 

QA does and did test this. Me :p

The warning should be that an _upgrade_ is not possible.

CC: (none) => shybluenight

Comment 15 Marja Van Waes 2017-07-11 11:08:16 CEST
(In reply to Chris B from comment #14)
> Wait. Our Live DVDs are just perfect to do just that: doing a fresh install
> of M6 while keeping a separate /home partition. I did it with my main
> desktop weeks ago. No data loss.
> By default /home will not be formatted. The checkmark is set to not format
> it. You can even use the same user name, and it will -at least with Xfce-
> work just fine. 
> 
> QA does and did test this. Me :p
> 
> The warning should be that an _upgrade_ is not possible.

Well, it _can_ overwrite important settings, as was reported by at least David Hodgins here, Nikita (see bug 20636) and Jehan Hysseo (bug 5990).

The current wiki warning is in https://wiki.mageia.org/en/Installation_Media#Live_DVD_ISO
Comment 16 Chris B 2017-07-11 11:46:21 CEST
Thank you, Marja. My bad, the wiki looks fine.

Note You need to log in before you can comment on or make changes to this bug.