Bug 5460 - Please add further info to the partition selection for bootloader installation on Summary screen (eg. /dev/sda7 12Gb ext4)
Summary: Please add further info to the partition selection for bootloader installatio...
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Installer (show other bugs)
Version: Cauldron
Hardware: x86_64 Linux
Priority: Normal enhancement
Target Milestone: Mageia 3
Assignee: Mageia Bug Squad
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-18 12:32 CEST by claire robinson
Modified: 2012-04-19 20:45 CEST (History)
2 users (show)

See Also:
Source RPM: drakx-installer-stage2
CVE:
Status comment:


Attachments

Description claire robinson 2012-04-18 12:32:57 CEST
Noticed during pre-release testing of Mga 2 Beta 3 DVD.

Configuring the bootloader from the summary screen during installation there is a drop down to select which partition to install grub to.

The info in the drop down is just a list of /dev/sdX

It would benefit from some extra details, such as /dev/sdX (size - type).

eg. /dev/sda7 (12Gb - ext4)
    /dev/sda8 (2Gb - Swap)
    /dev/sda9 (60Gb - ext4)

Perhaps even specifying the mount point if available.
claire robinson 2012-04-18 12:33:33 CEST

Target Milestone: --- => Mageia 3

Manuel Hiebel 2012-04-18 12:46:05 CEST

CC: (none) => pterjan, thierry.vignaud
Source RPM: (none) => drakx-installer-stage2

Comment 1 Pascal Terjan 2012-04-18 13:01:57 CEST
The code does:

my $name = $_->{info} || $_->{device_LABEL};
$boot_devices{$dev} = $name ? "$dev ($name)" : $dev;

So, it will display info or device_LABEL if they exist

info is set on disks (and probably LVM), device_LABEL is set if the partition has a label

We can easily use $_->{mntpoint} but should it be displayed only if no label, or the opposite, display only the label if there is no mount point?

We can't display too much information (it has to fit in text mode too)

I would suggest to try first label, then mount point, then size + filesystem
Comment 2 claire robinson 2012-04-18 15:47:09 CEST
That sounds ideal. Size and type would be helpful alone to identify which sdX was which and is much better than guessing :)
Comment 3 Pascal Terjan 2012-04-19 19:34:32 CEST
Fixed in svn (first tries mountpoint, then info or label, then size+fs_type)
Comment 4 claire robinson 2012-04-19 19:55:14 CEST
Thanks Pascal :)
Comment 5 Thierry Vignaud 2012-04-19 20:45:22 CEST
Closing

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.