Bug 5430 - Transmission-gtk crashes when clicking the Speed Tab [mga2]
Summary: Transmission-gtk crashes when clicking the Speed Tab [mga2]
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 2
Hardware: All Linux
Priority: Normal normal
Target Milestone: Mageia 2
Assignee: QA Team
QA Contact:
URL:
Whiteboard: MGA2-64-OK MGA2-32-OK
Keywords: validated_update
: 6001 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-04-16 23:50 CEST by Stephen Pettin
Modified: 2012-07-29 23:08 CEST (History)
12 users (show)

See Also:
Source RPM: oxygen-gtk3-1.0.3-1.1.mga2.src.rpm
CVE:
Status comment:


Attachments
Speed settings in transmission-gtk (51.67 KB, image/png)
2012-04-19 12:08 CEST, Hugo Pereira Da Costa
Details
patch to oxygen-gtk (1.42 KB, application/octet-stream)
2012-04-19 12:44 CEST, Hugo Pereira Da Costa
Details
patch to oxygen-gtk3-1.0.3 (1.71 KB, application/octet-stream)
2012-07-08 13:36 CEST, Hugo Pereira Da Costa
Details

Description Stephen Pettin 2012-04-16 23:50:52 CEST
When I try to adjust the Download/Upload speed in the Edit, Peference, Speed tab. When I click the Speed tab, it will close out Transmission-gtk completely. Any of the other tabs does not cause it to crash.


To reproduce the bug, do the following in Mga2 (testing) with KDE4. 

1. Open transmission with some active torrents.
2. Go to Edit --> Preference.
3. Click on the "Speed" tab in the transmission window. Transmission crashes immediately. None of the other tabs crash. No other issues that I can see other then this one.


Transmission-gtk v2.51.


# rpm -qif /usr/bin/transmission-gtk
Name        : transmission-gtk
Version     : 2.51
Release     : 1.mga2
Architecture: i586
Install Date: Mon 16 Apr 2012 07:54:39 AM CDT
Group       : Networking/File transfer
Size        : 3012170
License     : MIT and GPLv2
Signature   : RSA/SHA1, Fri 13 Apr 2012 09:22:22 AM CDT, Key ID b742fa8b80420f66
Source RPM  : transmission-2.51-1.mga2.src.rpm
Build Date  : Fri 13 Apr 2012 09:21:22 AM CDT
Build Host  : ecosse.mageia.org
Relocations : (not relocatable)
Packager    : boklm <boklm>
Vendor      : Mageia.Org
URL         : http://www.transmissionbt.com/
Summary     : GTK Interface for Transmission BitTorrent client
Stephen Pettin 2012-04-17 00:04:33 CEST

Target Milestone: --- => Mageia 2

Comment 1 Manuel Hiebel 2012-04-17 16:59:55 CEST
what is your gtk theme ? oxygen ? does it crash to if you use another one ?
Manuel Hiebel 2012-04-17 17:00:13 CEST

Source RPM: (none) => transmission

Comment 2 Stephen Pettin 2012-04-18 15:57:41 CEST
I'm not a big user of KDE4 but I was using the default theme, assuming Oxygen. 

Now I'm currently using Gnome3 Fallback mode and accessing the 'Speed' tab does not crash transmission. I'll have to try KDE again with a different theme as soon as I figure out how to change themes.

Thnx.
Comment 3 Hugo Pereira Da Costa 2012-04-19 09:52:57 CEST
I confirm the crash.
Happens only with oxygen-gtk3 as a widget theme. Not with Adwaita.
Investigating.

CC: (none) => hugo

Comment 4 Hugo Pereira Da Costa 2012-04-19 12:08:03 CEST
Created attachment 2042 [details]
Speed settings in transmission-gtk

crash is due to some custom comboboxes in the incriminated settings page (the speed), which crash as soon as one calls 
"gtk_combo_box_check_appearance"

(which in turn is called from inside oxygen-gtk via gtk_combo_box_set_wrap_width())

So far I have found no proper way of working this around in oxygen-gtk3, for this widget and this widget only. I suggest this crash (and this explanation) is forwarded upstream, while I keep investigated.

The incriminated "custom" comboboxes are visible on the screenshot.
They are the "schedule times" comboboxes.

also note that they are not rendered properly either (missing the left edge), which I'm not sure how to fix in oxygen-gtk either.
Comment 5 Hugo Pereira Da Costa 2012-04-19 12:44:59 CEST
Created attachment 2043 [details]
patch to oxygen-gtk

This patch fixes it.
I'm still checking for regressions before pushing to oxygen-gtk3 code.
Comment 6 Hugo Pereira Da Costa 2012-04-19 15:23:44 CEST
after double-checking, I pushed the changes to both oxygen-gtk git repositories.
Will become available with oxygen-gtk3-1.0.4 (due in about 1 month)
Comment 7 Hugo Pereira Da Costa 2012-05-14 13:49:37 CEST
As announced above, crash is fixed in latest oxygen-gtk3 version, available at:

http://download.kde.org/download.php?url=stable/oxygen-gtk3/1.0.4/src/oxygen-
gtk3-1.0.4.tar.bz2

Can someone push ?
Manuel Hiebel 2012-05-14 17:36:40 CEST

Assignee: bugsquad => juan.baptiste
Source RPM: transmission => oxygen-gtk3

Comment 8 Manuel Hiebel 2012-05-21 12:42:49 CEST
*** Bug 6001 has been marked as a duplicate of this bug. ***

CC: (none) => kristoffer.grundstrom1983

Comment 9 Marja Van Waes 2012-05-26 13:06:46 CEST
Hi,

This bug was filed against cauldron, but we do not have cauldron at the moment.

Please report whether this bug is still valid for Mageia 2.

Thanks :)

Cheers,
marja

Keywords: (none) => NEEDINFO

Comment 10 Manuel Hiebel 2012-06-12 21:50:44 CEST
still no update in mga2

Keywords: NEEDINFO => (none)
CC: (none) => dmorganec, fundawang, olav
Version: Cauldron => 2

Comment 11 Hugo Pereira Da Costa 2012-06-12 22:11:21 CEST
dmorgan promised he would make an update.
I guess I'll ping him again on IRC.
A new oxygen-gtk version will be released in the comming days (but no serious crashes fixed this time, cause I have not been aware of any)
Comment 12 Marja Van Waes 2012-07-06 15:03:49 CEST
Please look at the bottom of this mail to see whether you're the assignee of this  bug, if you don't already know whether you are.


If you're the assignee:

We'd like to know for sure whether this bug was assigned correctly. Please change status to ASSIGNED if it is, or put OK on the whiteboard instead.

If you don't have a clue and don't see a way to find out, then please put NEEDHELP on the whiteboard.

Please assign back to Bug Squad or to the correct person to solve this bug if we were wrong to assign it to you, and explain why.

Thanks :)

**************************** 

@ the reporter and persons in the cc of this bug:

If you have any new information that wasn't given before (like this bug being valid for another version of Mageia, too, or it being solved) please tell us.

@ the reporter of this bug

If you didn't reply yet to a request for more information, please do so within two weeks from now.

Thanks all :-D
Comment 13 Juan Luis Baptiste 2012-07-06 18:53:49 CEST
Well I'm the correct owner for this bug as I'm currently the maintainer for oxygen-gtk* packages, but as I haven't done anything for this and other oxygen-gtk related bugs due to lack of knowledge and experience with topics, I think that I should drop maintainership of those two packages and someone more competent with them, like tv or hugo (if he's a packager too, dunno if hi is) should grab them and be the owner of this bugs.
Comment 14 Hugo Pereira Da Costa 2012-07-07 12:43:40 CEST
Hi Juan Luis,

I can take care of fixing bugs upstream (in oxygen-gtk source code), which is better than distribution patches, and therefore am more than happy to be cc'ed to any oxygen-gtk related bug (this helps improve my code). However, I would rather not become a packager (no time available for that, sorry), and therefore not become official assignee of these. 

If I remember right, dmorgan (dmorganec@gmail.com) might also be able to help on this (the packaging part). Better ping him directly

For this particular bug (gtk-transmission), it has been fixed upstream (since release gtk3-1.0.4), and all that's needed is to package this release (or latest one, which is 3-1.0.5).

Also, next 'major' release (gtk3-1.1.0) will show up in about one week so maybe it is worth waiting for it. 

Cheers,

Hugo
Comment 15 Sander Lepik 2012-07-07 12:47:57 CEST
As this bug is filed against mga2 we probably can't upgrade to a new version. Hugo, is it possible that you direct us to the commit that fixes this problem? Is it possible to patch it on our version of the package?

CC: (none) => sander.lepik

Comment 16 Hugo Pereira Da Costa 2012-07-07 12:57:26 CEST
@Sander: 
bug has been fixed "twice" in fact. First I removed the 'crashing' functionality; second, I re-added it, and made it stable.

So two commits: 

- https://projects.kde.org/projects/playground/artwork/oxygen-gtk/repository/revisions/da10c6bf5d4fe8b39f3337f990e7424222117392

- https://projects.kde.org/projects/playground/artwork/oxygen-gtk/repository/revisions/733af5998fba65f97235ddb5f7602fd004818ffd

I think a patch combining the two diffs 'should' work on the oxygen-gtk3-1.0.3 (which is the release shipped with mageia 2).

I can help generating such a patch, if needed.

Cheers, 

Hugo
Comment 17 Manuel Hiebel 2012-07-07 13:44:55 CEST
>As this bug is filed against mga2 we probably can't upgrade to a new version.
Why ? before the complete frezee it was said (iirc) it's too late to update it but it was ok for after the release

Keywords: (none) => Junior_job

Comment 18 Hugo Pereira Da Costa 2012-07-07 13:47:49 CEST
@Manuel
yes, I remember that quote too :)
(but I'm not the one to decide what should be updated and what should not)

What I know for sure though is that Cauldron must get oxygen-gtk3-1.1.0 as soon as it is out, because there are plenty of rendering issues with current release and gtk+-3.3.x (due to changes in gtk+-3), that have been fixed since then

Hugo
Comment 19 Hugo Pereira Da Costa 2012-07-08 13:36:52 CEST
Created attachment 2535 [details]
patch to oxygen-gtk3-1.0.3

This patch should be applied to oxygen-gtk3-1.0.3
It fixes the issue as far as I can tell.
It is only necessary if you want to patch the oxygen-gtk3 version shipped with mageia2, rather than update to a more recent release.

It is not needed for Cauldron because: 
1/ the crash is not reproducible with more recent versions of gtk+-3.0 (namely 3.5.x)
2/ one should update oxygen-gtk3 to v1.1.0 whenever it is released, since it fixes many glitches with the aforementioned version of gtk+-3.0 

Hugo
Comment 20 Anderson Carvalho 2012-07-16 12:49:18 CEST
I confirm the same problem. Here also stops transmission-gtk in Mageia 2 x86_64. Tested the transmission-gtk-2.60-1.mga3.x86_64.rpm package and is having the same problem.

CC: (none) => frateraec
Hardware: i586 => All

Comment 21 D Morgan 2012-07-16 13:00:48 CEST
i just pushed a new oxygen-gtk3 with this patch
Comment 22 Anderson Carvalho 2012-07-16 13:56:28 CEST
Okay! But I did not find in the repositories core update for Mageia 2. :-(
Comment 23 D Morgan 2012-07-16 14:19:03 CEST
this is in updates_testing
Comment 24 Manuel Hiebel 2012-07-17 00:26:26 CEST
(In reply to comment #23)
> this is in updates_testing
thanks

Suggested Advisory:
-------------
Updated oxygen-gtk3 fix a crash of transmission-gtk when clicking on the speed tab.

https://bugs.mageia.org/show_bug.cgi?id=5430
-------------

SRPM: oxygen-gtk3-1.0.3-1.1.mga2.src.rpm

Assignee: juan.baptiste => qa-bugs
Summary: Transmission-gtk crashes when clicking the Speed Tab => Transmission-gtk crashes when clicking the Speed Tab [mga2]
Source RPM: oxygen-gtk3 => oxygen-gtk3-1.0.3-1.1.mga2.src.rpm

Comment 25 Olivier Delaune 2012-07-23 21:35:33 CEST
I installed oxygen-gtk3-1.0.3-1.1.mga2 and I rebooted my computer. However, transmission is still crashing when I go to Edition > Preferences > Speed tab
I got the following line during the crash
>(transmission-gtk:6008): Gtk-CRITICAL **: gtk_widget_get_style_context: assertion `GTK_IS_WIDGET (widget)' failed
>Erreur de segmentation
Is there any things to do before testing?

CC: (none) => olivier.delaune

Comment 26 Olivier Delaune 2012-07-23 21:36:02 CEST
Sorry, I forgot to mention I tested on Mageia 2 64-bits.
Comment 27 Olivier Delaune 2012-07-24 07:42:05 CEST
Oups, I have forgotten to install lib64oxygen-gtk3-1.0.3-1.1.mga2.x86_64.rpm. Now the crashes has disappear. This update fixes the problem here on Mageia 2 64-bits. Thanks.
Samuel Verschelde 2012-07-24 12:24:59 CEST

CC: (none) => stormi
Whiteboard: (none) => MGA2-64-OK

Comment 28 Malo Deniélou 2012-07-26 17:42:19 CEST
Tested ok on Mageia 2 i586.

Installed transmission-gtk3, confirmed the crash.

Installed oxygen-gtk3 and liboxygen-gtk3 from testing. No more crash Edition > Preferences > Speed tab

Thanks.

CC: (none) => malo
Whiteboard: MGA2-64-OK => MGA2-64-OK MGA2-32-OK

Comment 29 Malo Deniélou 2012-07-26 17:47:20 CEST
Validating.

Advisory in comment #24

Could sysadmin please push from core/updates_testing to core/updates.

Thank you!

Keywords: Junior_job => validated_update
CC: (none) => sysadmin-bugs

Comment 30 Thomas Backlund 2012-07-29 23:08:26 CEST
Update pushed:
https://wiki.mageia.org/en/Support/Advisories/MGAA-2012-0136

Status: NEW => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.