Bug 5032 - Buildsystem answer to failed package submit: Use --no-verbose or --progress dot:mega or --progress dot:binary for wget
Summary: Buildsystem answer to failed package submit: Use --no-verbose or --progress d...
Status: NEW
Alias: None
Product: Infrastructure
Classification: Unclassified
Component: BuildSystem (show other bugs)
Version: unspecified
Hardware: All Linux
Priority: Normal enhancement
Target Milestone: ---
Assignee: Sysadmin Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-20 10:16 CET by Olav Vitters
Modified: 2018-04-07 15:31 CEST (History)
4 users (show)

See Also:
Source RPM: mgarepo
CVE:
Status comment: A small visual improvement request


Attachments

Description Olav Vitters 2012-03-20 10:16:40 CET
Whenever "mgarepo submit" returns an error message, you see that in the output it shows wget.

Could the wget output be changed to either:
  --no-verbose
or
  --progress dot:mega
or
  --progress dot:binary
or
  progress = dot:mega in ~/.wgetrc

Currently you see wget showing loads of dots at 500MB/s. The output is only shown in case there is an error later on. There is no progress indication during the time that wget is working.

So the entire wget progress output is just noise. Wget should show if a download succeeded or not. Showing that thousands of dots just clogs up my terminal and scrollback buffer.

Obviously, this is a very low priority bug :P
Nicolas Vigier 2013-09-21 16:13:46 CEST

CC: (none) => boklm
Component: BuildSystem => RPM Packages
Version: unspecified => Cauldron
Assignee: sysadmin-bugs => boklm
Product: Infrastructure => Mageia
Source RPM: (none) => mgarepo

Nicolas Vigier 2014-03-24 10:52:42 CET

CC: boklm => (none)

Nicolas Vigier 2014-03-24 10:54:17 CET

Assignee: boklm => bugsquad

Olav Vitters 2015-10-08 10:34:22 CEST

Component: RPM Packages => BuildSystem
Version: Cauldron => unspecified
Product: Mageia => Infrastructure

Comment 1 Marja Van Waes 2016-10-09 21:17:41 CEST
What is this bug report about?

About what you see in your terminal when doing "mgarepo submit"?

Or about the error logs you can access via http://pkgsubmit.mageia.org/ ?

Keywords: (none) => NEEDINFO
CC: (none) => marja11

Comment 2 Samuel Verschelde 2016-10-11 20:44:13 CEST
It's about the output of mgarepo submit.

Component: BuildSystem => RPM Packages
Version: unspecified => Cauldron
Product: Infrastructure => Mageia

Samuel Verschelde 2016-10-11 20:44:46 CEST

Status comment: (none) => A small visual improvement request
Priority: Low => Normal
Assignee: bugsquad => mageiatools
Severity: normal => enhancement

Samuel Verschelde 2016-10-11 20:44:53 CEST

Keywords: NEEDINFO => (none)

Comment 3 papoteur 2016-10-12 07:16:14 CEST
Hello,
The download command is a parameter in mgarepo.conf, [global] section. See mgarepo.conf.example
Thus you need only add 
download-command = wget -c -O --progress dot:binary '$dest' $url
or somethink like that in mgarepo.conf.

CC: (none) => yves.brungard_mageia

Comment 4 Samuel Verschelde 2016-10-12 09:35:39 CEST
Closing then.

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 5 Olav Vitters 2016-10-13 00:03:27 CEST
Hello, I don't appreciate suddenly closing my bugreports. Everything people asked is explained in comment 0.

Status: RESOLVED => UNCONFIRMED
Component: RPM Packages => BuildSystem
Version: Cauldron => unspecified
Resolution: FIXED => (none)
Product: Mageia => Infrastructure
Ever confirmed: 1 => 0

Comment 6 Rémi Verschelde 2016-10-13 07:37:22 CEST
And bugsquad asked you for more info in comment 1, so obviously there's not *everything* in comment 0.

Comment 0 does sound like you want changes made in mgarepo, not in the buildsystem. mgarepo is a package, so to component would be RPM packages, SRPM: mgarepo, assignee mageiatools@. Please give more details.

Whiteboard: (none) => NEEDINFO

Comment 7 Olav Vitters 2016-10-13 09:01:26 CEST
It was closed when I was away.

I moved it back to the buildsystem. I filed it against the buildsystem. I said it happens when there's an error message by mgarepo submit, which submits a package to the buildsystem.

Please explain what you're on about.
Comment 8 Rémi Verschelde 2016-10-13 09:28:15 CEST
Ok, I reread all comments and finally understand what comment 0 is about. I would appreciate if you did such an effort too, which would tell you pretty clearly that Marja, Papoteur and Samuel apparently all misunderstood comment 0 (which should be a relatively good hint that it's not clear enough, but well).

So, reformulating comment 0 for bugsquad:

When you submit a package to the buildsystem (using mgarepo, but it's not dependent on the mgarepo program itself) and it fails, the buildsystem will answer with some logs about the failure which contain some wget output. *A priori* this is not something mgarepo controls, just the answer it gets from our buildsystem.

The wish expressed here is to modify whatever produces those logs to use one of the wget switches listed in comment 0.

Assignee: mageiatools => sysadmin-bugs
Whiteboard: NEEDINFO => (none)

Comment 9 Rémi Verschelde 2016-10-13 09:29:19 CEST
(Where did the REOPENED status go?)

Status: UNCONFIRMED => NEW
Summary: Wget: --no-verbose or --progress dot:mega or --progress dot:binary => Buildsystem answer to failed package submit: Use --no-verbose or --progress dot:mega or --progress dot:binary for wget
Ever confirmed: 0 => 1

Comment 10 Rémi Verschelde 2016-10-13 09:30:45 CEST
BTW a copy paste of such an error log would have go a long way to make the bug report easier to understand in the first place. Maybe for sysadmins it's crystal clear from comment 0, but after 4 years of inactivity I guess we can't just assume that they will fix such issues if bugsquad can't help push them forward.
Comment 11 Pascal Terjan 2016-10-13 09:39:45 CEST
The builsystem uses mgarepo too to download sources, so we would need to modify 
http://gitweb.mageia.org/infrastructure/puppet/tree/modules/buildsystem/templates/mgarepo.conf

CC: (none) => pterjan

Comment 12 Samuel Verschelde 2016-10-13 10:35:21 CEST
(In reply to Olav Vitters from comment #5)
> Hello, I don't appreciate suddenly closing my bugreports. Everything people
> asked is explained in comment 0.

1) Sorry that I misunderstood the bug report. 
2) What I DO appreciate on my side is when it is taken into account that when I go through dozens of old bug reports on behalf of bugsquad, in order to try and revive old bug reports and close all those that are not valid anymore, people show some forgiveness when I take the wrong action.
Comment 13 Marja Van Waes 2016-10-13 11:29:36 CEST
@ Olav,

I asked what this bug report was about in comment 2, because I had seen in the history that, while it was originally filed against the BuildSystem,

on 2013-09-21, boklm changed that into the mgarepo package
on 2015-10-08 you changed that back into the BS again. 

Both times, there was no explanation at all why the component was changed.

Note that neither papoteur nor me have the right to push packages, so some things that are obvious to you are _not_ obvious to us. The person who triaged most bugs in Mageia, leuhmanu, never pushed a package, either.

(In reply to Pascal Terjan from comment #11)
> The builsystem uses mgarepo too to download sources, so we would need to
> modify 
> http://gitweb.mageia.org/infrastructure/puppet/tree/modules/buildsystem/
> templates/mgarepo.conf

@ Pascal,

Thanks for the explanation. 

@ Pascal & Papoteur,

I'm still wondering why boklm thought it was the mgarepo package itself that needed changing. Is there a default setting or something in the example config file that had better be improved??
Comment 14 Pascal Terjan 2016-10-13 12:39:59 CEST
I guess what we have in puppet is based on the default config file at that time.

I am not sure why the behaviour is different on the buildsystem, maybe because wget notices there is no terminal?
Comment 15 Pascal Terjan 2016-10-13 16:05:46 CEST
Yes it's because there is no tty:

The "bar" indicator is used by default.  It draws an ASCII progress bar graphics (a.k.a "thermometer" display) indicating the status of retrieval.  If the output is not a TTY, the "dot" bar will be used by default.
Comment 16 papoteur 2018-04-07 15:31:50 CEST
@Pascal,
Do you think that mgarepo.conf in the package has to be changed?

Note You need to log in before you can comment on or make changes to this bug.