Bug 4927 - %debug_package_and_restore breaks rpm testsuite
Summary: %debug_package_and_restore breaks rpm testsuite
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Thierry Vignaud
QA Contact:
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-03-13 16:58 CET by Thierry Vignaud
Modified: 2015-06-21 12:56 CEST (History)
5 users (show)

See Also:
Source RPM: rpm-mageia-setup-build
CVE:
Status comment:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Thierry Vignaud 2012-03-13 16:58:48 CET 
I've packaged (not yet uploaded) fakechroot in order to make rpm's testsuite works.
However we still have one failure because of rpm-mageia-setup-build.
rpmspec is new since rpm-4.9.0[1].
Compare:

$ rpmspec --define "debug_package_and_restore %nil"  -q --qf "%{name}"  /root/rpmbuild/BUILD/rpm-4.9.1.2/tests/data/SPECS/hello.spec;echo
hello
$ rpmspec -q --qf "%{name}"  /root/rpmbuild/BUILD/rpm-4.9.1.2/tests/data/SPECS/hello.spec;echo
hellohello-debughello-__restore__

RH has a similar debug packaging system, however it doesn't interfere with rpmspec (see FC's /usr/lib/rpm/redhat/macros)

Removing /etc/rpm/macros.d/20build.macros make rpm's testsuite to pass but of course that's not an option on the BS.


[1] new as in "spec file query support has been split to
    a new "rpmspec" cli utility and enhanced in many ways.
    This also means the main rpm/rpmquery executables no
    longer need to link to librpmbuild"
Thierry Vignaud 2012-03-13 16:58:55 CET

CC: (none) => pterjan

Thierry Vignaud 2012-03-13 16:59:07 CET

CC: (none) => anssi.hannula

Thierry Vignaud 2012-03-13 16:59:15 CET

CC: (none) => misc

Thierry Vignaud 2012-03-13 16:59:27 CET

CC: (none) => tmb

Comment 1 Thierry Vignaud 2012-03-13 16:59:55 CET 
CCing commiters

CC: (none) => boklm

Thierry Vignaud 2012-03-13 17:00:08 CET

CC: (none) => mageia

Comment 2 Thierry Vignaud 2012-03-13 17:03:11 CET 
It's the following line that cause the failure
%install %{?_enable_debug_packages:%{?buildsubdir:%{debug_package_and_restore}}}\
(works fine with "%install \")

In order to test, just unpack the rpm sources, go into tests and run the following:
$ /usr/bin/autom4te --language=autotest rpmquery.at > /tmp/t.sh
$ sh /tmp/t.sh 
(...)
  4: rpmspec -q   FAILED (rpmquery.at:67)
(...)

Note that without fakechroot, you'll see another one
Comment 3 Marja Van Waes 2012-05-26 13:05:12 CEST 
Hi,

This bug was filed against cauldron, but we do not have cauldron at the moment.

Please report whether this bug is still valid for Mageia 2.

Thanks :)

Cheers,
marja

Keywords: (none) => NEEDINFO

D Morgan 2013-09-17 23:48:19 CEST

Assignee: dmorganec => thierry.vignaud

Nicolas Vigier 2014-03-24 10:52:25 CET

CC: boklm => (none)

Samuel Verschelde 2015-05-03 12:57:03 CEST

Keywords: NEEDINFO => (none)

Comment 4 Thierry Vignaud 2015-05-03 16:12:02 CEST 
Fixed in my local git

Keywords: (none) => PATCH

Comment 5 Thierry Vignaud 2015-05-19 11:27:13 CEST 
Closing, waiting for mga6 to push it

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 6 Mageia Robot 2015-06-21 12:56:29 CEST 
commit 83d87c53543c68e3c86619f0cc9275c3805617d0
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Sat May 2 09:34:59 2015 +0200

    kill redondant/unmainted macro (mga#4927)
    
    better use upstream macro
---
 Commit Link:
   http://gitweb.mageia.org/software/rpm/rpm-setup/commit/?id=83d87c53543c68e3c86619f0cc9275c3805617d0
Note You need to log in before you can comment on or make changes to this bug.