Bug 4175 - new SDL_image corrupts png of PseudoClass type
Summary: new SDL_image corrupts png of PseudoClass type
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal major
Target Milestone: ---
Assignee: Shlomi Fish
QA Contact:
URL:
Whiteboard:
Keywords: Triaged
Depends on:
Blocks:
 
Reported: 2012-01-17 22:31 CET by AL13N
Modified: 2012-01-18 23:18 CET (History)
0 users

See Also:
Source RPM: SDL_image-1.2.11-1.mga2
CVE:
Status comment:

Attachments
SDL_image-1.2.11-png_channels.patch (597 bytes, patch)
2012-01-18 23:17 CET, AL13N 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Description AL13N 2012-01-17 22:31:23 CET 
Description of problem:

manaplus is a game client that uses SDL_image, they include 2 types of png files:

skull.png PNG 32x32 32x32+0+0 8-bit DirectClass 645B 0.000u 0:00.000 
bone.png  PNG 32x32 32x32+0+0 8-bit PseudoClass 256c 1.33KB 0.000u 0:00.000

the bone one doesn't work.

SDL_image-1.2.10-1.mga2 works fine.


how to reproduce:
-----------------
1. updated cauldron
2. install manaplus
3. start manaplus

see the result:

http://imagebin.org/194159 <-- does not look good at all...
Comment 1 Manuel Hiebel 2012-01-18 04:24:22 CET 
Hi, thanks for reporting this bug.
Assigned to the package maintainer.

(Please set the status to 'assigned' if you are working on it)

Keywords: (none) => Triaged
Assignee: bugsquad => shlomif

Comment 2 Shlomi Fish 2012-01-18 08:19:45 CET 
Setting status to ASSIGNED.

Status: NEW => ASSIGNED

Comment 3 Shlomi Fish 2012-01-18 10:13:12 CET 
(In reply to comment #0)
> Description of problem:
> 
> manaplus is a game client that uses SDL_image, they include 2 types of png
> files:
> 
> skull.png PNG 32x32 32x32+0+0 8-bit DirectClass 645B 0.000u 0:00.000 
> bone.png  PNG 32x32 32x32+0+0 8-bit PseudoClass 256c 1.33KB 0.000u 0:00.000
> 
> the bone one doesn't work.
> 
> SDL_image-1.2.10-1.mga2 works fine.
> 
> 
> how to reproduce:
> -----------------
> 1. updated cauldron
> 2. install manaplus
> 3. start manaplus
> 
> see the result:
> 
> http://imagebin.org/194159 <-- does not look good at all...

Hi!

I can reproduce this here. However, the SDL_image package on Cauldron is completely unpatched, so we'll have to report it upstream.

Regards,

-- Shlomi Fish
Comment 4 AL13N 2012-01-18 12:33:23 CET 
i think i tried to report it upstream, no idea if it was successfull, i had troubles getting confirmation emails...

if it isn't fixed soon-ish, can we revert back to 1.2.10 plz?
AL13N 2012-01-18 12:37:53 CET

See Also: (none) => http://bugzilla.libsdl.org/show_bug.cgi?id=1377

Comment 5 AL13N 2012-01-18 23:17:51 CET 
Created attachment 1387 [details]
SDL_image-1.2.11-png_channels.patch

after looking around the removed patch which was upstreamed, and the code in question, i found a piece of weird code; working together with manaplus developers, i made this patch which works.

i've took the liberty of submitting it on BS as SDL_image-1.2.11-2.mga2 , so i'll just close this one...
Comment 6 AL13N 2012-01-18 23:18:15 CET 
so yeah, fixed

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED
Note You need to log in before you can comment on or make changes to this bug.