Bug 4093 - REGRESSION : Xarchiver drag&drop doesn't work correctly when dropping to directory containing spaces
Summary: REGRESSION : Xarchiver drag&drop doesn't work correctly when dropping to dire...
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: x86_64 Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Mageia Bug Squad
QA Contact:
URL: http://sourceforge.net/tracker/?func=...
Whiteboard:
Keywords: Junior_job, PATCH, UPSTREAM
Depends on:
Blocks:
 
Reported: 2012-01-10 23:21 CET by Jaromír Cápík
Modified: 2012-01-31 13:52 CET (History)
0 users

See Also:
Source RPM: xarchiver-0.5.2-8.mga1.src.rpm
CVE:
Status comment:


Attachments
xarchiver-0.5.2-whitespaces_in_path.patch (1.36 KB, patch)
2012-01-23 19:49 CET, Jaromír Cápík
Details | Diff
xarchiver-0.5.2-drag-n-drop_escaped_path.patch (780 bytes, patch)
2012-01-23 20:17 CET, Jaromír Cápík
Details | Diff
xarchiver-0.5.2-drag-n-drop_escaped_path.patch (885 bytes, patch)
2012-01-23 20:50 CET, Jaromír Cápík
Details | Diff

Description Jaromír Cápík 2012-01-10 23:21:35 CET
Description of problem:
I tried to drag&drop selected files from rar archive to Thunar. This worked well in Mandriva 2010.2, but now it unpacks the files in the same directory where the rar archive is placed. This happens only when the target directory contains spaces (maybe other separators like tabs too ... I haven't tested that). I'm pretty sure, that this worked well in the past even when there were spaces, because I haven't changed anything since the upgrade to Mageia and I used to unpack similar archives to the same directory.

Version-Release number of selected component (if applicable):
0.5.2-8.mga1

How reproducible:
always
Jaromír Cápík 2012-01-10 23:21:56 CET

Summary: REGRESION : Xarchiver drag&drop doesn't work correctly when dropping to directory containing spaces => REGRESSION : Xarchiver drag&drop doesn't work correctly when dropping to directory containing spaces

Comment 1 Manuel Hiebel 2012-01-11 00:24:50 CET
Hi, thanks for reporting this bug.

Seems it's an upstream bug:
http://sourceforge.net/tracker/?func=detail&aid=2847591&group_id=140153&atid=745600
https://bugzilla.xfce.org/show_bug.cgi?id=5187
https://bugs.gentoo.org/show_bug.cgi?id=262519

Keywords: (none) => NO_PATCH, UPSTREAM
URL: (none) => http://sourceforge.net/tracker/?func=detail&aid=2847591&group_id=140153&atid=745600
See Also: (none) => https://bugzilla.xfce.org/show_bug.cgi?id=5187

Comment 2 Jaromír Cápík 2012-01-23 19:49:07 CET
Created attachment 1409 [details]
xarchiver-0.5.2-whitespaces_in_path.patch

Hello.

I just created a patch for the issue ...
The generated command was missing quotation marks in the target path ... 
The attached patch fixes the issue in my case ...

Regards,
Jaromir.
Comment 3 Jaromír Cápík 2012-01-23 20:17:38 CET
Created attachment 1410 [details]
xarchiver-0.5.2-drag-n-drop_escaped_path.patch

The following patch fixes the issue better ... works for all characters which
need to be escaped ...

Attachment 1409 is obsolete: 0 => 1

Comment 4 Jaromír Cápík 2012-01-23 20:50:51 CET
Created attachment 1411 [details]
xarchiver-0.5.2-drag-n-drop_escaped_path.patch

The previous patch could produce unwanted memory leaks by leaving the original unescaped path unfreed.

Attachment 1410 is obsolete: 0 => 1

Comment 5 Manuel Hiebel 2012-01-23 21:11:38 CET
Great thanks, but we have no maintainer of xarchiver :/

Keywords: NO_PATCH => Junior_job, PATCH

Comment 6 Jaromír Cápík 2012-01-24 00:17:52 CET
I could possibly offer my help here ... I was about to read how to become a Mageia maintainer, but as I was a bit busy with my own distribution and other projects I couldn't find a free timeslot for that yet. We'll see in February.
Comment 7 Manuel Hiebel 2012-01-31 12:36:56 CET
This bug was fixxed by you no ? http://svnweb.mageia.org/packages/cauldron/xarchiver/current/SPECS/xarchiver.spec?r1=48700&r2=202692

Anyway, thanks :)

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 8 Jaromír Cápík 2012-01-31 13:52:50 CET
Yeah ... sorry ... I was too busy and forgot to close this bug.

Note You need to log in before you can comment on or make changes to this bug.