Bug 3699 - fwbackups fails to backup trying to open file/folder <fdopen>
Summary: fwbackups fails to backup trying to open file/folder <fdopen>
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 1
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL: https://forums.mageia.org/en/viewtopi...
Whiteboard:
Keywords: PATCH, Triaged, validated_update
Depends on:
Blocks:
 
Reported: 2011-12-11 06:10 CET by Paul Thompson
Modified: 2011-12-21 19:09 CET (History)
4 users (show)

See Also:
Source RPM: fwbackups
CVE:
Status comment:


Attachments
backup.py ... FIXED (33.80 KB, text/x-python)
2011-12-11 06:10 CET, Paul Thompson
Details

Description Paul Thompson 2011-12-11 06:10:38 CET
Created attachment 1222 [details]
backup.py ... FIXED

there is a bug that produces ...<fdopen>" failed: No such file or directory
this can be solved by opening backup.py and replacing on or near line 121 which should have "return fh.name" with "return path"
This solution was achieved by following doktor5000 suggestion.
BTW: This package was installed from the MAGeia 1 distro.
Comment 1 Manuel Hiebel 2011-12-11 11:27:49 CET
Hi, thanks for reporting this bug.
Assigned to the package maintainer.

Keywords: (none) => PATCH, Triaged
Assignee: bugsquad => anssi.hannula
Source RPM: (none) => fwbackups

Comment 2 Florian Hubold 2011-12-12 15:29:12 CET
Just adding the URL to the forum report for reference, and here's the relevant redhat bugreport https://bugzilla.redhat.com/show_bug.cgi?id=725933 and the patch: http://pkgs.fedoraproject.org/gitweb/?p=fwbackups.git;a=blob;f=fwbackups-1.43.4-fdopen.patch

Status: NEW => ASSIGNED
URL: (none) => https://forums.mageia.org/en/viewtopic.php?f=11&t=1555
CC: (none) => doktor5000
Assignee: anssi.hannula => doktor5000

Comment 3 Florian Hubold 2011-12-15 10:54:49 CET
There is now fwbackups-1.43.4-2.1.mga1 in core/updates_testing to validate
-------------------------------------------------------

Suggested advisory:
-------------------
This update addresses the following issue:

It was reported [1] that fwbackups would fail due to trying to backup files or folders referred to as "<fdopen>" (which is actually a C function) and failed to do a backup because of this. This issue has been fixed.

[1] https://forums.mageia.org/en/viewtopic.php?f=11&t=1555
-------------------------------------------------------
Steps to reproduce:

- install/update to update candidate
- try to to a backup

Assignee: doktor5000 => qa-bugs

Florian Hubold 2011-12-15 10:56:44 CET

Summary: fwbackups basic bug in backup.py AND SOLUTION => fwbackups fails to backup trying to open file/folder <fdopen>

Comment 4 claire robinson 2011-12-16 13:16:14 CET
I've not been able to reproduce this bug. I tried with manual backup to a local tar.gz and a couple of auto backups, one from a user directory and one of /var/www  both to a remote ssh tar.gz.

Are there any specific circumstances where this happens?

I notice strange permissions on the manually backup

$ ll *.gz
-rwx--x--x 1 claire claire     884648 Dec 16 11:49 Backup-OneTime-2011-12-16_11-49.tar.gz*

The auto backups are:

$ ls -l *.gz
-rw-r--r-- 1 claire claire  5613289 2011-12-16 11:58 Backup-fwbackupstest-2011-12-16_12-00.tar.gz
-rw-r--r-- 1 claire claire  1204958 2011-12-16 12:03 Backup-fwbackupstest2-2011-12-16_12-05.tar.gz


I've not updated to the new version yet.
Comment 5 Florian Hubold 2011-12-16 13:41:24 CET
(In reply to comment #0)
> 
> there is a bug that produces ...<fdopen>" failed: No such file or directory

For reference, what did you backup so you hit this bug?
Comment 6 claire robinson 2011-12-20 17:43:45 CET
Paul, could you report what conditions caused this to fail please?

As part of our QA process we attempt to recreate the failure and prove that the new package corrects it. So far I've been unable to make it fail :\
Comment 7 claire robinson 2011-12-20 17:45:13 CET
Failing that, could you please test that the updated package in core/updates_testing corrects the issue you are having and let us know which architecture you are using (i586 or x86_64)

Thanks.
Comment 8 Dave Hodgins 2011-12-21 04:45:42 CET
Testing complete on i586 for the srpm
fwbackups-1.43.4-2.1.mga1.src.rpm

On mageia 1, if you select the simple option to include disk information
when creating a backup set, then when you run the backup, the backup
completes, but does not include the disk information file, and shows
a status of error.

With the update installed, the disk information (output of fdisk -l)
is included in the backup.

Note that the option is only available if fwbackups is run as root.

Method to activate the bug found bug looking at the patch, and the
source.

CC: (none) => davidwhodgins

Comment 9 claire robinson 2011-12-21 12:35:27 CET
Well done Dave!


Using Dave's method

Before
------
Dec 21 11:26:10 :: WARNING : There was an error while performing the backup!
Dec 21 11:26:10 :: ERROR : Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/fwbackups/__init__.py", line 135, in run
    retval = self.__functorun(*self.__args)
  File "/usr/lib/python2.7/site-packages/fwbackups/operations/backup.py", line 498, in start
    self.deleteListFiles(pkgListfiles)
  File "/usr/lib/python2.7/site-packages/fwbackups/operations/backup.py", line 180, in deleteListFiles
    os.remove(file)
OSError: [Errno 2] No such file or directory: '<fdopen>'

Dec 21 11:26:10 :: INFO : Canceling the current operation!



Spelling mistake in this last INFO line, should be two L's in cancelling.

Backup contains rpm package list but no disk information.


After
-----

Dec 21 11:31:21 :: INFO : Starting one-time backup operation
Dec 21 11:31:24 :: INFO : Finished one-time backup

Backup contains Disk information and rpm package list as .txt files.


Update validated.


advisory:
-------------------
This update addresses the following issue:

It was reported [1] that fwbackups would fail due to trying to backup files or
folders referred to as "<fdopen>" (which is actually a C function) and failed
to do a backup because of this. This issue has been fixed.

[1] https://forums.mageia.org/en/viewtopic.php?f=11&t=1555
-------------------------------------------------------

SRPM: fwbackups-1.43.4-2.1.mga1.src.rpm


Could sysadmin please push from core/updates_testing to core/updates

Thankyou!

Keywords: (none) => validated_update
CC: (none) => sysadmin-bugs
Hardware: i586 => All

Comment 10 Thomas Backlund 2011-12-21 19:09:19 CET
Update pushed.

Status: ASSIGNED => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.