Bug 3248 - Clicking Add-button in mail-notification crashes the program
Summary: Clicking Add-button in mail-notification crashes the program
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 1
Hardware: x86_64 Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard:
Keywords: PATCH, Triaged, validated_update
Depends on:
Blocks:
 
Reported: 2011-11-02 02:56 CET by Kristoffer Grundström
Modified: 2012-03-07 10:53 CET (History)
8 users (show)

See Also:
Source RPM: mail-notification
CVE:
Status comment:


Attachments
This is my gdb-output from the crash (51.88 KB, text/x-log)
2011-11-02 02:57 CET, Kristoffer Grundström
Details
Proposed patch to prevent a crash when evolution is not installed (2.10 KB, patch)
2012-02-28 17:09 CET, Remco Rijnders
Details | Diff

Description Kristoffer Grundström 2011-11-02 02:56:35 CET
Description of problem: I installed mail-notification to make sure I get notified when there's a new email in my Inbox. I ran it from System -> Settings-> email-notifier & as I clicked the Add-button the program disappeared, but no crashreport by bug-buddy.

Version-Release number of selected component (if applicable): 5.4

How reproducible: Everytime I click that button.

Steps to Reproduce:
1. Open Terminal.
2. Login as root.
3. Type urpmi mail-notification & press Enter to install it.
4. After it's installed, close terminal.
5. Open System-menu & go to Settings & click email-notifier.
6. Click the Add-button to add an email-account to check.
Comment 1 Kristoffer Grundström 2011-11-02 02:57:02 CET
Created attachment 1037 [details]
This is my gdb-output from the crash
Kristoffer Grundström 2011-11-02 03:09:48 CET

Summary: Click Add-button in mail-notification crashes the program => Clicking Add-button in mail-notification crashes the program

Kristoffer Grundström 2011-11-02 03:09:58 CET

CC: (none) => kristoffer.grundstrom1983

Comment 2 Dave Hodgins 2011-11-03 03:36:33 CET
I cannot recreate the problem on my i586 system.

Due you have evolution installed?

CC: (none) => davidwhodgins

Manuel Hiebel 2011-11-10 00:43:11 CET

Keywords: (none) => NEEDINFO
Severity: critical => major

Comment 3 Kristoffer Grundström 2011-11-10 04:17:10 CET
No I don't. I even happens if I click to add an email-account in the gui.
Comment 4 Dave Hodgins 2011-11-10 05:31:05 CET
Try installing evolution, and see if that fixes the issue in the
mail-notification.
Comment 5 Kristoffer Grundström 2011-11-10 13:03:55 CET
Not to be rude or angry, but I wonder why I should install an email-program that I don't want or intend to use? I use Mozilla Thunderbird instead. Do you know any other possible solution?
Kristoffer Grundström 2011-11-10 13:04:22 CET

Severity: major => normal

Comment 6 Dave Hodgins 2011-11-10 19:57:45 CET
The reason for installing evolution (at least temporarily), is to confirm
whether or not that fixes the problem.

I haven't dug into the mail-notification program in detail, but I'm guessing
it may need some of the libraries provided by evolution, to check for new
mail.

If it does fix the problem, it will be up to the developer to decide whether
to add evolution as a requirement, or to identify which requirements of
evolution are needed by the mail-notification, and add those as
requirements.

If it doesn't fix the problem, then further debugging will be required.
Comment 7 Kristoffer Grundström 2011-11-11 16:34:59 CET
That seemed to fix it, but still I don't want to be forced to use evolution as an email-client 'cause I've had bad experience with it.
Comment 8 Dave Hodgins 2011-11-11 20:13:20 CET
(In reply to comment #7)
> That seemed to fix it, but still I don't want to be forced to use evolution as
> an email-client 'cause I've had bad experience with it.

Thanks for the test to confirm it's just a missing dependency.  You don't
need to use evolution for the mail-notification package to work, it just
had to be installed to get all of the needed dependencies.

Bug squad, if you could assign this to a developer now, it looks like the
simplest fix is to add a requires on evolution.  Better solution would
be to find out if it's evolution itself, or one of it's requires, that
is actually required.
Comment 9 Manuel Hiebel 2011-11-11 22:44:39 CET
Hi, thanks for reporting this bug.
Assigned to the package maintainer.

Kristoffer, what do you use for icon theme ?

(Also thanks to Dave ;) )

Keywords: NEEDINFO => Triaged
Assignee: bugsquad => olav

Comment 10 Kristoffer Grundström 2011-11-12 02:25:15 CET
(In reply to comment #9)
> Hi, thanks for reporting this bug.
> Assigned to the package maintainer.
> 
> Kristoffer, what do you use for icon theme ?
> 
> (Also thanks to Dave ;) )

The standard icon-theme. Ia Ora Night.
Comment 11 Olav Vitters 2011-11-12 15:09:56 CET
The evolution icon is only provided by the evolution package. My C is not good enough to write a patch for this. I'll look a bit into it, but think the only solution is to require evolution...
Comment 12 Marja Van Waes 2012-02-16 17:45:20 CET
Pinging, because nothing has happened with this report for more than 3 months, it still has the status NEW or REOPENED.

@ Olav

Please set status to ASSIGNED. If for work flow reasons you can't do that, then please put OK on the whiteboard instead.

CC: (none) => marja11

Remco Rijnders 2012-02-27 13:40:03 CET

CC: (none) => remco

Comment 13 Kristoffer Grundström 2012-02-27 19:38:39 CET
And the issue still happens.
Comment 14 Remco Rijnders 2012-02-28 17:09:48 CET
Created attachment 1653 [details]
Proposed patch to prevent a crash when evolution is not installed
Comment 15 Remco Rijnders 2012-02-28 17:11:16 CET
Olav, can you see if the attached svn diff above fixes this problem? You'll also have to package evolution.png with the package, but that seems preferrable to me over adding a require on evolution for just a single icon.
Comment 16 Olav Vitters 2012-02-28 17:17:20 CET
Remco: If you have rights, just submit an update / commit.
Remco Rijnders 2012-02-28 17:31:42 CET

CC: (none) => stormi

Comment 17 Remco Rijnders 2012-02-28 18:00:12 CET
Dear QA team / Kristoffer, please test the updated package now available in updates_testing which should solve the issue reported in this bug report.


How to test:
==============
Before installing the update, mail-notification should crash when clicking "add" in the first screen when evolution is not installed on your system. With evolution installed it should not crash.

After installing this update, mail-notification should not crash when clicking "add", no matter if evolution is or isn't installed.

Proposed advisory text:
=======================
This updates keeps mail-notification from crashing when adding a new account when the mail client 'evolution' was not installed on the system.

Keywords: (none) => PATCH
Assignee: olav => qa-bugs

Remco Rijnders 2012-02-28 18:00:30 CET

CC: (none) => olav

Comment 18 Dave Hodgins 2012-02-28 21:12:07 CET
Testing complete on i586 for the srpm
mail-notification-5.4-16.mga1.src.rpm

Without evolution installed, the prior version failed,
when selecting System/Preferences/Mail Notification in
the Gnome menu.  With the new version, it works.
Comment 19 Remco Rijnders 2012-03-06 08:26:21 CET
Hi team,

Can someone validate this update for x86_64? Alternatively, will you take my word for it as I tested it on x86_64 myself? :P
Comment 20 Dave Hodgins 2012-03-06 08:45:10 CET
Validating the update.

Could someone from the sysadmin team push the srpm
from Core Updates Testing to Core Updates.

Advisory: This updates keeps mail-notification from crashing when
adding a new account when the mail client 'evolution' was not
installed on the system.

https://bugs.mageia.org/show_bug.cgi?id=3248

Keywords: (none) => validated_update
CC: (none) => sysadmin-bugs

Comment 21 Thomas Backlund 2012-03-07 10:53:51 CET
Update pushed

Status: NEW => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.