Bug 30396 - Adwaita theme, some GUIs can't find some icons because they have an additional "-symbolic" in their names
Summary: Adwaita theme, some GUIs can't find some icons because they have an addition...
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Jani Välimaa
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-08 01:23 CEST by Ben McMonagle
Modified: 2022-10-11 06:15 CEST (History)
3 users (show)

See Also:
Source RPM: adwaita-icon-theme-42.0-1.mga9, rpmdrake-6.32-2.mga9
CVE:
Status comment:


Attachments

Description Ben McMonagle 2022-05-08 01:23:07 CEST
Description of problem: some drakrpm GUIs are missing icons:

# drakrpm
~
(drakrpm:278348): Gtk-WARNING **: 11:09:35.226: Error loading theme icon 'dialog-information' for stock: Icon 'dialog-information' not present in theme Adwaita

(drakrpm:278348): Gtk-WARNING **: 11:09:35.246: Error loading theme icon 'edit-find' for stock: Icon 'edit-find' not present in theme Adwaita

(drakrpm:278348): Gtk-WARNING **: 11:09:35.247: Error loading theme icon 'edit-clear' for stock: 

~

# drakrpm-editmedia 
~

(drakrpm-editmedia:301696): Gtk-WARNING **: 11:14:24.537: Error loading theme icon 'go-up' for stock: Icon 'go-up' not present in theme Adwaita

(drakrpm-editmedia:301696): Gtk-WARNING **: 11:14:24.539: Error loading theme icon 'go-down' for stock: Icon 'go-down' not present in theme Adwaita






Version-Release number of selected component (if applicable):


How reproducible: every time


Steps to Reproduce:
1.invoke drakrpm (drakrpm-editmedia) from virtual terminal 
2.note gtk warnings
3.note icons missing from GUIs
Ben McMonagle 2022-05-08 01:26:00 CEST

Source RPM: (none) => adwaita-icon-theme-42.0-1.mga9.noarch / adwaita-gtk2-theme-3.28-9.mga9.x86_64

Comment 1 Marja Van Waes 2022-05-10 23:04:12 CEST
Confirming the issue. 

(In reply to Ben McMonagle from comment #0)
> Description of problem: some drakrpm GUIs are missing icons:
> 
> # drakrpm
> ~
> (drakrpm:278348): Gtk-WARNING **: 11:09:35.226: Error loading theme icon
> 'dialog-information' for stock: Icon 'dialog-information' not present in
> theme Adwaita
> 
> (drakrpm:278348): Gtk-WARNING **: 11:09:35.246: Error loading theme icon
> 'edit-find' for stock: Icon 'edit-find' not present in theme Adwaita
> 
> (drakrpm:278348): Gtk-WARNING **: 11:09:35.247: Error loading theme icon
> 'edit-clear' for stock: 

adwaita-icon-theme does have dialog-information-symbolic, edit-find-symbolic and edit-clear-all-symbolic svg icons. (The png ones have even two "symbolic"s in their names)
 
> 
> ~
> 
> # drakrpm-editmedia 
> ~
> 
> (drakrpm-editmedia:301696): Gtk-WARNING **: 11:14:24.537: Error loading
> theme icon 'go-up' for stock: Icon 'go-up' not present in theme Adwaita
> 
> (drakrpm-editmedia:301696): Gtk-WARNING **: 11:14:24.539: Error loading
> theme icon 'go-down' for stock: Icon 'go-down' not present in theme Adwaita


adwaita-icon-theme does have go-up-symbolic.svg and go-down-symbolic.svg icons.

(The png ones have an additional ".symbolic" in their names)

Assigning to the registered adwaita-icon-theme maintainer. CC'ing the mageia tools maintainers and the rpmdrake maintainer.

Source RPM: adwaita-icon-theme-42.0-1.mga9.noarch / adwaita-gtk2-theme-3.28-9.mga9.x86_64 => adwaita-icon-theme-42.0-1.mga9, rpmdrake-6.32-2.mga9
CC: (none) => mageiatools, marja11, thierry.vignaud
Summary: Adwaita theme, some drakrpm GUIs are missing icons => Adwaita theme, some drakrpm GUIs can't find some icons because they have an additional ".symbolic" in their names
Assignee: bugsquad => jani.valimaa

Marja Van Waes 2022-05-10 23:04:53 CEST

Summary: Adwaita theme, some drakrpm GUIs can't find some icons because they have an additional ".symbolic" in their names => Adwaita theme, some drakrpm GUIs can't find some icons because they have an additional "-symbolic" in their names

Comment 2 Ben McMonagle 2022-05-11 00:05:51 CEST
can add:
 
$ gnome-control-settings 

missing an <- icon when using Adwaita theme also
Ben McMonagle 2022-05-11 00:07:08 CEST

Summary: Adwaita theme, some drakrpm GUIs can't find some icons because they have an additional "-symbolic" in their names => Adwaita theme, some GUIs can't find some icons because they have an additional "-symbolic" in their names

Comment 3 Ben McMonagle 2022-05-11 00:23:02 CEST
oops,: 
$ gnome-control-centre.

or "settings" from the Gnome exit menu
Comment 4 Jani Välimaa 2022-05-11 21:44:19 CEST
IMO this is not a bug in adwaita-icon-theme, but judge by yourself.

Gnome have not used fullcolor icons in UI since a long time and uses symbolic icons instead. See https://developer.gnome.org/hig/guidelines/ui-icons.html. App icons is a different story.

Adwaita icon theme is developed for Gnome and thus 'obsolete' UI icons are dropped. It's up to app developers to make app UIs to work also with modern symbolic icons. And themes with only symbolic UI icons available.

A hackish workaround for the issue would be adding symlinks with 'legacy' names, but a real fix would be re-designing and updating our tools to use symbolic icons or labels in UI.

The reason why there's 'an extra -symbolic' in .png icon file names is because they're converted/generated from .svg with a gtk-encode-symbolic-svg tool. All generated files have the extension .symbolic.png to distinguish them from ordinary pngs.

foobar-symbolic.svg => foobar-symbolic.symbolic.png

Blame Gnome upstream about the naming conventions. Icon name "foobar-symbolic" tells it's a symbolic one. Same as if the file name ends with '-symbolic.svg', '.symbolic.png' and a couple of others.
Jani Välimaa 2022-10-02 18:28:03 CEST

See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=30921

Comment 5 Jani Välimaa 2022-10-09 19:14:11 CEST
Is this bug still valid? I wasn't able to reproduce this with mga8 -> cauldron update.
Comment 6 Ben McMonagle 2022-10-11 06:15:03 CEST
checked with a new GNOME netinstall today -ok

making as fixed

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.