Bug 2946 - showFoto crashes when I cross Distortion in Automatic Correction
Summary: showFoto crashes when I cross Distortion in Automatic Correction
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 1
Hardware: All Linux
Priority: Normal normal
Target Milestone: Mageia 1
Assignee: QA Team
QA Contact:
URL:
Whiteboard:
Keywords: validated_update
Depends on:
Blocks:
 
Reported: 2011-10-05 23:06 CEST by Robert Ottlovich
Modified: 2011-10-20 12:25 CEST (History)
4 users (show)

See Also:
Source RPM: digikam-1.9.0-1.mga1.src.rpm
CVE:
Status comment:


Attachments
KCrash report (7.80 KB, application/octet-stream)
2011-10-05 23:23 CEST, Robert Ottlovich
Details
list of packages update, terminal output (11.36 KB, text/plain)
2011-10-06 19:14 CEST, Robert Ottlovich
Details
badly corrected image in showfoto (75.52 KB, image/jpeg)
2011-10-06 19:15 CEST, Robert Ottlovich
Details
terminal output with working plugin (1.57 KB, text/plain)
2011-10-14 08:30 CEST, Robert Ottlovich
Details

Description Robert Ottlovich 2011-10-05 23:06:51 CEST
Description of problem:
showFoto crashes when I click on Distortion in Automatic Correction window

Version-Release number of selected component (if applicable):
showFoto 1.9.0 with lensfun 0.2.5

How reproducible:
Always reproducible when clicking on Distorsion.

Steps to Reproduce:
1. Open a photo in showFoto
2. Feljavítás â¹ Lencsék â¹ Automatikus korrekció (Automatic correction)
3. Click on Distorsion (Torzítás)
4. showFoto crashes with segmentation fault.

kckrash + image in .tar:
http://www.4shared.com/file/OfssbZaK/showfoto-err.html
Comment 1 Robert Ottlovich 2011-10-05 23:08:54 CEST
There was no problem in Mandriva in showFoto 1.3.

Target Milestone: --- => Mageia 2

Comment 2 Robert Ottlovich 2011-10-05 23:20:41 CEST
The terminal output:

$ showfoto
KGlobal::locale::Warning your global KLocale is being recreated with a valid main component instead of a fake component, this usually means you tried to call i18n related functions before your main component was created. You should not do that since it most likely will not work 
Time elapsed: 39 ms
Model: Time elapsed: 1 ms
TextureColorizer::setSeaFileLandFile: Time elapsed: 10 ms
QFSFileEngine::open: No file name specified
Object::connect: No such slot DigikamEnhanceImagePlugin::LensAutoFixTool::slotUpdateSpotInfo(const Digikam::DColor&, const QPoint&)
Object::connect:  (receiver name: 'lensautocorrection')
Object::connect: No such slot DigikamEnhanceImagePlugin::LensAutoFixTool::slotUpdateSpotInfo(const Digikam::DColor&, const QPoint&)
Object::connect:  (receiver name: 'lensautocorrection')
QSocketNotifier: Invalid socket 20 and type 'Read', disabling...
KCrash: Application 'showfoto' crashing...
KCrash: Attempting to start /usr/lib/kde4/libexec/drkonqi from kdeinit
sock_file=/home/somebody/.kde4/socket-localhost/kdeinit4__0
Comment 3 Robert Ottlovich 2011-10-05 23:23:56 CEST
Created attachment 902 [details]
KCrash report
Manuel Hiebel 2011-10-06 01:37:48 CEST

Assignee: bugsquad => balcaen.john
Source RPM: (none) => digikam

Comment 4 John Balcaen 2011-10-06 02:56:48 CEST
Ok it seems similar to kde #260179, i'll try to reproduce locally & see if the workaround suggested by caulier works as expected.

CC: (none) => balcaen.john
See Also: (none) => https://bugs.kde.org/show_bug.cgi?id=261079

John Balcaen 2011-10-06 02:57:58 CEST

Target Milestone: Mageia 2 => Mageia 1
Source RPM: digikam => digikam-1.9.0-1.mga1.src.rpm

Comment 5 Robert Ottlovich 2011-10-06 09:04:24 CEST
Is this problem in KDE, isn't it? I have KDE 4.6.3. After update maybe works?
Comment 6 John Balcaen 2011-10-06 11:16:48 CEST
the problem is in the digikam requirement for lensfun library.
We're providing the last stable version of lensfun when in fact digikam (since 1.8.0 at least according to the buildreport) need a « trunk » version of lensfun.
I'll push an new package on core/updates_testing for that.

Of course you can still upgrade your mageia since we're providing KDE SC 4.6.5 since some days :p

Regards,
Comment 7 John Balcaen 2011-10-06 13:56:57 CEST
I did push a new package on core/updates_testing.
Could you please test it & report ?
Comment 8 Robert Ottlovich 2011-10-06 17:01:37 CEST
Sorry I am. No submenu in Colors (Színek) and next Correction? (Feljavítás) in showFoto. It seems digiKam works, but I don't use it in real.
It seems KDE usees non-compatible library. Do I have to update KDE to 4.6.5?
Is this version of KDE stable?

By the way 
What packeges do I have to refresh?
Only digikam and showfoto?
Comment 9 Robert Ottlovich 2011-10-06 19:12:03 CEST
Thanks. You was fast.

I think digiKam and showFoto work fine BUT camera database is not ready. As seen in image. 
When I choose autodetect by metadata info (it says: Canon PS A510 with Standard lens), the image goes bad.
When I try to select values manually there's no Standard lens item in this camera. No near, similar values: Canon Zoom lens 4Ã 5.0-23,2mm 1:2.6-5.5.
As I see the lensfun package is the latest version. In the older version the Standard lens was satisfying because it told 5.8-23.2mm what is true.

List all packages updated, my remark and the image is in attechment.
Comment 10 Robert Ottlovich 2011-10-06 19:14:22 CEST
Created attachment 909 [details]
list of packages update, terminal output
Comment 11 Robert Ottlovich 2011-10-06 19:15:16 CEST
Created attachment 910 [details]
badly corrected image in showfoto
Comment 12 John Balcaen 2011-10-06 19:20:18 CEST
Well here there's nothing i can do if autodetect does not work as expected, it's due to the internal lensfun library.
Comment 13 John Balcaen 2011-10-08 17:08:17 CEST
Hello qa :)
Could you please test that the crash spotted by Robert is fixed & then validate the upload of this new digikam package ?

Advisory 
« This package fix a crash which could occurs when using lensfun functionnality ( Distortion & Automatic Correction Window »

srpm :

list of i586 rpms :

digikam-1.9.0-1.1.mga1.i586.rpm
libdigikamcore1-1.9.0-1.1.mga1.i586.rpm
libdigikamdatabase1-1.9.0-1.1.mga1.i586.rpm
libdigikam-devel-1.9.0-1.1.mga1.i586.rpm
showfoto-1.9.0-1.1.mga1.i586.rpm

list of x86_64 rpms :
digikam-1.9.0-1.1.mga1.x86_64.rpm
lib64digikamcore1-1.9.0-1.1.mga1.x86_64.rpm
lib64digikamdatabase1-1.9.0-1.1.mga1.x86_64.rpm
lib64digikam-devel-1.9.0-1.1.mga1.x86_64.rpm
showfoto-1.9.0-1.1.mga1.x86_64.rpm

Assignee: balcaen.john => qa-bugs

Comment 14 John Balcaen 2011-10-08 17:09:24 CEST
srpm is digikam-1.9.0-1.1.mga1.src.rpm
Comment 15 Derek Jennings 2011-10-08 18:49:40 CEST
Sorry, I am unable to replicate the problem on x86_64
Installed packages are :-
media/core/release/showfoto-1.9.0-1.mga1.x86_64.rpm
media/core/release/digikam-1.9.0-1.mga1.x86_64.rpm                                                             
media/core/release/lib64digikamdatabase1-1.9.0-1.mga1.x86_64.rpm                                               
media/core/release/lib64digikamcore1-1.9.0-1.mga1.x86_64.rpm
media/core/release/lensfun-0.2.5-1.mga1.x86_64.rpm
media/core/release/lib64lensfun0-0.2.5-1.mga1.x86_64.rpm

To try to replicate I am opening an image, clicking on Enhance>Lens>Auto-Correction
The distortion checkbox is greyed out until I choose a different lens after which setting or unsetting distortion does not cause a segfault.
If I select Enhance>Lens>Distortion there is no segfault either.

Upgraded to the latest packages in testing
media/core/updates_testing/lib64digikamcore1-1.9.0-1.1.mga1.x86_64.rpm
media/core/updates_testing/lib64digikamdatabase1-1.9.0-1.1.mga1.x86_64.rpm
media/core/updates_testing/showfoto-1.9.0-1.1.mga1.x86_64.rpm
media/core/updates_testing/digikam-1.9.0-1.1.mga1.x86_64.rpm

Everything worked exactly the same so at least no regression has been introduced.

CC: (none) => derekjenn

Comment 16 claire robinson 2011-10-08 18:58:25 CEST
x86_64:

I'm not able to reproduce this. Enhance => Auto-Correction.. all the lens correction options are checked but greyed out and unclickable.

There is a message at the bottom that the lens corrections depend on lensfun libraries and a link to their website. I have lensfun installed.

# rpm -qa | grep lensfun
lib64lensfun0-0.2.5-1.mga1
lensfun-0.2.5-1.mga1
lib64lensfun-devel-0.2.5-1.mga1


After update nothing has changed.
Comment 17 claire robinson 2011-10-08 18:59:58 CEST
Oh snap, Derek!
Comment 18 claire robinson 2011-10-08 19:01:27 CEST
Robert can you test this please?
Comment 19 claire robinson 2011-10-13 01:56:17 CEST
I get the same results testing i586

Robert, as you were able to reproduce the bug can you please check that this new package corrects it and post your findings here.

Thankyou.
Comment 20 Robert Ottlovich 2011-10-14 08:29:25 CEST
It seems it's allright or not!!!
Program runs good. Plugin runs "as is".
Problems:
1. If Auto correction is on (by EXIF data) bad result comes.
2. If I set manual, I cannot see proper items to set. Only similar.
3. If manual is on, the three sliders (which were grayed out in auto) now movable but don't do nothing.(Gyújtótávolság, Rekesz, A tárgy távolsága; focal length, aperture, object distance)
4. Language localization error in showFoto: Menu â¹ "Ãctalakítás" is a typo (where rotaton and mirroring items are). Corrected word is "Ãtalakítás".

The following terminal output (showfoto-corr-term.txt) was on GNOME.
â run showfoto
â open a photo
â create lens correction
â save image
â close program


Bye
Comment 21 Robert Ottlovich 2011-10-14 08:30:44 CEST
Created attachment 960 [details]
terminal output with working plugin
Comment 22 John Balcaen 2011-10-14 11:45:54 CEST
The question is to know if it's crashing or not in fact here because that's the original bug : showfoto was crashing (& then you might loose data because of the crash).
Comment 23 claire robinson 2011-10-14 13:34:42 CEST
Robert, if you can please create separate bugs for the other issues and list them here I will validate this update with the crash fix.

John will still look at them but has to prioritise the more serious bugs in his list first.

Thankyou for testing this and for the bug reports.
Comment 24 Robert Ottlovich 2011-10-14 20:50:37 CEST
There was no crash with these new packages. (The bad functionality of the plugin is an other question.)
Comment 25 claire robinson 2011-10-15 10:43:42 CEST
Thankyou Robert. I understand your frustration. If you create the bug reports though they will be fixed.


Advisory 
« This package fix a crash in showfoto which could occur when using lensfun functionality ( Distortion & Automatic Correction Window ) »

SRPM: digikam-1.9.0-1.1.mga1.src.rpm


Could sysadmin please push from core/updates_testing to core/updates

Thankyou!

Keywords: (none) => validated_update
CC: (none) => sysadmin-bugs
Hardware: i586 => All

Comment 26 Thomas Backlund 2011-10-19 22:47:35 CEST
Update pushed.

Status: NEW => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED

Comment 27 Robert Ottlovich 2011-10-20 11:30:26 CEST
Sorry to interrupt.
These were the files which I updated:
digikam-1.9.0-1.1.mga1.i586.rpm
libdigikamcore1-1.9.0-1.1.mga1.i586.rpm
libdigikamdatabase1-1.9.0-1.1.mga1.i586.rpm
showfoto-1.9.0-1.1.mga1.i586.rpm

So I think these all four packages have to be pushed from core/updates_testing to core/updates. Not only digikam main package!
Comment 28 John Balcaen 2011-10-20 12:25:55 CEST
(In reply to comment #27)
> Sorry to interrupt.
[..]
> 
> So I think these all four packages have to be pushed from core/updates_testing
> to core/updates. Not only digikam main package!

The package mentionned in comment 25  is not the digikam main package but the src.rpm which is used by sysadmin script to push *all* related packages for all arch (currently i586 & x86_64 )

Regards,

Note You need to log in before you can comment on or make changes to this bug.