Bug 29438 - Filezilla locale detection fail with default proftpd config
Summary: Filezilla locale detection fail with default proftpd config
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 8
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: All Packagers
QA Contact:
URL: https://github.com/proftpd/proftpd/is...
Whiteboard:
Keywords:
Depends on: 29449
Blocks:
  Show dependency treegraph
 
Reported: 2021-09-05 07:49 CEST by Raphael Gertz
Modified: 2021-09-23 09:18 CEST (History)
5 users (show)

See Also:
Source RPM: proftpd-1.3.7a-2.mga8
CVE:
Status comment:


Attachments

Description Raphael Gertz 2021-09-05 07:49:17 CEST
Description of problem:
When connecting with default configuration, filezilla will incorrectly fail to determine locale.

Filezilla only try server features detection on first connection attempt and keept it cached afterwards.

This comes from the directive MultilineRFC2228 enabled by default that makes
proftpd issue a not rfc compliant answer.

Debian had same default configuration issue, see url.

Version-Release number of selected component (if applicable):
proftpd-1.3.7a-2.mga8

How reproducible:
Always
With filezilla you need to check "View log details" checkbox in log contextual menu before connection attempt and restart it completely between attempts.

Steps to Reproduce:
1. # urpmi proftpd filezilla
2. # systemctl start proftpd.service
3. $ filezilla
4. enable "View log details" in log contextual menu
5. connect to 127.0.0.1:21
6. see "Status: Server does not support non-ASCII characters." in journal log because answer to FEAT command is invalid (prefixed by 211- instead of only space)
Comment 1 Raphael Gertz 2021-09-05 08:01:27 CEST
I have uploaded a fixed package for Mageia 8.

You can test this by installing and see that it don't have a failing sysv init script anymore.

Suggested advisory:
========================

Updated proftpd packages to fix not rfc compliant feat answer:

Ftp clients like filezilla fails to detect locale with in log :
"Status: Server does not support non-ASCII characters."

This comes from proftpd MultilineRFC2228 directive enabled by default.

Without this directive  Filezilla is able to enable utf8 options correctly.

Instead of beeing able to enable UTF8 opts

Similar issue was present in an other distribution and they fixed it by disabling MultilineRFC2228 directive.

References:
https://github.com/proftpd/proftpd/issues/1085
========================

Updated packages in core/updates_testing:
========================
proftpd-1.3.7a-3.mga8
proftpd-debuginfo-1.3.7a-3.mga8
proftpd-debugsource-1.3.7a-3.mga8
proftpd-devel-1.3.7a-3.mga8
proftpd-mod_autohost-1.3.7a-3.mga8
proftpd-mod_autohost-debuginfo-1.3.7a-3.mga8
proftpd-mod_ban-1.3.7a-3.mga8
proftpd-mod_ban-debuginfo-1.3.7a-3.mga8
proftpd-mod_case-1.3.7a-3.mga8
proftpd-mod_case-debuginfo-1.3.7a-3.mga8
proftpd-mod_ctrls_admin-1.3.7a-3.mga8
proftpd-mod_ctrls_admin-debuginfo-1.3.7a-3.mga8
proftpd-mod_ifsession-1.3.7a-3.mga8
proftpd-mod_ifsession-debuginfo-1.3.7a-3.mga8
proftpd-mod_ldap-1.3.7a-3.mga8
proftpd-mod_ldap-debuginfo-1.3.7a-3.mga8
proftpd-mod_load-1.3.7a-3.mga8
proftpd-mod_load-debuginfo-1.3.7a-3.mga8
proftpd-mod_memcache-1.3.7a-3.mga8
proftpd-mod_memcache-debuginfo-1.3.7a-3.mga8
proftpd-mod_quotatab-1.3.7a-3.mga8
proftpd-mod_quotatab-debuginfo-1.3.7a-3.mga8
proftpd-mod_quotatab_file-1.3.7a-3.mga8
proftpd-mod_quotatab_file-debuginfo-1.3.7a-3.mga8
proftpd-mod_quotatab_ldap-1.3.7a-3.mga8
proftpd-mod_quotatab_ldap-debuginfo-1.3.7a-3.mga8
proftpd-mod_quotatab_radius-1.3.7a-3.mga8
proftpd-mod_quotatab_radius-debuginfo-1.3.7a-3.mga8
proftpd-mod_quotatab_sql-1.3.7a-3.mga8
proftpd-mod_quotatab_sql-debuginfo-1.3.7a-3.mga8
proftpd-mod_radius-1.3.7a-3.mga8
proftpd-mod_radius-debuginfo-1.3.7a-3.mga8
proftpd-mod_ratio-1.3.7a-3.mga8
proftpd-mod_ratio-debuginfo-1.3.7a-3.mga8
proftpd-mod_rewrite-1.3.7a-3.mga8
proftpd-mod_rewrite-debuginfo-1.3.7a-3.mga8
proftpd-mod_sftp-1.3.7a-3.mga8
proftpd-mod_sftp-debuginfo-1.3.7a-3.mga8
proftpd-mod_sftp_pam-1.3.7a-3.mga8
proftpd-mod_sftp_pam-debuginfo-1.3.7a-3.mga8
proftpd-mod_sftp_sql-1.3.7a-3.mga8
proftpd-mod_sftp_sql-debuginfo-1.3.7a-3.mga8
proftpd-mod_shaper-1.3.7a-3.mga8
proftpd-mod_shaper-debuginfo-1.3.7a-3.mga8
proftpd-mod_site_misc-1.3.7a-3.mga8
proftpd-mod_site_misc-debuginfo-1.3.7a-3.mga8
proftpd-mod_sql-1.3.7a-3.mga8
proftpd-mod_sql-debuginfo-1.3.7a-3.mga8
proftpd-mod_sql_mysql-1.3.7a-3.mga8
proftpd-mod_sql_mysql-debuginfo-1.3.7a-3.mga8
proftpd-mod_sql_passwd-1.3.7a-3.mga8
proftpd-mod_sql_passwd-debuginfo-1.3.7a-3.mga8
proftpd-mod_sql_postgres-1.3.7a-3.mga8
proftpd-mod_sql_postgres-debuginfo-1.3.7a-3.mga8
proftpd-mod_sql_sqlite-1.3.7a-3.mga8
proftpd-mod_sql_sqlite-debuginfo-1.3.7a-3.mga8
proftpd-mod_tls-1.3.7a-3.mga8
proftpd-mod_tls-debuginfo-1.3.7a-3.mga8
proftpd-mod_tls_memcache-1.3.7a-3.mga8
proftpd-mod_tls_memcache-debuginfo-1.3.7a-3.mga8
proftpd-mod_tls_shmcache-1.3.7a-3.mga8
proftpd-mod_tls_shmcache-debuginfo-1.3.7a-3.mga8
proftpd-mod_unique_id-1.3.7a-3.mga8
proftpd-mod_unique_id-debuginfo-1.3.7a-3.mga8
proftpd-mod_vroot-1.3.7a-3.mga8
proftpd-mod_vroot-debuginfo-1.3.7a-3.mga8
proftpd-mod_wrap-1.3.7a-3.mga8
proftpd-mod_wrap-debuginfo-1.3.7a-3.mga8
proftpd-mod_wrap_file-1.3.7a-3.mga8
proftpd-mod_wrap_file-debuginfo-1.3.7a-3.mga8
proftpd-mod_wrap_sql-1.3.7a-3.mga8
proftpd-mod_wrap_sql-debuginfo-1.3.7a-3.mga8

Source RPMs: 
proftpd-1.3.7a-3.mga8.src.rpm
Comment 2 Raphael Gertz 2021-09-05 08:02:16 CEST
Assign to qa-bugs@ml.mageia.org if you are fine with the change.
Comment 3 Raphael Gertz 2021-09-05 08:02:32 CEST
I did the same change in cauldron package.
Comment 5 Marja Van Waes 2021-09-05 19:17:36 CEST
(In reply to Raphael Gertz from comment #2)
> Assign to qa-bugs@ml.mageia.org if you are fine with the change.

When who is fine with it? You didn't CC anyone, "nobody" maintains proftpd and the current assignee (Bugsquad) doesn't know too much about packaging ;-)

Unless you think fellow packagers won't like your fix (in which case you should send an RFC - request for comments - to dev ml), it would have been fine to assign to QA team yourself, this report contains a way to reproduce the issue, the list of updated (S)RPMs and an advisory, that's all they need :-D
If the change fails their tests, then QA will assign this report back to you.

Please assign this report to QA if you don't need to mail dev ml.

CC: (none) => marja11
Source RPM: (none) => proftpd-1.3.7a-2.mga8
Assignee: bugsquad => mageia

Comment 6 Raphael Gertz 2021-09-06 14:29:58 CEST
Sorry before I was able to get maintainer with ":maint" on irc, but it's not working anymore and I don't know where to look now :'(

I don't think anyone will not like my change, my moto as packager is getting the distribution I want for myself that feet most needs of others :)

I just wanted to avoid the maintainer to complain by short circuiting him, like it happened in the past.

That way he had a chance to improve or reject my changes.

Assigning to qa as nobody complained ^_^

CC: (none) => mageia
Assignee: mageia => qa-bugs

Comment 7 Marja Van Waes 2021-09-06 15:15:28 CEST
(In reply to Raphael Gertz from comment #6)
> Sorry before I was able to get maintainer with ":maint" on irc, but it's not
> working anymore and I don't know where to look now :'(
> 

Sophie (who replied to ":maint") is gone, but we now have leuhmanu's [mbot can help you:

2021:09:06:15:14 <@marja> ,maint proftpd
2021:09:06:15:14 < [mbot> maint: ['nobody'] (srpm: proftpd)


mgarepo can help, too:

[marja@localhost ~]$ mgarepo maintdb get proftpd
nobody
Comment 8 Dave Hodgins 2021-09-06 17:55:27 CEST
Just fyi, there is also http://maintdb.mageia.org/proftpd to determine the
registered maintainer.

CC: (none) => davidwhodgins

Thomas Backlund 2021-09-10 13:20:22 CEST

Depends on: (none) => 29449

Thomas Backlund 2021-09-10 13:20:51 CEST

Assignee: qa-bugs => pkg-bugs

Comment 9 Marja Van Waes 2021-09-10 15:32:59 CEST
Hi Thomas :-)

Shouldn't the advisory of this bug report, without the (S)RPMs list, be merged with the advisory of bug 29449?

The changes that rapsys made in basic.conf are still there ;-)

I don't understand why this report got assigned to pkg-bugs ml, now that this issue is already fixed, also present in proftpd-1.3.7a-3.1.mga8 and only waiting for the fix to be tested

CC: (none) => nicolas.salguero, tmb

Comment 10 Marja Van Waes 2021-09-10 15:33:53 CEST
a/also present/the fix also present/
Comment 11 Thomas Backlund 2021-09-10 16:06:41 CEST
(In reply to Marja Van Waes from comment #9)
> Hi Thomas :-)
> 
> Shouldn't the advisory of this bug report, without the (S)RPMs list, be
> merged with the advisory of bug 29449?
> 

Yes, I just was too tired to do that part..

> 
> I don't understand why this report got assigned to pkg-bugs ml, now that
> this issue is already fixed, also present in proftpd-1.3.7a-3.1.mga8 and
> only waiting for the fix to be tested

It's just that there should not be 2 bugs for same package assigned to QA as it will cause confusion....
Comment 12 Thomas Backlund 2021-09-10 16:10:57 CEST
(In reply to Thomas Backlund from comment #11)

> 
> It's just that there should not be 2 bugs for same package assigned to QA as
> it will cause confusion....

... and it's not really fixed until the package is in updates...
Comment 13 Marja Van Waes 2021-09-10 22:42:01 CEST
(In reply to Thomas Backlund from comment #11)
> (In reply to Marja Van Waes from comment #9)
> > Hi Thomas :-)
> > 
> > Shouldn't the advisory of this bug report, without the (S)RPMs list, be
> > merged with the advisory of bug 29449?
> > 
> 
> Yes, I just was too tired to do that part..
> 
No problem, I just merged them in bug 29449, hopefully correctly.

Take care, Thomas :-)
Thanks a lot for all your work, but please don't overdo it.
Comment 14 Nicolas Salguero 2021-09-23 09:18:44 CEST
Fix in bug 29449.

Resolution: (none) => FIXED
Status: NEW => RESOLVED


Note You need to log in before you can comment on or make changes to this bug.