Bug 29229 - mplayer doesn't build with our x264, fails with linking error
Summary: mplayer doesn't build with our x264, fails with linking error
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: David GEIGER
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-06 01:47 CEST by David Walser
Modified: 2021-07-10 12:15 CEST (History)
1 user (show)

See Also:
Source RPM: x264-0.157-0.20191217.stable.2.mga8
CVE:
Status comment:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Walser 2021-07-06 01:47:39 CEST 
I've updated mplayer in Cauldron SVN to the latest snapshot from upstream, and it still fails to link when x264 is enabled, apparently since this commit to mplayer:
http://svnweb.mageia.org/packages?view=revision&revision=1712114

It's not apparent why, although that commit added --enable-x264 to configure, so maybe it was silently not working before that, and perhaps the issue started with the last update to x264 (r1602603).
Comment 1 Jani Välimaa 2021-07-10 11:39:57 CEST 
I fixed the logic behind enabling or disabling x264 support in .spec.

It didn't work as expected as mplayer's configure --enable-x264 is broken. Better to leave x264 check to auto mode and disable it explicitly only when x264 support is also disabled in .spec.

As a side note system ffmpeg devel pulls x264 devel ATM so actually x264 support was enabled previously even when %build_x264 was set to 0 in .spec.

CC: (none) => jani.valimaa

Comment 2 Jani Välimaa 2021-07-10 12:15:27 CEST 
Fixed with mplayer-1.4.1-1.r38313.2.mga9.

Status: NEW => RESOLVED
Resolution: (none) => FIXED
Note You need to log in before you can comment on or make changes to this bug.