Bug 2872 - CVE-2011-3378: rpm: crashes and overflows on malformed header
Summary: CVE-2011-3378: rpm: crashes and overflows on malformed header
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Security (show other bugs)
Version: 1
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: D Morgan
QA Contact:
URL:
Whiteboard:
Keywords: validated_update
Depends on:
Blocks:
 
Reported: 2011-09-29 15:14 CEST by Nicolas Vigier
Modified: 2011-10-08 23:36 CEST (History)
6 users (show)

See Also:
Source RPM: rpm
CVE:
Status comment:


Attachments

Comment 1 Nicolas Vigier 2011-09-29 15:19:59 CEST
This can be tested with this package :
https://bugzilla.redhat.com/attachment.cgi?id=525110

rpm -qp --checksig on this package creates a segmentation fault.
Comment 2 Dave Hodgins 2011-09-30 02:31:37 CEST
Problem confirmed with just --checksig.

$ rpm --checksig dataStart.rpm
Segmentation fault

CC: (none) => davidwhodgins

Comment 3 D Morgan 2011-10-01 11:57:13 CEST
rpm available in core/update_testing

Assignee: dmorganec => qa-bugs

Comment 4 Derek Jennings 2011-10-01 12:52:26 CEST
Confirmed bug and fix on x86_64 with rpm-4.8.1-10.1.mga1.x86_64.rpm
Verified rpm still working normally

CC: (none) => derekjenn

Comment 5 Dave Hodgins 2011-10-01 16:50:29 CEST
Confirmed fixed in i586.
$ rpm --checksig dataStart.rpm
error: dataStart.rpm: headerRead failed

Could someone from the sysadmin team push the srpm
rpm-4.8.1-10.1.mga1.src.rpm
from Core Updates Testing to Core Updates.

Advisory.
This security update corrects CVE-2011-3378 where a malformed
header could cause rpm to fail with a segfault.

https://bugs.mageia.org/show_bug.cgi?id=2872

Keywords: (none) => validated_update
CC: (none) => sysadmin-bugs

Comment 6 Samuel Verschelde 2011-10-01 16:58:17 CEST
As it's a very very very important package that we can't afford to break, I suggest to wait for a few days before pushing it.

CC: (none) => stormi

Comment 7 Nicolas Vigier 2011-10-01 23:30:10 CEST
One more patch fixing segfaults with malformed packages :
http://rpm.org/gitweb?p=rpm.git;a=commitdiff;h=30635dd4330a192fa2b6e202a0e2490eba599a93

I think we should include this one too.

Keywords: validated_update => (none)
Assignee: qa-bugs => dmorganec

Comment 8 Dave Hodgins 2011-10-02 01:55:48 CEST
Confirmed bug on i56 using
https://bugzilla.redhat.com/attachment.cgi?id=525758
# rpm -i ./nothing.rpm
Segmentation fault

CC: sysadmin-bugs => (none)

Comment 9 D Morgan 2011-10-02 02:50:20 CEST
new rpm just uploaded in the BS.
Comment 10 Samuel Verschelde 2011-10-02 22:06:20 CEST
The update creates a /etc/rpm/macros.rpmnew file:

current /etc/rpm/macros:
%_install_langs _:de:en:es:fr:fr_BE:fr_CA:fr_CH:fr_FR:fr_LU:it:pl:pt:ru

/etc/rpm/macros.rpmnew:
# Put your own system macros here
# usually contains 

# Set this one according your locales
# %_install_langs

I don't remember having changed /etc/rpm/macros by myself. Does it risk to occur for many users ? If yes, it will be confusing, as MageiaUpdate asks the user to make a choice (create .rpmnew, drop old changes, or do nothing).

CC: (none) => qa-bugs

Comment 11 Thomas Backlund 2011-10-02 22:54:07 CEST
It's the installer that modifies that file on system install according to selected languages, so only manpages for those languages are installed.

CC: (none) => tmb

Comment 12 Samuel Verschelde 2011-10-02 23:04:32 CEST
(In reply to comment #11)
> It's the installer that modifies that file on system install according to
> selected languages, so only manpages for those languages are installed.

Hmm, bad news, this means that all users will have this "there was a .rpmnew created during install" message and many probably wonder what it means.

There's no way to avoid it ?
Comment 13 Dave Hodgins 2011-10-03 01:29:13 CEST
(In reply to comment #7)
> One more patch fixing segfaults with malformed packages :
> http://rpm.org/gitweb?p=rpm.git;a=commitdiff;h=30635dd4330a192fa2b6e202a0e2490eba599a93
> 
> I think we should include this one too.

# rpm -i ./nothing.rpm
error: skipping package with unverifiable V0 signature
error: ./nothing.rpm cannot be installed

Confirmed fixed on i586.
Comment 14 Samuel Verschelde 2011-10-07 23:19:32 CEST
Confirmed fixed on x86_64.

If a packager can answer to comment #12, then we'll see if we push as is or wait for a change to handle it.
Comment 15 Thomas Backlund 2011-10-08 00:29:09 CEST
This is not a new problem, it has always been like this when pushing a new rpm.
It was (afaik still is) the same in mdv.

Yes, it would be nice to fix it somehow, but I dont think it should block this security update.
Comment 16 Dave Hodgins 2011-10-08 00:51:22 CEST
Agreed comment 12 is not a regression, so it does not block this update.

As the people testing the latest package have been running with it for q
week now, with no regressions detected, I'm validating the update.

Can someone from the sysadmin team push the srpm
rpm-4.8.1-10.2.mga1.src.rpm
from Core Updates Testing to Core Updates.

Advisory:
This security update to rpm fixes two vulnerabilities.
CVE-2011-3378: rpm: crashes and overflows on malformed header
Red Hat bug 742499: Sub-packet prefix length + packet length exceeds
the remaining packet length

https://bugs.mageia.org/show_bug.cgi?id=2872

Keywords: (none) => validated_update
CC: (none) => sysadmin-bugs

Comment 17 D Morgan 2011-10-08 23:36:49 CEST
update pushed.

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.