Bug 28407 - pressing F4 in PCManFM[-qt] try launching xterm instead of qterminal, wrong in conf file
Summary: pressing F4 in PCManFM[-qt] try launching xterm instead of qterminal, wrong i...
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 8
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard: MGA8-64-OK
Keywords: IN_ERRATA8, advisory, validated_update
Depends on:
Blocks:
 
Reported: 2021-02-22 18:02 CET by Morgan Leijström
Modified: 2021-04-12 22:01 CEST (History)
7 users (show)

See Also:
Source RPM: pcmanfm-qt-0.16.0-4.mga8.src.rpm
CVE:
Status comment:


Attachments
Showing the PcmanFM error on F4 if xterm not installed (8.71 KB, image/png)
2021-02-22 20:53 CET, Lewis Smith
Details
settings.conf in user space (2.08 KB, text/plain)
2021-02-23 18:46 CET, papoteur
Details

Description Morgan Leijström 2021-02-22 18:02:55 CET
Description of problem: xterm is missing

Version-Release: 
System installed from Live xfce 64 bit second internal final.
Then install of current task-lxqt

Steps to Reproduce:
1. Launch file manager
2. Press F4
3. No file manger launched, instead the error message xterm is not found
4. urpmi xterm
5. In PCManFM, F4 launches xterm  

I guess task-lxqt-minimal should require xterm
Comment 1 Lewis Smith 2021-02-22 20:50:56 CET
Thanks for the report.

$ urpmq --requires-recursive  task-lxqt-minimal | grep xterm
$ urpmq --whatrequires-recursive xterm | grep lxqt
$ urpmq --requires-recursive pcmanfm | grep xterm
$ urpmq --requires-recursive pcmanfm-qt | grep xterm
$ urpmq --whatrequires-recursive xterm | grep pcmanfm

So there is no dependency from either lxqt nor pcmanfm[-qt] for xterm, confirmed in the reverse sense.
I suspect that this dependency should be from pcmanfm[-qt], not lxqt - which *does* require pcmanfm-qt. Trying PcmanFM on LXDE:
 pcmanfm-qt-0.16.0-4.mga8
 pcmanfm-1.3.1-3.git20210129.2.mga8
(xterm *not* installed); launching it, then F4 gave the same error. I will screenshot it.

Source RPM: task-lxqt-minimal ? => pcmanfm-1.3.1-3.git20210129.2.mga8.src.rpm, pcmanfm-qt-0.16.0-4.mga8.src.rpm
Summary: LXQt: xterm not found, pressing F4 in the default file manager PCManFM => xterm not found, pressing F4 in PCManFM[-qt], missing dependency

Comment 2 Lewis Smith 2021-02-22 20:53:32 CET
Created attachment 12364 [details]
Showing the PcmanFM error on F4 if xterm not installed
Comment 3 Lewis Smith 2021-02-22 20:57:19 CET
pcmanfm & pcmanfm-qt have various committers, so assigning this globally and CC'ing the main ones.

Assignee: bugsquad => pkg-bugs
CC: (none) => geiger.david68210, nicolas.salguero

Comment 4 Aurelien Oudelet 2021-02-23 11:48:19 CET
Installed lxqt from Classic ISO final turn and with Online Repositories set at installattion time, so I can have the lxqt desktop proposed by DrakX.

Run this on VM x86_64 spin.
Logon lxqt-desktop session.

Run pcmanfm-qt.
Press F4.
Booh xterm.

So, I don't know what's wrong here.

CC: (none) => ouaurelien

Comment 5 Aurelien Oudelet 2021-02-23 11:54:48 CET
$ rpm --qa --last > ~/rpmlist.txt

Searching for xterm string:
xterm-363-1.mga8.x86_64                       sam. 20 févr. 2021 15:45:11
vim-enhanced-8.2.2143-2.mga8.x86_64           sam. 20 févr. 2021 15:45:11
strace-5.10-1.mga8.x86_64                     sam. 20 févr. 2021 15:45:11
sonnet-config-5.76.0-2.mga8.x86_64            sam. 20 févr. 2021 15:45:11
sane-backends-iscan-1.0.31-3.mga8.x86_64      sam. 20 févr. 2021 15:45:11
rpmdrake-6.32-1.mga8.noarch                   sam. 20 févr. 2021 15:45:11
qastools-0.23.0-2.mga8.x86_64                 sam. 20 févr. 2021 15:45:11
notepadqq-1.4.8-5.mga8.x86_64                 sam. 20 févr. 2021 15:45:11
lxqt-sudo-0.16.0-2.mga8.x86_64                sam. 20 févr. 2021 15:45:11
lxqt-globalkeys-0.16.0-3.mga8.x86_64          sam. 20 févr. 2021 15:45:11
lxqt-config-0.16.1-2.mga8.x86_64              sam. 20 févr. 2021 15:45:11
lxqt-about-0.16.0-2.mga8.x86_64               sam. 20 févr. 2021 15:45:11
kguiaddons-5.76.0-1.mga8.x86_64               sam. 20 févr. 2021 15:45:11
inxi-3.2.01-1.mga8.noarch                     sam. 20 févr. 2021 15:45:11
trojita-0.7-8.git20200625.2.mga8.x86_64       sam. 20 févr. 2021 15:45:10
sddm-config-editor-0.1.r8246144-5.mga8.x86_64 sam. 20 févr. 2021 15:45:10

It is in same rpm transaction at install time with other lxqt rpms.

Note also that REPORTER's bug was done by installing Xfce BEFORE installing after a first reboot, task-lxqt. Does urpmi consider some terminal apps already installed?

Note also that you can choose your preferred Terminal app under pcmanfm-qt Preferences, advanced tab. There is a drop-down menu for it.
Comment 6 papoteur 2021-02-23 13:30:25 CET
Hello,
I have done an installation with the classical installer, selecting LXQt Desktop only.
F4 with pcmanfm-qt opens a separate window which seems to be xterm.
xterm is in the menu, alongside with qterminal.
What I would expect is that default terminal would be qterminal.

CC: (none) => yves.brungard_mageia

Comment 7 Aurelien Oudelet 2021-02-23 14:14:13 CET
I also wonder why xterm is set by default rather use of qterminal...
Comment 8 David GEIGER 2021-02-23 16:15:13 CET
Normally xterm should not be needed with our pcmanfm-qt packake!

This http://svnweb.mageia.org/packages/cauldron/pcmanfm-qt/current/SOURCES/pcmanfm-qt-0.16.0-mga-customize-default-appearance.patch?revision=1675349&view=markup patch should call qterminal.
Comment 9 Aurelien Oudelet 2021-02-23 16:30:55 CET
Oh! That is strange!
Comment 10 papoteur 2021-02-23 18:46:58 CET
Created attachment 12372 [details]
settings.conf in user space

This is the onf file used, from .config/pcmanfm-qt/lxqt
It has Terminal=xterm
The installation is fresh from yesterday, with /home formatting.
Comment 11 Morgan Leijström 2021-02-23 18:51:22 CET
So that is the bug then

task-lxqt requires qterminal

Summary: xterm not found, pressing F4 in PCManFM[-qt], missing dependency => pressing F4 in PCManFM[-qt] try launching xterm instead of qterminal, wrong in conf file

Comment 12 Morgan Leijström 2021-02-23 18:52:40 CET
Second thought, I should not jump gun so quickly:
That default may be correct for other desktops?
Comment 13 papoteur 2021-02-23 19:55:37 CET
Hello,
I think that LXQt changed its settings since Mageia 7. It should now be 
Terminal=qterminal
Comment 14 David GEIGER 2021-02-24 08:06:15 CET
So it should be fixed with pcmanfm-qt-0.16.0-5.mga8 in Core/Updates_testing repo!
Comment 15 David GEIGER 2021-02-25 09:57:21 CET
You can test pcmanfm-qt-0.16.0-4.1.mga8 in Core/Updates_testing repo for mga8!
Comment 16 David GEIGER 2021-02-26 12:07:02 CET
Assigning to QA now,


Advisory:
========================

This update fixes the default terminal who should be used making sure that qterminal is properly set as default instead of xterm.

========================

Packages in 8/core/updates_testing:
========================
pcmanfm-qt-0.16.0-4.1.mga8.i586.rpm
pcmanfm-qt-0.16.0-4.1.mga8.x86_64.rpm

Source RPM: 
========================
pcmanfm-qt-0.16.0-4.1.mga8.src.rpm

Assignee: pkg-bugs => qa-bugs
Version: Cauldron => 8

Comment 17 Guillaume Royer 2021-02-26 21:48:01 CET
Hello,

I have tested: 

pcmanfm-qt-0.16.0-4.1.mga8.x86_64.rpm

With QA Repo and MGA8 LxQt VM.

I renamed /home/user/.config/pcmanfm-qt/lxqt/settings.conf, xterm is always opened with F4 instead qterminal

I created new user and qterminal is properly set as default instead of xterm with F4 pressed

So what I have to configure to enable it with user principal ?

CC: (none) => guillaume.royer

Comment 18 Aurelien Oudelet 2021-03-04 17:48:25 CET
(In reply to Guillaume Royer from comment #17)
> Hello,
> 
> I have tested: 
> 
> pcmanfm-qt-0.16.0-4.1.mga8.x86_64.rpm
> 
> With QA Repo and MGA8 LxQt VM.
> 
> I renamed /home/user/.config/pcmanfm-qt/lxqt/settings.conf, xterm is always
> opened with F4 instead qterminal
> 
> I created new user and qterminal is properly set as default instead of xterm
> with F4 pressed
> 
> So what I have to configure to enable it with user principal ?

Applying update and creating a new user make qterminal being the default terminal app. This is OK.

So, @Guillaume, have you logoff/logon? pcmanfm-qt should have his preferences loaded in memory because it is still running, whereas your conf file is deleted...
Perhaps.

Or, existing affected users need to choose qterminal in pcmanfm-qt configuration UI.
Comment 19 Guillaume Royer 2021-03-04 21:41:24 CET
(In reply to Aurelien Oudelet from comment #18)

 
> So, @Guillaume, have you logoff/logon? pcmanfm-qt should have his
> preferences loaded in memory because it is still running, whereas your conf
> file is deleted...
> Perhaps.
> 
> Or, existing affected users need to choose qterminal in pcmanfm-qt
> configuration UI.

Yes I have delete the config file and logoff/logon and even restart and no changes
Comment 20 Thomas Andrews 2021-04-11 02:30:51 CEST
First time ever running Lxqt. This should be interesting...

Created an Lxqt guest in Virtualbox, using the nonfree netinstall iso. On the first boot, ran the file manager, pressed F4, and xterm come up. So, problem is confirmed.

Installed qarepo, and used it to install the pcmanfm-qt update. No installation issues. Did a reboot to make sure any changes had been made. Tried F4 from the file manager again, and xterm still came up. 

Called on my old friend Mr Clunky to be a new user. Clunky knows even less about Mageia than I do, if you can believe it, but he has his uses. I had him log in and use F4 from the file manager, and qterminal came up. New default confirmed.

Logged back in as Tom, ran the file manager again, and used the gui to change the terminal setting to qterminal manually. Closed it, opened it again, and pressed F4. Qterminal came up.

All this would be expected behavior. The terminal choice is part of each user's individual configuration settings, and Mageia has a policy of not messing with those. So, while new users would have a default terminal of qterminal, existing users would have to change the setting manually.

Guillaume, deleting the config file might not work because of two possibilities: The default terminal setting *may* be somewhere else, or there may be a "config.old" (or something similar) file that is kept as a backup for the main config file, which is then used to recreate the config file you just deleted.

This update is OK for 64-bit. Validating. Advisory in Comment 16.

Keywords: (none) => validated_update
Whiteboard: (none) => MGA8-64-OK
CC: (none) => andrewsfarm, sysadmin-bugs

Comment 21 Aurelien Oudelet 2021-04-12 17:11:49 CEST
Advisory:
========================

This update fixes the default terminal who should be used making sure that qterminal is properly set as default instead of xterm, for new users added to
system after this update.
  
As our policy is to not remove user preferences, affected users should modify
settings in pcmanfm-qt preferences GUI.
========================

Packages in 8/core/updates_testing:
========================
pcmanfm-qt-0.16.0-4.1.mga8

Source RPM: 
========================
pcmanfm-qt-0.16.0-4.1.mga8.src.rpm


for ERRATA8

Keywords: (none) => FOR_ERRATA8, advisory
Source RPM: pcmanfm-1.3.1-3.git20210129.2.mga8.src.rpm, pcmanfm-qt-0.16.0-4.mga8.src.rpm => pcmanfm-qt-0.16.0-4.mga8.src.rpm

Comment 22 Morgan Leijström 2021-04-12 18:35:31 CEST
Added to https://wiki.mageia.org/en/Mageia_8_Errata#LXQt

Keywords: FOR_ERRATA8 => IN_ERRATA8

Comment 23 Mageia Robot 2021-04-12 22:01:59 CEST
An update for this issue has been pushed to the Mageia Updates repository.

https://advisories.mageia.org/MGAA-2021-0068.html

Resolution: (none) => FIXED
Status: NEW => RESOLVED


Note You need to log in before you can comment on or make changes to this bug.