Bug 28223 - Live: os-prober asked by Live Installer is missing
Summary: Live: os-prober asked by Live Installer is missing
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Release (media or process) (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: Mageia 8
Assignee: Mageia Bug Squad
QA Contact:
URL:
Whiteboard: 8RC (third internal)
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-26 14:48 CET by Morgan Leijström
Modified: 2021-02-02 08:37 CET (History)
3 users (show)

See Also:
Source RPM:
CVE:
Status comment:


Attachments
Screenshot of dialogues asking for os-prober and fail (42.83 KB, image/jpeg)
2021-01-26 14:50 CET, Morgan Leijström
Details

Description Morgan Leijström 2021-01-26 14:48:03 CET
Problem: I guess missing os-prober may lead to it not populating boot menu with other OS:ses installed ?

Version: Second internal round RC Live ISOs, (at least xfce 64 bit)

How reproducible:
After i took the screenshot, rebooted same Live, and installed to same target (another USB stick): this time it did not show any message dialogue about this, but still problem is shown in the terminal.  Weird. Only change this time is I started draklive-install from terminal window to get output, and another difference is this time laptop was run on battery so slower - if now timing have anything to do with it.


Steps to Reproduce: Start Live installer from terminal, and at the very end of install after it installs grub, this problem.


From terminal, last messages until end:

starting installing packages
skapade transaktion för installation på / (ta bort=0, installera=0, uppdatera=3)
unlocking urpmi database
unlocking rpm database
getting exclusive lock on rpm
getting lock on urpmi
undersöker synthesis-fil [/var/lib/urpmi/Live Core/synthesis.hdlist.cz]
undersöker synthesis-fil [/var/lib/urpmi/Live Nonfree/synthesis.hdlist.cz]


installerar grub2-mageia-theme-2.04.0-27.mga8.noarch.rpm från /var/local/mga_rpms/core
starting installing packages
skapade transaktion för installation på / (ta bort=0, installera=0, uppdatera=1)
Generera konfigurationsfil för grub …
Hittade tema: /boot/grub2/themes/maggy/theme.txt
Hittade linux-avbildning: /boot/vmlinuz-5.10.7-desktop-1.mga8
Hittade initrd-avbildning: /boot/initrd-5.10.7-desktop-1.mga8.img
färdigt
unlocking urpmi database
unlocking rpm database
fel: paket os-prober är inte installerat   <<<<<<<<<HERE<<<<<<<<<<

Translated: "error: package os-prober is not installed"

Note: This output shows SysV services only and does not include native
      systemd services. SysV configuration data might be overridden by native
      systemd configuration.

      If you want to list systemd services use 'systemctl list-unit-files'.
      To see services enabled on particular target use
      'systemctl list-dependencies [target]'.

Created symlink /etc/systemd/system/multi-user.target.wants/acpid.service → /usr/lib/systemd/system/acpid.service.
Running in chroot, ignoring command 'is-active'
Running in chroot, ignoring command 'restart'
umount: /dev/sdb1: inte monterad.
umount: /dev/sdb6: inte monterad.
[live@localhost ~]$
Comment 1 Morgan Leijström 2021-01-26 14:50:08 CET
Created attachment 12266 [details]
Screenshot of dialogues asking for os-prober and fail

Pressing "Slutför" = Finish" makes installer finish as normal, and the resulting system works.
Morgan Leijström 2021-01-26 14:51:20 CET

CC: (none) => mageia
Whiteboard: (none) => 8RC (second internal)

Comment 2 Thomas Backlund 2021-01-26 15:43:57 CET
(In reply to Morgan Leijström from comment #0)
> Problem: I guess missing os-prober may lead to it not populating boot menu
> with other OS:ses installed ?

Maybe, but os-prober is seriously broken trying to probe everything under the sun, wich caused some installs to hit more than 10 minute delay causing installs to time out and fail...

so *not* installing it by default is a good thing.

> fel: paket os-prober är inte installerat   <<<<<<<<<HERE<<<<<<<<<<
> 
> Translated: "error: package os-prober is not installed"


well, this is a packaging bug...
Anything calling out to os-prober without checking if it's installed needs to be fixed.
Comment 3 Martin Whitaker 2021-01-26 15:54:28 CET
% grep os-prober */*Live*.lst
Mageia-8-rc-Live-GNOME-x86_64/Mageia-8-rc-Live-GNOME-x86_64.lst:os-prober-1.77-1.mga8
Mageia-8-rc-Live-Plasma-x86_64/Mageia-8-rc-Live-Plasma-x86_64.lst:os-prober-1.77-1.mga8
Mageia-8-rc-Live-Xfce-i586/Mageia-8-rc-Live-Xfce-i586.lst:os-prober-1.77-1.mga8
Mageia-8-rc-Live-Xfce-x86_64/Mageia-8-rc-Live-Xfce-x86_64.lst:os-prober-1.77-1.mga8

Have you removed it?

(I agree with Thomas though, os-prober is a menace. I think we would have been better off adapting the old drakx code to generate the GRUB config file)
Comment 4 Morgan Leijström 2021-01-26 21:14:47 CET
(In reply to Thomas Backlund from comment #2)
> Anything calling out to os-prober without checking if it's installed needs
> to be fixed.

One time of four tries I got the dialogues in the attached screenshot.
So it asks... - but why only sometimes...?

(In reply to Martin Whitaker from comment #3)
> Have you removed it?

No.

My report was from running Live xfce x86_64.
Now booted Live Plasma:

§ drakrpm say it is installed
§ i can launch os-prober from CLI
§ but urpmq fail to find os-prober

So something is inconsistent.
Comment 5 Martin Whitaker 2021-01-26 21:26:35 CET
urpmq will only find it if you add the full distribution media.
Comment 6 Morgan Leijström 2021-01-27 14:31:22 CET
Ah, yes rpm -qa find os-prober is installed.

Thanks for that hint!  It is not obvious that full distribution media is needed to see if a package is installed... I added that now in https://wiki.mageia.org/en/URPMI#urpmq

Back to this bug:

I noted from system journal that draklive-install itself issue removal of os-prober (twice actually), probably only to uninstall it from target system, where I also verified it is not installed, and it is still installed on the system from where installer was launched.

So maybe the "error: package os-prober is not installed" is coming from it not existing on the target.  I dont know if that is intended or not.

The other mystery is why installer only sometimes pop up the dialogues asking for os-prober, per screenshot in attachement.  Maybe depending on what other partitions is found on disks in the system, and it thinks it should investigate them using os-prober?
Morgan Leijström 2021-01-27 14:31:45 CET

Whiteboard: 8RC (second internal) => 8RC (third internal)

Comment 7 Aurelien Oudelet 2021-01-28 21:15:14 CET
os-prober is only used when there are other partitions on harddisks.

His only purpose is to look for other installed systems and add them to the Grub2 menu. It is only needed by Grub2.

As long as a Live ISO will be used on a computer with an already installed system, it is worth to be installed on Live ISO. Please don't remove it on the live ISO.

That's strange is the fact it appears draklive-install try to remove it before installing Grub2? But Martin said in Comment 3 it is on Live ISO...

Ever confirmed: 1 => 0
Status: NEW => UNCONFIRMED
Target Milestone: --- => Mageia 8
CC: (none) => ouaurelien

Comment 8 Martin Whitaker 2021-01-28 22:08:22 CET
(In reply to Morgan Leijström from comment #6)
> Ah, yes rpm -qa find os-prober is installed.
> 
> Thanks for that hint!  It is not obvious that full distribution media is
> needed to see if a package is installed... I added that now in
> https://wiki.mageia.org/en/URPMI#urpmq

urpmq only reports on packages in the distribution media - it doesn't look at what is installed. 'rpm -q' does that.

> Back to this bug:
> 
> I noted from system journal that draklive-install itself issue removal of
> os-prober (twice actually), probably only to uninstall it from target
> system, where I also verified it is not installed, and it is still installed
> on the system from where installer was launched.
> 
> So maybe the "error: package os-prober is not installed" is coming from it
> not existing on the target.  I dont know if that is intended or not.
> 
> The other mystery is why installer only sometimes pop up the dialogues
> asking for os-prober, per screenshot in attachement.  Maybe depending on
> what other partitions is found on disks in the system, and it thinks it
> should investigate them using os-prober?

There's a check box in the bootloader install menu titled ".Probe foreign OS". If that is not checked, the installer will remove os-prober. I've not investigated, but I suspect that may be the only way to stop grub2-mkconfig from using it.

However, I also made the installer remove os-prober if it detects you are installing onto a removable drive, on the principle that you you don't want the GRUB menu on a removable drive to be tied to a specific machine. But if you then check the "Probe foreign OS" box, it will try to reinstall it, and that will fail in the live installer if you haven't added online media.
Comment 9 Morgan Leijström 2021-01-28 23:13:00 CET
(In reply to Martin Whitaker from comment #8)
> urpmq only reports on packages in the distribution media - it doesn't look
> at what is installed. 'rpm -q' does that.
OOpps yes, fixed.

 
> There's a check box in the bootloader install menu titled ".Probe foreign
> OS". If that is not checked, the installer will remove os-prober. I've not
> investigated, but I suspect that may be the only way to stop grub2-mkconfig
> from using it.
> 
> However, I also made the installer remove os-prober if it detects you are
> installing onto a removable drive, on the principle that you you don't want
> the GRUB menu on a removable drive to be tied to a specific machine.

That is great.

> But if
> you then check the "Probe foreign OS" box, it will try to reinstall it, and
> that will fail in the live installer if you haven't added online media.

Thanks for the explanation.

Could you move the eventual removal of os-prober to after that checkbox is evaluated?

(Attempting to not need to try to install os-prober again.)
Comment 10 Martin Whitaker 2021-01-30 17:25:50 CET
(In reply to Morgan Leijström from comment #9)
> Could you move the eventual removal of os-prober to after that checkbox is
> evaluated?

Done in git, should make its way onto the ISOs by the time we release.
Comment 11 Morgan Leijström 2021-01-30 17:28:52 CET
:)

I have put it in my list of issues to verify.
Comment 12 Lewis Smith 2021-02-01 12:38:13 CET
Thanks yet again Martin for a fix.

@Morgan, if you find things OK, please close this bug resolved fixed.
Comment 13 Morgan Leijström 2021-02-02 08:37:57 CET
Confirming it is fixed :)

Booted RC take five cfce Live 64 bit to desktop, no network access, started live installer from konsole, installed to another USB stick, at the end selected to probe foreign OS.

No problem, and os prober is found installed in the target system.

---

Sidenote: around the time it configures grub i noticed:

remove-boot-splash: Format of /boot/initrd-5.10.12-desktop-2.mga8.img not recognized

I experience no obvious issue.

---

Just to see what happens i first let it install with "use free space" to a Live stick.  Installer crash when grub fail.  Not elegant but why would someone seriously try...

Resolution: (none) => FIXED
Status: UNCONFIRMED => RESOLVED


Note You need to log in before you can comment on or make changes to this bug.