Bug 26643 - Deja-dup/duplicity give corrupted backup files with samba-4.10.15, some files appear as folders
Summary: Deja-dup/duplicity give corrupted backup files with samba-4.10.15, some files...
Status: RESOLVED OLD
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 7
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Buchan Milne
QA Contact:
URL: https://bugs.launchpad.net/duplicity/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-19 18:35 CEST by Daniel BEZIVIN
Modified: 2021-09-07 14:11 CEST (History)
1 user (show)

See Also:
Source RPM: samba-4.10.15-1.mga7.src.rpm
CVE:
Status comment:


Attachments

Description Daniel BEZIVIN 2020-05-19 18:35:52 CEST
Description of problem:
At the end of the backup, i get this message "The duplicity-full.20200518T182711Z.vol1.difftar.gz file was damaged during the upload "

Version-Release number of selected component (if applicable):
duplicity-0.8.12.1612-1.mga7
deja-dup-40.6-1.mga7

How reproducible:


Steps to Reproduce:
1. Launch deja-dup
2. Choose smb://livebox/usb_102/SavDesktop/ as storage place
3. launch the backup

It is not the same bug as this : https://bugs.mageia.org/show_bug.cgi?id=26534
Comment 1 Daniel BEZIVIN 2020-05-19 18:43:35 CEST
You can see the result of the command  "DEJA_DUP_DEBUG=1 deja-dup --backup" on MLO forum at this address https://www.mageialinux-online.org/forum/topic-27495-3+erreur-sauvegarde-avec-deja-dup.php#m269538
Comment 2 Lewis Smith 2020-05-21 21:33:05 CEST
Sorry for the problem, and the slow response.

We need a more exact description of when the problem happens, for example:
* From the moment you first used the software?
* After an update (both seem to have been updated once)?
* Is it related to the specific backup device you cite? Can you try to a different one? Does the error still happen?
* The specific error message apparently comes from Deja-dup [en mode graphique]. Do you know whether the backup was actually done OK by Duplicity??
* The log URL'd in comment 1 (essential viewing) shows many warnings & errors near the end, which start from a presumed incomplete/interrupted backup. Do you know anything about that?
* Is the target filesystem [below] NTFS? 'Windows' could mean FAT32 etc.

From the upstream bug report in the URL field:
> Type of target filesystem: Windows (an usb harddrive, plugged on
> Livebox smb://livebox/)
Interesting to be able to use a Livebox as a file server!

CC: (none) => lewyssmith
URL: (none) => https://bugs.launchpad.net/duplicity/+bug/1879887

Comment 3 Daniel BEZIVIN 2020-05-22 18:50:24 CEST
Hi Lewis,
I got recently problems with a precedent version of deja-dup(40.0) , but since update to version deja-dup-40.6-1 and duplicity-0.8.12.1612-1, the backup worked fine until this week. But now it doesn't works anymore with samba.
I have tried to use deja-dup, with differents backup devices plugged directly on the PC's usb ports such as an USB stick , or the same usb hardrive (NTFS system) plugged on Livebox, and it worked fine.

The problem seems so coming from the samba connexion .

However, even if the system gives a failure message at the end, the backup files are present on the device (i didn't noticed that there was some folders with a similar name as the files for ex : duplicity-full.20200522T093025Z.vol2.difftar.gz ).

And i have tried to restore some files, and it worked !

May it be a problem with errors handling ?
Thanks for your help
Comment 4 Daniel BEZIVIN 2020-05-23 08:54:08 CEST
A post on forum MLO, seems to confirm the problem : with samba, some files are shown as folders : https://www.mageialinux-online.org/forum/topic-27611-1+pdf-vu-comme-dossier.php#m269735
Comment 5 Daniel BEZIVIN 2020-05-23 14:02:25 CEST
The problem does not happen in Mageia 7 under Xfce4 :
Not any error message, and with thunar as files browser, all backup files are considered as files, not as folders. So it seems that the bug does not come from deja-dup or from duplicity, but from Plasma and samba ???
Comment 6 Daniel BEZIVIN 2020-05-23 17:12:00 CEST
As my netbook under Xfce4 uses samba 40.10.12 without any problem, and my desktop PC under Plasma uses samba 4.10.15, we can suppose that problems come from this version 4.10.15 ?
Comment 7 Lewis Smith 2020-05-23 20:27:30 CEST
In reply to the previous 3 comments - thank you for the information.
I had already wondered whether the problem was due to Samba (not Plasma), and have just researched when its last update was released:
 Fri, 8 May 2020: samba-4.10.15-1.mga7
and was going to ask whether your problem started around then.
But you have already answered the question, well done. You have been very helpful gathering evidence.

So this looks like a reversion in the Samba update. For anyone thus troubled, you can revert to the previous version with:
 # urpmi --downgrade samba

Assigning to Buchan for samba.

CC: lewyssmith => (none)
Assignee: bugsquad => bgmilne
Summary: Deja-dup gives corrupted backup files => Deja-dup/duplicity give corrupted backup files with samba-4.10.15, some files appear as folders
Source RPM: duplicity-0.8.12.1612-1.mga7 deja-dup-40.6-1.mga7 => samba-4.10.15-1.mga7.src.rpm

Comment 8 Daniel BEZIVIN 2020-05-23 21:15:04 CEST
Ok , i'll try this , as soon as possible, and come back to comment the result
Thanks a lot
Comment 9 marc fanjoux 2020-05-23 22:54:45 CEST
# urpmi --downgrade samba

the same even after the reboot.

CC: (none) => marcounet

Comment 10 marc fanjoux 2020-05-24 08:55:26 CEST
with : urpmi --downgrade samba-4.10.12-1.mga7.x86_64 all is ok !
Comment 11 Daniel BEZIVIN 2020-05-24 10:12:46 CEST
Hello,
I have downgraded to samba 4.10.12, no more files considered as folders, and deja-dup works as fine as before.
All is OK, Waiting for a new upgrade of samba.
Thanks.
Comment 12 Daniel BEZIVIN 2020-06-13 17:33:00 CEST
Hello,
Samba version 4.10.15 is still in the updates.
Anything new about fixing the bug ?
Comment 13 Buchan Milne 2020-06-16 17:46:16 CEST
In the time since the bug was assigned, I hadn't tested with dejadup/duplicity, but I have tested transferring files with smbclient from samba-client-4.10.15-1.mga7 to samba running both samba-4.10.15-1.mga7 and samba-4.10.12-1.mga7 without any issues.

As such, I believe that the issue here is compatibility of deja-dup/duplicity with the samba client libraries.

However, I don't see an issue with KDE (accessing smb:// URLs via e.g. Dolphin).

I have now installed deja-dup, to see if I can reproduce.

Of course, part of the problem here is I can't reproduce the steps provided:
> 2. Choose smb://livebox/usb_102/SavDesktop/ as storage place

I don't have a livebox, is this related or not (e.g. if you set up samba on one of your computers can you browse/copy files from the other one without seeing the same issue)?

Ever confirmed: 1 => 0
Status: NEW => UNCONFIRMED

Comment 14 marc fanjoux 2020-06-16 19:35:06 CEST
Hello,
I have a router icotera I4850 ans i have the same issue.
Some files are seen as directories with Dolphin .
Copy/paste is not possible
Comment 15 Buchan Milne 2020-06-16 19:41:38 CEST
I have tested with deja-dup (I needed to install gvfs-smb before it would prompt for my username and password), and it was able to complete a backup to a server with both samba-4.10.12-1.mga7 and samba-4.10.15-1.mga7 without any issues:

[bgmilne@buchan-desktop ~]$ DEJA_DUP_DEBUG=1 deja-dup --backup > deja-dup-$(date +%Y%m%d-%H%M%S).log 2>&1;echo $?
0
[bgmilne@buchan-desktop ~]$ rpm -q $(urpmq -d deja-dup|grep smb)
gvfs-smb-1.40.1-4.1.mga7
lib64smbclient0-4.10.15-1.mga7
[bgmilne@buchan-desktop ~]$

However, it could depend on the version/capabilities of the SMB server.

Reading the release notes for versions between 4.10.12 and 4.10.15, it seems 4.10.13 had this change:

> o  Andreas Schneider <asn@samba.org>
>    * BUG 14101: libsmbclient: smbc_stat() doesn't return the correct st_mode
>      and also the uid/gid is not filled (SMBv1)

The relevant bug is: https://bugzilla.samba.org/show_bug.cgi?id=14101

It looks like the source code for 4.10.15 doesn't match the statement in that bug:
> Karolin, please apply the patch to remove it please. Sorry for the inconvenience ... Thanks.

So, it may be that https://bugzilla.samba.org/attachment.cgi?id=15901 will fix this.
Comment 16 Buchan Milne 2020-06-16 22:17:49 CEST
I have submitted samba-4.10.15-2.mga7, with the patch in https://bugzilla.samba.org/attachment.cgi?id=15901, to core/updates_testing for 7 on the build system ( http://pkgsubmit.mageia.org/ ).

Please test it when it is available.

Status: UNCONFIRMED => ASSIGNED
Ever confirmed: 0 => 1

Comment 17 Daniel BEZIVIN 2020-06-17 10:17:14 CEST
(In reply to Buchan Milne from comment #16)
> I have submitted samba-4.10.15-2.mga7, with the patch in
> https://bugzilla.samba.org/attachment.cgi?id=15901, to core/updates_testing
> for 7 on the build system ( http://pkgsubmit.mageia.org/ ).
> 
> Please test it when it is available.

Hello,
Not available for now, I'll test it as soon as possible.
Comment 18 Buchan Milne 2020-06-19 18:56:59 CEST
>  Daniel BEZIVIN 2020-06-17 10:17:14 CEST
>  Hello,
>  Not available for now, I'll test it as soon as possible.

Hmm, it seems to have been available at the time. From my nearest mirror:

http://ftp.sun.ac.za/ftp/pub/mirrors/mageia/distrib/7/x86_64/media/core/updates_testing/samba-4.10.15-2.mga7.x86_64.rpm

[ ]	samba-4.10.15-2.mga7..>	2020-06-16 22:49 	597K	 
[ ]	samba-client-4.10.15..>	2020-06-16 22:49 	533K	 
[ ]	samba-common-4.10.15..>	2020-06-16 22:49 	553K	 

Please test, so we can consider sending for QA before we push an update.
Comment 19 Daniel BEZIVIN 2020-06-20 09:16:57 CEST
Ok , i have found it after updated mirrors.
It works fine, no apparent troubles .
Thanks for all.
Comment 20 Buchan Milne 2020-07-20 22:15:25 CEST
This should now be fixed by the latest security update (https://advisories.mageia.org/MGASA-2020-0289.html) of samba-4.10.17-1.mga7, please test and confirm.
Comment 21 marc fanjoux 2020-07-21 06:36:01 CEST
Yes, now it's ok with this update !
Comment 22 Aurelien Oudelet 2021-07-06 13:14:07 CEST
Mageia 7 is EOL since July 1st 2021.
There will not have any further bugfix for this release.

You are encouraged to upgrade to Mageia 8 as soon as possible.

@reporter, if this bug still apply with Mageia 8, please let us know it.

@packager, if you work on the Mageia 7 version of your package, please check the Mageia 8 package if issue is also present. In this case, please fix the Mageia 8 version instead.

This bug report will be closed OLD if there is no further notice within 1st September 2021.
Comment 23 Marja Van Waes 2021-09-07 14:11:16 CEST
Hi bug reporter and hi assignee and others involved,

Please reopen this bug report if it is still valid for Mageia 8 or 9(cauldron), and change "Version:" in the upper left of this report accordingly.

This report is being closed as OLD because it was filed against Mageia 7, for which  support ended on June 30th 2021.

Thanks,
Marja

Resolution: (none) => OLD
Status: ASSIGNED => RESOLVED


Note You need to log in before you can comment on or make changes to this bug.